GNU bug report logs - #42608
[PATCH] gnu: emacs-org-roam: Update to 1.2.1.

Previous Next

Package: guix-patches;

Reported by: Pierre Langlois <pierre.langlois <at> gmx.com>

Date: Wed, 29 Jul 2020 23:51:01 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42608 in the body.
You can then email your comments to 42608 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#42608; Package guix-patches. (Wed, 29 Jul 2020 23:51:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Pierre Langlois <pierre.langlois <at> gmx.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 29 Jul 2020 23:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-org-roam: Update to 1.2.1.
Date: Thu, 30 Jul 2020 00:50:18 +0100

[Message part 1 (text/plain, inline)]
Hello Guix!

Here's an update for the emacs-org-roam package. I've had to include the
emacsql-sqlite3 package as a new dependency first (see
https://github.com/org-roam/org-roam/pull/701).

Thanks!
Pierre


[0001-gnu-Add-emacs-emacsql-sqlite3.patch (text/x-patch, attachment)]
[0002-gnu-emacs-org-roam-Update-to-1.2.1.patch (text/x-patch, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#42608; Package guix-patches. (Sun, 02 Aug 2020 13:16:01 GMT) Full text and rfc822 format available.

Message #8 received at 42608 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 42608 <at> debbugs.gnu.org
Subject: Re: [bug#42608] [PATCH] gnu: emacs-org-roam: Update to 1.2.1.
Date: Sun, 02 Aug 2020 16:15:11 +0300

[Message part 1 (text/plain, inline)]
Hi,

Could you take a look on running the test-suite inside
emacsql-sqlite3-test.el file, please?

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#42608; Package guix-patches. (Sun, 02 Aug 2020 13:44:02 GMT) Full text and rfc822 format available.

Message #11 received at 42608 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>, 42608 <at> debbugs.gnu.org
Subject: Re: [bug#42608] [PATCH] gnu: emacs-org-roam: Update to 1.2.1.
Date: Sun, 02 Aug 2020 14:43:15 +0100

[Message part 1 (text/plain, inline)]
Hi Oleg, thanks for taking a look!

Oleg Pykhalov writes:

> Hi,
>
> Could you take a look on running the test-suite inside
> emacsql-sqlite3-test.el file, please?

Oh yes good idea! I hadn't noticed there were tests.


See attached patch, I copied the test invocation from
https://github.com/cireu/emacsql-sqlite3/blob/master/.github/workflows/main.yml#L40.
I've also removed the ".git" from the origin url, to make 'guix lint'
happy.

Thanks!
Pierre


[0001-gnu-Add-emacs-emacsql-sqlite3.patch (text/x-patch, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#42608; Package guix-patches. (Sun, 02 Aug 2020 13:51:02 GMT) Full text and rfc822 format available.

Message #14 received at 42608 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>, 42608 <at> debbugs.gnu.org
Subject: fixup!
Date: Sun, 02 Aug 2020 14:50:13 +0100

[Message part 1 (text/plain, inline)]
Pierre Langlois writes:

> Hi Oleg, thanks for taking a look!
>
> Oleg Pykhalov writes:
>
>> Hi,
>>
>> Could you take a look on running the test-suite inside
>> emacsql-sqlite3-test.el file, please?
>
> Oh yes good idea! I hadn't noticed there were tests.
>
>
> See attached patch, I copied the test invocation from
> https://github.com/cireu/emacsql-sqlite3/blob/master/.github/workflows/main.yml#L40.
> I've also removed the ".git" from the origin url, to make 'guix lint'
> happy.

Whoops, I forgot to run the indent-code.el script, see new patch which
adds a couple of adjustments. I really need to setup emacs properly for
scheme... :-)


[0001-gnu-Add-emacs-emacsql-sqlite3.patch (text/x-patch, attachment)]
Reply sent to Oleg Pykhalov <go.wigust <at> gmail.com>:
You have taken responsibility. (Sun, 02 Aug 2020 15:05:02 GMT) Full text and rfc822 format available.
Notification sent to Pierre Langlois <pierre.langlois <at> gmx.com>:
bug acknowledged by developer. (Sun, 02 Aug 2020 15:05:02 GMT) Full text and rfc822 format available.

Message #19 received at 42608-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 42608-done <at> debbugs.gnu.org
Subject: Re: fixup!
Date: Sun, 02 Aug 2020 18:04:44 +0300

[Message part 1 (text/plain, inline)]
OK, also I deleted .git from https://github.com/org-roam/org-roam.git
because of guix lint reports a HTTP redirect.

Pushed to master.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 31 Aug 2020 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 233 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.