GNU bug report logs - #42615
[PATCH] guix: lint: Ignore unsupported source URL’s.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42615 in the body.
You can then email your comments to 42615 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] guix: lint: Ignore unsupported source URL’s.
Date: Thu, 30 Jul 2020 09:05:18 +0200

[Message part 1 (text/plain, inline)]

Hi,

in https://issues.guix.gnu.org/issue/42306 I noticed git:// URI’s in source
urls (see package nfs4-acl-tools) cause `guix lint` to fail currently. Attached
is a patch that fixes the issue, but I’m not sure that’s the “correct” way to
do it.

Cheers,
Lars

[0001-guix-lint-Ignore-unsupported-source-URL-s.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 42615-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
Cc: 42615-done <at> debbugs.gnu.org
Subject: Re: [bug#42615] [PATCH] guix: lint: Ignore unsupported source
 URL’s.
Date: Sat, 01 Aug 2020 08:44:45 +0200

Hello,

> in https://issues.guix.gnu.org/issue/42306 I noticed git:// URI’s in source
> urls (see package nfs4-acl-tools) cause `guix lint` to fail currently. Attached
> is a patch that fixes the issue, but I’m not sure that’s the “correct” way to
> do it.

I considered adding a warning saying that URI validation failed, but
I think it can be misleading and let the user think that something is
wrong with the package definition.

Anyway looks fine, pushed!

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.