GNU bug report logs - #42638
[PATCH] bump libuv to 1.38

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42638 in the body.
You can then email your comments to 42638 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] bump libuv to 1.38
Date: Fri, 31 Jul 2020 17:08:23 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-bump-libuv.patch (text/x-patch, attachment)]

Message #8 received at 42638 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Formbi <formbi <at> protonmail.com>
Cc: 42638 <at> debbugs.gnu.org
Subject: Re: [bug#42638] [PATCH] bump libuv to 1.38
Date: Sat, 01 Aug 2020 08:59:11 +0200

Hello Formbi,

When updating a package, the commit message has to follow a few
conventions detailed in the manual here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html.

> +(define-public libuv-1.38
> +  (package
> +    (inherit libuv)
> +    (version "1.38.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://dist.libuv.org/dist/v" version
> +                                  "/libuv-v" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0iy6yp9nrxpj643w7la3kl3j59ni59b0l4v6n23a63s8kqkpvkhf"))))))

Regarding this very update, why do we need this specific version?

Thanks,

Mathieu

Message #11 received at 42638 <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: "42638 <at> debbugs.gnu.org" <42638 <at> debbugs.gnu.org>
Subject: Re: [bug#42638] [PATCH] bump libuv to 1.38
Date: Sat, 01 Aug 2020 21:47:59 +0000

>why do we need this specific version?

It's needed by the 14.6 version of Node.

Message #14 received at 42638 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Formbi <formbi <at> protonmail.com>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>,
 "42638 <at> debbugs.gnu.org" <42638 <at> debbugs.gnu.org>
Subject: Re: [bug#42638] [PATCH] bump libuv to 1.38
Date: Thu, 6 Aug 2020 23:28:53 +0200

[Message part 1 (text/plain, inline)]

On Sat, Aug 01, 2020 at 09:47:59PM +0000, Formbi wrote:
> >why do we need this specific version?
> 
> It's needed by the 14.6 version of Node.

The core-updates branch already has libuv 1.38.1, so this patch might
become unnecessary depending on when Node 14.6 gets added - I think it
would be better if you submitted this patch as part of the Node 14.6
patchstack.

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 42638 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Formbi <formbi <at> protonmail.com>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>,
 "42638 <at> debbugs.gnu.org" <42638 <at> debbugs.gnu.org>
Subject: Re: [bug#42638] [PATCH] bump libuv to 1.38
Date: Thu, 6 Aug 2020 23:31:12 +0200

[Message part 1 (text/plain, inline)]

On Thu, Aug 06, 2020 at 11:28:55PM +0200, Jakub Kądziołka wrote:
> On Sat, Aug 01, 2020 at 09:47:59PM +0000, Formbi wrote:
> > >why do we need this specific version?
> > 
> > It's needed by the 14.6 version of Node.
> 
> The core-updates branch already has libuv 1.38.1, so this patch might
> become unnecessary depending on when Node 14.6 gets added - I think it
> would be better if you submitted this patch as part of the Node 14.6
> patchstack.
> 
> Regards,
> Jakub Kądziołka

Whoops, I didn't see your Node patch, as the page-break on Debbugs
obscured it. Not too long ago we only had a single page worth of pending
patches... :/

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 42638-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: 42638-done <at> debbugs.gnu.org
Cc: Jakub Kądziołka <kuba <at> kadziolka.net>,
 Mathieu Othacehe <othacehe <at> gnu.org>, Formbi <formbi <at> protonmail.com>
Subject: Re: bug#42638: [PATCH] bump libuv to 1.38
Date: Sun, 28 May 2023 23:56:46 +0200

We now use libuv <at> 1.44.2 on master (/w node <at> 18), so closing this one.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.