GNU bug report logs - #42639
[PATCH] bump Node to 14.6

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42639 in the body.
You can then email your comments to 42639 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] bump Node to 14.6
Date: Fri, 31 Jul 2020 17:11:38 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0002-bump-node-to-14.6.patch (text/x-patch, attachment)]

Message #8 received at 42639 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Formbi <formbi <at> protonmail.com>,
 Formbi via Guix-patches <guix-patches <at> gnu.org>, 42639 <at> debbugs.gnu.org
Subject: Re: [bug#42639] [PATCH] bump Node to 14.6
Date: Fri, 31 Jul 2020 23:26:52 +0200

Hey Formbi,


Formbi via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH 2/2] bump node to 14.6

Sadly, recent node versions come bundled with generated code based on
the llhttp[1] project. These generated source files can be found in the
deps/llhttp/src directory of the 14.6 release, and the annoying thing is
that upstream uses typescript to generate these C files. See [2] for my
feeble attempt at having upstream take note of this issue to allow for
properly bootstrapping lltthp and subsequently recent versions of node.

There are some alternative typescript implementations that I
unsuccessfully have tried in the past in at least translating the
typescript used in llhttp to normal javascript, which we could then
interpret using our packaged version of node to build the C files that
would allow us to build newer versions of node. The ones I looked at in
some detail are:

- Sucrase [3] but it doesn't support all used typescript constructs
- swc [4] but it actually depends on the normal typescript compiler

I'm sorry I don't have better news to share either.  Perhaps some
guile-guru can drop down from their higher spheres of existence and
create a hacky interpreter that translates typescript to
extremely-ugly-yet-correct javascript to help us escape this quagmire.

- Jelle


[1] https://github.com/nodejs/llhttp
[2] https://github.com/nodejs/llhttp/issues/14
[3] https://github.com/alangpierce/sucrase/issues/464
[4] https://github.com/swc-project/swc

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: "42639 <at> debbugs.gnu.org" <42639 <at> debbugs.gnu.org>,
 Formbi via Guix-patches <guix-patches <at> gnu.org>
Subject: Re: [bug#42639] [PATCH] bump Node to 14.6
Date: Fri, 31 Jul 2020 21:33:11 +0000

oh my bananas, that's bad news :(

Message #20 received at 42639 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: formbi <at> protonmail.com, 42639 <at> debbugs.gnu.org
Subject: Re: [bug#42639] [PATCH] bump Node to 14.6
Date: Fri, 31 Jul 2020 23:37:24 +0200

Jelle Licht <jlicht <at> fsfe.org> writes:

> would allow us to build newer versions of node. The ones I looked at in
> some detail are:
>
> - Sucrase [3] but it doesn't support all used typescript constructs
> - swc [4] but it actually depends on the normal typescript compiler
 [snip]
> [4] https://github.com/swc-project/swc
It seems this is not actually the case, but swc still seems to depend on
having a rust nightly compiler available.

- Jelle

Message #23 received at 42639 <at> debbugs.gnu.org (full text, mbox):

From: Formbi <formbi <at> protonmail.com>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: "42639 <at> debbugs.gnu.org" <42639 <at> debbugs.gnu.org>
Subject: Re: [bug#42639] [PATCH] bump Node to 14.6
Date: Fri, 31 Jul 2020 21:41:07 +0000

> seems to depend on having a rust nightly compiler available.

we have Rust 1.45.1 in Guix, wouldn't it be sufficient?

Message #26 received at 42639 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Jelle Licht <jlicht <at> fsfe.org>, r <at> gravity
Cc: formbi <at> protonmail.com, 42639 <at> debbugs.gnu.org
Subject: Re: [bug#42639] [PATCH] bump Node to 14.6
Date: Fri, 7 Aug 2020 00:01:24 +0200

[Message part 1 (text/plain, inline)]

On Fri, Jul 31, 2020 at 11:37:24PM +0200, Jelle Licht wrote:
> Jelle Licht <jlicht <at> fsfe.org> writes:
> 
> > would allow us to build newer versions of node. The ones I looked at in
> > some detail are:
> >
> > - Sucrase [3] but it doesn't support all used typescript constructs
> > - swc [4] but it actually depends on the normal typescript compiler
>  [snip]
> > [4] https://github.com/swc-project/swc
> It seems this is not actually the case, but swc still seems to depend on
> having a rust nightly compiler available.
> 
> - Jelle

It seems that a nightly compiler is only used for an optimization flag:
commenting out the -Z thinlto=no line in .cargo/config in swc's repo
made it pass `cargo check' just fine.

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 42639 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Jakub Kądziołka <kuba <at> kadziolka.net>, r <at> gravity
Cc: formbi <at> protonmail.com, 42639 <at> debbugs.gnu.org
Subject: Re: [bug#42639] [PATCH] bump Node to 14.6
Date: Fri, 07 Aug 2020 00:53:53 +0200

Jakub Kądziołka <kuba <at> kadziolka.net> writes:

> On Fri, Jul 31, 2020 at 11:37:24PM +0200, Jelle Licht wrote:
>> It seems this is not actually the case, but swc still seems to depend on
>> having a rust nightly compiler available.
>> 
>> - Jelle
>
> It seems that a nightly compiler is only used for an optimization flag:
> commenting out the -Z thinlto=no line in .cargo/config in swc's repo
> made it pass `cargo check' just fine.

Indeed it does; does that fix this problem for us? At this stage, I end
up with a library that was built successfully, but no clue how to
continue from here. Either way, progress! ;)

- Jelle

Message #32 received at 42639 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: formbi <at> protonmail.com, 42639 <at> debbugs.gnu.org
Subject: Re: [bug#42639] [PATCH] bump Node to 14.6
Date: Fri, 7 Aug 2020 15:58:39 +0200

[Message part 1 (text/plain, inline)]

On Fri, Aug 07, 2020 at 12:53:53AM +0200, Jelle Licht wrote:
> Indeed it does; does that fix this problem for us? At this stage, I end
> up with a library that was built successfully, but no clue how to
> continue from here. Either way, progress! ;)

Hmm, it seems that the main way to use swc is by a wrapper written in
TypeScript (node-swc/src), which is built with neon, also a tool written
in TypeScript. However, it seems that it shouldn't be too hard to invoke
swc with just Rust, with something along the lines of examples/usage.rs

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 42639-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: 42639-done <at> debbugs.gnu.org 
Cc: Jakub Kądziołka <kuba <at> kadziolka.net>,
 formbi <at> protonmail.com
Subject: Re: bug#42639: [PATCH] bump Node to 14.6
Date: Sun, 28 May 2023 23:58:11 +0200

We now have node <at> 18 on master, and worked around the bootstrapping issue
using a different solution (esbuild). Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.