GNU bug report logs - #42658
[PATCH 1/2] gnu: android: export android-libcutils

Previous Next

Package: guix-patches;

Reported by: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>

Date: Sat, 1 Aug 2020 20:24:03 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42658 in the body.
You can then email your comments to 42658 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#42658; Package guix-patches. (Sat, 01 Aug 2020 20:24:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 01 Aug 2020 20:24:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Julien Lepiller <julien <at> lepiller.eu>,
 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 1/2] gnu: android: export android-libcutils
Date: Sat,  1 Aug 2020 22:16:24 +0200
Android's libcutils is used by many Android components, and as Guix can be
used to bulid Android components, it is useful to export it as it can then
be reused as an input to packages being developped outside of the Guix
source code repository.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
---
 gnu/packages/android.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index 0fb4330d3e..af2b817298 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -229,7 +229,7 @@ in Main, System, Radio and Events sub-logs.")
 various Android core host applications.")
     (license license:asl2.0)))
 
-(define android-libcutils
+(define-public android-libcutils
   (package
     (name "android-libcutils")
     (version (android-platform-version))
-- 
2.28.0





Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Mon, 03 Aug 2020 07:17:02 GMT) Full text and rfc822 format available.

Notification sent to Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>:
bug acknowledged by developer. (Mon, 03 Aug 2020 07:17:02 GMT) Full text and rfc822 format available.

Message #10 received at 42658-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Julien Lepiller <julien <at> lepiller.eu>, 42658-done <at> debbugs.gnu.org
Subject: Re: [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils
Date: Mon, 03 Aug 2020 09:16:16 +0200
Hello,

> Android's libcutils is used by many Android components, and as Guix can be
> used to bulid Android components, it is useful to export it as it can then
> be reused as an input to packages being developped outside of the Guix
> source code repository.

This looks fine. I pushed those two patches with edited commit
messages. For future reference, very similar patches can be send in the
same serie :).

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#42658; Package guix-patches. (Wed, 05 Aug 2020 06:30:01 GMT) Full text and rfc822 format available.

Message #13 received at 42658-done <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Julien Lepiller <julien <at> lepiller.eu>, 42658-done <at> debbugs.gnu.org
Subject: Re: [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils
Date: Wed, 5 Aug 2020 08:20:31 +0200
[Message part 1 (text/plain, inline)]
On Mon, 03 Aug 2020 09:16:16 +0200
Mathieu Othacehe <othacehe <at> gnu.org> wrote:

> Hello,
Hi,

> This looks fine. I pushed those two patches with edited commit
> messages. 
Thanks a lot. I'll probably have more patches that I need to send it
soon but I need to find a faster way to test them.

> For future reference, very similar patches can be send in
> the same serie :).

How do I do that? I used the following command to send the patch:
> git send-email --to="guix-patches <at> gnu.org" \
> 	--cc="Julien Lepiller <julien <at> lepiller.eu>" \
> 	--cc="Danny Milosavljevic <dannym <at> scratchpost.org>" \
> 	0001-gnu-android-export-android-libcutils.patch \
> 	0002-gnu-android-export-android-liblog.patch \
> 	${sentinel}

Do I need to use --compose?

Denis.
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#42658; Package guix-patches. (Wed, 05 Aug 2020 07:41:02 GMT) Full text and rfc822 format available.

Message #16 received at 42658-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Julien Lepiller <julien <at> lepiller.eu>, 42658-done <at> debbugs.gnu.org
Subject: Re: [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils
Date: Wed, 05 Aug 2020 09:40:25 +0200
Hello,

> How do I do that? I used the following command to send the patch:
>> git send-email --to="guix-patches <at> gnu.org" \
>> 	--cc="Julien Lepiller <julien <at> lepiller.eu>" \
>> 	--cc="Danny Milosavljevic <dannym <at> scratchpost.org>" \
>> 	0001-gnu-android-export-android-libcutils.patch \
>> 	0002-gnu-android-export-android-liblog.patch \
>> 	${sentinel}

Each time a mail is sent to "guix-patches <at> gnu.org" a new bug ticket is
created. You should first send either the cover letter or the first
patch, and then send all the subsequent patches to NNN <at> debbugs.gnu.org
where NNN is the ticket number created when the first patch is sent.

See the bottom of
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html for
further explications.

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#42658; Package guix-patches. (Wed, 05 Aug 2020 09:21:02 GMT) Full text and rfc822 format available.

Message #19 received at 42658-done <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Julien Lepiller <julien <at> lepiller.eu>, 42658-done <at> debbugs.gnu.org
Subject: Re: [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils
Date: Wed, 5 Aug 2020 11:11:49 +0200
[Message part 1 (text/plain, inline)]
On Wed, 05 Aug 2020 09:40:25 +0200
Mathieu Othacehe <othacehe <at> gnu.org> wrote:
> Each time a mail is sent to "guix-patches <at> gnu.org" a new bug ticket is
> created. You should first send either the cover letter or the first
> patch, and then send all the subsequent patches to NNN <at> debbugs.gnu.org
> where NNN is the ticket number created when the first patch is sent.
> 
> See the bottom of
> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html for
> further explications.
Thanks a lot.

I read that part in the manual some time ago but I didn't think of
(ab)using it in this way to get the intended result.

Denis.
[Message part 2 (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 02 Sep 2020 11:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 208 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.