GNU bug report logs - #42681
[PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search paths.

Previous Next

Package: guix-patches;

Reported by: Jakub Kądziołka <kuba <at> kadziolka.net>

Date: Sun, 2 Aug 2020 20:35:02 UTC

Severity: normal

Tags: patch

Done: Jakub Kądziołka <kuba <at> kadziolka.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42681 in the body.
You can then email your comments to 42681 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#42681; Package guix-patches. (Sun, 02 Aug 2020 20:35:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jakub Kądziołka <kuba <at> kadziolka.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 02 Aug 2020 20:35:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: guix-patches <at> gnu.org
Cc: efraim <at> flashner.co.il
Subject: [PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search paths.
Date: Sun,  2 Aug 2020 22:34:21 +0200
This updates the bootstrap-gcc to use the same search path strategy as
the main compilers, making the bootstrap environment more similar across
architectures, and fixing the bootstrap path on non-x86 architectures
again.

This is a follow up to commit 7cde865f12dd67e55946a52a21103e71f447eced.

* gnu/packages/bootstrap.scm (%bootstrap-gcc)[native-search-paths]: Use
  C_INCLUDE_PATH and CPLUS_INCLUDE_PATH instead of CPATH.
---

Note: because I don't have any non-x86 machines on hand, I haven't
actually tested the patch yet.

Efraim, you have helped me investigate this with your ARM board, perhaps
you could test this patch?

Regards,
Jakub Kądziołka
 gnu/packages/bootstrap.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bootstrap.scm b/gnu/packages/bootstrap.scm
index c39e60ec8b..fd6c2e099c 100644
--- a/gnu/packages/bootstrap.scm
+++ b/gnu/packages/bootstrap.scm
@@ -740,8 +740,11 @@ exec ~a/bin/.gcc-wrapped -B~a/lib \
                            "1m5miqkyng45l745n0sfafdpjkqv9225xf44jqkygwsipj2cv9ks")))))))))
     (native-search-paths
      (list (search-path-specification
-            (variable "CPATH")
+            (variable "C_INCLUDE_PATH")
             (files '("include")))
+           (search-path-specification
+            (variable "CPLUS_INCLUDE_PATH")
+            (files '("include/c++" "include")))
            (search-path-specification
             (variable "LIBRARY_PATH")
             (files '("lib" "lib64")))))
-- 
2.28.0





Information forwarded to guix-patches <at> gnu.org:
bug#42681; Package guix-patches. (Mon, 03 Aug 2020 06:42:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search
 paths.
Date: Mon, 3 Aug 2020 09:40:26 +0300
[Message part 1 (text/plain, inline)]
On Sun, Aug 02, 2020 at 10:34:21PM +0200, Jakub Kądziołka wrote:
> This updates the bootstrap-gcc to use the same search path strategy as
> the main compilers, making the bootstrap environment more similar across
> architectures, and fixing the bootstrap path on non-x86 architectures
> again.
> 
> This is a follow up to commit 7cde865f12dd67e55946a52a21103e71f447eced.
> 
> * gnu/packages/bootstrap.scm (%bootstrap-gcc)[native-search-paths]: Use
>   C_INCLUDE_PATH and CPLUS_INCLUDE_PATH instead of CPATH.
> ---
> 
> Note: because I don't have any non-x86 machines on hand, I haven't
> actually tested the patch yet.
> 
> Efraim, you have helped me investigate this with your ARM board, perhaps
> you could test this patch?
> 
> Regards,
> Jakub Kądziołka
>  gnu/packages/bootstrap.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/bootstrap.scm b/gnu/packages/bootstrap.scm
> index c39e60ec8b..fd6c2e099c 100644
> --- a/gnu/packages/bootstrap.scm
> +++ b/gnu/packages/bootstrap.scm
> @@ -740,8 +740,11 @@ exec ~a/bin/.gcc-wrapped -B~a/lib \
>                             "1m5miqkyng45l745n0sfafdpjkqv9225xf44jqkygwsipj2cv9ks")))))))))
>      (native-search-paths
>       (list (search-path-specification
> -            (variable "CPATH")
> +            (variable "C_INCLUDE_PATH")
>              (files '("include")))
> +           (search-path-specification
> +            (variable "CPLUS_INCLUDE_PATH")
> +            (files '("include/c++" "include")))
>             (search-path-specification
>              (variable "LIBRARY_PATH")
>              (files '("lib" "lib64")))))
> -- 
> 2.28.0
> 

I'm building out to hello on my aarch64 board now, starting from
make-boot0 apparently. Guile is only listed once so hopefully it won't
take too long.

I assume this doesn't break anything on x86_64?

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#42681; Package guix-patches. (Mon, 03 Aug 2020 11:04:02 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search
 paths.
Date: Mon, 3 Aug 2020 13:03:52 +0200
[Message part 1 (text/plain, inline)]
On Mon, Aug 03, 2020 at 09:40:26AM +0300, Efraim Flashner wrote:
> On Sun, Aug 02, 2020 at 10:34:21PM +0200, Jakub Kądziołka wrote:
> > This updates the bootstrap-gcc to use the same search path strategy as
> > the main compilers, making the bootstrap environment more similar across
> > architectures, and fixing the bootstrap path on non-x86 architectures
> > again.
> > 
> > This is a follow up to commit 7cde865f12dd67e55946a52a21103e71f447eced.
> > 
> > * gnu/packages/bootstrap.scm (%bootstrap-gcc)[native-search-paths]: Use
> >   C_INCLUDE_PATH and CPLUS_INCLUDE_PATH instead of CPATH.
> > ---
> > 
> > Note: because I don't have any non-x86 machines on hand, I haven't
> > actually tested the patch yet.
> > 
> > Efraim, you have helped me investigate this with your ARM board, perhaps
> > you could test this patch?
> > 
> > Regards,
> > Jakub Kądziołka
> >  gnu/packages/bootstrap.scm | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/bootstrap.scm b/gnu/packages/bootstrap.scm
> > index c39e60ec8b..fd6c2e099c 100644
> > --- a/gnu/packages/bootstrap.scm
> > +++ b/gnu/packages/bootstrap.scm
> > @@ -740,8 +740,11 @@ exec ~a/bin/.gcc-wrapped -B~a/lib \
> >                             "1m5miqkyng45l745n0sfafdpjkqv9225xf44jqkygwsipj2cv9ks")))))))))
> >      (native-search-paths
> >       (list (search-path-specification
> > -            (variable "CPATH")
> > +            (variable "C_INCLUDE_PATH")
> >              (files '("include")))
> > +           (search-path-specification
> > +            (variable "CPLUS_INCLUDE_PATH")
> > +            (files '("include/c++" "include")))
> >             (search-path-specification
> >              (variable "LIBRARY_PATH")
> >              (files '("lib" "lib64")))))
> > -- 
> > 2.28.0
> > 
> 
> I'm building out to hello on my aarch64 board now, starting from
> make-boot0 apparently. Guile is only listed once so hopefully it won't
> take too long.

Thanks!

> I assume this doesn't break anything on x86_64?

I don't have hello built on current core-updates (it also wants to start
from make-boot0), but I have confirmed that guix build --no-grafts -d
hello returns the same derivation path before and after the commit.
%bootstrap-gcc is not present at all in the package graph on x86.

Regards,
Jakub Kądziołka
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#42681; Package guix-patches. (Tue, 04 Aug 2020 06:01:02 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search
 paths.
Date: Tue, 4 Aug 2020 09:00:06 +0300
[Message part 1 (text/plain, inline)]
On Mon, Aug 03, 2020 at 01:03:52PM +0200, Jakub Kądziołka wrote:
> On Mon, Aug 03, 2020 at 09:40:26AM +0300, Efraim Flashner wrote:
> > On Sun, Aug 02, 2020 at 10:34:21PM +0200, Jakub Kądziołka wrote:
> > > This updates the bootstrap-gcc to use the same search path strategy as
> > > the main compilers, making the bootstrap environment more similar across
> > > architectures, and fixing the bootstrap path on non-x86 architectures
> > > again.
> > > 
> > > This is a follow up to commit 7cde865f12dd67e55946a52a21103e71f447eced.
> > > 
> > > * gnu/packages/bootstrap.scm (%bootstrap-gcc)[native-search-paths]: Use
> > >   C_INCLUDE_PATH and CPLUS_INCLUDE_PATH instead of CPATH.
> > > ---
> > > 
> > > Note: because I don't have any non-x86 machines on hand, I haven't
> > > actually tested the patch yet.
> > > 
> > > Efraim, you have helped me investigate this with your ARM board, perhaps
> > > you could test this patch?
> > > 
> > > Regards,
> > > Jakub Kądziołka
> > >  gnu/packages/bootstrap.scm | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/gnu/packages/bootstrap.scm b/gnu/packages/bootstrap.scm
> > > index c39e60ec8b..fd6c2e099c 100644
> > > --- a/gnu/packages/bootstrap.scm
> > > +++ b/gnu/packages/bootstrap.scm
> > > @@ -740,8 +740,11 @@ exec ~a/bin/.gcc-wrapped -B~a/lib \
> > >                             "1m5miqkyng45l745n0sfafdpjkqv9225xf44jqkygwsipj2cv9ks")))))))))
> > >      (native-search-paths
> > >       (list (search-path-specification
> > > -            (variable "CPATH")
> > > +            (variable "C_INCLUDE_PATH")
> > >              (files '("include")))
> > > +           (search-path-specification
> > > +            (variable "CPLUS_INCLUDE_PATH")
> > > +            (files '("include/c++" "include")))
> > >             (search-path-specification
> > >              (variable "LIBRARY_PATH")
> > >              (files '("lib" "lib64")))))
> > > -- 
> > > 2.28.0
> > > 
> > 
> > I'm building out to hello on my aarch64 board now, starting from
> > make-boot0 apparently. Guile is only listed once so hopefully it won't
> > take too long.
> 
> Thanks!
> 
> > I assume this doesn't break anything on x86_64?
> 
> I don't have hello built on current core-updates (it also wants to start
> from make-boot0), but I have confirmed that guix build --no-grafts -d
> hello returns the same derivation path before and after the commit.
> %bootstrap-gcc is not present at all in the package graph on x86.
> 
> Regards,
> Jakub Kądziołka

I was able to successfully build all the way out to hello on
aarch64-linux.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Reply sent to Jakub Kądziołka <kuba <at> kadziolka.net>:
You have taken responsibility. (Tue, 04 Aug 2020 12:35:01 GMT) Full text and rfc822 format available.

Notification sent to Jakub Kądziołka <kuba <at> kadziolka.net>:
bug acknowledged by developer. (Tue, 04 Aug 2020 12:35:01 GMT) Full text and rfc822 format available.

Message #19 received at 42681-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 42681-done <at> debbugs.gnu.org
Subject: Re: [PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search
 paths.
Date: Tue, 4 Aug 2020 14:34:35 +0200
[Message part 1 (text/plain, inline)]
On Tue, Aug 04, 2020 at 09:00:06AM +0300, Efraim Flashner wrote:
> On Mon, Aug 03, 2020 at 01:03:52PM +0200, Jakub Kądziołka wrote:
> > On Mon, Aug 03, 2020 at 09:40:26AM +0300, Efraim Flashner wrote:
> > > On Sun, Aug 02, 2020 at 10:34:21PM +0200, Jakub Kądziołka wrote:
> > > I'm building out to hello on my aarch64 board now, starting from
> > > make-boot0 apparently. Guile is only listed once so hopefully it won't
> > > take too long.
> > 
> > Thanks!
> > 
> > > I assume this doesn't break anything on x86_64?
> > 
> > I don't have hello built on current core-updates (it also wants to start
> > from make-boot0), but I have confirmed that guix build --no-grafts -d
> > hello returns the same derivation path before and after the commit.
> > %bootstrap-gcc is not present at all in the package graph on x86.
> > 
> > Regards,
> > Jakub Kądziołka
> 
> I was able to successfully build all the way out to hello on
> aarch64-linux.

This is great news! Patch pushed.

Regards,
Jakub Kądziołka
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#42681; Package guix-patches. (Wed, 05 Aug 2020 08:57:02 GMT) Full text and rfc822 format available.

Message #22 received at 42681-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 42681-done <at> debbugs.gnu.org
Subject: Re: [PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search
 paths.
Date: Wed, 5 Aug 2020 11:56:06 +0300
[Message part 1 (text/plain, inline)]
On Tue, Aug 04, 2020 at 02:34:35PM +0200, Jakub Kądziołka wrote:
> On Tue, Aug 04, 2020 at 09:00:06AM +0300, Efraim Flashner wrote:
> > On Mon, Aug 03, 2020 at 01:03:52PM +0200, Jakub Kądziołka wrote:
> > > On Mon, Aug 03, 2020 at 09:40:26AM +0300, Efraim Flashner wrote:
> > > > On Sun, Aug 02, 2020 at 10:34:21PM +0200, Jakub Kądziołka wrote:
> > > > I'm building out to hello on my aarch64 board now, starting from
> > > > make-boot0 apparently. Guile is only listed once so hopefully it won't
> > > > take too long.
> > > 
> > > Thanks!
> > > 
> > > > I assume this doesn't break anything on x86_64?
> > > 
> > > I don't have hello built on current core-updates (it also wants to start
> > > from make-boot0), but I have confirmed that guix build --no-grafts -d
> > > hello returns the same derivation path before and after the commit.
> > > %bootstrap-gcc is not present at all in the package graph on x86.
> > > 
> > 
> > I was able to successfully build all the way out to hello on
> > aarch64-linux.
> 
> This is great news! Patch pushed.
> 

Continued testing shows that this also worked on my aarch64 board when
building for armhf.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 02 Sep 2020 11:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 208 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.