GNU bug report logs - #42689
add sbcl-cl-livesupport

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42689 in the body.
You can then email your comments to 42689 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: add sbcl-cl-livesupport
Date: Mon, 3 Aug 2020 09:30:11 +0200 (CEST)

(define-public sbcl-cl-livesupport
  (let ((commit "71e6e412df9f3759ad8378fabb203913d82e228a")
(revision "1"))
    (package
      (name "sbcl-livesupport")
      (version (git-version "0.0.0" revision commit))
      (source
       (origin
         (method git-fetch)
         (uri (git-reference
               (url "https://github.com/cbaggers/livesupport")
               (commit commit)))
         (file-name (git-file-name name version))
         (sha256
          (base32 "1rvnl0mncylbx63608pz5llss7y92j7z3ydambk9mcnjg2mjaapg"))))
      (build-system asdf-build-system/sbcl)
      (home-page "https://github.com/cbaggers/livesupport")
      (synopsis "Some helpers that make livecoding at little easier")
      (description "A macro commonly used in livecoding to enable continuing when errors are raised. Simply wrap around a chunk of code and it provides a restart called 'continue' which ignores the error and carrys on from the end of the body. I usually wrap this around the code 'step' function in my main loop.")
      (license license:bsd-2))))

Message #8 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Adam Kandur <rndd <at> tuta.io>
Cc: 42689 <at> debbugs.gnu.org
Subject: Re: [bug#42689] add sbcl-cl-livesupport
Date: Mon, 03 Aug 2020 23:22:00 -0500

Adam Kandur <rndd <at> tuta.io> writes:

> (define-public sbcl-cl-livesupport
>   (let ((commit "71e6e412df9f3759ad8378fabb203913d82e228a")
> (revision "1"))
>     (package
>       (name "sbcl-livesupport")
>       (version (git-version "0.0.0" revision commit))
>       (source
>        (origin
>          (method git-fetch)
>          (uri (git-reference
>                (url "https://github.com/cbaggers/livesupport")
>                (commit commit)))
>          (file-name (git-file-name name version))
>          (sha256
>           (base32 "1rvnl0mncylbx63608pz5llss7y92j7z3ydambk9mcnjg2mjaapg"))))
>       (build-system asdf-build-system/sbcl)
>       (home-page "https://github.com/cbaggers/livesupport")
>       (synopsis "Some helpers that make livecoding at little easier")
>       (description "A macro commonly used in livecoding to enable
> continuing when errors are raised. Simply wrap around a chunk of code
> and it provides a restart called 'continue' which ignores the error
> and carrys on from the end of the body. I usually wrap this around the
> code 'step' function in my main loop.")
>       (license license:bsd-2))))

Hi again, Adam!

Same situation here, as per my last email :).

Message #11 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Adam Kandur <rndd <at> tuta.io>, 42689 <at> debbugs.gnu.org
Subject: Re: [bug#42689] add sbcl-cl-livesupport
Date: Tue, 04 Aug 2020 12:28:19 -0500

Adam Kandur <rndd <at> tuta.io> writes:

> like this ?
>
> From 5cade1fff3fb64892321505edd9ac1b13420782e Mon Sep 17 00:00:00 2001
> From: Adam Kandur <rndd <at> tuta.io>
> Date: Tue, 4 Aug 2020 17:40:50 +0300
> Subject: [PATCH] add sbcl-livesupport in gnu/packages/lisp-xyz.scm
>


This is closer, however the commit message and subheader do not conform
to our standards. We use the changelog format for our commit messages
and headers. This can be automated using our snippets with yasnippet if
you are an emacs user. Let me know if you need more help. Also, be sure
to reply to all when interacting with our bug reports. This email is
considered "off list" as you sent it to me only, and thus nobody else
will be able to see your last message :).

Brett Gilio

Message #14 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Adam Kandur <rndd <at> tuta.io>, 42689 <at> debbugs.gnu.org
Subject: Re: [bug#42689] add sbcl-cl-livesupport
Date: Tue, 04 Aug 2020 13:09:32 -0500

Adam Kandur <rndd <at> tuta.io> writes:

> ok, could you give me more information about this format and where i can view some accepted patches?
>
>
>
> Aug 4, 2020, 17:28 by brettg <at> gnu.org:
>
>> Adam Kandur <rndd <at> tuta.io> writes:
>>
>>> like this ?
>>>
>>> From 5cade1fff3fb64892321505edd9ac1b13420782e Mon Sep 17 00:00:00 2001
>>> From: Adam Kandur <rndd <at> tuta.io>
>>> Date: Tue, 4 Aug 2020 17:40:50 +0300
>>> Subject: [PATCH] add sbcl-livesupport in gnu/packages/lisp-xyz.scm
>>>
>>
>>
>> This is closer, however the commit message and subheader do not conform
>> to our standards. We use the changelog format for our commit messages
>> and headers. This can be automated using our snippets with yasnippet if
>> you are an emacs user. Let me know if you need more help. Also, be sure
>> to reply to all when interacting with our bug reports. This email is
>> considered "off list" as you sent it to me only, and thus nobody else
>> will be able to see your last message :).
>>
>> Brett Gilio
>>

Hi again, Adam.

I don't think you are replying to all when you respond. This is
important so that everybody subscribed to the list can see our
interactions! :)

If you use emacs, use yasnippet and our snippets for adding and updating
packages are in ./etc/snippets. You can configure yasnippet to load
these whenever you interact with
magit. https://guix.gnu.org/manual/en/html_node/The-Perfect-Setup.html

For some examples of guix patches that have been accepted and committed,
check the git log either from magit (M-x magit-log), or from
http://git.savannah.gnu.org/cgit/guix.git/.

Thanks!

Brett Gilio

Message #17 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: 42689 <at> debbugs.gnu.org
Subject: another try
Date: Tue, 4 Aug 2020 20:54:56 +0200 (CEST)

From 5cade1fff3fb64892321505edd9ac1b13420782e Mon Sep 17 00:00:00 2001
From: Adam Kandur <rndd <at> tuta.io>
Date: Tue, 4 Aug 2020 17:40:50 +0300
Subject: [PATCH] add sbcl-livesupport in gnu/packages/lisp-xyz.scm

---
 gnu/packages/lisp-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 767f50c104..fb2b664f26 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -13395,3 +13395,32 @@ and decoder for Common Lisp.")
 
 (define-public ecl-qbase64
   (sbcl-package->ecl-package sbcl-qbase64))
+
+(define-public sbcl-livesupport
+  (let ((commit "71e6e412df9f3759ad8378fabb203913d82e228a")
+    (revision "1"))
+    (package
+      (name "sbcl-livesupport")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/cbaggers/livesupport")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1rvnl0mncylbx63608pz5llss7y92j7z3ydambk9mcnjg2mjaapg"))))
+      (build-system asdf-build-system/sbcl)
+      (home-page "https://github.com/cbaggers/livesupport")
+      (synopsis "Some helpers that make livecoding at little easier")
+      (description "A macro commonly used in livecoding to enable continuing when errors are raised. 
+Simply wrap around a chunk of code and it provides a restart called 'continue' which ignores the error and carrys on from the end of the body. 
+I usually wrap this around the code 'step' function in my main loop.")
+      (license license:bsd-2))))
+
+(define-public cl-livesupport
+  (sbcl-package->cl-source-package sbcl-livesupport))
+
+(define-public ecl-livesupport
+  (sbcl-package->ecl-package sbcl-livesupport))
-- 
2.28.0

Message #20 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Adam Kandur <rndd <at> tuta.io>
Cc: 42689 <at> debbugs.gnu.org
Subject: Re: [bug#42689] another try
Date: Tue, 04 Aug 2020 20:38:04 -0500

Adam Kandur <rndd <at> tuta.io> writes:

>>From 5cade1fff3fb64892321505edd9ac1b13420782e Mon Sep 17 00:00:00 2001
> From: Adam Kandur <rndd <at> tuta.io>
> Date: Tue, 4 Aug 2020 17:40:50 +0300
> Subject: [PATCH] add sbcl-livesupport in gnu/packages/lisp-xyz.scm
>
> ---
>  gnu/packages/lisp-xyz.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>

Hi Adam,

I am sorry to be a pest, but the commit message is still not following
our snippet protocol. I was trying to apply your patch, and take care of
it for you so that you could see what our expectation is more clearly
but your patch is mangled.

Could you walk me through, step by step, how you are creating, and then
sending the patch? That will help us immensely, in both getting you in
the right direction for future contributions (if you so choose), and in
seeing if there is something we need to do differently. :)

Thanks!
Brett Gilio

Message #23 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
To: Brett Gilio <brettg <at> gnu.org>
Cc: 42689 <at> debbugs.gnu.org, Adam Kandur <rndd <at> tuta.io>
Subject: Re: [bug#42689] another try
Date: Wed, 05 Aug 2020 08:28:39 +0300

Hello Adam and Brett,

Brett Gilio <brettg <at> gnu.org> writes:

> Adam Kandur <rndd <at> tuta.io> writes:
>
>>>>From 5cade1fff3fb64892321505edd9ac1b13420782e Mon Sep 17 00:00:00 2001
>> From: Adam Kandur <rndd <at> tuta.io>
>> Date: Tue, 4 Aug 2020 17:40:50 +0300
>> Subject: [PATCH] add sbcl-livesupport in gnu/packages/lisp-xyz.scm
>>
>> ---
>>  gnu/packages/lisp-xyz.scm | 29 +++++++++++++++++++++++++++++
>>  1 file changed, 29 insertions(+)
>>
>
> Hi Adam,
>
> I am sorry to be a pest, but the commit message is still not following
> our snippet protocol. I was trying to apply your patch, and take care of
> it for you so that you could see what our expectation is more clearly
> but your patch is mangled.

Adam, I'm a fellow contributor, like you, and I'd like to share some of
what I learned when sending patches to Guix.

Brett says that your patch is mangled -- that usually happens at
sending, depending on your email client. If you create your patches with
`git format-patch`, I wouldn't trust an email client to keep the text
intact by just pasting in the body of the mail. I would, instead, attach
the patch file.

You could, instead of manually putting the patch in a mail yourself,
send it with `git send-email`. There is a great guide regarding how to
do this: https://git-send-email.io/ . This is what I use to send patches
to GNU Guix.

As for the commit message itself, besides the snippet solution Brett
suggested (maybe you're not using Emacs), there's always grepping the
git log. I run `git log` in the guix source directory and search (using
the '/' key) for whatever my patch does: if I'm adding a package, I
search for "Add", for example.

Here's what a commit that adds a new package usually looks like:

--8<---------------cut here---------------start------------->8---
commit 28cbf3ef42353a491028d405a66595d45f3c8998
    gnu: Add python-pgpy.

    * gnu/packages/python-crypto.scm (python-pgpy): New variable.
--8<---------------cut here---------------end--------------->8---

Most of the time when adding a new package you follow this
template. Replace the package name and file with whatever you have and
you should be all set. (The "commit 28..." is just to show you what
commit is this taken from. You must care only about what follows after it.)

To format the commit message nicely, I recommend that you don't use the
-m/--message flag, but let git open your $EDITOR so you can easily write
multiple lines, like in the example above.

If you want to change the message of your last commit, you can use git
commit --amend.

If you want to read more about the ChangeLog format, I believe this is
the right place to look:
https://www.gnu.org/prep/standards/html_node/Change-Logs.html . Myself,
I never read that, but I always looks through the git log to see how
others formatted messages for similar commits before.

Cheers,
Sergiu

Message #26 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: 42689 <42689 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: Add sbcl-livesupport
Date: Wed, 5 Aug 2020 09:17:21 +0200 (CEST)

[Message part 1 (text/plain, inline)]

so, when i want to make a patch:
1) i "cd ~/path/to/guix"
2) make changes
3) git add gnu/packages/file_i_changed.scm (gnu/packages/lisp-xyz.scm for example)
4) git commit -m 'gnu: Add sbcl-livesupport'
5) git format-patch origin/master
6) for this one i attached file 0001-gnu-Add-sbcl-livesupport.patch

P.S.: my bad but i don't know how to use email with git. if anyone used tutanota.com please note how to do it

[0001-gnu-Add-sbcl-livesupport.patch (text/x-patch, attachment)]

Message #29 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: 42689 <42689 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: Add sbcl-livesupport
Date: Tue, 11 Aug 2020 22:23:09 +0200 (CEST)

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-sbcl-livesupport.patch (text/x-patch, attachment)]

Message #32 received at 42689 <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: 42689 <42689 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: Add sbcl-livesupport
Date: Wed, 12 Aug 2020 08:55:36 +0200 (CEST)

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-sbcl-livesupport.patch (text/x-patch, attachment)]

Message #35 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Adam Kandur via Guix-patches via <guix-patches <at> gnu.org>
Cc: 42689 <42689-done <at> debbugs.gnu.org>
Subject: Re: [bug#42689] [PATCH] gnu: Add sbcl-livesupport
Date: Sat, 22 Aug 2020 14:23:21 -0400

> From 1aeb04ad466937b50acd1a2540e50f59446b6d8c Mon Sep 17 00:00:00 2001
> From: Adam Kandur <rndd <at> tuta.io>
> Date: Wed, 12 Aug 2020 09:52:05 +0300
> Subject: [PATCH] gnu: Add sbcl-livesupport.
> 
> * gnu/packages/lisp-xyz.scm (sbcl-livesupport): New variable.

Thanks! I added the other new variables to the commit message...

> +      (description "A macro commonly used in livecoding to enable continuing when errors are raised. 
> +Simply wrap around a chunk of code and it provides a restart called 'continue' which ignores the error and carrys on from the end of the body.")

And fixed some issues reported by `guix lint` in the description.

Pushed as ca7eada91819c7cd5a78e144d285cd972a478a0c

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.