GNU bug report logs - #42723
28.0.50; cconv-tests fails on Macos

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42723 in the body.
You can then email your comments to 42723 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; cconv-tests fails on Macos
Date: Wed, 05 Aug 2020 21:35:08 +0200

"make check" log:

Running 14 tests (2020-08-05 21:32:02+0200, selector `(not (or (tag :expensive-test) (tag :unstable)))')
   passed   1/14  cconv-convert-lambda-lifted (0.000360 sec)
Type C-x 1 to delete the help window, C-M-v to scroll help.
   failed   2/14  cconv-tests-cl-defgeneric-:documentation (0.033138 sec)
Type C-x 1 to delete the help window, C-M-v to scroll help.
   passed   3/14  cconv-tests-cl-defgeneric-literal-:documentation (0.025397 sec)
   passed   4/14  cconv-tests-cl-defsubst-:documentation (0.000081 sec)
   passed   5/14  cconv-tests-cl-defun-:documentation (0.000073 sec)
   failed   6/14  cconv-tests-cl-function-:documentation (0.000111 sec)
Test cconv-tests-cl-iter-defun-:documentation passed unexpectedly
   PASSED   7/14  cconv-tests-cl-iter-defun-:documentation (0.000054 sec)
   passed   8/14  cconv-tests-defsubst-:documentation (0.000046 sec)
   passed   9/14  cconv-tests-defun-:documentation (0.000046 sec)
   passed  10/14  cconv-tests-function-:documentation (0.000046 sec)
Test cconv-tests-iter-defun-:documentation passed unexpectedly
   PASSED  11/14  cconv-tests-iter-defun-:documentation (0.000050 sec)
   failed  12/14  cconv-tests-iter-lambda-:documentation (0.000081 sec)
   passed  13/14  cconv-tests-lambda-:documentation (0.000050 sec)
   passed  14/14  cconv-tests-pcase-lambda-:documentation (0.000050 sec)

Ran 14 tests, 12 results as expected, 2 unexpected (2020-08-05 21:32:02+0200, 0.060335 sec)
3 expected failures

2 unexpected results:
   PASSED  cconv-tests-cl-iter-defun-:documentation
   PASSED  cconv-tests-iter-defun-:documentation



In GNU Emacs 28.0.50 (build 7, x86_64-apple-darwin19.6.0, NS appkit-1894.60 Ver\
sion 10.15.6 (Build 19G73))
 of 2020-08-05 built on space.local
Repository revision: 1669cf2f286649ea62991371fd19bbc592ca21bb
Repository branch: master
System Description:  Mac OS X 10.15.6



-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #8 received at 42723 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 42723 <at> debbugs.gnu.org
Subject: Re: bug#42723: 28.0.50; cconv-tests fails on Macos
Date: Thu, 6 Aug 2020 01:59:48 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Running 14 tests (2020-08-05 21:32:02+0200, selector `(not (or (tag :expensive-test) (tag :unstable)))')
>    passed   1/14  cconv-convert-lambda-lifted (0.000360 sec)
> Type C-x 1 to delete the help window, C-M-v to scroll help.
>    failed   2/14  cconv-tests-cl-defgeneric-:documentation (0.033138 sec)
> Type C-x 1 to delete the help window, C-M-v to scroll help.
>    passed   3/14  cconv-tests-cl-defgeneric-literal-:documentation (0.025397 sec)
>    passed   4/14  cconv-tests-cl-defsubst-:documentation (0.000081 sec)
>    passed   5/14  cconv-tests-cl-defun-:documentation (0.000073 sec)
>    failed   6/14  cconv-tests-cl-function-:documentation (0.000111 sec)
> Test cconv-tests-cl-iter-defun-:documentation passed unexpectedly
>    PASSED   7/14  cconv-tests-cl-iter-defun-:documentation (0.000054 sec)
>    passed   8/14  cconv-tests-defsubst-:documentation (0.000046 sec)
>    passed   9/14  cconv-tests-defun-:documentation (0.000046 sec)
>    passed  10/14  cconv-tests-function-:documentation (0.000046 sec)
> Test cconv-tests-iter-defun-:documentation passed unexpectedly
>    PASSED  11/14  cconv-tests-iter-defun-:documentation (0.000050 sec)
>    failed  12/14  cconv-tests-iter-lambda-:documentation (0.000081 sec)
>    passed  13/14  cconv-tests-lambda-:documentation (0.000050 sec)
>    passed  14/14  cconv-tests-pcase-lambda-:documentation (0.000050 sec)
>
> Ran 14 tests, 12 results as expected, 2 unexpected (2020-08-05 21:32:02+0200, 0.060335 sec)
> 3 expected failures

These tests were added in:

commit b0e828da4f55d0dddcd8f8fc2e21e4b02a12852e
Author: Stefan Kangas <stefankangas <at> gmail.com>
Date:   Fri Jul 31 06:09:09 2020 +0200

    Add new cconv-tests (Bug#28557)

    These tests are all written by Gemini Lasswell <gazally <at> runbox.com>.

I guess the failing tests should just be marked unstable for now. I'll
do that when I find some time if no one beats me to it.

I'm not sure, but maybe the "expected failures" should also properly
be marked as unstable instead since they reflect unresolved bugs.

Best regards,
Stefan Kangas

Message #11 received at 42723 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 42723 <at> debbugs.gnu.org
Subject: Re: bug#42723: 28.0.50; cconv-tests fails on Macos
Date: Thu, 06 Aug 2020 09:11:26 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> I guess the failing tests should just be marked unstable for now. I'll
> do that when I find some time if no one beats me to it.
>
> I'm not sure, but maybe the "expected failures" should also properly
> be marked as unstable instead since they reflect unresolved bugs.

Ah, right.  I didn't know about :unstable...  I've now marked them as
such, and now the make check test no longer fails.

So I'm closing this bug report -- Bug#28557 is about the things the
tests are testing for.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.