GNU bug report logs - #42725
[PATCH] drawpile package (sans upnp)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42725 in the body.
You can then email your comments to 42725 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] drawpile package (sans upnp)
Date: Thu, 6 Aug 2020 00:29:33 +0200

[Message part 1 (text/plain, inline)]

Hai! Packaged this on a whim, it was rather straightforward.

Caveat: it crashes (segfaults) due to a UPnP related error, i have not
yet determined why. It's an optional dependency, so I disabled it for
now.

Tested it through an Yggdrasil connection and it worked.

[0001-gnu-Added-drawpile-without-UPnP-support-see-comment-.patch (text/x-patch, attachment)]

Message #8 received at 42725 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 42725 <at> debbugs.gnu.org
Subject: Re: [bug#42725] [PATCH] drawpile package (sans upnp)
Date: Fri, 07 Aug 2020 10:34:22 +0200

Hello,

> +       (method url-fetch)
> +       (uri (string-append "https://github.com/drawpile/Drawpile/archive/"
> +                           version
> +                           ".tar.gz"))

We prefer not to use those github archives that can be re-generated and
prefer to use "git-fetch" method instead.

> +       (sha256
> +        (base32
> +         "0brscm95nay31xa1c02n1w144gg9hm8pxwa9sfnis0x5dj2nkrb7"))))
> +    (build-system qt-build-system)
> +    (arguments '(#:tests? #f))

You should explain why tests are not run with a comment.

> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)))
> +    (inputs
> +     `(("giflib" ,giflib)
> +       ("karchive" ,karchive)
> +       ("kdnssd" ,kdnssd)
> +       ("libmicrohttpd" ,libmicrohttpd)
> +       ("libsodium" ,libsodium)
> +       ("libvpx" ,libvpx)
> +       ;("miniupnpc" ,miniupnpc) ;; TODO segfaults for some reason

No need to comment twice.

> +       ("qtbase" ,qtbase)
> +       ("qtkeychain" ,qtkeychain)
> +       ("qtmultimedia" ,qtmultimedia)
> +       ("qtsvg" ,qtsvg)))
> +    (home-page "https://drawpile.net")
> +    (synopsis "Collaborative drawing program")
> +    (description
> +"Drawpile is a drawing program that lets you share the canvas with other users
> +in real time.
> +
> +Some feature highlights:
> +Runs on Linux, Windows and OSX

No need to talk about those operating systems I think.

> +Shared canvas using the built-in server or a dedicated server
> +Record, play back and export drawing sessions
> +Simple animation support
> +Layers and blending modes
> +Text layers
> +Supports pressure sensitive Wacom tablets
> +Built-in chat
> +Supports OpenRaster file format
> +Encrypted connections using SSL
> +Automatic port forwarding with UPnP")

You could use texinfo to render this list nicely. See "libmemcached"
package for an example.

Could you send an updated patch?

Thanks,

Mathieu

Message #11 received at 42725 <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: 42725 <at> debbugs.gnu.org
Subject: Re: [bug#42725] [PATCH] drawpile package (sans upnp)
Date: Sat, 8 Aug 2020 00:50:08 +0200

[Message part 1 (text/plain, inline)]

On Fri, 07 Aug 2020 10:34:22 +0200
Mathieu Othacehe <othacehe <at> gnu.org> wrote:

> Hello,
> 
> > +       (method url-fetch)
> > +       (uri (string-append
> > "https://github.com/drawpile/Drawpile/archive/"
> > +                           version
> > +                           ".tar.gz"))  
> 
> We prefer not to use those github archives that can be re-generated
> and prefer to use "git-fetch" method instead.

Done!

> > +       (sha256
> > +        (base32
> > +         "0brscm95nay31xa1c02n1w144gg9hm8pxwa9sfnis0x5dj2nkrb7"))))
> > +    (build-system qt-build-system)
> > +    (arguments '(#:tests? #f))  
> 
> You should explain why tests are not run with a comment.

It didn't generate a "test" target, but I figured out how to enable it.
Now it runs them! Also enabled some more functionality that could be
useful.

> > +    (native-inputs
> > +     `(("extra-cmake-modules" ,extra-cmake-modules)))
> > +    (inputs
> > +     `(("giflib" ,giflib)
> > +       ("karchive" ,karchive)
> > +       ("kdnssd" ,kdnssd)
> > +       ("libmicrohttpd" ,libmicrohttpd)
> > +       ("libsodium" ,libsodium)
> > +       ("libvpx" ,libvpx)
> > +       ;("miniupnpc" ,miniupnpc) ;; TODO segfaults for some reason
> >  
> 
> No need to comment twice.

Makes it easier to enable the dependency and still keep the TODO note
without causing a syntax error.

> > +       ("qtbase" ,qtbase)
> > +       ("qtkeychain" ,qtkeychain)
> > +       ("qtmultimedia" ,qtmultimedia)
> > +       ("qtsvg" ,qtsvg)))
> > +    (home-page "https://drawpile.net")
> > +    (synopsis "Collaborative drawing program")
> > +    (description
> > +"Drawpile is a drawing program that lets you share the canvas with
> > other users +in real time.
> > +
> > +Some feature highlights:
> > +Runs on Linux, Windows and OSX  
> 
> No need to talk about those operating systems I think.

Done.

> > +Shared canvas using the built-in server or a dedicated server
> > +Record, play back and export drawing sessions
> > +Simple animation support
> > +Layers and blending modes
> > +Text layers
> > +Supports pressure sensitive Wacom tablets
> > +Built-in chat
> > +Supports OpenRaster file format
> > +Encrypted connections using SSL
> > +Automatic port forwarding with UPnP")  
> 
> You could use texinfo to render this list nicely. See "libmemcached"
> package for an example.
> 
> Could you send an updated patch?
> 
> Thanks,
> 
> Mathieu

Thanks for the quick response! Here it is :D

[0001-gnu-Added-drawpile-UPnP-support-pending-at-version-2.patch (text/x-patch, attachment)]

Message #16 received at 42725-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: raingloom <raingloom <at> riseup.net>
Cc: 42725-done <at> debbugs.gnu.org
Subject: Re: [bug#42725] [PATCH] drawpile package (sans upnp)
Date: Thu, 13 Aug 2020 11:08:21 +0300

[Message part 1 (text/plain, inline)]

Hi,

Apologies for delay and thank you for the patch!

Pushed to master as 9ac2a4ee3424dd216b1b67056968e0585197952a with
following changes:

[Message part 2 (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.