GNU bug report logs - #42801
26.3; customize-apropos shows bogus State buttons after saving

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42801 in the body.
You can then email your comments to 42801 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Szunti <szunti <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3; customize-apropos shows bogus State buttons after saving
Date: Mon, 10 Aug 2020 18:27:31 +0200

After deleting user-emacs-directory (because can't save custom variables
with -Q), started emacs and did the following:

1) M-x customize-apropos RET inhibit RET
2) Toggled Inhibit Startup Screen's value:
Stepped with TAB-s to Inhibit Startup Screen's arrow, RET to open the
details, another TAB onto Toggle button and RET
3) Then typed C-x C-s, confirmed with yes RET

After this the customization buffer refreshed and all options despite
closed, got a State button with STANDARD value.

S-TAB thrice to get onto the State button of the previous option
(Inhibit Startup Echo Area Message) and after RET on the State button,
the echo area tells,

Symbol’s function definition is void: nil

In GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20)
of 2020-05-19 built on felixonmars2
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Arch Linux

Recent messages:
Change the state of this item.
widget-apply: Symbol’s function definition is void: nil
Show or hide rest of the documentation.
Hide or show this option.
Change the state of this item.
user-error: Canceled
Show or hide rest of the documentation.
Create customization buffer for this group.
Show the value of this option.
Change the state of this item.
widget-apply: Symbol’s function definition is void: nil
Configured using:
'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
--localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-wide-int
--with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt'
CPPFLAGS=-D_FORTIFY_SOURCE=2
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2

Important settings:
value of $LC_TIME: C
value of $LANG: hu_HU.utf8
locale-coding-system: utf-8-unix

Major mode: Custom

Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml
mml-sec password-cache epa derived epg epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils apropos cus-edit easymenu cus-start
cus-load wid-edit cl-loaddefs cl-lib elec-pair time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 120540 10887)
(symbols 48 21950 1)
(miscs 40 503 405)
(strings 32 32148 1208)
(string-bytes 1 840406)
(vectors 16 15666)
(vector-slots 8 518108 7434)
(floats 8 61 152)
(intervals 56 448 2)
(buffers 992 15))

Message #8 received at 42801 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Szunti <szunti <at> gmail.com>
Cc: 42801 <at> debbugs.gnu.org
Subject: Re: bug#42801: 26.3; customize-apropos shows bogus State buttons
 after saving
Date: Tue, 11 Aug 2020 10:47:59 -0300

[Message part 1 (text/plain, inline)]

tags 42801 patch
quit

Szunti <szunti <at> gmail.com> writes:

> 1) M-x customize-apropos RET inhibit RET
> 2) Toggled Inhibit Startup Screen's value:
> Stepped with TAB-s to Inhibit Startup Screen's arrow, RET to open the
> details, another TAB onto Toggle button and RET
> 3) Then typed C-x C-s, confirmed with yes RET
>
> After this the customization buffer refreshed and all options despite
> closed, got a State button with STANDARD value.
>
> S-TAB thrice to get onto the State button of the previous option
> (Inhibit Startup Echo Area Message) and after RET on the State button,
> the echo area tells,
>
> Symbol’s function definition is void: nil

Thanks for the bug report.

I can reproduce this bug in Emacs 26.3.  On current master, the bug
manifests
differently: we don't get the State buttons, but we do get the message:
Symbol's function definition is void: nil

The difference lies in `custom-variable-modified-p' bugging out before we
draw
the bogus State buttons for all options, because it is not supposed to
handle
hidden widgets.

The bug is that Custom-save recalculates the state and redraws all widgets,
even the hidden ones.  I propose the attached patch, that changes
Custom-save to only act on edited widgets in the buffer.

[Message part 2 (text/html, inline)]

[0001-Make-sure-we-only-act-on-edited-widgets-in-Custom-sa.patch (text/x-patch, attachment)]

Message #13 received at 42801 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: Szunti <szunti <at> gmail.com>, 42801 <at> debbugs.gnu.org
Subject: Re: bug#42801: 26.3; customize-apropos shows bogus State buttons
 after saving
Date: Fri, 14 Aug 2020 16:41:03 +0200

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> I can reproduce this bug in Emacs 26.3.  On current master, the bug manifests
> differently: we don't get the State buttons, but we do get the message:
> Symbol's function definition is void: nil
>
> The difference lies in `custom-variable-modified-p' bugging out before we draw
> the bogus State buttons for all options, because it is not supposed to handle
> hidden widgets.
>
> The bug is that Custom-save recalculates the state and redraws all widgets,
> even the hidden ones.  I propose the attached patch, that changes
> Custom-save to only act on edited widgets in the buffer.

Thanks; applied to Emacs 28.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 42801 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Szunti <szunti <at> gmail.com>, 42801 <at> debbugs.gnu.org
Subject: Re: bug#42801: 26.3; customize-apropos shows bogus State buttons
 after saving
Date: Sun, 16 Aug 2020 11:05:00 -0300

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>
>> I can reproduce this bug in Emacs 26.3.  On current master, the bug
manifests
>> differently: we don't get the State buttons, but we do get the message:
>> Symbol's function definition is void: nil
>>
>> The difference lies in `custom-variable-modified-p' bugging out before
we draw
>> the bogus State buttons for all options, because it is not supposed to
handle
>> hidden widgets.
>>
>> The bug is that Custom-save recalculates the state and redraws all
widgets,
>> even the hidden ones.  I propose the attached patch, that changes
>> Custom-save to only act on edited widgets in the buffer.
>
> Thanks; applied to Emacs 28.1.

Thank you!

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.