GNU bug report logs - #42802
Unhandled FTP exception when using GNU importer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42802 in the body.
You can then email your comments to 42802 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: Unhandled FTP exception when using GNU importer
Date: Mon, 10 Aug 2020 14:33:38 -0400

Here I naively tried importing libsocketcan, which isn't a GNU project:

--8<---------------cut here---------------start------------->8---
guix import gnu libsocketcan
Backtrace:
          10 (primitive-load "/home/maxim/.config/guix/current/bin/guix")
In guix/ui.scm:
  2046:12  9 (run-guix-command _ . _)
In guix/scripts/import.scm:
   116:11  8 (guix-import . _)
In ice-9/boot-9.scm:
  1736:10  7 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
  1731:15  6 (with-exception-handler #<procedure 7f19d6ef7270 at ice-9/boot-9.scm:1815:7 (exn)> _ #:unwind? _ #:unwind-for-type _)
In guix/import/gnu.scm:
    111:2  5 (gnu->guix-package "libsocketcan" #:key-download _)
In guix/gnu-maintenance.scm:
   364:20  4 (latest-ftp-release "libsocketcan" #:server _ #:directory _ #:keep-file? _ #:file->signature _ #:ftp-open _ #:ftp-close _)
In guix/ftp-client.scm:
    233:6  3 (ftp-list #<<ftp-connection> socket: #<input-output: socket 16> addrinfo: #(32 2 1 6 #(2 3509828628 21) #f)> _ #:timeout _)
In srfi/srfi-1.scm:
   460:18  2 (fold #<procedure 7f19d6ef71b0 at guix/ftp-client.scm:187:10 (dir result)> _ _)
In guix/ftp-client.scm:
     74:8  1 (_ _ _)
In ice-9/boot-9.scm:
  1669:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1669:16: In procedure raise-exception:
Throw to key `ftp-error' with args `(#<input-output: socket 16> "CWD
libsocketcan" 550 "Failed to change directory.\r")'.

--8<---------------cut here---------------end--------------->8---

The error should be handled and a more appropriate message should be
displayed to the user.

Maxim

Message #10 received at 42802-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 42802-done <at> debbugs.gnu.org
Subject: Re: bug#42802: Unhandled FTP exception when using GNU importer
Date: Tue, 02 Feb 2021 13:58:46 +0100

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Here I naively tried importing libsocketcan, which isn't a GNU project:
>
> guix import gnu libsocketcan
> Backtrace:
>           10 (primitive-load "/home/maxim/.config/guix/current/bin/guix")
> In guix/ui.scm:
>   2046:12  9 (run-guix-command _ . _)
> In guix/scripts/import.scm:
>    116:11  8 (guix-import . _)
> In ice-9/boot-9.scm:
>   1736:10  7 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
>   1731:15  6 (with-exception-handler #<procedure 7f19d6ef7270 at ice-9/boot-9.scm:1815:7 (exn)> _ #:unwind? _ #:unwind-for-type _)
> In guix/import/gnu.scm:
>     111:2  5 (gnu->guix-package "libsocketcan" #:key-download _)
> In guix/gnu-maintenance.scm:
>    364:20  4 (latest-ftp-release "libsocketcan" #:server _ #:directory _ #:keep-file? _ #:file->signature _ #:ftp-open _ #:ftp-close _)
> In guix/ftp-client.scm:
>     233:6  3 (ftp-list #<<ftp-connection> socket: #<input-output: socket 16> addrinfo: #(32 2 1 6 #(2 3509828628 21) #f)> _ #:timeout _)
> In srfi/srfi-1.scm:
>    460:18  2 (fold #<procedure 7f19d6ef71b0 at guix/ftp-client.scm:187:10 (dir result)> _ _)
> In guix/ftp-client.scm:
>      74:8  1 (_ _ _)
> In ice-9/boot-9.scm:
>   1669:16  0 (raise-exception _ #:continuable? _)
>
> ice-9/boot-9.scm:1669:16: In procedure raise-exception:
> Throw to key `ftp-error' with args `(#<input-output: socket 16> "CWD
> libsocketcan" 550 "Failed to change directory.\r")'.
>
> The error should be handled and a more appropriate message should be
> displayed to the user.

I believe this is fixed by be84fc600e76e3962123b94bf14baea4a2e4f442.

Ludo’.

Message #13 received at 42802 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 42802 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>, 
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 42802-done <at> debbugs.gnu.org
Subject: Re: bug#42802: Unhandled FTP exception when using GNU importer
Date: Tue, 2 Feb 2021 15:09:05 +0100

Hi,

On Tue, 2 Feb 2021 at 13:59, Ludovic Courtès <ludo <at> gnu.org> wrote:

> > The error should be handled and a more appropriate message should be
> > displayed to the user.
>
> I believe this is fixed by be84fc600e76e3962123b94bf14baea4a2e4f442.

Ah sorry, I missed this bug and so report it in the commit message.

Cheers,
simon

Message #19 received at 42802-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 42802-done <at> debbugs.gnu.org
Subject: Re: bug#42802: Unhandled FTP exception when using GNU importer
Date: Tue, 02 Feb 2021 09:12:34 -0500

Hi Ludo,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> Here I naively tried importing libsocketcan, which isn't a GNU project:
>>
>> guix import gnu libsocketcan
>> Backtrace:
>>           10 (primitive-load "/home/maxim/.config/guix/current/bin/guix")
>> In guix/ui.scm:
>>   2046:12  9 (run-guix-command _ . _)
>> In guix/scripts/import.scm:
>>    116:11  8 (guix-import . _)
>> In ice-9/boot-9.scm:
>>   1736:10  7 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
>>   1731:15  6 (with-exception-handler #<procedure 7f19d6ef7270 at ice-9/boot-9.scm:1815:7 (exn)> _ #:unwind? _ #:unwind-for-type _)
>> In guix/import/gnu.scm:
>>     111:2  5 (gnu->guix-package "libsocketcan" #:key-download _)
>> In guix/gnu-maintenance.scm:
>>    364:20  4 (latest-ftp-release "libsocketcan" #:server _ #:directory _ #:keep-file? _ #:file->signature _ #:ftp-open _ #:ftp-close _)
>> In guix/ftp-client.scm:
>>     233:6  3 (ftp-list #<<ftp-connection> socket: #<input-output: socket 16> addrinfo: #(32 2 1 6 #(2 3509828628 21) #f)> _ #:timeout _)
>> In srfi/srfi-1.scm:
>>    460:18  2 (fold #<procedure 7f19d6ef71b0 at guix/ftp-client.scm:187:10 (dir result)> _ _)
>> In guix/ftp-client.scm:
>>      74:8  1 (_ _ _)
>> In ice-9/boot-9.scm:
>>   1669:16  0 (raise-exception _ #:continuable? _)
>>
>> ice-9/boot-9.scm:1669:16: In procedure raise-exception:
>> Throw to key `ftp-error' with args `(#<input-output: socket 16> "CWD
>> libsocketcan" 550 "Failed to change directory.\r")'.
>>
>> The error should be handled and a more appropriate message should be
>> displayed to the user.
>
> I believe this is fixed by be84fc600e76e3962123b94bf14baea4a2e4f442.
>
> Ludo’.

./pre-inst-env guix import gnu libsocketcan
guix import: error: failed to determine latest release of GNU libsocketcan

Thanks for the fix; that's much nicer than a backtrace.  It would be
even better if it said:

'guix import: error: No GNU package found for "libsocketcan"'

Thanks!

Maxim

Message #22 received at 42802-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 42802-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#42802: Unhandled FTP exception when using GNU importer
Date: Tue, 2 Feb 2021 15:31:58 +0100

[Message part 1 (text/plain, inline)]

Hi Maxim

On Tue, 2 Feb 2021 at 15:13, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

> ./pre-inst-env guix import gnu libsocketcan
> guix import: error: failed to determine latest release of GNU libsocketcan
>
> Thanks for the fix; that's much nicer than a backtrace.  It would be
> even better if it said:
>
> 'guix import: error: No GNU package found for "libsocketcan"'

Yeah, replace the message sounds good.  The one you are proposing
works for both cases: "guix import gnu hello <at> 1.2.3" and "guix import
gnu not-gnu-package".  Even if version is not supported, another
story.
Attached the trivial patch in case.


Cheers,
simon

[0001-import-gnu-Fix-error-message.patch (text/x-patch, attachment)]

Message #25 received at 42802-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 42802-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#42802: Unhandled FTP exception when using GNU importer
Date: Tue, 02 Feb 2021 13:50:20 -0500

Hi Simon,

zimoun <zimon.toutoune <at> gmail.com> writes:

> Hi Maxim
>
> On Tue, 2 Feb 2021 at 15:13, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>> ./pre-inst-env guix import gnu libsocketcan
>> guix import: error: failed to determine latest release of GNU libsocketcan
>>
>> Thanks for the fix; that's much nicer than a backtrace.  It would be
>> even better if it said:
>>
>> 'guix import: error: No GNU package found for "libsocketcan"'


> Yeah, replace the message sounds good.  The one you are proposing
> works for both cases: "guix import gnu hello <at> 1.2.3" and "guix import
> gnu not-gnu-package".  Even if version is not supported, another
> story.
> Attached the trivial patch in case.

There was more to it than just the message; some code was already in
place to address this case but was not exercised.

See commit 889f425b35, which fixes it.

Thanks!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.