GNU bug report logs - #42868
[PATCH] maint: Only run `make authenticate` when pushing commits.

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Fri, 14 Aug 2020 20:32:01 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42868 in the body.
You can then email your comments to 42868 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#42868; Package guix-patches. (Fri, 14 Aug 2020 20:32:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 14 Aug 2020 20:32:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] maint: Only run `make authenticate` when pushing commits.
Date: Fri, 14 Aug 2020 16:30:47 -0400
When deleting a remote branch, no commits are pushed to the remote, and
thus there are no signatures to be verified.

* etc/git/pre-push: Exit early when deleting a branch.
---
 etc/git/pre-push | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/etc/git/pre-push b/etc/git/pre-push
index 415345fc75..689673dcc9 100755
--- a/etc/git/pre-push
+++ b/etc/git/pre-push
@@ -20,13 +20,21 @@
 #
 #   <local ref> <local sha1> <remote ref> <remote sha1>
 
-# Only use the hook when pushing to Savannah.
-case "$2" in
-    *.gnu.org*)
-	exec make authenticate check-channel-news
-	exit 127
-	;;
-    *)
-	exit 0
-	;;
-esac
+z40=0000000000000000000000000000000000000000
+
+# If deleting a branch, there are no commits to check.
+if [ "$local_sha" = $z40 ]
+then
+	true
+else
+	# Only use the hook when pushing to Savannah.
+	case "$2" in
+	    *.gnu.org*)
+		exec make authenticate check-channel-news
+		exit 127
+		;;
+	    *)
+		exit 0
+		;;
+	esac
+fi
-- 
2.28.0





Information forwarded to guix-patches <at> gnu.org:
bug#42868; Package guix-patches. (Wed, 19 Aug 2020 22:30:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] maint: Only run `make authenticate` when pushing commits.
Date: Thu, 20 Aug 2020 00:29:27 +0200
[Message part 1 (text/plain, inline)]
On Fri, Aug 14, 2020 at 04:30:47PM -0400, Leo Famulari wrote:
> +z40=0000000000000000000000000000000000000000
> +
> +# If deleting a branch, there are no commits to check.
> +if [ "$local_sha" = $z40 ]
> +then
> +	true
> +else

Is there a reason this `if' is written like that? I would use != and get
rid of the do-nothing branch entirely.

Regards,
Jakub Kądziołka
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#42868; Package guix-patches. (Sun, 30 Aug 2020 19:49:01 GMT) Full text and rfc822 format available.

Message #11 received at 42868 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 42868 <at> debbugs.gnu.org
Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when
 pushing commits.
Date: Sun, 30 Aug 2020 21:47:59 +0200
Hi,

Leo Famulari <leo <at> famulari.name> skribis:

> When deleting a remote branch, no commits are pushed to the remote, and
> thus there are no signatures to be verified.
>
> * etc/git/pre-push: Exit early when deleting a branch.

I agree with Jakub regarding the ‘if’ :-), but other than that it LGTM.

Thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#42868; Package guix-patches. (Sun, 13 Dec 2020 20:36:01 GMT) Full text and rfc822 format available.

Message #14 received at 42868 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 42868 <at> debbugs.gnu.org
Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when
 pushing commits.
Date: Sun, 13 Dec 2020 15:35:24 -0500
[Message part 1 (text/plain, inline)]
On Sun, Aug 30, 2020 at 09:47:59PM +0200, Ludovic Courtès wrote:
> Hi,
> 
> Leo Famulari <leo <at> famulari.name> skribis:
> 
> > When deleting a remote branch, no commits are pushed to the remote, and
> > thus there are no signatures to be verified.
> >
> > * etc/git/pre-push: Exit early when deleting a branch.
> 
> I agree with Jakub regarding the ‘if’ :-), but other than that it LGTM.

The previous version of this patch was untested and broken!

Here is a new one that is actually tested and working.
[0001-maint-Only-run-make-authenticate-when-pushing-commit.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#42868; Package guix-patches. (Mon, 14 Dec 2020 08:29:01 GMT) Full text and rfc822 format available.

Message #17 received at 42868 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 42868 <at> debbugs.gnu.org
Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when
 pushing commits.
Date: Mon, 14 Dec 2020 09:28:01 +0100
Hi,

Leo Famulari <leo <at> famulari.name> skribis:

> From e8546a590a560825c3231af14724329c3d2bfee7 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo <at> famulari.name>
> Date: Fri, 14 Aug 2020 16:30:47 -0400
> Subject: [PATCH] maint: Only run `make authenticate` when pushing commits.
>
> * etc/git/pre-push: Exit early when deleting a branch.

LGTM, thanks!

Ludo’.




Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Mon, 14 Dec 2020 17:18:01 GMT) Full text and rfc822 format available.

Notification sent to Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer. (Mon, 14 Dec 2020 17:18:02 GMT) Full text and rfc822 format available.

Message #22 received at 42868-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 42868-done <at> debbugs.gnu.org
Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when
 pushing commits.
Date: Mon, 14 Dec 2020 12:17:13 -0500
On Mon, Dec 14, 2020 at 09:28:01AM +0100, Ludovic Courtès wrote:
> Hi,
> 
> Leo Famulari <leo <at> famulari.name> skribis:
> 
> > From e8546a590a560825c3231af14724329c3d2bfee7 Mon Sep 17 00:00:00 2001
> > From: Leo Famulari <leo <at> famulari.name>
> > Date: Fri, 14 Aug 2020 16:30:47 -0400
> > Subject: [PATCH] maint: Only run `make authenticate` when pushing commits.
> >
> > * etc/git/pre-push: Exit early when deleting a branch.
> 
> LGTM, thanks!

Thanks! Pushed as 80ebcdd100a82fdc582e62f35042c74ce38ea753




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 12 Jan 2021 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 76 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.