GNU bug report logs - #42918
[PATCH 0/1] services: fcgiwrap: Create parent directory for unix socket.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Tue, 18 Aug 2020 18:18:02 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42918 in the body.
You can then email your comments to 42918 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#42918; Package guix-patches. (Tue, 18 Aug 2020 18:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Arun Isaac <arunisaac <at> systemreboot.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 18 Aug 2020 18:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 0/1] services: fcgiwrap: Create parent directory for unix
 socket.
Date: Tue, 18 Aug 2020 23:47:06 +0530
Currently, fcgiwrap listening on a unix socket is unworkable since the
fcgiwrap user may not have the necessary permissions to create the socket
file.

Arun Isaac (1):
  services: fcgiwrap: Create parent directory for unix socket.

 gnu/services/web.scm | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

-- 
2.28.0





Information forwarded to guix-patches <at> gnu.org:
bug#42918; Package guix-patches. (Tue, 18 Aug 2020 18:21:02 GMT) Full text and rfc822 format available.

Message #8 received at 42918 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 42918 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 1/1] services: fcgiwrap: Create parent directory for unix
 socket.
Date: Tue, 18 Aug 2020 23:50:32 +0530
* gnu/services/web.scm (fcgiwrap-activation): New function.
(fcgiwrap-service-type): Extend activation-service-type with
fcgiwrap-activation.
---
 gnu/services/web.scm | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index 3b9f9e40be..d11a1c0545 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2019, 2020 Florian Pelz <pelzflorian <at> pelzflorian.de>
 ;;; Copyright © 2020 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2020 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -794,13 +795,29 @@ of index files."
 		      #:user #$user #:group #$group))
             (stop #~(make-kill-destructor)))))))
 
+(define fcgiwrap-activation
+  (match-lambda
+    (($ <fcgiwrap-configuration> package socket user group)
+     #~(begin
+         ;; When listening on a unix socket, create a parent directory for the
+         ;; socket with the correct permissions.
+         (when (string-prefix? "unix:" #$socket)
+           (let ((run-directory
+                  (dirname (substring #$socket (string-length "unix:")))))
+             (mkdir-p run-directory)
+             (chown run-directory
+                    (passwd:uid (getpw #$user))
+                    (group:gid (getgr #$group)))))))))
+
 (define fcgiwrap-service-type
   (service-type (name 'fcgiwrap)
                 (extensions
                  (list (service-extension shepherd-root-service-type
                                           fcgiwrap-shepherd-service)
 		       (service-extension account-service-type
-                                          fcgiwrap-accounts)))
+                                          fcgiwrap-accounts)
+                       (service-extension activation-service-type
+                                          fcgiwrap-activation)))
                 (default-value (fcgiwrap-configuration))))
 
 (define-record-type* <php-fpm-configuration> php-fpm-configuration
-- 
2.28.0





Information forwarded to guix-patches <at> gnu.org:
bug#42918; Package guix-patches. (Mon, 24 Aug 2020 09:26:02 GMT) Full text and rfc822 format available.

Message #11 received at 42918 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 42918 <at> debbugs.gnu.org
Subject: Re: [bug#42918] [PATCH 1/1] services: fcgiwrap: Create parent
 directory for unix socket.
Date: Mon, 24 Aug 2020 11:25:29 +0200
Hey Arun,

> * gnu/services/web.scm (fcgiwrap-activation): New function.
> (fcgiwrap-service-type): Extend activation-service-type with
> fcgiwrap-activation.

This looks fine, feel free to proceed!

Thanks,

Mathieu




Reply sent to Arun Isaac <arunisaac <at> systemreboot.net>:
You have taken responsibility. (Wed, 26 Aug 2020 17:59:02 GMT) Full text and rfc822 format available.

Notification sent to Arun Isaac <arunisaac <at> systemreboot.net>:
bug acknowledged by developer. (Wed, 26 Aug 2020 17:59:02 GMT) Full text and rfc822 format available.

Message #16 received at 42918-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 42918-done <at> debbugs.gnu.org
Subject: Re: [bug#42918] [PATCH 1/1] services: fcgiwrap: Create parent
 directory for unix socket.
Date: Wed, 26 Aug 2020 23:27:57 +0530
[Message part 1 (text/plain, inline)]
Thanks for the review, pushed to master!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 24 Sep 2020 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 187 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.