GNU bug report logs - #43004
28.0.50; Test failures due to symlinked Emacs sources

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Stephen Berman <stephen.berman@HIDDEN>; dated Sun, 23 Aug 2020 21:28:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 43004 <at> debbugs.gnu.org:


Received: (at 43004) by debbugs.gnu.org; 16 Oct 2020 08:34:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 16 04:34:46 2020
Received: from localhost ([127.0.0.1]:57606 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kTLCI-0007sr-Ev
	for submit <at> debbugs.gnu.org; Fri, 16 Oct 2020 04:34:46 -0400
Received: from quimby.gnus.org ([95.216.78.240]:52818)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1kTLCC-0007sY-44
 for 43004 <at> debbugs.gnu.org; Fri, 16 Oct 2020 04:34:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=fQEgBnZ6K2ZpfE8YWYd343xU+Kp58xBTqVjjfT7LwcY=; b=qdQ3YSMUTW8/DGqrnHlvQEHfDo
 LW+HmAK43bnfh1E73PgPG1JmNTxEaoNvneC6Uk8ajW3bhiBiu0kO83gpExbxObkc+qtRYhGjU0/Lf
 AMWSrFuv+icuBfg9W6AWsf9lRJaHqF4ZVEruwI/aHPb9FhTPpq8q2k5HE4wxtReBUnNc=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1kTLC3-0000jF-If; Fri, 16 Oct 2020 10:34:34 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Stephen Berman <stephen.berman@HIDDEN>
Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources
References: <87o8n1aw9k.fsf@HIDDEN>
X-Now-Playing: ELP's _Tarkus_: "Tarkus"
Date: Fri, 16 Oct 2020 10:34:30 +0200
In-Reply-To: <87o8n1aw9k.fsf@HIDDEN> (Stephen Berman's message of "Sun, 23
 Aug 2020 23:27:03 +0200")
Message-ID: <87imbamuw9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Stephen Berman <stephen.berman@HIDDEN> writes: > However,
 concerning the latter,
 it seems that the tests expect > help-fns-function-description-header
 to return the quoted basename of > the file, while in my environment it returns
 the absolute fil [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43004
Cc: 43004 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stephen Berman <stephen.berman@HIDDEN> writes:

> However, concerning the latter, it seems that the tests expect
> help-fns-function-description-header to return the quoted basename of
> the file, while in my environment it returns the absolute filename.
> Adjusting the regexp used in the tests fixes this issue (see the first
> patch below) and then all tests pass regardless of where I start the
> batch run.
>
> Concerning cl-generic-tests.el, using file-truename as in the second
> patch below prevents the one failure, also regardless of where I start
> the batch run.

Thanks; I've now applied your patch to the trunk.

> The same reduction but not full elimination is achieved by removing
> the call to file-truename in the value of the defvar emacs-test-dir in
> elisp-mode-tests.el.  So far I haven't figured out how to prevent
> these five failures.

Have you made any progress on these remaining failures, by any chance?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43004; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 23 Aug 2020 21:27:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 23 17:27:10 2020
Received: from localhost ([127.0.0.1]:55243 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1k9xWA-0001ot-6m
	for submit <at> debbugs.gnu.org; Sun, 23 Aug 2020 17:27:10 -0400
Received: from lists.gnu.org ([209.51.188.17]:51500)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1k9xW8-0001ol-BE
 for submit <at> debbugs.gnu.org; Sun, 23 Aug 2020 17:27:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55394)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1k9xW8-0004kd-5N
 for bug-gnu-emacs@HIDDEN; Sun, 23 Aug 2020 17:27:08 -0400
Received: from mout.gmx.net ([212.227.17.20]:40683)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1k9xW6-0008Ab-1n
 for bug-gnu-emacs@HIDDEN; Sun, 23 Aug 2020 17:27:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1598218024;
 bh=9zrhIyeRec70tABMq30PBFJuMGvqVYz/+lDzAP/Wgaw=;
 h=X-UI-Sender-Class:From:To:Subject:Date;
 b=MKKwZZUtcFkP+RwXPhl1+15cfY7g3k/WKLFe0ppxyvNa7IVhRDFcFZWn3Z8bxAg8/
 pCRNIP9/fZV7gzfVV8y4U3+bmGCDqaq8LGtP/TZiVhU6PiJgdTR6MGwkxufWE34BzX
 GFulm54IttUEK8jqWfBufGy2ZF8GqmKKhs0h1i9o=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([92.73.78.116]) by mail.gmx.com (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mn2WF-1ksfeh0mSV-00k47s for
 <bug-gnu-emacs@HIDDEN>; Sun, 23 Aug 2020 23:27:04 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 28.0.50; Test failures due to symlinked Emacs sources
Date: Sun, 23 Aug 2020 23:27:03 +0200
Message-ID: <87o8n1aw9k.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:RpiLGj8Hi9tcWown+M74tja1S6JQOgiFSsB+rNjO2mNdFXr8/f9
 iBnEBIge3KyH2mQnYmnB2L4rs9JGA5SOzRpxhiI4JV8SqZaiv80eKejfh0Qp8ovqLCefc43
 cMil+p17gQWdTIonrQ5nnZmO2aTZ0iyy2IoRx0e8QK+SuRIReTFspaSiJSjiC9MwkesiGYL
 LAOkpBHbiMDk/dHwCEfeg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:l6lpWtpptIU=:o7mRlbirjaMn73m9Qc7yRw
 gXC/C50aRS/h5MR5e/rgOZ9ZryVAM9/oAel+MDONDuy/5NnezMqut6XmpODJlhFlYm7J4uD3x
 bAuPWIlDU0npGBJbT60R/swp3n2bqL3kybys57p5vfYQtcENC8V93Dn5mnSn/mtmsei37X4xx
 kQw9pQlo0cEwwxLl8Snpx487gX1wo/M8ZekGZBvw//9mwlKKs7YtNqJlfmbiTdZEK+ggUe9fj
 VXFmG3yi70JXuRF2H87LZABNXLpXLvRGwAy9j6X5PzoBtnA4aqiyGF5rsDmlNCPyWQNhrGjcR
 WLkauQNAImKuDBfWRT8EQJBj2aL5C1ickxsSg9CTbVBkWbG0Bn7q5llwXI6sq2/IoYZwNxTyy
 LI88gEucNtrnhgLDxXrupR8fX59DRQS9pI37kjCZH0jChdE8pK+P+JT/5JBJhNXLlwwrJqNVR
 xGXj4H7/q5KHFq8AnwpDl55xtaEVXzSjgZGY/y1aje7X2esFdTnfKsS9Ydmx/iQpBAwJkbrS0
 z1v9rQFnXnKGroC8Ni2+aqq/t/1D3UaEGCp96mpCyvQDdx8jlbj0iYmn8AxU3JVQmWV5FoT3M
 JmLJu/ZwbOhChn4jBx28gU+qnqxklq4DG6fxovkB8+wQLPPiuZZrSvTAWboaCvULqx+ajrsKD
 93B9Kkna8dScb3Y7cilA6Q56vFqElj2PBtsL2EBpf2Mip0YnLiB41LX8K7AEpv/4sMmWweQ27
 NfXYSbAryJytq19+SEhtcjUiN6M4HMebOYBGFkTpfPJ09aBtjjaZJJ8b0jOTS6R3dq4gfjLXN
 XXCQU/KTop5qRutPgeDgEvOaTVmwlBEWYL7gFi93kXV8RdtwTxW9W9bq3BgL6zctCqDnxsXLK
 5u8R1fOQhaGSDJCEEPnHBJKuOWLJWnbfZjWhg4tzb4Bu51seXyCxay1U1Ej1+2xIREh5h1c+p
 UDNDN43Nm18tyfYhe0I2OtC/p46nbhijn3IELR4elr3RdmTelh0Z+rxPHUZGGnnpE8+9jQxky
 FA3/qOscRu7Seh/V//eeRczAeaX8iI/gxU8t/GF3ERq2aYKunpIhdDsfaZk0nVO4HeUaDMeYC
 UxP4Zcc0s0SuA6VMmy6/6WNTfox7s/tglCLvTPRW6TXIQIqX4D9A2GOxnONDvg9eTnyYxjRFV
 LmLojf2YfR2m94hSRqHgkKf9JloXgnIK4uKf5FIAtZ37jb/0RJtcuc2+fOImThSmlmJu3m+qu
 v+vjn9vpO+4clCc3ukfHQSq/bpWsoh1yfiKt69Q==
Received-SPF: pass client-ip=212.227.17.20;
 envelope-from=stephen.berman@HIDDEN; helo=mout.gmx.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/23 17:27:04
X-ACL-Warn: Detected OS   = Linux 3.11 and newer
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.2 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

After my latest build from master I ran make check (for the first time
in a long time) and got the following 20 unexpected failures:

In test/lisp/progmodes/elisp-mode-tests.el 14 unexpected results:
   FAILED  xref-elisp-test-find-defs-defgeneric-co-located-default
   FAILED  xref-elisp-test-find-defs-defgeneric-el
   FAILED  xref-elisp-test-find-defs-defgeneric-implicit-generic
   FAILED  xref-elisp-test-find-defs-defgeneric-no-default
   FAILED  xref-elisp-test-find-defs-defgeneric-no-methods
   FAILED  xref-elisp-test-find-defs-defgeneric-separate-default
   FAILED  xref-elisp-test-find-defs-define-overload-co-located-default
   FAILED  xref-elisp-test-find-defs-define-overload-no-default
   FAILED  xref-elisp-test-find-defs-define-overload-no-methods
   FAILED  xref-elisp-test-find-defs-define-overload-separate-default
   FAILED  xref-elisp-test-find-defs-defun-defvar-el
   FAILED  xref-elisp-test-find-defs-defun-el
   FAILED  xref-elisp-test-find-defs-defvar-el
   FAILED  xref-elisp-test-find-defs-feature-el

In test/lisp/help-fns-tests.el 5 unexpected results:
   FAILED  help-fns-test-alias-to-defun
   FAILED  help-fns-test-bug23887
   FAILED  help-fns-test-lisp-defsubst
   FAILED  help-fns-test-lisp-defun
   FAILED  help-fns-test-lisp-macro

In test/lisp/emacs-lisp/cl-generic-tests.el 1 unexpected result:
   FAILED  cl-generic-tests--method-files--finds-methods

It seems that the failures arise because my Emacs sources are in a
directory on a different partition from my home directory, and the
source directory is symlinked from =C2=A7HOME, and my Emacs build directory
is under $HOME.  When I do batch runs of the test three files in
question starting from my home directory (i.e. dereferencing the symlink
to the sources), I get the the failures I reported; but when I start the
batch runs from the real directory containing the test sources, the one
test in cl-generic-tests.el that failed now passes, and of the fourteen
xref tests in elisp-mode-tests.el that failed, now only these five fail:

   FAILED  xref-elisp-test-find-defs-defgeneric-el
   FAILED  xref-elisp-test-find-defs-defun-defvar-el
   FAILED  xref-elisp-test-find-defs-defun-el
   FAILED  xref-elisp-test-find-defs-defvar-el
   FAILED  xref-elisp-test-find-defs-feature-el

But all five of the failing tests in help-fns-tests.el still fail.

However, concerning the latter, it seems that the tests expect
help-fns-function-description-header to return the quoted basename of
the file, while in my environment it returns the absolute filename.
Adjusting the regexp used in the tests fixes this issue (see the first
patch below) and then all tests pass regardless of where I start the
batch run.

Concerning cl-generic-tests.el, using file-truename as in the second
patch below prevents the one failure, also regardless of where I start
the batch run.

As for the failing xref tests in elisp-mode-tests.el, by applying
file-truename to the result of calls to find-lisp-object-file-name in
elisp--xref-find-definitions (in elisp-mode.el) and
xref-mode-local-overload (in mode-local.el) I could reduce the 14
failures to the same five that fail when doing the batch run from the
real directory without following the symlink.  The same reduction but
not full elimination is achieved by removing the call to file-truename
in the value of the defvar emacs-test-dir in elisp-mode-tests.el.  So
far I haven't figured out how to prevent these five failures.


diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el
index da2b49e6b8..7782a41b9f 100644
--- a/test/lisp/help-fns-tests.el
+++ b/test/lisp/help-fns-tests.el
@@ -56,28 +56,28 @@ help-fns-test-interactive-built-in
     (should (string-match regexp result))))
=20
 (ert-deftest help-fns-test-lisp-macro ()
-  (let ((regexp "a Lisp macro in .subr\\.el")
+  (let ((regexp "a Lisp macro in .+subr\\.el")
         (result (help-fns-tests--describe-function 'when)))
     (should (string-match regexp result))))
=20
 (ert-deftest help-fns-test-lisp-defun ()
-  (let ((regexp "a compiled Lisp function in .subr\\.el")
+  (let ((regexp "a compiled Lisp function in .+subr\\.el")
         (result (help-fns-tests--describe-function 'last)))
     (should (string-match regexp result))))
=20
 (ert-deftest help-fns-test-lisp-defsubst ()
-  (let ((regexp "a compiled Lisp function in .subr\\.el")
+  (let ((regexp "a compiled Lisp function in .+subr\\.el")
         (result (help-fns-tests--describe-function 'posn-window)))
     (should (string-match regexp result))))
=20
 (ert-deftest help-fns-test-alias-to-defun ()
-  (let ((regexp "an alias for .set-file-modes. in .subr\\.el")
+  (let ((regexp "an alias for .set-file-modes. in .+subr\\.el")
         (result (help-fns-tests--describe-function 'chmod)))
     (should (string-match regexp result))))
=20
 (ert-deftest help-fns-test-bug23887 ()
   "Test for https://debbugs.gnu.org/23887 ."
-  (let ((regexp "an alias for .re-search-forward. in .subr\\.el")
+  (let ((regexp "an alias for .re-search-forward. in .+subr\\.el")
         (result (help-fns-tests--describe-function 'search-forward-regexp)=
))
     (should (string-match regexp result))))
=20

diff --git a/test/lisp/emacs-lisp/cl-generic-tests.el b/test/lisp/emacs-lis=
p/cl-generic-tests.el
index 5aa58782f3..9582907e51 100644
--- a/test/lisp/emacs-lisp/cl-generic-tests.el
+++ b/test/lisp/emacs-lisp/cl-generic-tests.el
@@ -240,7 +240,7 @@ cl-generic-tests--method-files--finds-methods
   (let ((retval (cl--generic-method-files 'cl-generic-tests--generic)))
     (should (equal (length retval) 2))
     (mapc (lambda (x)
-            (should (equal (car x) cl-generic-tests--this-file))
+            (should (equal (file-truename (car x)) cl-generic-tests--this-=
file))
             (should (equal (cadr x) 'cl-generic-tests--generic)))
           retval)
     (should-not (equal (nth 0 retval) (nth 1 retval)))))


In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, =
cairo version 1.17.3)
 of 2020-08-21 built on strobe-jhalfs
Repository revision: 3e10174fb65f4eb601b1921271bdcf10c933b879
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Linux From Scratch SVN-20200401

Configured using:
 'configure 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt5/lib/pkgconfig'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD PDUMPER LCMS2




Acknowledgement sent to Stephen Berman <stephen.berman@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#43004; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 16 Oct 2020 08:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.