Stefan Kangas <stefan@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 43004) by debbugs.gnu.org; 31 Oct 2020 21:31:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 31 17:31:05 2020
Received: from localhost ([127.0.0.1]:34678 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kYySl-00057J-VL
for submit <at> debbugs.gnu.org; Sat, 31 Oct 2020 17:31:05 -0400
Received: from mout.gmx.net ([212.227.15.19]:48813)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stephen.berman@HIDDEN>) id 1kYySi-00056n-Ju
for 43004 <at> debbugs.gnu.org; Sat, 31 Oct 2020 17:31:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1604179854;
bh=UbEajGlGlEu4WHMx9WDkwoL1PabJfnBK2BMze33V8tk=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=UZ2BusvLymTCzA9gDcZtLVi6RjN63f07L9R+IFlnucYJqazj3EGDDnK6dpXbb3x5m
vDBXu6qtqa1i2bjPQ+smLJTvvNtQ8ljjXuCAqMs/NUg1K9fC+S164ojnIT7sMKg3Zy
DZZhQ7JsFnViCAlzQ8la7MA+K4lYXYRLQbzsIric=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.175.240]) by mail.gmx.com (mrgmx004
[212.227.17.190]) with ESMTPSA (Nemesis) id 1MLi8g-1kqVLR46ka-00Hfdw; Sat, 31
Oct 2020 22:30:54 +0100
From: Stephen Berman <stephen.berman@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources
References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN>
<87r1pyz27k.fsf@HIDDEN> <871rhy5j9h.fsf@HIDDEN>
<87mu0mz0op.fsf@HIDDEN>
<7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN>
<87ft6dzybm.fsf@HIDDEN>
<edfa04f7-5ae4-0542-0c4f-2d77c3cd9eb2@HIDDEN>
<87a6w3mmma.fsf@HIDDEN>
<3a490fed-c53e-eabe-34a6-427833a71c45@HIDDEN>
Date: Sat, 31 Oct 2020 22:30:48 +0100
In-Reply-To: <3a490fed-c53e-eabe-34a6-427833a71c45@HIDDEN> (Dmitry Gutov's
message of "Sat, 31 Oct 2020 03:39:12 +0200")
Message-ID: <87pn4yqe0n.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:EWWLxCNbLck3apLX+wO+BBE/GDYXYewR/mZYVei3N8NyjO3m02T
H+xl5doFFT2cB7EF8K2oCwCrFCzu/YcslYUEwPF9YhHnRBZdo3xwja0SNrc2r1IOCVzKkww
PF7GGophEncs1qhoeCGttVxJz21Wj0SBRQuVM3QAOXmV1B21Njiag6Qhw5tyKHiih2LOAeZ
BbCE+cXiIysM226gYNHAg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:f3qCVOfHpQY=:mLrMGjjVqq7LaNhlZFTQ0N
Zie1vBN6UrM1ewtETGC2A1Sob++sRAAaiIlv0XohTrLZ6vqyb66HLJNkV2eVkQIIIL+AFWAvo
MyM3+KRR4G6WdKx99460AomSr8tyQBELuFFgL+dnqc2EojElOXk7P8QPk6AafGxbaThej3Jto
5VC7S+4dLoChL4OrWN1jOThDQlUVrD0W62TXxsypLk2Ifl4GCKlHnbkF/voUrrQOh9R8H6uf+
AjbkVfdTABLXyOsrf89Bt+cLs7tXmpz/jcS/hv3WYRlmH4EUWfBbM3SIZhLCKi+PsJCqpqLRp
2EwkClMS5fKrIAFWM3fJF+j7cbX0fuHzNhLniBOqS8azeO5YOMyGON//5QK3C75ghpsiq37AL
TEGo5rYlV6pPo9qg1ckG49Kx1QpGmg5VrpRmpfGITxXlVO/iY+O0mKBka3UsdRd1O1O0D0Rj6
cLRIccpId3MFy3Qb8e1j/FY3Ep/D+nwubpqJ+UlavTcHAeJIzuy35Z0L+ff8rOAwk7qJ+1Olu
RSFchB3zqtyg3wpBl6is1UXyyzDq7w18P8kHdTUaps8hku+oYjsApCNclyNahX3IfqBK8KRhl
yhdv21Iq71+FGTw2S3188VgOMIfRbsdLeOOND1rYfWArf3OG4+0/0+veZ4Tp3leemD/bRjfiq
/0FRWpY7iRnE9gsArgGXqMfHaGWcisxmSYDCSePZpiye4ETYAazFLGa2sFJu1hEVQdMApjGXa
SBI8G0AaMNVOVUI8pWYaG++tfv9HONf6/I7Tm59v3RXMR52O/IT/gjMHxjsFHDvAgJ//fj3Zt
1UJoNYuoGXAujjKLKQhBn+jSwd4r5Nv2W3RPmHKEsAY5H4nnb+D0zdGFE2O63IC8CNVbsa5yl
5hiHdUv0tiuWFmfdYvPw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43004
Cc: Glenn Morris <rgm@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>,
43004 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
On Sat, 31 Oct 2020 03:39:12 +0200 Dmitry Gutov <dgutov@HIDDEN> wrote:
> On 30.10.2020 23:26, Stephen Berman wrote:
>> That's what I did in my patch in<87r1pyz27k.fsf@HIDDEN>
>> (https://debbugs.gnu.org/cgi/bugreport.cgi?msg=11;att=1;bug=43004) and
>> initially concluded that with that patch "I now get no unexpected
>> failures when running the tests in batch mode, though when run
>> interactively xref-elisp-test-find-defs-defgeneric-implicit-generic
>> still fails."
>
> But looking at that patch, you moved some of the 'file-truename' calls, at
> least, down inside the test definitions, to produce the "expected" values.
>
> What happens if you just remove that 'file-truename' call without adding it
> somewhere else?
With just that change, a batch run started in the test subdirectory of
the emacs sources symlinked from my home directory gives:
5 unexpected results:
FAILED xref-elisp-test-find-defs-constructor
FAILED xref-elisp-test-find-defs-defalias-defun-el
FAILED xref-elisp-test-find-defs-defgeneric-el
FAILED xref-elisp-test-find-defs-defun-el-defvar-c
FAILED xref-elisp-test-find-defs-face-el
A batch run started in the non-symlinked test subdirectory gives:
5 unexpected results:
FAILED xref-elisp-test-find-defs-defgeneric-el
FAILED xref-elisp-test-find-defs-defun-defvar-el
FAILED xref-elisp-test-find-defs-defun-el
FAILED xref-elisp-test-find-defs-defvar-el
FAILED xref-elisp-test-find-defs-feature-el
Full output of the batch runs is attached.
Steve Berman
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment
Content-Transfer-Encoding: quoted-printable
Content-Description: ert batch output
steve [ ~/src/emacs/emacs-master/test/lisp/progmodes ]$ emacs-master -batch=
-l ert -l elisp-mode-tests.el -f ert-run-tests-batch-and-exit
Running 46 tests (2020-10-31 22:19:26+0100, selector =E2=80=98t=E2=80=99)
passed 1/46 elisp--highlight-function-argument-indexed (0.000136 sec)
passed 2/46 elisp--highlight-function-argument-keyed-1 (0.000197 sec)
passed 3/46 elisp--highlight-function-argument-keyed-2 (0.000172 sec)
passed 4/46 elisp--preceding-sexp--char-name (0.000107 sec)
passed 5/46 elisp-completes-anything-quoted (0.010651 sec)
passed 6/46 elisp-completes-functions (0.001088 sec)
passed 7/46 elisp-completes-functions-after-hash-quote (0.000037 sec)
passed 8/46 elisp-completes-functions-after-let-bindings (0.001059 se=
c)
passed 9/46 elisp-completes-functions-in-special-macros (0.002027 sec)
passed 10/46 elisp-completes-local-variables (0.001054 sec)
passed 11/46 elisp-completes-variables (0.001045 sec)
passed 12/46 elisp-completes-variables-unquoted (0.003028 sec)
passed 13/46 elisp-completest-variables-in-let-bindings (0.002004 sec)
Indenting region...=20
Indenting region...done
passed 14/46 elisp-indent-basic (0.000256 sec)
passed 15/46 eval-last-sexp-print-format-large-int (0.000116 sec)
skipped 16/46 eval-last-sexp-print-format-large-int-echo (0.000109 sec)
passed 17/46 eval-last-sexp-print-format-small-int (0.000089 sec)
skipped 18/46 eval-last-sexp-print-format-small-int-echo (0.000073 sec)
passed 19/46 eval-last-sexp-print-format-sym (0.000059 sec)
skipped 20/46 eval-last-sexp-print-format-sym-echo (0.000076 sec)
Test xref-elisp-test-find-defs-constructor backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-5ad7e8>) ((#<xref-item xr
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (t) nil (let ((find-file-suppress-same-file-warnings t)) (x
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-constructor
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-constructor condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(cl-defstruct (xref-elisp-location (:constructor xref-make-elisp-locat=
ion)))" 1 13 ... 14 34 ...)
#s(xref-elisp-location xref-elisp-location define-type "/datadisk/steve/s=
rc/emacs/emacs-master/lisp/progmodes/elisp-mode.el"))
#s(xref-item "(cl-defstruct (xref-elisp-location (:constructor xref-=
make-elisp-location)))" #s(xref-elisp-location xref-elisp-location define-t=
ype "/home/steve/src/emacs/emacs-master/lisp/progmodes/elisp-mode.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 67 63 "/datadisk/steve/src/emacs/emac=
s-master/lisp/progmodes/elisp-mode.el" "/home/steve/src/emacs/emacs-master/=
lisp/progmodes/elisp-mode.el" first-mismatch-at 1)))))
FAILED 21/46 xref-elisp-test-find-defs-constructor (0.004539 sec)
Test xref-elisp-test-find-defs-defalias-defun-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-4c1df2> #<xref-item xref-
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (t) nil (let ((find-file-suppress-same-file-warnings t)) (x
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defalias-de
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defalias-defun-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defalias Buffer-menu-sort)" 1 9 ... 10 26 ...)
#s(xref-elisp-location Buffer-menu-sort defalias "/datadisk/steve/src/ema=
cs/emacs-master/lisp/buff-menu.elc"))
#s(xref-item "(defalias Buffer-menu-sort)" #s(xref-elisp-location Bu=
ffer-menu-sort defalias "/home/steve/src/emacs/emacs-master/lisp/buff-menu.=
elc")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 53 "/datadisk/steve/src/emacs/emac=
s-master/lisp/buff-menu.elc" "/home/steve/src/emacs/emacs-master/lisp/buff-=
menu.elc" first-mismatch-at 1)))))
FAILED 22/46 xref-elisp-test-find-defs-defalias-defun-el (0.000506 sec)
passed 23/46 xref-elisp-test-find-defs-defgeneric-co-located-default (=
0.015220 sec)
Test xref-elisp-test-find-defs-defgeneric-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-4d2930> #<xref-item xref-
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defgeneric-
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defgeneric-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(cl-defmethod xref-location-marker ((l xref-elisp-location)))" 1 13 ..=
. 14 34 ...)
#s(xref-elisp-location ... cl-defmethod "/datadisk/steve/src/emacs/emacs-=
master/lisp/progmodes/elisp-mode.el"))
#s(xref-item "(cl-defmethod xref-location-marker ((l xref-elisp-loca=
tion)))" #s(xref-elisp-location ... cl-defmethod "/home/steve/src/emacs/ema=
cs-master/lisp/progmodes/elisp-mode.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 67 63 "/datadisk/steve/src/emacs/emac=
s-master/lisp/progmodes/elisp-mode.el" "/home/steve/src/emacs/emacs-master/=
lisp/progmodes/elisp-mode.el" first-mismatch-at 1)))))
FAILED 24/46 xref-elisp-test-find-defs-defgeneric-el (0.007537 sec)
passed 25/46 xref-elisp-test-find-defs-defgeneric-eval (0.000135 sec)
passed 26/46 xref-elisp-test-find-defs-defgeneric-implicit-generic (0.=
001208 sec)
passed 27/46 xref-elisp-test-find-defs-defgeneric-no-default (0.001076=
sec)
passed 28/46 xref-elisp-test-find-defs-defgeneric-no-methods (0.000736=
sec)
passed 29/46 xref-elisp-test-find-defs-defgeneric-separate-default (0.=
002073 sec)
passed 30/46 xref-elisp-test-find-defs-define-overload-co-located-defa=
ult (0.005438 sec)
passed 31/46 xref-elisp-test-find-defs-define-overload-no-default (0.0=
03121 sec)
passed 32/46 xref-elisp-test-find-defs-define-overload-no-methods (0.0=
02311 sec)
passed 33/46 xref-elisp-test-find-defs-define-overload-separate-defaul=
t (0.003169 sec)
passed 34/46 xref-elisp-test-find-defs-defun-c (0.091946 sec)
passed 35/46 xref-elisp-test-find-defs-defun-c-defvar-c (0.027455 sec)
passed 36/46 xref-elisp-test-find-defs-defun-defvar-el (0.008166 sec)
passed 37/46 xref-elisp-test-find-defs-defun-el (0.001137 sec)
Test xref-elisp-test-find-defs-defun-el-defvar-c backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-4678d2> #<xref-item xref-
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defun-el-de
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defun-el-defvar-c condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defun abbrev-mode)" 1 6 ... 7 18 ...)
#s(xref-elisp-location abbrev-mode nil "/datadisk/steve/src/emacs/emacs-m=
aster/lisp/abbrev.el"))
#s(xref-item "(defun abbrev-mode)" #s(xref-elisp-location abbrev-mod=
e nil "/home/steve/src/emacs/emacs-master/lisp/abbrev.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 53 49 "/datadisk/steve/src/emacs/emac=
s-master/lisp/abbrev.el" "/home/steve/src/emacs/emacs-master/lisp/abbrev.el=
" first-mismatch-at 1)))))
FAILED 38/46 xref-elisp-test-find-defs-defun-el-defvar-c (0.002712 sec)
passed 39/46 xref-elisp-test-find-defs-defun-eval (0.000313 sec)
passed 40/46 xref-elisp-test-find-defs-defvar-c (0.002259 sec)
passed 41/46 xref-elisp-test-find-defs-defvar-el (0.000795 sec)
passed 42/46 xref-elisp-test-find-defs-defvar-eval (0.000118 sec)
Test xref-elisp-test-find-defs-face-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-39bf06> #<xref-item xref-
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-face-el :do
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-face-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defvar font-lock-keyword-face)" 1 7 ... 8 30 ...)
#s(xref-elisp-location font-lock-keyword-face defvar "/datadisk/steve/src=
/emacs/emacs-master/lisp/font-lock.el"))
#s(xref-item "(defvar font-lock-keyword-face)" #s(xref-elisp-locatio=
n font-lock-keyword-face defvar "/home/steve/src/emacs/emacs-master/lisp/fo=
nt-lock.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 56 52 "/datadisk/steve/src/emacs/emac=
s-master/lisp/font-lock.el" "/home/steve/src/emacs/emacs-master/lisp/font-l=
ock.el" first-mismatch-at 1)))))
FAILED 43/46 xref-elisp-test-find-defs-face-el (0.000368 sec)
passed 44/46 xref-elisp-test-find-defs-face-eval (0.000304 sec)
passed 45/46 xref-elisp-test-find-defs-feature-el (0.000697 sec)
passed 46/46 xref-elisp-test-find-defs-feature-eval (0.001119 sec)
Ran 46 tests, 38 results as expected, 5 unexpected, 3 skipped (2020-10-31 2=
2:19:27+0100, 1.007205 sec)
5 unexpected results:
FAILED xref-elisp-test-find-defs-constructor
FAILED xref-elisp-test-find-defs-defalias-defun-el
FAILED xref-elisp-test-find-defs-defgeneric-el
FAILED xref-elisp-test-find-defs-defun-el-defvar-c
FAILED xref-elisp-test-find-defs-face-el
3 skipped results:
SKIPPED eval-last-sexp-print-format-large-int-echo
SKIPPED eval-last-sexp-print-format-small-int-echo
SKIPPED eval-last-sexp-print-format-sym-echo
steve [ ~/src/emacs/emacs-master/test/lisp/progmodes ]$ cd /datadisk/steve/=
src/emacs/emacs-master/test/lisp/progmodes/
steve [ /datadisk/steve/src/emacs/emacs-master/test/lisp/progmodes ]$ emacs=
-master -batch -l ert -l elisp-mode-tests.el -f ert-run-tests-batch-and-exit
Running 46 tests (2020-10-31 22:20:00+0100, selector =E2=80=98t=E2=80=99)
passed 1/46 elisp--highlight-function-argument-indexed (0.000134 sec)
passed 2/46 elisp--highlight-function-argument-keyed-1 (0.000208 sec)
passed 3/46 elisp--highlight-function-argument-keyed-2 (0.000183 sec)
passed 4/46 elisp--preceding-sexp--char-name (0.000112 sec)
passed 5/46 elisp-completes-anything-quoted (0.010931 sec)
passed 6/46 elisp-completes-functions (0.001037 sec)
passed 7/46 elisp-completes-functions-after-hash-quote (0.000039 sec)
passed 8/46 elisp-completes-functions-after-let-bindings (0.001043 se=
c)
passed 9/46 elisp-completes-functions-in-special-macros (0.002019 sec)
passed 10/46 elisp-completes-local-variables (0.001069 sec)
passed 11/46 elisp-completes-variables (0.001149 sec)
passed 12/46 elisp-completes-variables-unquoted (0.003082 sec)
passed 13/46 elisp-completest-variables-in-let-bindings (0.002124 sec)
Indenting region...=20
Indenting region...done
passed 14/46 elisp-indent-basic (0.000266 sec)
passed 15/46 eval-last-sexp-print-format-large-int (0.000110 sec)
skipped 16/46 eval-last-sexp-print-format-large-int-echo (0.000092 sec)
passed 17/46 eval-last-sexp-print-format-small-int (0.000089 sec)
skipped 18/46 eval-last-sexp-print-format-small-int-echo (0.000074 sec)
passed 19/46 eval-last-sexp-print-format-sym (0.000056 sec)
skipped 20/46 eval-last-sexp-print-format-sym-echo (0.000073 sec)
passed 21/46 xref-elisp-test-find-defs-constructor (0.031150 sec)
passed 22/46 xref-elisp-test-find-defs-defalias-defun-el (0.013090 sec)
passed 23/46 xref-elisp-test-find-defs-defgeneric-co-located-default (=
0.008294 sec)
Test xref-elisp-test-find-defs-defgeneric-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-5ac4fe> #<xref-item xref-
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defgeneric-
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defgeneric-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(cl-defgeneric xref-location-marker)" 1 14 ... 15 35 ...)
#s(xref-elisp-location xref-location-marker cl-defgeneric "/home/steve/sr=
c/emacs/emacs-master/lisp/progmodes/xref.el"))
#s(xref-item "(cl-defgeneric xref-location-marker)" #s(xref-elisp-lo=
cation xref-location-marker cl-defgeneric "/datadisk/steve/src/emacs/emacs-=
master/lisp/progmodes/xref.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 61 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/xref.el" "/datadisk/steve/src/emacs/emacs-master/lisp/p=
rogmodes/xref.el" first-mismatch-at 1)))))
FAILED 24/46 xref-elisp-test-find-defs-defgeneric-el (0.001146 sec)
passed 25/46 xref-elisp-test-find-defs-defgeneric-eval (0.000130 sec)
passed 26/46 xref-elisp-test-find-defs-defgeneric-implicit-generic (0.=
000965 sec)
passed 27/46 xref-elisp-test-find-defs-defgeneric-no-default (0.000864=
sec)
passed 28/46 xref-elisp-test-find-defs-defgeneric-no-methods (0.000460=
sec)
passed 29/46 xref-elisp-test-find-defs-defgeneric-separate-default (0.=
001256 sec)
passed 30/46 xref-elisp-test-find-defs-define-overload-co-located-defa=
ult (0.005342 sec)
passed 31/46 xref-elisp-test-find-defs-define-overload-no-default (0.0=
04410 sec)
passed 32/46 xref-elisp-test-find-defs-define-overload-no-methods (0.0=
03895 sec)
passed 33/46 xref-elisp-test-find-defs-define-overload-separate-defaul=
t (0.003244 sec)
passed 34/46 xref-elisp-test-find-defs-defun-c (0.093858 sec)
passed 35/46 xref-elisp-test-find-defs-defun-c-defvar-c (0.027207 sec)
Test xref-elisp-test-find-defs-defun-defvar-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-61a1b8>) ((#<xref-item xr
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defun-defva
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defun-defvar-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defun compilation-minor-mode)" 1 6 ... 7 29 ...)
#s(xref-elisp-location compilation-minor-mode nil "/home/steve/src/emacs/=
emacs-master/lisp/progmodes/compile.el"))
#s(xref-item "(defun compilation-minor-mode)" #s(xref-elisp-location=
compilation-minor-mode nil "/datadisk/steve/src/emacs/emacs-master/lisp/pr=
ogmodes/compile.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 60 64 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/compile.el" "/datadisk/steve/src/emacs/emacs-master/lis=
p/progmodes/compile.el" first-mismatch-at 1)))))
FAILED 36/46 xref-elisp-test-find-defs-defun-defvar-el (0.000364 sec)
Test xref-elisp-test-find-defs-defun-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-5dc1e2>) (#<xref-item xre
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defun-el :d
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defun-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defun xref-find-definitions)" 1 6 ... 7 28 ...)
#s(xref-elisp-location xref-find-definitions nil "/home/steve/src/emacs/e=
macs-master/lisp/progmodes/xref.el"))
#s(xref-item "(defun xref-find-definitions)" #s(xref-elisp-location =
xref-find-definitions nil "/datadisk/steve/src/emacs/emacs-master/lisp/prog=
modes/xref.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 61 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/xref.el" "/datadisk/steve/src/emacs/emacs-master/lisp/p=
rogmodes/xref.el" first-mismatch-at 1)))))
FAILED 37/46 xref-elisp-test-find-defs-defun-el (0.000277 sec)
passed 38/46 xref-elisp-test-find-defs-defun-el-defvar-c (0.010073 sec)
passed 39/46 xref-elisp-test-find-defs-defun-eval (0.000464 sec)
passed 40/46 xref-elisp-test-find-defs-defvar-c (0.002247 sec)
Test xref-elisp-test-find-defs-defvar-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-5b481c>) (#<xref-item xre
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defvar-el :
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defvar-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defvar xref--marker-ring)" 1 7 ... 8 25 ...)
#s(xref-elisp-location xref--marker-ring defvar "/home/steve/src/emacs/em=
acs-master/lisp/progmodes/xref.el"))
#s(xref-item "(defvar xref--marker-ring)" #s(xref-elisp-location xre=
f--marker-ring defvar "/datadisk/steve/src/emacs/emacs-master/lisp/progmode=
s/xref.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 61 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/xref.el" "/datadisk/steve/src/emacs/emacs-master/lisp/p=
rogmodes/xref.el" first-mismatch-at 1)))))
FAILED 41/46 xref-elisp-test-find-defs-defvar-el (0.000243 sec)
passed 42/46 xref-elisp-test-find-defs-defvar-eval (0.000179 sec)
passed 43/46 xref-elisp-test-find-defs-face-el (0.009761 sec)
passed 44/46 xref-elisp-test-find-defs-face-eval (0.000469 sec)
Test xref-elisp-test-find-defs-feature-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-66040e>) ((#<xref-item xr
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-feature-el=20
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-feature-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(feature xref)" 1 8 ... 9 13 ...)
#s(xref-elisp-location xref feature "/home/steve/src/emacs/emacs-master/l=
isp/progmodes/xref.el"))
#s(xref-item "(feature xref)" #s(xref-elisp-location xref feature "/=
datadisk/steve/src/emacs/emacs-master/lisp/progmodes/xref.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 61 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/xref.el" "/datadisk/steve/src/emacs/emacs-master/lisp/p=
rogmodes/xref.el" first-mismatch-at 1)))))
FAILED 45/46 xref-elisp-test-find-defs-feature-el (0.000362 sec)
passed 46/46 xref-elisp-test-find-defs-feature-eval (0.001159 sec)
Ran 46 tests, 38 results as expected, 5 unexpected, 3 skipped (2020-10-31 2=
2:20:01+0100, 1.097991 sec)
5 unexpected results:
FAILED xref-elisp-test-find-defs-defgeneric-el
FAILED xref-elisp-test-find-defs-defun-defvar-el
FAILED xref-elisp-test-find-defs-defun-el
FAILED xref-elisp-test-find-defs-defvar-el
FAILED xref-elisp-test-find-defs-feature-el
3 skipped results:
SKIPPED eval-last-sexp-print-format-large-int-echo
SKIPPED eval-last-sexp-print-format-small-int-echo
SKIPPED eval-last-sexp-print-format-sym-echo
steve [ /datadisk/steve/src/emacs/emacs-master/test/lisp/progmodes ]$=20
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.Received: (at 43004) by debbugs.gnu.org; 31 Oct 2020 01:39:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 30 21:39:22 2020 Received: from localhost ([127.0.0.1]:60236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kYfrW-0001tJ-J0 for submit <at> debbugs.gnu.org; Fri, 30 Oct 2020 21:39:22 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:43184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1kYfrV-0001t6-D9 for 43004 <at> debbugs.gnu.org; Fri, 30 Oct 2020 21:39:22 -0400 Received: by mail-ej1-f43.google.com with SMTP id k3so11046758ejj.10 for <43004 <at> debbugs.gnu.org>; Fri, 30 Oct 2020 18:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Q0hp1le6g1ThnKItFA0Qq0zF1aS5paWqXTARNsrHs4w=; b=vMIunSgTErwuNpkyFfm4w2pRe93rBAWOb4dSAO5cHKr1QP7riUS/AXGoyfz/7Ph7pf xpet8XFnlPSC8pEMYd13OZrmpoX4/vY2WolBydT43rgz40tz3EpF6xtB6CmQyOx52rFd MI99/QVV1IGI9gDoaHXwxJOSh8Yr+jvDcl+C4tv10hjQoo4opzmxC5eJBM8GoW3B9G7d 8bi1QoPeHdGgRzCbjQR7VqLEizTcepzJPJQgDqpKpd0Be0CCzo+ElotFYMnkcc1nziMY QBOm60L7eOTMs8yIbbfbr/I+hGP2wamCccwB7AISvY2zGkxeq5p0HjdiIJSYENt/UGkc P4fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q0hp1le6g1ThnKItFA0Qq0zF1aS5paWqXTARNsrHs4w=; b=O5D6jklBuE1+9EWkQ2oeD8ENyBJlvscOqe8ZA0R5Dp7fDvePXLhhdOxLw4RuPWC4F0 x2ZjDXx0K/clXIUcJFWHVTaMgPU7TBb5LFc5sVhZ3uW454sgcosm3ZP+6GFum2XQ5ra9 lgs6KCynMf37t8a0vlz6r+ZtX12RDCf/Z0Qp35yTIgKmaEoahiovAYYBMA7OklScxQlt vJRez54JZrJfmR45lSTtHArJcPPpyf3RWd0WsccGFTUL/Ju+JvThkp7QxHWJt0wnsp6b Qwb87yDQY18uPcEmQErAfGzpzPLLpOXYa6+Ja56nCuJqepTO7NRuTsUEP1V2aW3zCE4E uiUA== X-Gm-Message-State: AOAM530qhJ2jTMdV98LGMnUXC5VdQxfNvRMXIrLUixyRzM4NRJdmy7/b S8bmeD0H3AJycx6eV+5ti5yp0u2lDiaQRA== X-Google-Smtp-Source: ABdhPJwNYmHwVQ+MO1OQcrYOHZmMwgoio4Hwclh87jkHn2SU0X4Xg2KoTQshjY1N/LpphL4sazJOZQ== X-Received: by 2002:a17:906:590d:: with SMTP id h13mr5205814ejq.226.1604108355253; Fri, 30 Oct 2020 18:39:15 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id p20sm3549925ejd.78.2020.10.30.18.39.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Oct 2020 18:39:14 -0700 (PDT) Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources To: Stephen Berman <stephen.berman@HIDDEN> References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN> <87r1pyz27k.fsf@HIDDEN> <871rhy5j9h.fsf@HIDDEN> <87mu0mz0op.fsf@HIDDEN> <7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN> <87ft6dzybm.fsf@HIDDEN> <edfa04f7-5ae4-0542-0c4f-2d77c3cd9eb2@HIDDEN> <87a6w3mmma.fsf@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <3a490fed-c53e-eabe-34a6-427833a71c45@HIDDEN> Date: Sat, 31 Oct 2020 03:39:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87a6w3mmma.fsf@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43004 Cc: Glenn Morris <rgm@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 43004 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) On 30.10.2020 23:26, Stephen Berman wrote: > That's what I did in my patch in<87r1pyz27k.fsf@HIDDEN> > (https://debbugs.gnu.org/cgi/bugreport.cgi?msg=11;att=1;bug=43004) and > initially concluded that with that patch "I now get no unexpected > failures when running the tests in batch mode, though when run > interactively xref-elisp-test-find-defs-defgeneric-implicit-generic > still fails." But looking at that patch, you moved some of the 'file-truename' calls, at least, down inside the test definitions, to produce the "expected" values. What happens if you just remove that 'file-truename' call without adding it somewhere else?
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.Received: (at 43004) by debbugs.gnu.org; 30 Oct 2020 21:26:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 30 17:26:35 2020 Received: from localhost ([127.0.0.1]:59963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kYbut-0001yH-Kt for submit <at> debbugs.gnu.org; Fri, 30 Oct 2020 17:26:35 -0400 Received: from mout.gmx.net ([212.227.15.18]:59351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stephen.berman@HIDDEN>) id 1kYbuq-0001y0-OC for 43004 <at> debbugs.gnu.org; Fri, 30 Oct 2020 17:26:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604093186; bh=YK8wXFYgRZ9psWxA25btmhu5zs9Bojf9usVmYCJeXto=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=bRK4Ib/kJNvji3Mqr8T1lIEUhWMwAyFPu4fF63SWJw9rqU5382ll4JTdHO5USUoJ+ +DFHMHtVKk41nab+yA/g/xPosMDqc9xQlq+HrBbCzoIH26j7tQqNyq4jVi9vsfNll/ YP6NOh2RQSoWkjAJsSB3ux6246/ivhMx7EhPJfWE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([92.73.67.224]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXXyP-1ksGD708tD-00YvXg; Fri, 30 Oct 2020 22:26:26 +0100 From: Stephen Berman <stephen.berman@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN> <87r1pyz27k.fsf@HIDDEN> <871rhy5j9h.fsf@HIDDEN> <87mu0mz0op.fsf@HIDDEN> <7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN> <87ft6dzybm.fsf@HIDDEN> <edfa04f7-5ae4-0542-0c4f-2d77c3cd9eb2@HIDDEN> Date: Fri, 30 Oct 2020 22:26:21 +0100 In-Reply-To: <edfa04f7-5ae4-0542-0c4f-2d77c3cd9eb2@HIDDEN> (Dmitry Gutov's message of "Fri, 30 Oct 2020 01:02:14 +0200") Message-ID: <87a6w3mmma.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Wa3CJt6Tp/xgrObp4M4M6BYtuTO1VjpvqKottKMBbHl1QkXtfEM PqZ88TJU+kya5C5rLoYIpTR/I/WU2nyX6pvgFOZt//dMrhLh4c7Czd1qyNekMw4CgeONBX0 un3Tc5dtb9ATU0q7hYBLxtsFXQIVJJm+koXrGcHhkXhZWomWClj1qBz1U5Pha5dtsyEizM+ Trc+PdisZzH7vP2LLL/Aw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:IgZFc5cFHUc=:d3IWBPmzsJBthPGt5ygyjV wdDEuLDweJQEH1qYM+j+QJViM/RUI5FaEXwOwkHPkcumz21CnB2GGk+yRJiOh5RKwvgdp9HlK 8fTe3DKbrnTqFNSCzcT6J9xL6se5Ak9cTK+LMcyFP1yDPUYGpD0kIkNYy7xnOCPcdJt3MVQqI FVJnoYUREv/EQEwKovu89uaK5DKvPW9vpAKu4yj618BQ68mdeHi+Z0fEWiRb7VfDuKkRjimoO e2K1USvhWvjdBXPRZ1UiS8bFa7HvUGzO2jPEb4byFNuJ2nUBRxam57pc4rleIE7XGmraj/e1T x8hpmCyFRY++nLtBiVmWgVoy4Hhd8/tB6/U6Rn7LbCDjpGtn7tsu7wbpT5jLyfzC2MAa84jDU az9E4btDGwGuR8kst0vi92qWgEucElRnYo/2EVvUZ+4uMzfd41GEx+lYQxSzvqHBLK00k3bHW YiYhfamZstEkK9xJI0BYzx/RYenJg4zjezbzZi1Q2M+8ZxFhgEKaYbGaGJUwvuSJHMbItlWQL 13QWwcCgS09mq6xsVbjYa+lJY0GKnsSa4W/I95K41Rq4mJt7LdVdFjF7IUFZRemzCud6kGFE2 Mt2aOE48Cgs5hsQZg4aQfBVQM08xqTSDqXwZb+Yl3nRPWc9fXM7zO4jHDAmcZiaWZO5ziZ8ZA vXXlFEZWpt5I9NqQZs3bo5pKi+T+b7w3TB8mCqisuEa6xCqc54T0iLPnH6Rhrtz2889lMk/fS df1s92VvUEcSpns16vhkdWHUWCjwgvfbH66YTGbRdRRvg87d7yglWhRaELj1mrPoMZ4IewuGG eYjTcGqJte/sITkaEUSytrrjwixXcJ7LIZWh0bd7kvP1jEdeUf+IHVlEqK5g7ekUA5aKVV8hd s2mgsu/Y6rdkpRRnFAjQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43004 Cc: Glenn Morris <rgm@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 43004 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On Fri, 30 Oct 2020 01:02:14 +0200 Dmitry Gutov <dgutov@HIDDEN> wrote: > On 16.10.2020 23:54, Stephen Berman wrote: >> I've attached the output of two batch runs using the patched >> elisp-mode-tests.el. The first run was executed from my home directory, >> the second run was executed from the partition the file is really >> located on, which is symlinked from my home directory: >> (expand-file-name >> "~/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el") >> => >> "/home/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el" >> (file-truename >> "/home/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el") >> => >> "/datadisk/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el" >> On the first run there are no unexpected failures, on the second, there >> are five unexpected failures. > > So, what happens if you just remove the 'file-truename' call from the > declaration of emacs-test-dir? That's what I did in my patch in <87r1pyz27k.fsf@HIDDEN> (https://debbugs.gnu.org/cgi/bugreport.cgi?msg=11;att=1;bug=43004) and initially concluded that with that patch "I now get no unexpected failures when running the tests in batch mode, though when run interactively xref-elisp-test-find-defs-defgeneric-implicit-generic still fails." But then in my next followup: "I also just realized that I had run the patched batch mode tests from my home directory, i.e., following the symlink. When I run them from the source directory without following the symlink, I get the same five failures again (i.e., with the patch) that I had gotten before without the patch. So much for that attempt." > It was added by Glenn in c4ecc01a45, and there must be a reason for it, but it > seems like it causes the current failures. > > Ultimately, if we don't manage to fix it in an easy way, we could replace the > > (should (equal xref expected-xref)) > > comparison inside xref-elisp-test-run with multiple deeper comparisons (and > use file-equal-p instead of equal for file names). Or call > xref-location-marker and compare markers. That may be a better test for my setup. Steve Berman
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.Received: (at 43004) by debbugs.gnu.org; 29 Oct 2020 23:02:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 29 19:02:23 2020 Received: from localhost ([127.0.0.1]:55270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kYGw3-0000A5-7w for submit <at> debbugs.gnu.org; Thu, 29 Oct 2020 19:02:23 -0400 Received: from mail-ej1-f41.google.com ([209.85.218.41]:43346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1kYGw2-00009u-G0 for 43004 <at> debbugs.gnu.org; Thu, 29 Oct 2020 19:02:22 -0400 Received: by mail-ej1-f41.google.com with SMTP id k3so6040528ejj.10 for <43004 <at> debbugs.gnu.org>; Thu, 29 Oct 2020 16:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cemCvFIPrSsNUuM7EdW0NNrv21YqyEo1nu1e8vrpyhs=; b=toLbLaROsXrFBNJFn5RaCoemVk8f4yDCaHG4toTdGM3z5cgglPolEdNSLW/JH6XGne faHFWUWdWrBNNVAqxW8UgWtBH6n7m34No8Pl5yHWjjqxPQjI/93hZmTpscLDnySZ/niE jqObFruUws/eJQNP0u5TDm6DHMo+1Z5yfLaSiXlkFRRiMo0WWHtf5rof6EAtvThHg00H WHQLlcaGiAEwVwYcBfqPeHdDUP2VdfmnhJV+IXh8vTBJ8B1C1RjyxSFdtRPEGYDF6qnU WF2/wDc5Gm0aqTwVpLoaTdu+lEcDxCzIVZJM+JKDrCTVl8CQFuDEYIWlLtj10X4O0cmN ZzAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cemCvFIPrSsNUuM7EdW0NNrv21YqyEo1nu1e8vrpyhs=; b=JAshp5pE1ovKASXFYtZ/x4Eo4w8JP0vkv27Ak2QiiRuPrRt/dLO+M+sPQX3Uiut9WV hM+mZMFJxpLmU9ugNvLhvUZLWYh/xrojmDw47tUZ+BOykZoNxPICImbklNvozS2XfoVr Rr+VNY3XkIbY4UNkoAePehLZQ8m/wXm5vFLmPH+dl9WaWQwGMaTvXu/O8uJfUB/IDv+A mLLT61SqKxxCMSeCoP2Gz/Nj97LykPiY03lPmo7HnCc7Bsno2xQ3dxFxnPcspWkXE/S9 S295VFaiZzbRRyqD/uw/ufSuv98fh813TuGQwHrqEDmhi5GH4d7+V7mFl4YnG48wzplm aLJg== X-Gm-Message-State: AOAM531D0GdpVAyFhjU9tvws+1IVu+uSZjz/+DJJMVmKOiKKkXJAHum+ nNCPDA2osUHPbXIWRYn680o= X-Google-Smtp-Source: ABdhPJywthgA0Y7gPGltcpLUURtOi5XGtSrFx0csfVIYJCgAyStg44V913wAWVigLzfKXeNUYxL22A== X-Received: by 2002:a17:906:d41:: with SMTP id r1mr6114493ejh.383.1604012536699; Thu, 29 Oct 2020 16:02:16 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id ef13sm2169764ejb.44.2020.10.29.16.02.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 16:02:15 -0700 (PDT) Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources To: Stephen Berman <stephen.berman@HIDDEN> References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN> <87r1pyz27k.fsf@HIDDEN> <871rhy5j9h.fsf@HIDDEN> <87mu0mz0op.fsf@HIDDEN> <7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN> <87ft6dzybm.fsf@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <edfa04f7-5ae4-0542-0c4f-2d77c3cd9eb2@HIDDEN> Date: Fri, 30 Oct 2020 01:02:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87ft6dzybm.fsf@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43004 Cc: Glenn Morris <rgm@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, 43004 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) On 16.10.2020 23:54, Stephen Berman wrote: > I've attached the output of two batch runs using the patched > elisp-mode-tests.el. The first run was executed from my home directory, > the second run was executed from the partition the file is really > located on, which is symlinked from my home directory: > > (expand-file-name > "~/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el") > => > "/home/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el" > > (file-truename > "/home/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el") > => > "/datadisk/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el" > > On the first run there are no unexpected failures, on the second, there > are five unexpected failures. So, what happens if you just remove the 'file-truename' call from the declaration of emacs-test-dir? It was added by Glenn in c4ecc01a45, and there must be a reason for it, but it seems like it causes the current failures. Ultimately, if we don't manage to fix it in an easy way, we could replace the (should (equal xref expected-xref)) comparison inside xref-elisp-test-run with multiple deeper comparisons (and use file-equal-p instead of equal for file names). Or call xref-location-marker and compare markers.
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.Received: (at 43004) by debbugs.gnu.org; 17 Oct 2020 06:39:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 17 02:39:49 2020 Received: from localhost ([127.0.0.1]:33106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kTfsb-0003xT-8b for submit <at> debbugs.gnu.org; Sat, 17 Oct 2020 02:39:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1kTfsZ-0003xG-TR for 43004 <at> debbugs.gnu.org; Sat, 17 Oct 2020 02:39:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=se3e5XtiwMjstuvPUCgSzBjQzWrcuqCkSiDktScLHDE=; b=oHccL3BH0vLEhN0QfIwtxUjXFp OP1WozN+9wxnkI/Z1uH757qw6tzHxruCDgcaNh+V/9gR4XWDW1XNg35DdOGUE5XOE0Vt+2yvqgY8D DhMGX8LhEY5V16Z8HjpOpkcHYtrO5E9TpJ4KzOBDyYI8CMPFcoqfh0Zgxkz43FJgmYy0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1kTfsR-00007Q-KV; Sat, 17 Oct 2020 08:39:42 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN> <87r1pyz27k.fsf@HIDDEN> <871rhy5j9h.fsf@HIDDEN> <87mu0mz0op.fsf@HIDDEN> <7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN> X-Now-Playing: Various's _1-8 Split Series_: "Ad Vanz, Gescom - Viral" Date: Sat, 17 Oct 2020 08:39:38 +0200 In-Reply-To: <7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN> (Dmitry Gutov's message of "Fri, 16 Oct 2020 23:20:19 +0300") Message-ID: <87k0vpz785.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: > I'm not sure what would be the best change here, or whether your usage > is something we absolutely need to support in 'make check' (Lars? do > we?), but one thing that should help is the exact exam [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43004 Cc: Stephen Berman <stephen.berman@HIDDEN>, 43004 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Dmitry Gutov <dgutov@HIDDEN> writes: > I'm not sure what would be the best change here, or whether your usage > is something we absolutely need to support in 'make check' (Lars? do > we?), but one thing that should help is the exact examples of strings > ( absolute file names) that mismatch. It'd certainly be nice if this worked -- especially since these are the only checks that fail in this situation. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.
Received: (at 43004) by debbugs.gnu.org; 16 Oct 2020 20:54:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 16 16:54:36 2020
Received: from localhost ([127.0.0.1]:32777 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kTWkF-0006kD-RI
for submit <at> debbugs.gnu.org; Fri, 16 Oct 2020 16:54:36 -0400
Received: from mout.gmx.net ([212.227.17.20]:56385)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stephen.berman@HIDDEN>) id 1kTWkD-0006jz-2W
for 43004 <at> debbugs.gnu.org; Fri, 16 Oct 2020 16:54:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1602881666;
bh=Ny5s3T3XB3rvswhcz9K4Xf4BZ+zhEyDwXtA9HxcLG6s=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=P61uDR4h47hi5AodnnANbMhkeroXwg2otd1Drm/ffJ/zDmYhIyVhe3BpTLf7wQzPZ
BSqj081bcCsoM3kDSs04F/MU4z7nQDSbqIjYfwXdsO7BKrIXk57mq3k55+//fwyqbh
zG7xrcFo8sLk8tfK3Nmj6WdnXQS0sp4X2TSKDibQ=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([178.6.213.172]) by mail.gmx.com (mrgmx104
[212.227.17.168]) with ESMTPSA (Nemesis) id 1Ma20q-1kzYAg0aKC-00Vx6q; Fri, 16
Oct 2020 22:54:26 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources
References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN>
<87r1pyz27k.fsf@HIDDEN> <871rhy5j9h.fsf@HIDDEN>
<87mu0mz0op.fsf@HIDDEN>
<7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN>
Date: Fri, 16 Oct 2020 22:54:21 +0200
In-Reply-To: <7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN> (Dmitry Gutov's
message of "Fri, 16 Oct 2020 23:20:19 +0300")
Message-ID: <87ft6dzybm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:j6BUXyMx8VCvy1OB2TvoYVEqqNQiwSHAYyK3NOhR0r3pEbgqunK
L8tw5SLZLmj4QdB+h/UFELRXEfbsOT2UJ7qwzjpSlf0esYdymE23b4+z79pHRjfGlDm5gaB
boprxmN1yaa9Vo8UjlhuIj27fq6WEVknYvhGuuZ+1TBvZErXTQYlCDMQhcWy9jwlHULMxSF
8QJzFaM6iBO6bbKHdexMg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:cWxJ7AXEoFY=:A5OgOGizEH6BY+SdlTvYRz
vEzsPuTkzjNpNl+8b09NvVrJrcGhTceoJ5KPULtph9bN8H+8MEJZ+3ZBI9TPWhRhkxBBJfjnd
oxbEvcM5WK8a3WZxxa1XWxTrpsZ3LvLGKfvm1OHKs1LQVYcDo560PwCh27pIMQOga6cOnF+Si
Q7Bj4k4+kJYwlaLaIRsfOHloMI5NZxl/9W195UruBiSly+Xz/ZPDlyX4cZaRWE709q27pbpWV
3jNQZY82SyEqN9GUs83sf1XgjJLpC+nqedQvJNifTTLWHQhpeHoTWTVdLLtnUYYxI/ZdbRyE5
HQENygyqW+1OUY1LknsWIsCEyuZnJDos0rX8Bm6vTJqdmg3/1DRSmAPuwBwnBsjnbugOniAIp
0TcS0TdCWUGnhQiYJccZxwWv9iP5+reBcz5WsmW+pZMX6k1X573anZrOjAjA7jiL23Jwo8k+G
hJfh8fR9Tiv120naw1UEThdslk4FSAbdECYqXcWcdZnGUNzmTop/vGipE2ttnyHNCWStpJkbV
RdSspkDRj5aL9pqhHF1WqwKaWj1P+5iKiZR2+CBjv+P17RcvHmFRpeolXvti5eqY/b9eZ0lEz
NaLViXNkX63INk2A9tXAj7Cw32SM8CZT8+r3TGy6MMOcp6LT3CIpJwRXHbLTz89SdX54uw6/T
F+9vUudsbAZWBU6csqqaqDtYkm0HRtz9L5Se/WsjB8e6BVrA82be8n+oddyTz9smcCqJ0WJbG
zbUSHPNsAJKcq/SPJK5a4NID/3/0NwyPH8fn++ul++xOXMSnkZ8inYPBrByzXxz8qrGLFuNS1
/OQvcORRAmZuYaVBdfCLo37hOQgoovtz0hUy5vVqu8UBRhddH1mdeh1McWBJqMkxGyGls0uPT
9fNa2zvm9tzSCh7/y42A==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43004
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 43004 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
On Fri, 16 Oct 2020 23:20:19 +0300 Dmitry Gutov <dgutov@HIDDEN> wrote:
> On 16.10.2020 17:48, Stephen Berman wrote:
>> Yes, please. I also just realized that I had run the patched batch mode
>> tests from my home directory, i.e., following the symlink. When I run
>> them from the source directory without following the symlink, I get the
>> same five failures again (i.e., with the patch) that I had gotten before
>> without the patch. So much for that attempt.
>
> So... the patch doesn't work?
>
> I'm not sure what would be the best change here, or whether your usage is
> something we absolutely need to support in 'make check' (Lars? do we?), but
> one thing that should help is the exact examples of strings ( absolute file
> names) that mismatch.
I've attached the output of two batch runs using the patched
elisp-mode-tests.el. The first run was executed from my home directory,
the second run was executed from the partition the file is really
located on, which is symlinked from my home directory:
(expand-file-name
"~/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el")
=>
"/home/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el"
(file-truename
"/home/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el")
=>
"/datadisk/steve/src/emacs/emacs-master/test/lisp/progmodes/elisp-mode-tests.el"
On the first run there are no unexpected failures, on the second, there
are five unexpected failures.
Steve Berman
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment; filename=xref-tests
Content-Transfer-Encoding: quoted-printable
Content-Description: elisp-mode-tests.el batch runs
steve [ ~ ]$ cd ~/src/emacs/emacs-master/test/lisp/progmodes/
steve [ ~/src/emacs/emacs-master/test/lisp/progmodes ]$ emacs-master -batch=
-l ert -l elisp-mode-tests.el -f ert-run-tests-batch-and-exit
Running 46 tests (2020-10-16 22:31:08+0200, selector =E2=80=98t=E2=80=99)
passed 1/46 elisp--highlight-function-argument-indexed (0.000164 sec)
passed 2/46 elisp--highlight-function-argument-keyed-1 (0.000199 sec)
passed 3/46 elisp--highlight-function-argument-keyed-2 (0.000163 sec)
passed 4/46 elisp--preceding-sexp--char-name (0.000108 sec)
passed 5/46 elisp-completes-anything-quoted (0.010978 sec)
passed 6/46 elisp-completes-functions (0.001097 sec)
passed 7/46 elisp-completes-functions-after-hash-quote (0.000085 sec)
passed 8/46 elisp-completes-functions-after-let-bindings (0.001057 se=
c)
passed 9/46 elisp-completes-functions-in-special-macros (0.002016 sec)
passed 10/46 elisp-completes-local-variables (0.001070 sec)
passed 11/46 elisp-completes-variables (0.001058 sec)
passed 12/46 elisp-completes-variables-unquoted (0.003069 sec)
passed 13/46 elisp-completest-variables-in-let-bindings (0.002225 sec)
Indenting region...=20
Indenting region...done
passed 14/46 elisp-indent-basic (0.000288 sec)
passed 15/46 eval-last-sexp-print-format-large-int (0.000165 sec)
skipped 16/46 eval-last-sexp-print-format-large-int-echo (0.000091 sec)
passed 17/46 eval-last-sexp-print-format-small-int (0.000090 sec)
skipped 18/46 eval-last-sexp-print-format-small-int-echo (0.000125 sec)
passed 19/46 eval-last-sexp-print-format-sym (0.000055 sec)
skipped 20/46 eval-last-sexp-print-format-sym-echo (0.000072 sec)
passed 21/46 xref-elisp-test-find-defs-constructor (0.030686 sec)
passed 22/46 xref-elisp-test-find-defs-defalias-defun-el (0.013515 sec)
passed 23/46 xref-elisp-test-find-defs-defgeneric-co-located-default (=
0.010218 sec)
passed 24/46 xref-elisp-test-find-defs-defgeneric-el (0.015510 sec)
passed 25/46 xref-elisp-test-find-defs-defgeneric-eval (0.000188 sec)
passed 26/46 xref-elisp-test-find-defs-defgeneric-implicit-generic (0.=
001169 sec)
passed 27/46 xref-elisp-test-find-defs-defgeneric-no-default (0.001111=
sec)
passed 28/46 xref-elisp-test-find-defs-defgeneric-no-methods (0.000652=
sec)
passed 29/46 xref-elisp-test-find-defs-defgeneric-separate-default (0.=
014258 sec)
passed 30/46 xref-elisp-test-find-defs-define-overload-co-located-defa=
ult (0.005824 sec)
passed 31/46 xref-elisp-test-find-defs-define-overload-no-default (0.0=
03958 sec)
passed 32/46 xref-elisp-test-find-defs-define-overload-no-methods (0.0=
02439 sec)
passed 33/46 xref-elisp-test-find-defs-define-overload-separate-defaul=
t (0.003328 sec)
passed 34/46 xref-elisp-test-find-defs-defun-c (0.097183 sec)
passed 35/46 xref-elisp-test-find-defs-defun-c-defvar-c (0.027612 sec)
passed 36/46 xref-elisp-test-find-defs-defun-defvar-el (0.009292 sec)
passed 37/46 xref-elisp-test-find-defs-defun-el (0.001261 sec)
passed 38/46 xref-elisp-test-find-defs-defun-el-defvar-c (0.009443 sec)
passed 39/46 xref-elisp-test-find-defs-defun-eval (0.000340 sec)
passed 40/46 xref-elisp-test-find-defs-defvar-c (0.002124 sec)
passed 41/46 xref-elisp-test-find-defs-defvar-el (0.000751 sec)
passed 42/46 xref-elisp-test-find-defs-defvar-eval (0.000117 sec)
passed 43/46 xref-elisp-test-find-defs-face-el (0.022559 sec)
passed 44/46 xref-elisp-test-find-defs-face-eval (0.000318 sec)
passed 45/46 xref-elisp-test-find-defs-feature-el (0.000655 sec)
passed 46/46 xref-elisp-test-find-defs-feature-eval (0.001085 sec)
Ran 46 tests, 43 results as expected, 0 unexpected, 3 skipped (2020-10-16 2=
2:31:08+0200, 0.301689 sec)
3 skipped results:
SKIPPED eval-last-sexp-print-format-large-int-echo
SKIPPED eval-last-sexp-print-format-small-int-echo
SKIPPED eval-last-sexp-print-format-sym-echo
steve [ ~/src/emacs/emacs-master/test/lisp/progmodes ]$ cd /datadisk/steve/=
src/emacs/emacs-master/test/lisp/progmodes/
steve [ /datadisk/steve/src/emacs/emacs-master/test/lisp/progmodes ]$ emacs=
-master -batch -l ert -l elisp-mode-tests.el -f ert-run-tests-batch-and-exit
Running 46 tests (2020-10-16 22:32:16+0200, selector =E2=80=98t=E2=80=99)
passed 1/46 elisp--highlight-function-argument-indexed (0.000149 sec)
passed 2/46 elisp--highlight-function-argument-keyed-1 (0.000199 sec)
passed 3/46 elisp--highlight-function-argument-keyed-2 (0.000161 sec)
passed 4/46 elisp--preceding-sexp--char-name (0.000106 sec)
passed 5/46 elisp-completes-anything-quoted (0.009869 sec)
passed 6/46 elisp-completes-functions (0.001164 sec)
passed 7/46 elisp-completes-functions-after-hash-quote (0.000056 sec)
passed 8/46 elisp-completes-functions-after-let-bindings (0.001062 se=
c)
passed 9/46 elisp-completes-functions-in-special-macros (0.002005 sec)
passed 10/46 elisp-completes-local-variables (0.001122 sec)
passed 11/46 elisp-completes-variables (0.001043 sec)
passed 12/46 elisp-completes-variables-unquoted (0.003025 sec)
passed 13/46 elisp-completest-variables-in-let-bindings (0.001980 sec)
Indenting region...=20
Indenting region...done
passed 14/46 elisp-indent-basic (0.000274 sec)
passed 15/46 eval-last-sexp-print-format-large-int (0.000108 sec)
skipped 16/46 eval-last-sexp-print-format-large-int-echo (0.000090 sec)
passed 17/46 eval-last-sexp-print-format-small-int (0.000085 sec)
skipped 18/46 eval-last-sexp-print-format-small-int-echo (0.000089 sec)
passed 19/46 eval-last-sexp-print-format-sym (0.000056 sec)
skipped 20/46 eval-last-sexp-print-format-sym-echo (0.000072 sec)
passed 21/46 xref-elisp-test-find-defs-constructor (0.027042 sec)
passed 22/46 xref-elisp-test-find-defs-defalias-defun-el (0.014630 sec)
passed 23/46 xref-elisp-test-find-defs-defgeneric-co-located-default (=
0.007012 sec)
Test xref-elisp-test-find-defs-defgeneric-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-a47932> #<xref-item xref-
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defgeneric-
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defgeneric-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(cl-defgeneric xref-location-marker)" 1 14 ... 15 35 ...)
#s(xref-elisp-location xref-location-marker cl-defgeneric "/home/steve/sr=
c/emacs/emacs-master/lisp/progmodes/xref.el"))
#s(xref-item "(cl-defgeneric xref-location-marker)" #s(xref-elisp-lo=
cation xref-location-marker cl-defgeneric "/datadisk/steve/src/emacs/emacs-=
master/lisp/progmodes/xref.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 61 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/xref.el" "/datadisk/steve/src/emacs/emacs-master/lisp/p=
rogmodes/xref.el" first-mismatch-at 1)))))
FAILED 24/46 xref-elisp-test-find-defs-defgeneric-el (0.000845 sec)
passed 25/46 xref-elisp-test-find-defs-defgeneric-eval (0.000156 sec)
passed 26/46 xref-elisp-test-find-defs-defgeneric-implicit-generic (0.=
000990 sec)
passed 27/46 xref-elisp-test-find-defs-defgeneric-no-default (0.000866=
sec)
passed 28/46 xref-elisp-test-find-defs-defgeneric-no-methods (0.000454=
sec)
passed 29/46 xref-elisp-test-find-defs-defgeneric-separate-default (0.=
001363 sec)
passed 30/46 xref-elisp-test-find-defs-define-overload-co-located-defa=
ult (0.005104 sec)
passed 31/46 xref-elisp-test-find-defs-define-overload-no-default (0.0=
03468 sec)
passed 32/46 xref-elisp-test-find-defs-define-overload-no-methods (0.0=
02156 sec)
passed 33/46 xref-elisp-test-find-defs-define-overload-separate-defaul=
t (0.002859 sec)
passed 34/46 xref-elisp-test-find-defs-defun-c (0.092257 sec)
passed 35/46 xref-elisp-test-find-defs-defun-c-defvar-c (0.027617 sec)
Test xref-elisp-test-find-defs-defun-defvar-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-ba0646>) ((#<xref-item xr
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defun-defva
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defun-defvar-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defun compilation-minor-mode)" 1 6 ... 7 29 ...)
#s(xref-elisp-location compilation-minor-mode nil "/home/steve/src/emacs/=
emacs-master/lisp/progmodes/compile.el"))
#s(xref-item "(defun compilation-minor-mode)" #s(xref-elisp-location=
compilation-minor-mode nil "/datadisk/steve/src/emacs/emacs-master/lisp/pr=
ogmodes/compile.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 60 64 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/compile.el" "/datadisk/steve/src/emacs/emacs-master/lis=
p/progmodes/compile.el" first-mismatch-at 1)))))
FAILED 36/46 xref-elisp-test-find-defs-defun-defvar-el (0.000341 sec)
Test xref-elisp-test-find-defs-defun-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-acba8e>) (#<xref-item xre
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defun-el :d
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defun-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defun xref-find-definitions)" 1 6 ... 7 28 ...)
#s(xref-elisp-location xref-find-definitions nil "/home/steve/src/emacs/e=
macs-master/lisp/progmodes/xref.el"))
#s(xref-item "(defun xref-find-definitions)" #s(xref-elisp-location =
xref-find-definitions nil "/datadisk/steve/src/emacs/emacs-master/lisp/prog=
modes/xref.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 61 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/xref.el" "/datadisk/steve/src/emacs/emacs-master/lisp/p=
rogmodes/xref.el" first-mismatch-at 1)))))
FAILED 37/46 xref-elisp-test-find-defs-defun-el (0.000323 sec)
passed 38/46 xref-elisp-test-find-defs-defun-el-defvar-c (0.010689 sec)
passed 39/46 xref-elisp-test-find-defs-defun-eval (0.000454 sec)
passed 40/46 xref-elisp-test-find-defs-defvar-c (0.002041 sec)
Test xref-elisp-test-find-defs-defvar-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-b6b684>) (#<xref-item xre
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-defvar-el :
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-defvar-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(defvar xref--marker-ring)" 1 7 ... 8 25 ...)
#s(xref-elisp-location xref--marker-ring defvar "/home/steve/src/emacs/em=
acs-master/lisp/progmodes/xref.el"))
#s(xref-item "(defvar xref--marker-ring)" #s(xref-elisp-location xre=
f--marker-ring defvar "/datadisk/steve/src/emacs/emacs-master/lisp/progmode=
s/xref.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 61 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/xref.el" "/datadisk/steve/src/emacs/emacs-master/lisp/p=
rogmodes/xref.el" first-mismatch-at 1)))))
FAILED 41/46 xref-elisp-test-find-defs-defvar-el (0.000203 sec)
passed 42/46 xref-elisp-test-find-defs-defvar-eval (0.000166 sec)
passed 43/46 xref-elisp-test-find-defs-face-el (0.010067 sec)
passed 44/46 xref-elisp-test-find-defs-face-eval (0.000463 sec)
Test xref-elisp-test-find-defs-feature-el backtrace:
signal(ert-test-failed (((should (equal xref expected-xref)) :form (
ert-fail(((should (equal xref expected-xref)) :form (equal #<xref-it
(if (unwind-protect (setq value-222 (apply fn-220 args-221)) (setq f
(let (form-description-224) (if (unwind-protect (setq value-222 (app
(let ((value-222 'ert-form-evaluation-aborted-223)) (let (form-descr
(let* ((fn-220 #'equal) (args-221 (condition-case err (let ((signal-
(let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xrefs))))) (exp
(while xrefs (let* ((xref (car-safe (prog1 xrefs (setq xrefs (cdr xr
xref-elisp-test-run((#<xref-item xref-item-a574e4>) ((#<xref-item xr
(let ((find-file-suppress-same-file-warnings t)) (xref-elisp-test-ru
(closure (cl-struct-xref-elisp-root-type-tags t) nil (let ((find-fil
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xref-elisp-test-find-defs-feature-el=20
ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-l" "ert" "-l" "elisp-mode-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test xref-elisp-test-find-defs-feature-el condition:
(ert-test-failed
((should
(equal xref expected-xref))
:form
(equal #s(xref-item
#("(feature xref)" 1 8 ... 9 13 ...)
#s(xref-elisp-location xref feature "/home/steve/src/emacs/emacs-master/l=
isp/progmodes/xref.el"))
#s(xref-item "(feature xref)" #s(xref-elisp-location xref feature "/=
datadisk/steve/src/emacs/emacs-master/lisp/progmodes/xref.el")))
:value nil :explanation
(array-elt 2
(struct-field file
(arrays-of-different-length 57 61 "/home/steve/src/emacs/emacs-ma=
ster/lisp/progmodes/xref.el" "/datadisk/steve/src/emacs/emacs-master/lisp/p=
rogmodes/xref.el" first-mismatch-at 1)))))
FAILED 45/46 xref-elisp-test-find-defs-feature-el (0.000272 sec)
passed 46/46 xref-elisp-test-find-defs-feature-eval (0.001159 sec)
Ran 46 tests, 38 results as expected, 5 unexpected, 3 skipped (2020-10-16 2=
2:32:17+0200, 1.046538 sec)
5 unexpected results:
FAILED xref-elisp-test-find-defs-defgeneric-el
FAILED xref-elisp-test-find-defs-defun-defvar-el
FAILED xref-elisp-test-find-defs-defun-el
FAILED xref-elisp-test-find-defs-defvar-el
FAILED xref-elisp-test-find-defs-feature-el
3 skipped results:
SKIPPED eval-last-sexp-print-format-large-int-echo
SKIPPED eval-last-sexp-print-format-small-int-echo
SKIPPED eval-last-sexp-print-format-sym-echo
steve [ /datadisk/steve/src/emacs/emacs-master/test/lisp/progmodes ]$=20
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.Received: (at 43004) by debbugs.gnu.org; 16 Oct 2020 20:20:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 16 16:20:28 2020 Received: from localhost ([127.0.0.1]:60981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kTWDE-0005w5-AB for submit <at> debbugs.gnu.org; Fri, 16 Oct 2020 16:20:28 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:43324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <raaahh@HIDDEN>) id 1kTWDD-0005vt-2i for 43004 <at> debbugs.gnu.org; Fri, 16 Oct 2020 16:20:27 -0400 Received: by mail-wr1-f54.google.com with SMTP id g12so4381858wrp.10 for <43004 <at> debbugs.gnu.org>; Fri, 16 Oct 2020 13:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EAr8Ic9wwapoY7h2cHiyW5yP5WlNPNXI7subHSgk9d4=; b=Ob2hCBapjBCpZgCfEE/rTtjOrtHMGKsf7Fx39QTd+z4bWwoWkLQ9mBPGng3UEGTstH 8BmKS/aCVRpDWhUKXVv8MqOqCbTPkGyPtdQ4XGz26Bi9JNI6ha3yc2FVy79zr8esxsNr RN8spfLfdp9Rr2erkq9f8syoSIqp1ICGs0XfBsjorR5uYWNIC7luhgx4cFOahJfMUoAU kn6YJVutrCKlv6ySr+PhEIcER0BbaRvfveDkd/i7dGgViReIPA2aYbORuvHoZQnJfhrg 8CbiN3H0MZpJwqKl5CHkRvvqWCup3z2Cj0jWVKmlXWeJ9i8agrjglpo9Ec2gRhZ5j7eA dSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EAr8Ic9wwapoY7h2cHiyW5yP5WlNPNXI7subHSgk9d4=; b=fCDVvffUUcHslDcQY8fsLBR3GAt5LqqUPJ6sh8ewkjrd9h+jtkw8+8SfJ2OfuR+cUD 0xZlXgjEtZsQdY6KLxVTNw488Etqa560kUOu2U6lOX1JUd+YCqNJDudKvKXek/8X1osd DieP9Vllsp7v4sGXGxRhWfM9bk7zEpA4VqU2gSBtC4qbqk3QmP/Q9eG3X4biVWtSKujd RibQZ/rnC2aI4F7+U7IsXKVvgGL89B9QNkVZbwC9FJT1ZnrZdj4lggdjkpFQlyjD3IpR SYt0tR0chtsAjw9RZ6LJh23LmqVxeFLBPpIbeR2lAppGgQNyD8WG6ebzJ/NBIBK7twZP 7ueg== X-Gm-Message-State: AOAM533cTrHaKAu3XA5LQ9NQtGxlN2bL7kq4x4HW27ERGYgOfJ3oPz/z ycekJ8ngNZAa05qrvwoP/ODllZP0EBXpQA== X-Google-Smtp-Source: ABdhPJxqS2/qNxVHmwxS2g98IEsVy8afKqlwcKZSZkkIAddIBbURsJJNdRnEI4h4hRIZm436BLboHw== X-Received: by 2002:adf:f210:: with SMTP id p16mr724055wro.40.1602879620796; Fri, 16 Oct 2020 13:20:20 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id f5sm4053717wmh.16.2020.10.16.13.20.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Oct 2020 13:20:20 -0700 (PDT) Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources To: Stephen Berman <stephen.berman@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN> References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN> <87r1pyz27k.fsf@HIDDEN> <871rhy5j9h.fsf@HIDDEN> <87mu0mz0op.fsf@HIDDEN> From: Dmitry Gutov <dgutov@HIDDEN> Message-ID: <7002ef78-2d34-a812-5d38-5b4423d3068e@HIDDEN> Date: Fri, 16 Oct 2020 23:20:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87mu0mz0op.fsf@HIDDEN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43004 Cc: 43004 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) On 16.10.2020 17:48, Stephen Berman wrote: > Yes, please. I also just realized that I had run the patched batch mode > tests from my home directory, i.e., following the symlink. When I run > them from the source directory without following the symlink, I get the > same five failures again (i.e., with the patch) that I had gotten before > without the patch. So much for that attempt. So... the patch doesn't work? I'm not sure what would be the best change here, or whether your usage is something we absolutely need to support in 'make check' (Lars? do we?), but one thing that should help is the exact examples of strings ( absolute file names) that mismatch.
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.Received: (at 43004) by debbugs.gnu.org; 16 Oct 2020 14:48:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 16 10:48:52 2020 Received: from localhost ([127.0.0.1]:60462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kTR2J-0005ia-T9 for submit <at> debbugs.gnu.org; Fri, 16 Oct 2020 10:48:52 -0400 Received: from mout.gmx.net ([212.227.17.22]:56647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stephen.berman@HIDDEN>) id 1kTR2H-0005iM-Ip for 43004 <at> debbugs.gnu.org; Fri, 16 Oct 2020 10:48:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602859723; bh=MlILKJLe/8lirxlaOxFTo62W2dX6J7Xeb33Lu3W9U9I=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=U/Xa+5euWEjh6/GBj1FU0rwTsvDorkY2/ArDafyXa520CIk3b4sTI3vsj30jRK1th kuOuTuHZfjGbtZX3fICsBdf0w7zbOEMOCJXuglak8apkyvE5BiMCpB9unXf6Ljt6hd 7XFqprm93aa7HVVw+DkIuqXcsc431+7XpKGMz+II= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([178.6.213.172]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M6ll8-1kXHK041DK-008L0o; Fri, 16 Oct 2020 16:48:43 +0200 From: Stephen Berman <stephen.berman@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN> <87r1pyz27k.fsf@HIDDEN> <871rhy5j9h.fsf@HIDDEN> Date: Fri, 16 Oct 2020 16:48:38 +0200 In-Reply-To: <871rhy5j9h.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Fri, 16 Oct 2020 16:37:46 +0200") Message-ID: <87mu0mz0op.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:SP9TaXkaTv8v8ISoQ61mwkSukGSZjqlKNyTlsXh+mFm/6g6mogk 1qNDiUqy75mvLBrpIvH+mtz3vcVnFxgIwcJmxbzGZaiCu1qPh+XYTVyuL3A1w36WqPNtV4v 5pcKXMVRHSPbd9hIXd18ag7HwcG9Nwj+3/XhXltOGu0+HqJh/uHcL+gHIoCxdHb55TPUru6 0Aem+/q2Ma45ew0HLdwGg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:G1d1PukOXyI=:8wPwdlZyqT2XAU9WEJFmVH Rdqr2ySuHO174GOEuzVZOUKi+Hp8fP7wP7zKbw4yvq6mBWXRDVN2wxTGlNmv96O19+3RiGmmz 05e7uHNTFL4dwnphiZMBRJkxOCcO/lgCJrtOvCpVTT3+7E0ncUi+HA9xmvmeLeuErxIi3kGXn I/VxIa/qocG5e8CU9vifSFy/p9SVcfSv7sRVBaD4mwwxVRJbXD5ExgFL/scY+/TJGvkm+iFpP 4s2VN0hPubVXxV6aGLsjbvSEigzZUL9YMUOKzpD6+ZH/EatGTdhzhN+mndDZY/S2yNMe5/myy LmiptDpE60lMSUQTRL5iQeikentF5yvp+XlgLs2srL5K2cQNsyuoVmXV+w/8g48HessyepHly 1ssizOj2NrJRliCfnfFEWtL2wcsk6N+98xMQ+7NrLynRO7uLeilm9fy4PIwlUN7CSnp+OCR81 uDism9OObmQNdga/L2ZQHe8ds0AjU0n9rKfe1J3G1sGZ5rgKng/T8ba/cKR+hfw2jqYHhA/bL P/rHWy3UlM+4rLLgzBjA2164OdctkuqJuWi4Qz3dRhhD/xHZqqY7fjdc4f6M743pZarYVBNSN xk0dbJLBKNDgKojv+TyBkZVZG70OOBAaAOY+mzTMznTOPjwV+C0qJKB3hXL5sG2d8bSTmZk65 c7PpQKjCGO/gJJfDdabCYoeQL21EYAmBE8MKVy2ih6UaksJcAy3f9vrXulvo22cM76KVj7uAe pNrtWDnoYbcNLWckyhQwkTHktrU9zIgLRjqYc8cY+2Y0jK/FzPHM+9ilwgru5yDPb9+V8busU KxpxDX23Ht/GOY/WgbjlfFE6sMl1aLMGfjINV6t9WKt6gmhdAFpdYbbKKR9jnOzeI7///VfxN zXk58dzpJhJyE7NmzpPA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43004 Cc: 43004 <at> debbugs.gnu.org, Dmitry Gutov <dgutov@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On Fri, 16 Oct 2020 16:37:46 +0200 Lars Ingebrigtsen <larsi@HIDDEN> wrote: >> I looked at them again and, by trial and error, came up with the >> attached patch, with which I now get no unexpected failures when running >> the tests in batch mode, though when run interactively >> xref-elisp-test-find-defs-defgeneric-implicit-generic still fails. But >> in any case I wouldn't blindly install this patch; someone who knows the >> xref code really needs to look at what's going on here. > > Dmitry, could you have a look at this patch to the xref tests? Yes, please. I also just realized that I had run the patched batch mode tests from my home directory, i.e., following the symlink. When I run them from the source directory without following the symlink, I get the same five failures again (i.e., with the patch) that I had gotten before without the patch. So much for that attempt. Steve Berman
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.Received: (at 43004) by debbugs.gnu.org; 16 Oct 2020 14:37:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 16 10:37:58 2020 Received: from localhost ([127.0.0.1]:60399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kTQrm-0005Pj-JI for submit <at> debbugs.gnu.org; Fri, 16 Oct 2020 10:37:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1kTQrk-0005PV-NC for 43004 <at> debbugs.gnu.org; Fri, 16 Oct 2020 10:37:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GR8tC4PdlyW1KAzZYfGFvwanr9WTM8njYWqcPZjaCt4=; b=lIasE5LuLO8+bV9uoID3C0v5YH 2Bae643aij/6ZibjV198zmfzEJ2oJCZh+3kObRBSUo3oke+HMh2G+/K1gLnUf8jbhB8w6YHEEo36a EOLi4GPXvKPqCZ6DdffnQ1acAFhDZiewkh7Rn+Wy+UBVtjfROsoLKBwSwdwQeLs6s+Uw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1kTQrb-0004G3-K3; Fri, 16 Oct 2020 16:37:50 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Stephen Berman <stephen.berman@HIDDEN> Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN> <87r1pyz27k.fsf@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAMFBMVEX+/v7s6ejj393R zMtnXVuyrKssIB9EOTeDeHYzJyUkGRgaEBDGvbhQPzuelZL///8RPH+VAAAAAWJLR0QPGLoA2QAA AAd0SU1FB+QKEA4lDl59bOAAAACTSURBVDjLY2AYBUMLMCoIMxhgk2B2CDMoYW7ClGB1iFRcwrLZ 5AAWCaUtLLmZjpgSYUpLni+bYYBFh3Lmqi2Y9vNceGW3O30qFlcVvKrebpqHRWKO99odfOswJZhm 7n66hRWLDtZdt4238JRgSrzeah2UwnwF04oplzQfTmeIwwxDAyUmARcBXCHMMAoGGgjhEAcA9Msm KaubwYcAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAtMTZUMTQ6Mzc6MTQrMDA6MDCjoS0GAAAA JXRFWHRkYXRlOm1vZGlmeQAyMDIwLTEwLTE2VDE0OjM3OjE0KzAwOjAw0vyVugAAAABJRU5ErkJg gg== X-Now-Playing: Lamb's _5_: "She Walks" Date: Fri, 16 Oct 2020 16:37:46 +0200 In-Reply-To: <87r1pyz27k.fsf@HIDDEN> (Stephen Berman's message of "Fri, 16 Oct 2020 16:15:43 +0200") Message-ID: <871rhy5j9h.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: > I looked at them again and, by trial and error, came up with the > attached patch, with which I now get no unexpected failures when running > the tests in batch mode, though when run interactively > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43004 Cc: 43004 <at> debbugs.gnu.org, Dmitry Gutov <dgutov@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > I looked at them again and, by trial and error, came up with the > attached patch, with which I now get no unexpected failures when running > the tests in batch mode, though when run interactively > xref-elisp-test-find-defs-defgeneric-implicit-generic still fails. But > in any case I wouldn't blindly install this patch; someone who knows the > xref code really needs to look at what's going on here. Dmitry, could you have a look at this patch to the xref tests? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.
Received: (at 43004) by debbugs.gnu.org; 16 Oct 2020 14:15:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 16 10:15:57 2020
Received: from localhost ([127.0.0.1]:60375 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kTQWT-0004qZ-JJ
for submit <at> debbugs.gnu.org; Fri, 16 Oct 2020 10:15:57 -0400
Received: from mout.gmx.net ([212.227.15.19]:52057)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stephen.berman@HIDDEN>) id 1kTQWR-0004qK-KJ
for 43004 <at> debbugs.gnu.org; Fri, 16 Oct 2020 10:15:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1602857748;
bh=ixQWNgmQCpysVTiq2UkJh1cQf4PKF39vac01IeuHhj4=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=QOITSU4fCcoo7/41QidEE9ekVUlYM+mLj5n7HfY+l70j7A/sU0wIEUcDOfwAlrCno
v7ce0JAAmpK6/dXhWxonf7hx0lpN+XQfp73wEaITwSVkoSpXNOcEge5r8ySs9rNwgH
eCpuk/IxWd8zn2PBgP2h2+A8vFwsbdtb6x5YKr3g=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([178.6.213.172]) by mail.gmx.com (mrgmx005
[212.227.17.190]) with ESMTPSA (Nemesis) id 1MDhhN-1kdZH10Lmp-00AnX5; Fri, 16
Oct 2020 16:15:48 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources
References: <87o8n1aw9k.fsf@HIDDEN> <87imbamuw9.fsf@HIDDEN>
Date: Fri, 16 Oct 2020 16:15:43 +0200
In-Reply-To: <87imbamuw9.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Fri,
16 Oct 2020 10:34:30 +0200")
Message-ID: <87r1pyz27k.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:jvD18688axj/dyprrK5R2TWLIcrVFDF3v9afCPam/Snij1a3l44
XYYtdN4m+Y59GsvyvAQfYATHcajf4OJOjalTLXkxFP8adQWOxLVaFa0uZ6M6t7Vm1Kp2QHW
f4nzlifPNUf0Ea3DAYpcytuQzaqQ0uItGki6mRyt2RgGGdqbTLBKMmDAq/x3gUWtEMUDRUt
lEOGMB+gb/55IoLAGMI9A==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:WyaIlHNeWlc=:cfJ5eEMUpqt29mOr4vVQ+1
ELwE4qXHBxI3kLlmauGoIx2nTNAFPxVK0gZ3smDyC6WjFjZW8emhUDg8foiwgVeM5v4fELBcV
sh6mE9aRy+bOn6LP1o6osYlvALulPaLuO5G7w9KKCCBndDy0cCO1PDbZWnfs4scNLhO2Aa2JJ
JXcuWXUe6M/jhBzgiZcoDcK/5hX2q/haRqpslhZbxn60wY76Zy0X4/MBhmw3mg/4bhpa6W0pD
tWKlkt98cwO66jlRbJ2MfUGKGGIwQ0FlQvIElk5JRDRigne0rAptTpFaJWPWnmLV3sqbxreLi
VivmbGuyW7cxoHoaCMa3yOVqownXS2fNK7xABn9n12US2SS9jkMpiC/CFhdL32MJPRZ79MRCe
vCZGTIi1WSnjzUANPusC/Hptc79Jonpi/Y1OH1FDt0mpl/eKTFuYBihYKkxPT9N/cQkwWbvWP
/eS57hXanHu/mWLZQU+SxcQgZh4p2wbsy+8p97sVSOMKkRvI1wZ2ea+btVZoyOsJqrA73mVOn
Am5TlX+hfonM+74ZoBp2kik5VhiQ1OpRwICBxIgEK94HFUS68mxvnNFGvcrG4QHrVYSnAWh6A
wEBTEwpbhfQ9jSqaynnMgJePnYFQmqHkLDGEDT/khdXHhpR06K1bJ/8YODAu3wJk3Lh/VKKQ2
etPqafh+BJJvsmIfH0ltyX87LhtbFDaGovOcSVZAg/5aLVisa6Ax64yXPJ6nPf7N45r36kUDn
JkAm1MTshdH3XWHWC2/DeV88vNpmU+iDQu3LgtDTmRYjzsOgzq3Ylk6pEwac0H+YNyML1p/jq
XpYTvmYGhaZBB1ofLhnKAavdpIH22bHgiL+M0U3QiwORx+ijBe8p+bRMyrjaXcr13fs5fWmlM
lfG/Z9Uxg4++zSqSMdxA==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43004
Cc: 43004 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
On Fri, 16 Oct 2020 10:34:30 +0200 Lars Ingebrigtsen <larsi@HIDDEN> wrote:
> Stephen Berman <stephen.berman@HIDDEN> writes:
>
>> However, concerning the latter, it seems that the tests expect
>> help-fns-function-description-header to return the quoted basename of
>> the file, while in my environment it returns the absolute filename.
>> Adjusting the regexp used in the tests fixes this issue (see the first
>> patch below) and then all tests pass regardless of where I start the
>> batch run.
>>
>> Concerning cl-generic-tests.el, using file-truename as in the second
>> patch below prevents the one failure, also regardless of where I start
>> the batch run.
>
> Thanks; I've now applied your patch to the trunk.
Thanks.
>> The same reduction but not full elimination is achieved by removing
>> the call to file-truename in the value of the defvar emacs-test-dir in
>> elisp-mode-tests.el. So far I haven't figured out how to prevent
>> these five failures.
>
> Have you made any progress on these remaining failures, by any chance?
I looked at them again and, by trial and error, came up with the
attached patch, with which I now get no unexpected failures when running
the tests in batch mode, though when run interactively
xref-elisp-test-find-defs-defgeneric-implicit-generic still fails. But
in any case I wouldn't blindly install this patch; someone who knows the
xref code really needs to look at what's going on here.
Steve Berman
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline
Content-Description: elisp-mode-tests.el patch
Content-Transfer-Encoding: quoted-printable
diff --git a/test/lisp/progmodes/elisp-mode-tests.el b/test/lisp/progmodes=
/elisp-mode-tests.el
index 6c30e4f664..95259290ce 100644
=2D-- a/test/lisp/progmodes/elisp-mode-tests.el
+++ b/test/lisp/progmodes/elisp-mode-tests.el
@@ -360,8 +360,7 @@ xref-elisp-deftest
;; `xref-elisp-test-run'.
(defvar emacs-test-dir
(funcall (if xref--case-insensitive 'downcase 'identity)
- (file-truename (file-name-directory
- (or load-file-name (buffer-file-name))))))
+ (file-name-directory (or load-file-name (buffer-file-name)))))
;; alphabetical by test name
@@ -381,7 +380,8 @@ find-defs-constructor
(xref-make "(cl-defstruct (xref-elisp-location (:constructor xref-mak=
e-elisp-location)))"
(xref-make-elisp-location
'xref-elisp-location 'define-type
- (expand-file-name "../../../lisp/progmodes/elisp-mode.el"=
emacs-test-dir)))
+ (file-truename
+ (expand-file-name "../../../lisp/progmodes/elisp-mode.el=
" emacs-test-dir))))
;; It's not worth adding another special case to `xref-elisp-test-des=
cr-to-target' for this
"(cl-defstruct (xref-elisp-location")
))
@@ -392,11 +392,13 @@ find-defs-defalias-defun-el
(xref-make "(defalias Buffer-menu-sort)"
(xref-make-elisp-location
'Buffer-menu-sort 'defalias
- (expand-file-name "../../../lisp/buff-menu.elc" emacs-test-dir)))
+ (file-truename
+ (expand-file-name "../../../lisp/buff-menu.elc" emacs-te=
st-dir))))
(xref-make "(defun tabulated-list-sort)"
(xref-make-elisp-location
'tabulated-list-sort nil
- (expand-file-name "../../../lisp/emacs-lisp/tabulated-list.el" em=
acs-test-dir)))
+ (file-truename
+ (expand-file-name "../../../lisp/emacs-lisp/tabulated-li=
st.el" emacs-test-dir))))
))
;; FIXME: defconst
@@ -564,7 +566,8 @@ find-defs-defgeneric-el
(cl--generic-load-hist-format
'xref-location-marker nil '(xref-elisp-location))
'cl-defmethod
- (expand-file-name "../../../lisp/progmodes/elisp-mode.el" emacs-t=
est-dir)))
+ (file-truename
+ (expand-file-name "../../../lisp/progmodes/elisp-mode.el" emacs-=
test-dir))))
(xref-make "(cl-defmethod xref-location-marker ((l xref-file-location)=
))"
(xref-make-elisp-location
(cl--generic-load-hist-format
@@ -724,7 +727,8 @@ find-defs-defun-el-defvar-c
(xref-make "(defun abbrev-mode)"
(xref-make-elisp-location
'abbrev-mode nil
- (expand-file-name "../../../lisp/abbrev.el" emacs-test-di=
r)))
+ (file-truename
+ (expand-file-name "../../../lisp/abbrev.el" emacs-test-d=
ir))))
"(define-minor-mode abbrev-mode"))
)
@@ -778,11 +782,13 @@ find-defs-face-el
(xref-make "(defvar font-lock-keyword-face)"
(xref-make-elisp-location
'font-lock-keyword-face 'defvar
- (expand-file-name "../../../lisp/font-lock.el" emacs-test-dir)))
+ (file-truename
+ (expand-file-name "../../../lisp/font-lock.el" emacs-tes=
t-dir))))
(xref-make "(defface font-lock-keyword-face)"
(xref-make-elisp-location
'font-lock-keyword-face 'defface
- (expand-file-name "../../../lisp/font-lock.el" emacs-test-dir)))
+ (file-truename
+ (expand-file-name "../../../lisp/font-lock.el" emacs-tes=
t-dir))))
))
(xref-elisp-deftest find-defs-face-eval
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.Received: (at 43004) by debbugs.gnu.org; 16 Oct 2020 08:34:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Oct 16 04:34:46 2020 Received: from localhost ([127.0.0.1]:57606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kTLCI-0007sr-Ev for submit <at> debbugs.gnu.org; Fri, 16 Oct 2020 04:34:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1kTLCC-0007sY-44 for 43004 <at> debbugs.gnu.org; Fri, 16 Oct 2020 04:34:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fQEgBnZ6K2ZpfE8YWYd343xU+Kp58xBTqVjjfT7LwcY=; b=qdQ3YSMUTW8/DGqrnHlvQEHfDo LW+HmAK43bnfh1E73PgPG1JmNTxEaoNvneC6Uk8ajW3bhiBiu0kO83gpExbxObkc+qtRYhGjU0/Lf AMWSrFuv+icuBfg9W6AWsf9lRJaHqF4ZVEruwI/aHPb9FhTPpq8q2k5HE4wxtReBUnNc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1kTLC3-0000jF-If; Fri, 16 Oct 2020 10:34:34 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Stephen Berman <stephen.berman@HIDDEN> Subject: Re: bug#43004: 28.0.50; Test failures due to symlinked Emacs sources References: <87o8n1aw9k.fsf@HIDDEN> X-Now-Playing: ELP's _Tarkus_: "Tarkus" Date: Fri, 16 Oct 2020 10:34:30 +0200 In-Reply-To: <87o8n1aw9k.fsf@HIDDEN> (Stephen Berman's message of "Sun, 23 Aug 2020 23:27:03 +0200") Message-ID: <87imbamuw9.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman <stephen.berman@HIDDEN> writes: > However, concerning the latter, it seems that the tests expect > help-fns-function-description-header to return the quoted basename of > the file, while in my environment it returns the absolute fil [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43004 Cc: 43004 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stephen Berman <stephen.berman@HIDDEN> writes: > However, concerning the latter, it seems that the tests expect > help-fns-function-description-header to return the quoted basename of > the file, while in my environment it returns the absolute filename. > Adjusting the regexp used in the tests fixes this issue (see the first > patch below) and then all tests pass regardless of where I start the > batch run. > > Concerning cl-generic-tests.el, using file-truename as in the second > patch below prevents the one failure, also regardless of where I start > the batch run. Thanks; I've now applied your patch to the trunk. > The same reduction but not full elimination is achieved by removing > the call to file-truename in the value of the defvar emacs-test-dir in > elisp-mode-tests.el. So far I haven't figured out how to prevent > these five failures. Have you made any progress on these remaining failures, by any chance? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 23 Aug 2020 21:27:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 23 17:27:10 2020
Received: from localhost ([127.0.0.1]:55243 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k9xWA-0001ot-6m
for submit <at> debbugs.gnu.org; Sun, 23 Aug 2020 17:27:10 -0400
Received: from lists.gnu.org ([209.51.188.17]:51500)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stephen.berman@HIDDEN>) id 1k9xW8-0001ol-BE
for submit <at> debbugs.gnu.org; Sun, 23 Aug 2020 17:27:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55394)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
id 1k9xW8-0004kd-5N
for bug-gnu-emacs@HIDDEN; Sun, 23 Aug 2020 17:27:08 -0400
Received: from mout.gmx.net ([212.227.17.20]:40683)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
id 1k9xW6-0008Ab-1n
for bug-gnu-emacs@HIDDEN; Sun, 23 Aug 2020 17:27:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1598218024;
bh=9zrhIyeRec70tABMq30PBFJuMGvqVYz/+lDzAP/Wgaw=;
h=X-UI-Sender-Class:From:To:Subject:Date;
b=MKKwZZUtcFkP+RwXPhl1+15cfY7g3k/WKLFe0ppxyvNa7IVhRDFcFZWn3Z8bxAg8/
pCRNIP9/fZV7gzfVV8y4U3+bmGCDqaq8LGtP/TZiVhU6PiJgdTR6MGwkxufWE34BzX
GFulm54IttUEK8jqWfBufGy2ZF8GqmKKhs0h1i9o=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([92.73.78.116]) by mail.gmx.com (mrgmx105
[212.227.17.168]) with ESMTPSA (Nemesis) id 1Mn2WF-1ksfeh0mSV-00k47s for
<bug-gnu-emacs@HIDDEN>; Sun, 23 Aug 2020 23:27:04 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 28.0.50; Test failures due to symlinked Emacs sources
Date: Sun, 23 Aug 2020 23:27:03 +0200
Message-ID: <87o8n1aw9k.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:RpiLGj8Hi9tcWown+M74tja1S6JQOgiFSsB+rNjO2mNdFXr8/f9
iBnEBIge3KyH2mQnYmnB2L4rs9JGA5SOzRpxhiI4JV8SqZaiv80eKejfh0Qp8ovqLCefc43
cMil+p17gQWdTIonrQ5nnZmO2aTZ0iyy2IoRx0e8QK+SuRIReTFspaSiJSjiC9MwkesiGYL
LAOkpBHbiMDk/dHwCEfeg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:l6lpWtpptIU=:o7mRlbirjaMn73m9Qc7yRw
gXC/C50aRS/h5MR5e/rgOZ9ZryVAM9/oAel+MDONDuy/5NnezMqut6XmpODJlhFlYm7J4uD3x
bAuPWIlDU0npGBJbT60R/swp3n2bqL3kybys57p5vfYQtcENC8V93Dn5mnSn/mtmsei37X4xx
kQw9pQlo0cEwwxLl8Snpx487gX1wo/M8ZekGZBvw//9mwlKKs7YtNqJlfmbiTdZEK+ggUe9fj
VXFmG3yi70JXuRF2H87LZABNXLpXLvRGwAy9j6X5PzoBtnA4aqiyGF5rsDmlNCPyWQNhrGjcR
WLkauQNAImKuDBfWRT8EQJBj2aL5C1ickxsSg9CTbVBkWbG0Bn7q5llwXI6sq2/IoYZwNxTyy
LI88gEucNtrnhgLDxXrupR8fX59DRQS9pI37kjCZH0jChdE8pK+P+JT/5JBJhNXLlwwrJqNVR
xGXj4H7/q5KHFq8AnwpDl55xtaEVXzSjgZGY/y1aje7X2esFdTnfKsS9Ydmx/iQpBAwJkbrS0
z1v9rQFnXnKGroC8Ni2+aqq/t/1D3UaEGCp96mpCyvQDdx8jlbj0iYmn8AxU3JVQmWV5FoT3M
JmLJu/ZwbOhChn4jBx28gU+qnqxklq4DG6fxovkB8+wQLPPiuZZrSvTAWboaCvULqx+ajrsKD
93B9Kkna8dScb3Y7cilA6Q56vFqElj2PBtsL2EBpf2Mip0YnLiB41LX8K7AEpv/4sMmWweQ27
NfXYSbAryJytq19+SEhtcjUiN6M4HMebOYBGFkTpfPJ09aBtjjaZJJ8b0jOTS6R3dq4gfjLXN
XXCQU/KTop5qRutPgeDgEvOaTVmwlBEWYL7gFi93kXV8RdtwTxW9W9bq3BgL6zctCqDnxsXLK
5u8R1fOQhaGSDJCEEPnHBJKuOWLJWnbfZjWhg4tzb4Bu51seXyCxay1U1Ej1+2xIREh5h1c+p
UDNDN43Nm18tyfYhe0I2OtC/p46nbhijn3IELR4elr3RdmTelh0Z+rxPHUZGGnnpE8+9jQxky
FA3/qOscRu7Seh/V//eeRczAeaX8iI/gxU8t/GF3ERq2aYKunpIhdDsfaZk0nVO4HeUaDMeYC
UxP4Zcc0s0SuA6VMmy6/6WNTfox7s/tglCLvTPRW6TXIQIqX4D9A2GOxnONDvg9eTnyYxjRFV
LmLojf2YfR2m94hSRqHgkKf9JloXgnIK4uKf5FIAtZ37jb/0RJtcuc2+fOImThSmlmJu3m+qu
v+vjn9vpO+4clCc3ukfHQSq/bpWsoh1yfiKt69Q==
Received-SPF: pass client-ip=212.227.17.20;
envelope-from=stephen.berman@HIDDEN; helo=mout.gmx.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/23 17:27:04
X-ACL-Warn: Detected OS = Linux 3.11 and newer
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.2 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
After my latest build from master I ran make check (for the first time
in a long time) and got the following 20 unexpected failures:
In test/lisp/progmodes/elisp-mode-tests.el 14 unexpected results:
FAILED xref-elisp-test-find-defs-defgeneric-co-located-default
FAILED xref-elisp-test-find-defs-defgeneric-el
FAILED xref-elisp-test-find-defs-defgeneric-implicit-generic
FAILED xref-elisp-test-find-defs-defgeneric-no-default
FAILED xref-elisp-test-find-defs-defgeneric-no-methods
FAILED xref-elisp-test-find-defs-defgeneric-separate-default
FAILED xref-elisp-test-find-defs-define-overload-co-located-default
FAILED xref-elisp-test-find-defs-define-overload-no-default
FAILED xref-elisp-test-find-defs-define-overload-no-methods
FAILED xref-elisp-test-find-defs-define-overload-separate-default
FAILED xref-elisp-test-find-defs-defun-defvar-el
FAILED xref-elisp-test-find-defs-defun-el
FAILED xref-elisp-test-find-defs-defvar-el
FAILED xref-elisp-test-find-defs-feature-el
In test/lisp/help-fns-tests.el 5 unexpected results:
FAILED help-fns-test-alias-to-defun
FAILED help-fns-test-bug23887
FAILED help-fns-test-lisp-defsubst
FAILED help-fns-test-lisp-defun
FAILED help-fns-test-lisp-macro
In test/lisp/emacs-lisp/cl-generic-tests.el 1 unexpected result:
FAILED cl-generic-tests--method-files--finds-methods
It seems that the failures arise because my Emacs sources are in a
directory on a different partition from my home directory, and the
source directory is symlinked from =C2=A7HOME, and my Emacs build directory
is under $HOME. When I do batch runs of the test three files in
question starting from my home directory (i.e. dereferencing the symlink
to the sources), I get the the failures I reported; but when I start the
batch runs from the real directory containing the test sources, the one
test in cl-generic-tests.el that failed now passes, and of the fourteen
xref tests in elisp-mode-tests.el that failed, now only these five fail:
FAILED xref-elisp-test-find-defs-defgeneric-el
FAILED xref-elisp-test-find-defs-defun-defvar-el
FAILED xref-elisp-test-find-defs-defun-el
FAILED xref-elisp-test-find-defs-defvar-el
FAILED xref-elisp-test-find-defs-feature-el
But all five of the failing tests in help-fns-tests.el still fail.
However, concerning the latter, it seems that the tests expect
help-fns-function-description-header to return the quoted basename of
the file, while in my environment it returns the absolute filename.
Adjusting the regexp used in the tests fixes this issue (see the first
patch below) and then all tests pass regardless of where I start the
batch run.
Concerning cl-generic-tests.el, using file-truename as in the second
patch below prevents the one failure, also regardless of where I start
the batch run.
As for the failing xref tests in elisp-mode-tests.el, by applying
file-truename to the result of calls to find-lisp-object-file-name in
elisp--xref-find-definitions (in elisp-mode.el) and
xref-mode-local-overload (in mode-local.el) I could reduce the 14
failures to the same five that fail when doing the batch run from the
real directory without following the symlink. The same reduction but
not full elimination is achieved by removing the call to file-truename
in the value of the defvar emacs-test-dir in elisp-mode-tests.el. So
far I haven't figured out how to prevent these five failures.
diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el
index da2b49e6b8..7782a41b9f 100644
--- a/test/lisp/help-fns-tests.el
+++ b/test/lisp/help-fns-tests.el
@@ -56,28 +56,28 @@ help-fns-test-interactive-built-in
(should (string-match regexp result))))
=20
(ert-deftest help-fns-test-lisp-macro ()
- (let ((regexp "a Lisp macro in .subr\\.el")
+ (let ((regexp "a Lisp macro in .+subr\\.el")
(result (help-fns-tests--describe-function 'when)))
(should (string-match regexp result))))
=20
(ert-deftest help-fns-test-lisp-defun ()
- (let ((regexp "a compiled Lisp function in .subr\\.el")
+ (let ((regexp "a compiled Lisp function in .+subr\\.el")
(result (help-fns-tests--describe-function 'last)))
(should (string-match regexp result))))
=20
(ert-deftest help-fns-test-lisp-defsubst ()
- (let ((regexp "a compiled Lisp function in .subr\\.el")
+ (let ((regexp "a compiled Lisp function in .+subr\\.el")
(result (help-fns-tests--describe-function 'posn-window)))
(should (string-match regexp result))))
=20
(ert-deftest help-fns-test-alias-to-defun ()
- (let ((regexp "an alias for .set-file-modes. in .subr\\.el")
+ (let ((regexp "an alias for .set-file-modes. in .+subr\\.el")
(result (help-fns-tests--describe-function 'chmod)))
(should (string-match regexp result))))
=20
(ert-deftest help-fns-test-bug23887 ()
"Test for https://debbugs.gnu.org/23887 ."
- (let ((regexp "an alias for .re-search-forward. in .subr\\.el")
+ (let ((regexp "an alias for .re-search-forward. in .+subr\\.el")
(result (help-fns-tests--describe-function 'search-forward-regexp)=
))
(should (string-match regexp result))))
=20
diff --git a/test/lisp/emacs-lisp/cl-generic-tests.el b/test/lisp/emacs-lis=
p/cl-generic-tests.el
index 5aa58782f3..9582907e51 100644
--- a/test/lisp/emacs-lisp/cl-generic-tests.el
+++ b/test/lisp/emacs-lisp/cl-generic-tests.el
@@ -240,7 +240,7 @@ cl-generic-tests--method-files--finds-methods
(let ((retval (cl--generic-method-files 'cl-generic-tests--generic)))
(should (equal (length retval) 2))
(mapc (lambda (x)
- (should (equal (car x) cl-generic-tests--this-file))
+ (should (equal (file-truename (car x)) cl-generic-tests--this-=
file))
(should (equal (cadr x) 'cl-generic-tests--generic)))
retval)
(should-not (equal (nth 0 retval) (nth 1 retval)))))
In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, =
cairo version 1.17.3)
of 2020-08-21 built on strobe-jhalfs
Repository revision: 3e10174fb65f4eb601b1921271bdcf10c933b879
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Linux From Scratch SVN-20200401
Configured using:
'configure 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt5/lib/pkgconfig'
Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD PDUMPER LCMS2
Stephen Berman <stephen.berman@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#43004; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.