GNU bug report logs - #43015
git-fetched packages' working copy is not writable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43015 in the body.
You can then email your comments to 43015 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: <bug-guix <at> gnu.org>
Subject: git-fetched packages' working copy is not writable
Date: Mon, 24 Aug 2020 11:13:59 +0200

[Message part 1 (text/plain, inline)]

Hi,

the working copy of a package build when the package was git-fetched is not
writable.

On the other hand, if it's url-fetched, it's perfectly writable.

Shall we fix this on core-updates ?

[Message part 2 (application/pgp-signature, inline)]

Message #8 received at 43015 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 43015 <at> debbugs.gnu.org
Subject: Re: bug#43015: git-fetched packages' working copy is not writable
Date: Mon, 24 Aug 2020 12:22:56 +0300

[Message part 1 (text/plain, inline)]

On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote:
> Hi,
> 
> the working copy of a package build when the package was git-fetched is not
> writable.
> 
> On the other hand, if it's url-fetched, it's perfectly writable.
> 
> Shall we fix this on core-updates ?

(ins)efraim <at> E5400 ~/workspace/guix$ git grep make-files-writable | grep unpack | grep gnu/packages
gnu/packages/bioinformatics.scm:         (add-after 'unpack 'make-files-writable
gnu/packages/code.scm:                    (add-after 'unpack 'make-files-writable
gnu/packages/djvu.scm:         (add-after 'unpack 'make-files-writable
gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
gnu/packages/machine-learning.scm:         (add-after 'unpack 'make-files-writable
gnu/packages/ocaml.scm:         (add-after 'unpack 'make-files-writable
gnu/packages/ruby.scm:                    (add-after 'unpack 'make-files-writable

My only concern would be if there were files which weren't supposed to
be writable. We're building the package, not making changes to be
submitted upstream or anything, so I don't see that as being a reason to
hold back.

I'm in favor



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 43015-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 43015-done <at> debbugs.gnu.org, Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: bug#43015: git-fetched packages' working copy is not writable
Date: Thu, 04 Feb 2021 07:41:10 -0500

Hello,

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote:
>> Hi,
>> 
>> the working copy of a package build when the package was git-fetched is not
>> writable.
>> 
>> On the other hand, if it's url-fetched, it's perfectly writable.
>> 
>> Shall we fix this on core-updates ?
>
> (ins)efraim <at> E5400 ~/workspace/guix$ git grep make-files-writable | grep unpack | grep gnu/packages
> gnu/packages/bioinformatics.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/code.scm:                    (add-after 'unpack 'make-files-writable
> gnu/packages/djvu.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/machine-learning.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/ocaml.scm:         (add-after 'unpack 'make-files-writable
> gnu/packages/ruby.scm:                    (add-after 'unpack 'make-files-writable
>
> My only concern would be if there were files which weren't supposed to
> be writable. We're building the package, not making changes to be
> submitted upstream or anything, so I don't see that as being a reason to
> hold back.
>
> I'm in favor

I've included the fix as part as the unpack phase, and pushed to
core-updates as commit 6129ebddbd.

Thanks for the report!

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.