GNU bug report logs -
#43065
Fix or remove broken flyspell-issue-welcome-flag option
Previous Next
Reported by: Stefan Kangas <stefan <at> marxist.se>
Date: Thu, 27 Aug 2020 05:25:02 UTC
Severity: normal
Fixed in version 28.1
Done: Stefan Kangas <stefan <at> marxist.se>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43065 in the body.
You can then email your comments to 43065 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#43065
; Package
emacs
.
(Thu, 27 Aug 2020 05:25:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Stefan Kangas <stefan <at> marxist.se>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Thu, 27 Aug 2020 05:25:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
The flyspell-issue-welcome-flag option is supposed to control whether or
not a welcome message is shown when enabling flyspell-mode:
"Welcome to Flyspell. Use C-. or Mouse-3 to correct words."
This does not work; flyspell-mode does not show such a message.
From digging in the sources, it's not clear to me if this has worked at
all since 2002 or so. I didn't bother with a full investigation, so I
might be overlooking something.
In any case, I see three options:
1. Fix it. I have attached a patch here which does that. The message
is mildly annoying, but could be useful to beginners. (And it's
easy to disabled using the mentioned variable.)
2. Fix it, but change the default to nil. I think this is pointless,
since this would mostly be useful to beginners.
3. Remove the code and make the option obsolete.
Any opinions or preferences?
[Message part 2 (text/plain, attachment)]
[0001-Fix-flyspell-welcome-message.patch (text/x-diff, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#43065
; Package
emacs
.
(Thu, 27 Aug 2020 08:43:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 43065 <at> debbugs.gnu.org (full text, mbox):
> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 26 Aug 2020 22:24:45 -0700
>
> 1. Fix it. I have attached a patch here which does that. The message
> is mildly annoying, but could be useful to beginners. (And it's
> easy to disabled using the mentioned variable.)
>
> 2. Fix it, but change the default to nil. I think this is pointless,
> since this would mostly be useful to beginners.
>
> 3. Remove the code and make the option obsolete.
>
> Any opinions or preferences?
#1, please.
Thanks for paying attention to this.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#43065
; Package
emacs
.
(Thu, 27 Aug 2020 09:07:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 43065 <at> debbugs.gnu.org (full text, mbox):
> Date: Thu, 27 Aug 2020 11:42:25 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 43065 <at> debbugs.gnu.org
>
> > From: Stefan Kangas <stefan <at> marxist.se>
> > Date: Wed, 26 Aug 2020 22:24:45 -0700
> >
> > 1. Fix it. I have attached a patch here which does that. The message
> > is mildly annoying, but could be useful to beginners. (And it's
> > easy to disabled using the mentioned variable.)
> >
> > 2. Fix it, but change the default to nil. I think this is pointless,
> > since this would mostly be useful to beginners.
> >
> > 3. Remove the code and make the option obsolete.
> >
> > Any opinions or preferences?
>
> #1, please.
Btw, can we make this only display the welcome message if
flyspell-mode is invoked interactively? Your patch makes this
unconditional, which I don't think was the original intent.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#43065
; Package
emacs
.
(Thu, 27 Aug 2020 09:28:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 43065 <at> debbugs.gnu.org (full text, mbox):
Eli Zaretskii <eliz <at> gnu.org> writes:
> Btw, can we make this only display the welcome message if
> flyspell-mode is invoked interactively? Your patch makes this
> unconditional, which I don't think was the original intent.
(I received your email less than a minute after pushing.)
Your observation is correct, I think.
Is this one of those places where we are forced to use
(called-interactively-p 'interactive)? Or can we add an optional
argument to `define-minor-mode' somehow?
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#43065
; Package
emacs
.
(Thu, 27 Aug 2020 09:28:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 43065 <at> debbugs.gnu.org (full text, mbox):
close 43065 28.1
thanks
Eli Zaretskii <eliz <at> gnu.org> writes:
>> 1. Fix it. I have attached a patch here which does that. The message
>> is mildly annoying, but could be useful to beginners. (And it's
>> easy to disabled using the mentioned variable.)
>>
>> 2. Fix it, but change the default to nil. I think this is pointless,
>> since this would mostly be useful to beginners.
>>
>> 3. Remove the code and make the option obsolete.
>>
>> Any opinions or preferences?
>
> #1, please.
Fix pushed to master as commit 4766006d3c. Closing.
Best regards,
Stefan Kangas
bug marked as fixed in version 28.1, send any further explanations to
43065 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se>
Request was from
Stefan Kangas <stefan <at> marxist.se>
to
control <at> debbugs.gnu.org
.
(Thu, 27 Aug 2020 09:28:03 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#43065
; Package
emacs
.
(Thu, 27 Aug 2020 09:33:01 GMT)
Full text and
rfc822 format available.
Message #22 received at 43065 <at> debbugs.gnu.org (full text, mbox):
> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Thu, 27 Aug 2020 02:27:13 -0700
> Cc: 43065 <at> debbugs.gnu.org
>
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> > Btw, can we make this only display the welcome message if
> > flyspell-mode is invoked interactively? Your patch makes this
> > unconditional, which I don't think was the original intent.
>
> (I received your email less than a minute after pushing.)
>
> Your observation is correct, I think.
>
> Is this one of those places where we are forced to use
> (called-interactively-p 'interactive)?
Yes, I think so.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#43065
; Package
emacs
.
(Thu, 27 Aug 2020 09:48:02 GMT)
Full text and
rfc822 format available.
Message #25 received at 43065 <at> debbugs.gnu.org (full text, mbox):
Eli Zaretskii <eliz <at> gnu.org> writes:
> Yes, I think so.
OK, thanks. Pushed fix to master as commit f40260f121.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 24 Sep 2020 11:24:08 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 186 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.