GNU bug report logs - #43093
emacs-ess fails to build: FAILED test-ess-roxy-literate

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43093 in the body.
You can then email your comments to 43093 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: divoplade <d <at> divoplade.fr>
To: bug-guix <at> gnu.org
Subject: emacs-ess is broken by emacs 27.1
Date: Fri, 28 Aug 2020 22:07:26 +0200

Hello all,

Right now emacs-ess is broken so I cannot upgrade to emacs 27. The
failing test is "test-ess-roxy-literate".

Thank you anyway, I cannot wait to have emacs 27!

divoplade

Message #8 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 43093 <at> debbugs.gnu.org, divoplade <d <at> divoplade.fr>
Subject: Is Emacs 27.1 that breaks emacs-ess?
Date: Fri, 4 Sep 2020 16:44:26 +0200

Dear,

On Fri, 28 Aug 2020 at 22:07, divoplade <d <at> divoplade.fr> wrote:

> Right now emacs-ess is broken so I cannot upgrade to emacs 27. The
> failing test is "test-ess-roxy-literate".

I confirm.

--8<---------------cut here---------------start------------->8---
guix time-machine --commit=36a09d1853 \
     -- build emacs-ess -K
--8<---------------cut here---------------end--------------->8---

leads to "build of
/gnu/store/xm0lh7c0xfq3l0gfq34hxp1kjcnm6dri-emacs-ess-18.10.2.drv
failed" where the log reads:

--8<---------------cut here---------------start------------->8---
1 unexpected results:
   FAILED  test-ess-roxy-literate

2 skipped results:
  SKIPPED  runner-R-3\.2\.1-buffer-name
  SKIPPED  runner-R-3\.2\.1-defined
--8<---------------cut here---------------end--------------->8---

But the commit 36a09d1853 introducing Emacs 27 had been pushed on Fri Aug 28
00:13:51 2020 -0400 and the CI reported failures before this offending
commit.

https://ci.guix.gnu.org/search?query=spec%3Aguix-master+system%3Ax86_64-linux+emacs-ess

For other examples, see:

https://data.guix.gnu.org/repository/1/branch/master/package/emacs-ess/output-history

reporting issues both on Berlin and Bayfront and before the push of Emacs 27.


Note that the parent commit c05d2cfcbd builds successfully on my
machine.  Therefore, I do not know from where the failure comes from.


All the best,
simon

Message #11 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: divoplade <d <at> divoplade.fr>
To: zimoun <zimon.toutoune <at> gmail.com>, 43093 <at> debbugs.gnu.org
Subject: Re: Is Emacs 27.1 that breaks emacs-ess?
Date: Fri, 04 Sep 2020 17:26:41 +0200

Hello,
Le vendredi 04 septembre 2020 à 16:44 +0200, zimoun a écrit :
> But the commit 36a09d1853 introducing Emacs 27 had been pushed on Fri
> Aug 28
> 00:13:51 2020 -0400 and the CI reported failures before this
> offending
> commit.
> 
> https://ci.guix.gnu.org/search?query=spec%3Aguix-master+system%3Ax86_64-linux+emacs-ess
> 
> For other examples, see:
> 
> https://data.guix.gnu.org/repository/1/branch/master/package/emacs-ess/output-history
> 
> reporting issues both on Berlin and Bayfront and before the push of
> Emacs 27.
> 

Well, you must be right. I did not think it out long enough. It broke
at the same time I saw the emacs update, so I inferred it incorrectly.
Is it possible to edit the title?

> 
> Note that the parent commit c05d2cfcbd builds successfully on my
> machine.  Therefore, I do not know from where the failure comes from.
I can't find such a commit ID. It does not seem to exist in the git
repo. Do you know the date, author or committer?

Message #14 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: divoplade <d <at> divoplade.fr>, zimoun <zimon.toutoune <at> gmail.com>,
 43093 <at> debbugs.gnu.org
Subject: Re: bug#43093: Is Emacs 27.1 that breaks emacs-ess?
Date: Fri, 04 Sep 2020 13:00:37 -0400

divoplade <d <at> divoplade.fr> writes:
> Is it possible to edit the title?

Yes.  To do so, send an email to 'control <at> debbugs.gnu.org' with the
following two-line body:

--8<---------------cut here---------------start------------->8---
retitle 43093 THE_NEW_BUG_TITLE_GOES_HERE
thanks
--8<---------------cut here---------------end--------------->8---

For more details on how to use the control server, see:

  https://debbugs.gnu.org/server-control.html

which is linked from the main debbugs help page, here:

  https://debbugs.gnu.org

      Mark

Message #17 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: divoplade <d <at> divoplade.fr>
Cc: 43093 <at> debbugs.gnu.org
Subject: Re: Is Emacs 27.1 that breaks emacs-ess?
Date: Fri, 4 Sep 2020 20:09:41 +0200

On Fri, 4 Sep 2020 at 17:26, divoplade <d <at> divoplade.fr> wrote:

> Well, you must be right. I did not think it out long enough. It broke
> at the same time I saw the emacs update, so I inferred it incorrectly.

Nonetheless, it is still annoying. :-)

> > Note that the parent commit c05d2cfcbd builds successfully on my
> > machine.  Therefore, I do not know from where the failure comes from.
> I can't find such a commit ID. It does not seem to exist in the git
> repo. Do you know the date, author or committer?

   git log --format="%p" -1 36a09d1853

and the answer is c05d2cfcbe.  I do not know how I did the mistake
when copy/pasting.

All the best,
simon

Message #20 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: Tim Howes <timhowes <at> lavabit.com>
To: divoplade <d <at> divoplade.fr>, 43093 <at> debbugs.gnu.org
Subject: Re: bug#43093: emacs-ess is broken by emacs 27.1
Date: Fri, 4 Sep 2020 11:25:24 -0700

On 8/28/2020 1:07 PM, divoplade wrote:
> Hello all,
> 
> Right now emacs-ess is broken so I cannot upgrade to emacs 27. The
> failing test is "test-ess-roxy-literate".
> 
> Thank you anyway, I cannot wait to have emacs 27!
> 
> divoplade
> 
> 
> 
> 

Hello,

I think, instead of disabling the test or trying to make it work with 
emacs 27, I'd like to update emacs-ess to a more recent version. Right 
now it's using the latest tagged release (18.10.2), which was from 2018, 
but there's been active development on the github repo since then. I can 
take the latest commit and give it a version number based on the commit 
time, similar to how it's done on melpa (20200903.1516). I'll try making 
a patch to update it to that version.

-Tim

Message #25 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: Tim Howes <timhowes <at> lavabit.com>
To: 43093 <at> debbugs.gnu.org
Subject: [PATCH] gnu: emacs-ess: Update to 20200903.1516.
Date: Fri,  4 Sep 2020 16:25:37 -0700

* gnu/packages/statistics.scm (emacs-ess): Update to 20200903.1516.
[version]: Use latest commit, assign version based on commit date.
[source]: Fix snippet for removing julia-mode.  Remove snippet to modify
roxy-preview-Rd-test.  Add snippet to modify r-help-mode test.  Add
snippet to fix install target to install files to correct directories.
[arguments]: Add flag to specify INFODIR.  Remove patch modifying SHELL.
---
This updates emacs-ess to the current version on github and resolves
bugs #43093 and #42259.

 gnu/packages/statistics.scm | 43 ++++++++++++++++---------------------
 1 file changed, 19 insertions(+), 24 deletions(-)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index c1cefa8c41..aa14e2887f 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -5805,29 +5805,24 @@ Java package that provides routines for various statistical distributions.")
 (define-public emacs-ess
   (package
     (name "emacs-ess")
-    (version "18.10.2")
+    ;; Use version number based on commit date and time (UTC), similar to melpa.
+    (version "20200903.1516")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/emacs-ess/ESS")
-                    (commit (string-append "v" version))))
+                    (commit "09c1adecf8406d85426d14e5efe2aaba6c59f224")))
               (sha256
                (base32
-                "1yq41l2bicwjrc0b731iic20cpcnz6ppigri1jn621qv2qv22vy3"))
+                "0hl8nhf8w3rfpfqb2bfzcbh4lpsk51p83w2j5fc2knd4da4sb1s5"))
               (file-name (git-file-name name version))
               (modules '((guix build utils)))
               (snippet
                '(begin
                   ;; Stop ESS from trying to bundle an external julia-mode.el.
                   (substitute* "lisp/Makefile"
-                    (("^ess-julia.elc: julia-mode.elc") "")
-                    (("^all: julia-mode.el")
-                     "all:"))
-                  ;; Include *.el files in install target.
-                  (substitute* "lisp/Makefile"
-                    (("\t\\$\\(INSTALL) \\$\\(ELC\\) \\$\\(LISPDIR\\)" elc)
-                     (string-append "\t$(INSTALL) $(ELS) ess-autoloads.el "
-                                    "$(LISPDIR)\n" elc)))
+                    ((" \\$\\(JULIAS)") "")
+                    (("\ttest.*julia-mode.*\\.el") ""))
                   ;; Only build docs in info format.
                   (substitute* "doc/Makefile"
                     (("all  : info text")
@@ -5836,12 +5831,16 @@ Java package that provides routines for various statistical distributions.")
                      "install: install-info"))
                   ;; Stop install-info from trying to update the info directory.
                   (substitute* "doc/Makefile"
-                    ((".*\\$\\(INFODIR\\)/dir.*") ""))
-                  ;; Fix roxygen preview test.
-                  (substitute* "test/ess-r-tests.el"
-                               (("Add together two numbers.\n")
-                                "Add together two numbers. ")
-                               (("##' add\\(10, 1\\)") "add(10, 1)"))
+                    ((".*/dir.*") ""))
+                  ;; Fix r-help-mode test.
+                  (substitute* "test/ess-test-r.el"
+                    (("\\(equal ess-help-object \"plot.default\")") "t"))
+                  ;; Install to correct directories.
+                  (substitute* "Makefile"
+                    (("mkdir -p \\$\\(ESSDESTDIR)")
+                     "$(MAKE) -C lisp install; $(MAKE) -C doc install")
+                    (("\\$\\(INSTALL) -R \\./\\* \\$\\(ESSDESTDIR)/")
+                     "$(MAKE) -C etc install"))
                   #t))))
     (build-system gnu-build-system)
     (arguments
@@ -5850,16 +5849,12 @@ Java package that provides routines for various statistical distributions.")
                             (string-append "ETCDIR=" %output
                                            ,base-directory "/etc")
                             (string-append "LISPDIR=" %output
-                                           ,base-directory))
+                                           ,base-directory)
+                            (string-append "INFODIR=" %output
+                                           "/share/info"))
          #:phases
          (modify-phases %standard-phases
            (delete 'configure)
-           (add-before 'build 'more-shebang-patching
-             (lambda* (#:key inputs #:allow-other-keys)
-               (substitute* "Makeconf"
-                 (("SHELL = /bin/sh")
-                  (string-append "SHELL = " (which "sh"))))
-               #t))
            (replace 'check
              (lambda _
                (invoke "make" "test")))))))
-- 
2.28.0

Message #28 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: divoplade <d <at> divoplade.fr>
To: Tim Howes <timhowes <at> lavabit.com>, 43093 <at> debbugs.gnu.org
Subject: Re: bug#43093: emacs-ess is broken by emacs 27.1
Date: Mon, 07 Sep 2020 23:19:40 +0200

[Message part 1 (text/plain, inline)]

Hello Tim,

Le vendredi 04 septembre 2020 à 11:25 -0700, Tim Howes a écrit :
> I think, instead of disabling the test or trying to make it work
> with 
> emacs 27, I'd like to update emacs-ess to a more recent version.
> Right 
> now it's using the latest tagged release (18.10.2), which was from
> 2018, 
> but there's been active development on the github repo since then. I
> can 
> take the latest commit and give it a version number based on the
> commit 
> time, similar to how it's done on melpa (20200903.1516). I'll try
> making 
> a patch to update it to that version.

Right, emacs-ess is already a tag. Let's take the latest commit,
82cd308ae54a6b918bbceb235e6bf02f53e48e19

If I run guix hash -xr within the code, I get
0zw6j8jzrdmy41g6313js7c0xlmc2wmiazx4d4wm6hdvykn8q39k

The version would be 20200905.1022

If I do a drop-in replacement, remove the "Fix roxygen preview test."
modification and change the commands to disable julia, I get one other
test that fails:

Test ess-test-r-help-mode condition:
    (ert-test-failed
     ((should
       (or
	(equal ess-help-object "plot.default")
	(equal ess-help-object "plot")))
      :form
      (or
       (equal ess-help-object "plot.default")
       (equal ess-help-object "plot"))
      :value nil))

The test is in test/ess-test-r.el, line 628.

(ert-deftest ess-test-r-help-mode ()
  (with-r-running nil
    (let ((ess-pop-to-buffer t))
      (ess-display-help-on-object "plot")
      (should (equal ess-help-object "plot"))
      (should (derived-mode-p 'ess-r-help-mode))
      ;; Ensure help buffers after button presses are also in
      ;; `ess-r-help-mode', Bug#836
      (forward-button 2)
      (push-button)
      (should (or (equal ess-help-object "plot.default")
                  (equal ess-help-object "plot"))) ;; Badaboom
                                                ;;(the value is "NULL")
      (should (derived-mode-p 'ess-r-help-mode)))))

Looking at its friend, ess-test-r-index-mode, line 643:

(ert-deftest ess-test-r-index-mode ()
  (skip-unless (not noninteractive)) ;; negation overflow ;p
  (with-r-running nil
    (let ((ess-pop-to-buffer t))
      (ess-display-package-index "stats")
      (should (equal ess-help-object "stats"))
      (should (derived-mode-p 'ess-r-help-mode))
      ;; Ensure help buffers after button presses are also in
      ;; `ess-r-help-mode', Bug#836
      (forward-button 2)
      (push-button)
      (should (equal ess-help-object "plot.default"))
      (should (derived-mode-p 'ess-r-help-mode)))))

it seems that these tests should only run if (not (not (not (not
interactive)))) (i.e. interactive), and ess-test-r-help-mode has missed
a copy-paste.

Also, the license has changed: it is now gpl3+!

Anyway, here is a version that's working (I tested it with "emacs-ess-
next" as a name, but replaced it for this message).

Sorry, I don't know how to make a patch.

Best regards,

divoplade

[modified-emacs.scm (text/x-scheme, attachment)]

Message #31 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: divoplade <d <at> divoplade.fr>
To: 43093 <at> debbugs.gnu.org
Subject: Re: bug#43093: emacs-ess is broken by emacs 27.1
Date: Mon, 07 Sep 2020 23:43:59 +0200

[Message part 1 (text/plain, inline)]

Le lundi 07 septembre 2020 à 23:19 +0200, divoplade a écrit :
> Sorry, I don't know how to make a patch.

Trying: does it work like that?

[0001-Update-emacs-ess-to-a-more-recent-snapshot.patch (text/x-patch, attachment)]

Message #34 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: divoplade <d <at> divoplade.fr>
To: Tim Howes <timhowes <at> lavabit.com>, 43093 <at> debbugs.gnu.org
Subject: Re: bug#43093: emacs-ess is broken by emacs 27.1
Date: Mon, 07 Sep 2020 23:52:15 +0200

Le lundi 07 septembre 2020 à 23:19 +0200, divoplade a écrit :
> Sorry, I don't know how to make a patch.
> 
By trying to make one, I noticed that you have already sent a patch. I
don't know why I did not recieve it. I am still clueless about a lot of
things here.

Anyway, you forgot to update the license. It is now GPLv3+.

Best regards,

divoplade

Message #37 received at 43093 <at> debbugs.gnu.org (full text, mbox):

From: Tim Howes <timhowes <at> lavabit.com>
To: divoplade <d <at> divoplade.fr>, 43093 <at> debbugs.gnu.org
Subject: Re: bug#43093: emacs-ess is broken by emacs 27.1
Date: Tue, 8 Sep 2020 12:24:40 -0700

On 9/7/2020 2:52 PM, divoplade wrote:
> Le lundi 07 septembre 2020 à 23:19 +0200, divoplade a écrit :
>> Sorry, I don't know how to make a patch.
>>
> By trying to make one, I noticed that you have already sent a patch. I
> don't know why I did not recieve it. I am still clueless about a lot of
> things here.
> 
> Anyway, you forgot to update the license. It is now GPLv3+.
> 
> Best regards,
> 
> divoplade
> 

That's alright, I should have cc'd you with the patch, but forgot since 
I was using git send-email.

I started a separate thread here for this patch. There still seems to be 
a problem with it, as the build sometimes fails due to a file locking 
issue. And it was suggested that I should version it as a revision of 
18.02.2 instead of this versioning scheme.

https://issues.guix.gnu.org/43208

Thanks also for the note about the license. I'll update that accordingly.
-Tim

Message #42 received at 43093-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Tim Howes <timhowes <at> lavabit.com>
Cc: 43093-done <at> debbugs.gnu.org
Subject: Re: bug#43093: [PATCH] gnu: emacs-ess: Update to 20200903.1516.
Date: Sun, 27 Sep 2020 23:28:12 -0400

Hello!

Tim Howes <timhowes <at> lavabit.com> writes:

> * gnu/packages/statistics.scm (emacs-ess): Update to 20200903.1516.
> [version]: Use latest commit, assign version based on commit date.
> [source]: Fix snippet for removing julia-mode.  Remove snippet to modify
> roxy-preview-Rd-test.  Add snippet to modify r-help-mode test.  Add
> snippet to fix install target to install files to correct directories.
> [arguments]: Add flag to specify INFODIR.  Remove patch modifying SHELL.
> ---
> This updates emacs-ess to the current version on github and resolves
> bugs #43093 and #42259.

I'm closing this bug, since a more current patch was merged to master
[0] about two days ago, which resolves the issue.

Thank you!

Maxim

[0]  https://issues.guix.gnu.org/43208#11

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.