GNU bug report logs - #43119
[PATCH] gnu: Add guile-srfi-180.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43119 in the body.
You can then email your comments to 43119 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Martin Becze <mjbecze <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: Martin Becze <mjbecze <at> riseup.net>
Subject: [PATCH] gnu: Add guile-srfi-180.
Date: Sun, 30 Aug 2020 13:11:45 -0500

* gnu/packages/guile-xyz.scm (guile-srfi-180): New variable.
---
 gnu/packages/guile-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 9f9335c8f7..b6d163a8bd 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -2887,6 +2887,41 @@ formatting combinators specified by
 more expressive and flexible than the traditional @code{format} procedure.")
       (license license:bsd-3))))
 
+(define-public guile-srfi-180
+  (let ((commit "9188bf9724c6d320ef804579d222e855b007b193")
+        (revision "0"))
+    (package
+      (name "guile-srfi-180")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (commit commit)
+               (url "https://github.com/scheme-requests-for-implementation/srfi-180.git")))
+         (sha256
+          (base32
+           "08lf70rsak8mwfij55xc37pg9zg7c87fizmhz7ln46skzj68sl3y"))
+         (modules '((guix build utils)))
+         (snippet
+          '(begin
+             (delete-file-recursively "srfi/files")
+             (delete-file "srfi/run-r7rs-checks.guile.scm")
+             (delete-file "srfi/run-r7rs-checks.scm")
+             #t))
+         (file-name (git-file-name name version))))
+      (build-system guile-build-system)
+      (native-inputs
+       `(("guile" ,guile-3.0)))
+      (propagated-inputs
+       `(("guile-srfi-145" ,guile-srfi-145)))
+      (home-page "https://srfi.schemers.org/srfi-180/")
+      (synopsis "JSON parser and printer for Guile")
+      (description
+       "This library describes a JavaScript Object Notation (JSON) parser and printer.
+It supports JSON that may be bigger than memory.")
+      (license license:expat))))
+
 (define-public emacsy
   (package
     (name "emacsy")
-- 
2.28.0

Message #8 received at 43119 <at> debbugs.gnu.org (full text, mbox):

From: Martin Becze <mjbecze <at> riseup.net>
To: 43119 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add guile-srfi-180.
Date: Sun, 30 Aug 2020 16:14:10 -0500

[Message part 1 (text/plain, inline)]

opps there is a lint fail. attached is a cleaner version.

On 8/30/20 1:11 PM, Martin Becze wrote:
> * gnu/packages/guile-xyz.scm (guile-srfi-180): New variable.
> ---
>   gnu/packages/guile-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
>   1 file changed, 35 insertions(+)
> 
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 9f9335c8f7..b6d163a8bd 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -2887,6 +2887,41 @@ formatting combinators specified by
>   more expressive and flexible than the traditional @code{format} procedure.")
>         (license license:bsd-3))))
>   
> +(define-public guile-srfi-180
> +  (let ((commit "9188bf9724c6d320ef804579d222e855b007b193")
> +        (revision "0"))
> +    (package
> +      (name "guile-srfi-180")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (commit commit)
> +               (url "https://github.com/scheme-requests-for-implementation/srfi-180.git")))
> +         (sha256
> +          (base32
> +           "08lf70rsak8mwfij55xc37pg9zg7c87fizmhz7ln46skzj68sl3y"))
> +         (modules '((guix build utils)))
> +         (snippet
> +          '(begin
> +             (delete-file-recursively "srfi/files")
> +             (delete-file "srfi/run-r7rs-checks.guile.scm")
> +             (delete-file "srfi/run-r7rs-checks.scm")
> +             #t))
> +         (file-name (git-file-name name version))))
> +      (build-system guile-build-system)
> +      (native-inputs
> +       `(("guile" ,guile-3.0)))
> +      (propagated-inputs
> +       `(("guile-srfi-145" ,guile-srfi-145)))
> +      (home-page "https://srfi.schemers.org/srfi-180/")
> +      (synopsis "JSON parser and printer for Guile")
> +      (description
> +       "This library describes a JavaScript Object Notation (JSON) parser and printer.
> +It supports JSON that may be bigger than memory.")
> +      (license license:expat))))
> +
>   (define-public emacsy
>     (package
>       (name "emacsy")
> 

[v2-0001-gnu-Add-guile-srfi-180.patch (text/x-patch, attachment)]

Message #11 received at 43119 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Martin Becze <mjbecze <at> riseup.net>
Cc: 43119 <at> debbugs.gnu.org
Subject: Re: [bug#43119] [PATCH] gnu: Add guile-srfi-180.
Date: Mon, 31 Aug 2020 10:14:25 +0200

Hey,

>> * gnu/packages/guile-xyz.scm (guile-srfi-180): New variable.

I'm getting a whole bunch of warnings when building srfi/180/body.scm,
such as:

--8<---------------cut here---------------start------------->8---
srfi/180/body.scm:237:11: warning: possibly unbound variable `textual-port?'
srfi/180/body.scm:198:4: warning: possibly unbound variable `eof-object'
srfi/180/body.scm:195:2: warning: possibly unbound variable `assume'
srfi/180/body.scm:191:23: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:190:29: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:186:16: warning: possibly unbound variable `valid-number?'
srfi/180/body.scm:167:29: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:146:59: warning: possibly unbound variable `bitwise-ior'
srfi/180/body.scm:111:15: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:106:15: warning: possibly unbound variable `make-json-error'
--8<---------------cut here---------------end--------------->8---

Do you think they could be fixed?

>> +       "This library describes a JavaScript Object Notation (JSON) parser and printer.
>> +It supports JSON that may be bigger than memory.")

Even though this description is a copy of the SRFI abstract, it seems a
bit vague. I would change "describes" to "implements" or "provides". The
affirmation "JSON bigger than memory" could also be expanded I think.

Thanks,

Mathieu

Message #14 received at 43119 <at> debbugs.gnu.org (full text, mbox):

From: Martin Becze <mjbecze <at> riseup.net>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 43119 <at> debbugs.gnu.org
Subject: Re: [bug#43119] [PATCH] gnu: Add guile-srfi-180.
Date: Mon, 31 Aug 2020 04:11:15 -0500

[Message part 1 (text/plain, inline)]

>> Do you think they could be fixed?

Fixed in the attached patch.

> Even though this description is a copy of the SRFI abstract, it seems a
> bit vague. I would change "describes" to "implements" or "provides". The
> affirmation "JSON bigger than memory" could also be expanded I think.

I tried to spruce it up a bit. Thanks for the feedback!

On 8/31/20 3:14 AM, Mathieu Othacehe wrote:
> 
> Hey,
> 
>>> * gnu/packages/guile-xyz.scm (guile-srfi-180): New variable.
> 
> I'm getting a whole bunch of warnings when building srfi/180/body.scm,
> such as:
> 
> --8<---------------cut here---------------start------------->8---
> srfi/180/body.scm:237:11: warning: possibly unbound variable `textual-port?'
> srfi/180/body.scm:198:4: warning: possibly unbound variable `eof-object'
> srfi/180/body.scm:195:2: warning: possibly unbound variable `assume'
> srfi/180/body.scm:191:23: warning: possibly unbound variable `make-json-error'
> srfi/180/body.scm:190:29: warning: possibly unbound variable `make-json-error'
> srfi/180/body.scm:186:16: warning: possibly unbound variable `valid-number?'
> srfi/180/body.scm:167:29: warning: possibly unbound variable `make-json-error'
> srfi/180/body.scm:146:59: warning: possibly unbound variable `bitwise-ior'
> srfi/180/body.scm:111:15: warning: possibly unbound variable `make-json-error'
> srfi/180/body.scm:106:15: warning: possibly unbound variable `make-json-error'
> --8<---------------cut here---------------end--------------->8---
> 
> Do you think they could be fixed?
> 
>>> +       "This library describes a JavaScript Object Notation (JSON) parser and printer.
>>> +It supports JSON that may be bigger than memory.")
> 
> Even though this description is a copy of the SRFI abstract, it seems a
> bit vague. I would change "describes" to "implements" or "provides". The
> affirmation "JSON bigger than memory" could also be expanded I think.
> 
> Thanks,
> 
> Mathieu
> 

[v2-0001-gnu-Add-guile-srfi-180.patch (text/x-patch, attachment)]

Message #19 received at 43119-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Martin Becze <mjbecze <at> riseup.net>
Cc: 43119-done <at> debbugs.gnu.org
Subject: Re: [bug#43119] [PATCH] gnu: Add guile-srfi-180.
Date: Tue, 01 Sep 2020 21:23:25 +0200

Hello Martin,

> I tried to spruce it up a bit. Thanks for the feedback!

Thanks for the v2, pushed!

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.