GNU bug report logs - #43133
Update Chez to 9.5.4, Add a static output for lz4

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43133 in the body.
You can then email your comments to 43133 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: guix-patches <at> gnu.org
Subject: Update Chez to 9.5.4, Add a static output for lz4
Date: Mon, 31 Aug 2020 22:07:39 +1000

[Message part 1 (text/plain, inline)]

I haven't tested it but it seems to work. I wanted to build some of the 
dependent packages against it but i noticed chez-irregex, chez-sockets, 
chez-scmutils are all broken anyway. chez-fmt builds at least.

[0001-gnu-lz4-Install-static-build-to-static-output.patch (text/x-patch, attachment)]

[0002-gnu-chez-scheme-Update-to-9.5.4.patch (text/x-patch, attachment)]

[0003-gnu-chez-scheme-Patch-more-hard-coded-paths.patch (text/x-patch, attachment)]

Message #8 received at 43133 <at> debbugs.gnu.org (full text, mbox):

From: Martin Becze <mjbecze <at> riseup.net>
To: Brendan Tildesley <mail <at> brendan.scot>, 43133 <at> debbugs.gnu.org
Subject: Re: [bug#43133] Update Chez to 9.5.4, Add a static output for lz4
Date: Mon, 31 Aug 2020 11:57:06 -0500

The broken dependent packages are related to issue #42947 
https://issues.guix.gnu.org/42947https://issues.guix.gnu.org/42947

On 8/31/20 7:07 AM, Brendan Tildesley wrote:
> I haven't tested it but it seems to work. I wanted to build some of the 
> dependent packages against it but i noticed chez-irregex, chez-sockets, 
> chez-scmutils are all broken anyway. chez-fmt builds at least.

Message #11 received at 43133 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 43133 <at> debbugs.gnu.org
Subject: Re: [bug#43133] Update Chez to 9.5.4, Add a static output for lz4
Date: Tue, 03 Nov 2020 11:55:44 +0100

Hi Brendan,

Apologies for the long delay; I guess quite a few patches that arrived
during the summer fell through the cracks.  :-/

Brendan Tildesley <mail <at> brendan.scot> skribis:

> I haven't tested it but it seems to work. I wanted to build some of
> the dependent packages against it but i noticed chez-irregex,
> chez-sockets, chez-scmutils are all broken anyway. chez-fmt builds at
> least.

That should be fixed now as Martin pointed out:

  https://issues.guix.gnu.org/42947

>>From c81a0521d44f6dc6fa70b745b4062db2fc89a5b6 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail <at> brendan.scot>
> Date: Mon, 31 Aug 2020 16:39:02 +1000
> Subject: [PATCH 1/3] gnu: lz4: Install static build to "static" output.
>
> * gnu/packages/compression.scm (lz4): Mimic the zlib package by moving
> the static build output to a separate "static" output. This allows
> programs like chez-scheme to link to the static version.

The patch LGTM.  In theory it should go to ‘staging’, I have to check
what the status is.

>>From 4e7d52173cee354e5ac0dfedd6f22b95e96ffe86 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail <at> brendan.scot>
> Date: Mon, 31 Aug 2020 17:26:17 +1000
> Subject: [PATCH 2/3] gnu: chez-scheme: Update to 9.5.4.
>
> * gnu/packages/chez.scm
> (nanopass): Update to 1.9.1.
> (stex): Update to 1.2.2.
> (chez-scheme): Update to 9.5.4.
> [inputs]: Add newly required lz4 and lz4:static.
> [arguments]:
>  - Remove unused zlib symbol.
>  - Since we are using ZLIB=, it looks like the substitution of libz.a path in
>  .c/Mf-... files is no longer needed.
>  - add lz4-static symbol and use new LZ4= and ZLIB= configure options to
>    point to their static binaries.

[...]

>                 (substitute* "stex/Makefile"
>                   (("PREFIX=/usr") (string-append "PREFIX=" out)))
>                 (invoke "./configure" "--threads"
> +                       (string-append "ZLIB=" zlib-static "/lib/libz.a")
> +                       (string-append "LZ4=" lz4-static "/lib/liblz4.a")

Why should Chez static-link against those?  In general we should avoid
that as that prevents security update propagation through grafts.  Can
we remove these two lines?

>>From 939a1f8185f7e77ff1b809e6cc8de6fbf43b9768 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail <at> brendan.scot>
> Date: Mon, 31 Aug 2020 21:51:34 +1000
> Subject: [PATCH 3/3] gnu: chez-scheme: Patch more hard-coded paths.
>
> * gnu/packages/chez.scm (chez-scheme): Patch out some /bin/rm and
> /bin/echo references.

LGTM.

Thank you!

Ludo’.

Message #16 received at 43133-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 43133-done <at> debbugs.gnu.org
Subject: Re: [bug#43133] Update Chez to 9.5.4, Add a static output for lz4
Date: Fri, 18 Dec 2020 16:09:49 +0100

Hi Brendan,

Brendan Tildesley <mail <at> brendan.scot> skribis:

>>From 4e7d52173cee354e5ac0dfedd6f22b95e96ffe86 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail <at> brendan.scot>
> Date: Mon, 31 Aug 2020 17:26:17 +1000
> Subject: [PATCH 2/3] gnu: chez-scheme: Update to 9.5.4.
>
> * gnu/packages/chez.scm
> (nanopass): Update to 1.9.1.
> (stex): Update to 1.2.2.
> (chez-scheme): Update to 9.5.4.
> [inputs]: Add newly required lz4 and lz4:static.
> [arguments]:
>  - Remove unused zlib symbol.
>  - Since we are using ZLIB=, it looks like the substitution of libz.a path in
>  .c/Mf-... files is no longer needed.
>  - add lz4-static symbol and use new LZ4= and ZLIB= configure options to
>    point to their static binaries.

[...]

>>From 939a1f8185f7e77ff1b809e6cc8de6fbf43b9768 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail <at> brendan.scot>
> Date: Mon, 31 Aug 2020 21:51:34 +1000
> Subject: [PATCH 3/3] gnu: chez-scheme: Patch more hard-coded paths.
>
> * gnu/packages/chez.scm (chez-scheme): Patch out some /bin/rm and
> /bin/echo references.

I went ahead and applied these two patches.

Some of the chez-* packages currently fail due to some TeX Live issue
unfortunately, but at least ‘chez-fmt’ and ‘chez-scmutils’ build fine
with these changes.

It would still be interesting to link dynamically (instead of
statically) against libz and liblz4 as a followup.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.