GNU bug report logs - #43180
[PATCH] scripts: system: Expand some help messages.

Previous Next

Package: guix;

Reported by: Efraim Flashner <efraim <at> flashner.co.il>

Date: Thu, 3 Sep 2020 11:57:01 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43180 in the body.
You can then email your comments to 43180 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#43180; Package guix. (Thu, 03 Sep 2020 11:57:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Efraim Flashner <efraim <at> flashner.co.il>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Thu, 03 Sep 2020 11:57:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: bug-guix <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] scripts: system: Expand some help messages.
Date: Thu,  3 Sep 2020 14:55:42 +0300
* guix/scripts/system.scm (show-help): Add to '--share=SPEC' and
'--expose=SPEC' that it also works for containers.
---
 guix/scripts/system.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
index b75b0e5b60..be17bc1ba7 100644
--- a/guix/scripts/system.scm
+++ b/guix/scripts/system.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2019 Christopher Baines <mail <at> cbaines.net>
 ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
 ;;; Copyright © 2020 Julien Lepiller <julien <at> lepiller.eu>
+;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -956,9 +957,11 @@ Some ACTIONS support additional ARGS.\n"))
   (display (G_ "
       --save-provenance  save provenance information"))
   (display (G_ "
-      --share=SPEC       for 'vm', share host file system according to SPEC"))
+      --share=SPEC       for 'vm' and 'container', share host file system
+                         according to SPEC"))
   (display (G_ "
-      --expose=SPEC      for 'vm', expose host file system according to SPEC"))
+      --expose=SPEC      for 'vm' and 'container', expose host file system
+                         according to SPEC"))
   (display (G_ "
   -N, --network          for 'container', allow containers to access the network"))
   (display (G_ "
-- 
2.28.0





Information forwarded to bug-guix <at> gnu.org:
bug#43180; Package guix. (Thu, 03 Sep 2020 12:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 43180 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 43180 <at> debbugs.gnu.org
Subject: Re: bug#43180: [PATCH] scripts: system: Expand some help messages.
Date: Thu, 3 Sep 2020 14:46:23 +0200
Le Thu,  3 Sep 2020 14:55:42 +0300,
Efraim Flashner <efraim <at> flashner.co.il> a écrit :

> * guix/scripts/system.scm (show-help): Add to '--share=SPEC' and
> '--expose=SPEC' that it also works for containers.
> ---
>  guix/scripts/system.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
> index b75b0e5b60..be17bc1ba7 100644
> --- a/guix/scripts/system.scm
> +++ b/guix/scripts/system.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2019 Christopher Baines <mail <at> cbaines.net>
>  ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
>  ;;; Copyright © 2020 Julien Lepiller <julien <at> lepiller.eu>
> +;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -956,9 +957,11 @@ Some ACTIONS support additional ARGS.\n"))
>    (display (G_ "
>        --save-provenance  save provenance information"))
>    (display (G_ "
> -      --share=SPEC       for 'vm', share host file system according
> to SPEC"))
> +      --share=SPEC       for 'vm' and 'container', share host file
> system
> +                         according to SPEC"))
>    (display (G_ "
> -      --expose=SPEC      for 'vm', expose host file system according
> to SPEC"))
> +      --expose=SPEC      for 'vm' and 'container', expose host file
> system
> +                         according to SPEC"))
>    (display (G_ "
>    -N, --network          for 'container', allow containers to access
> the network")) (display (G_ "

Should we say something about how sharing is read-write, exposing is
read-only?




Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Sat, 05 Sep 2020 19:28:02 GMT) Full text and rfc822 format available.

Notification sent to Efraim Flashner <efraim <at> flashner.co.il>:
bug acknowledged by developer. (Sat, 05 Sep 2020 19:28:02 GMT) Full text and rfc822 format available.

Message #13 received at 43180-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 43180-done <at> debbugs.gnu.org
Subject: Re: bug#43180: [PATCH] scripts: system: Expand some help messages.
Date: Sat, 5 Sep 2020 22:26:44 +0300
[Message part 1 (text/plain, inline)]
On Thu, Sep 03, 2020 at 02:46:23PM +0200, Julien Lepiller wrote:
> Le Thu,  3 Sep 2020 14:55:42 +0300,
> Efraim Flashner <efraim <at> flashner.co.il> a écrit :
> 
> > * guix/scripts/system.scm (show-help): Add to '--share=SPEC' and
> > '--expose=SPEC' that it also works for containers.
> > ---
> >  guix/scripts/system.scm | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
> > index b75b0e5b60..be17bc1ba7 100644
> > --- a/guix/scripts/system.scm
> > +++ b/guix/scripts/system.scm
> > @@ -7,6 +7,7 @@
> >  ;;; Copyright © 2019 Christopher Baines <mail <at> cbaines.net>
> >  ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
> >  ;;; Copyright © 2020 Julien Lepiller <julien <at> lepiller.eu>
> > +;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -956,9 +957,11 @@ Some ACTIONS support additional ARGS.\n"))
> >    (display (G_ "
> >        --save-provenance  save provenance information"))
> >    (display (G_ "
> > -      --share=SPEC       for 'vm', share host file system according
> > to SPEC"))
> > +      --share=SPEC       for 'vm' and 'container', share host file
> > system
> > +                         according to SPEC"))
> >    (display (G_ "
> > -      --expose=SPEC      for 'vm', expose host file system according
> > to SPEC"))
> > +      --expose=SPEC      for 'vm' and 'container', expose host file
> > system
> > +                         according to SPEC"))
> >    (display (G_ "
> >    -N, --network          for 'container', allow containers to access
> > the network")) (display (G_ "
> 
> Should we say something about how sharing is read-write, exposing is
> read-only?

Sounds good. I expanded it a bit to mention share is read/write and
expose is read-only.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 04 Oct 2020 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 177 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.