GNU logs - #43210, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout 
Resent-From: "Hamzeh Nasajpour" <h.nasajpour@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 05 Sep 2020 05:55:02 +0000
Resent-Message-ID: <handler.43210.B.15992852837034 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 43210 <at> debbugs.gnu.org
User-Agent: Cyrus-JMAP/3.3.0-259-g88fbbfa-fm-20200903.003-g88fbbfa3
Mime-Version: 1.0
Message-Id: <2a9af2f5-62b9-45c9-bfa5-430241158521@HIDDEN>
Date: Sat, 05 Sep 2020 10:24:14 +0430
From: "Hamzeh Nasajpour" <h.nasajpour@HIDDEN>
Content-Type: text/plain
Received-SPF: pass client-ip=66.111.4.29;
 envelope-from=h.nasajpour@HIDDEN; helo=out5-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 21587609ce..baa2ee6795 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -379,6 +379,7 @@ the operating system LXQt is running on.")
        ("qtbase" ,qtbase)
        ("qtsvg" ,qtsvg)
        ("qtx11extras" ,qtx11extras)
+       ("setxkbmap" ,setxkbmap)
        ("solid" ,solid)
        ("xf86-input-libinput" ,xf86-input-libinput)
        ("xkeyboard-config" ,xkeyboard-config)
@@ -418,7 +419,16 @@ the operating system LXQt is running on.")
                (("\\$\\{LXQT_TRANSLATIONS_DIR\\}")
                 (string-append (assoc-ref outputs "out")
                                "/share/lxqt/translations")))
-             #t)))))
+             #t))
+          (add-after 'install 'wrap-for-setxkbmap-path
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((out              (assoc-ref outputs "out"))
+                    (setxkbmap          (assoc-ref %build-inputs "setxkbmap")))
+                       (wrap-program (string-append out "/bin/lxqt-config")
+                            `("PATH" ":" prefix (,(string-append setxkbmap "/bin/"))))
+                       (wrap-program (string-append out "/bin/lxqt-config-input")
+                           `("PATH" ":" prefix (,(string-append setxkbmap "/bin/"))))
+               #t))))))
     (home-page "https://lxqt.github.io")
     (synopsis "Tools to configure LXQt and the underlying operating system")
     (description "lxqt-config is providing several tools involved in the

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Hamzeh Nasajpour" <h.nasajpour@HIDDEN>
Subject: bug#43210: Acknowledgement ([PATCH] gnu: lxqt-config: Wrapping
 the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for
 fixing save added layout )
Message-ID: <handler.43210.B.15992852837034.ack <at> debbugs.gnu.org>
References: <2a9af2f5-62b9-45c9-bfa5-430241158521@HIDDEN>
X-Gnu-PR-Message: ack 43210
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 43210 <at> debbugs.gnu.org
Date: Sat, 05 Sep 2020 05:55:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 43210 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
43210: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43210
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout 
Resent-From: "Hamzeh Nasajpour" <h.nasajpour@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 12 Sep 2020 12:03:01 +0000
Resent-Message-ID: <handler.43210.B.159991213531881 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 43210 <at> debbugs.gnu.org
User-Agent: Cyrus-JMAP/3.3.0-259-g88fbbfa-fm-20200903.003-g88fbbfa3
Mime-Version: 1.0
Message-Id: <48a7703f-7edf-48e0-b8a9-8e03944d5e20@HIDDEN>
In-Reply-To: <2a9af2f5-62b9-45c9-bfa5-430241158521@HIDDEN>
References: <2a9af2f5-62b9-45c9-bfa5-430241158521@HIDDEN>
Date: Sat, 12 Sep 2020 16:31:33 +0430
From: "Hamzeh Nasajpour" <h.nasajpour@HIDDEN>
Content-Type: text/plain
Received-SPF: pass client-ip=64.147.123.19;
 envelope-from=h.nasajpour@HIDDEN; helo=wout3-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi guys.
Seems that anyway we have to add `setxkbmap` to `propagated-inputs`. The previous commit will fix the adding `keyboard-layout` but without having the `setxkbmap` in `propagated-inputs` the added layouts won't add as permanent and will be reset after each reboot. So again, we need to add `setxkbmap` as a dependency in `propagated-inputs`.


On Sat, Sep 5, 2020, at 10:24 AM, Hamzeh Nasajpour wrote:
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index 21587609ce..baa2ee6795 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -379,6 +379,7 @@ the operating system LXQt is running on.")
>         ("qtbase" ,qtbase)
>         ("qtsvg" ,qtsvg)
>         ("qtx11extras" ,qtx11extras)
> +       ("setxkbmap" ,setxkbmap)
>         ("solid" ,solid)
>         ("xf86-input-libinput" ,xf86-input-libinput)
>         ("xkeyboard-config" ,xkeyboard-config)
> @@ -418,7 +419,16 @@ the operating system LXQt is running on.")
>                 (("\\$\\{LXQT_TRANSLATIONS_DIR\\}")
>                  (string-append (assoc-ref outputs "out")
>                                 "/share/lxqt/translations")))
> -             #t)))))
> +             #t))
> +          (add-after 'install 'wrap-for-setxkbmap-path
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((out              (assoc-ref outputs "out"))
> +                    (setxkbmap          (assoc-ref %build-inputs 
> "setxkbmap")))
> +                       (wrap-program (string-append out 
> "/bin/lxqt-config")
> +                            `("PATH" ":" prefix (,(string-append 
> setxkbmap "/bin/"))))
> +                       (wrap-program (string-append out 
> "/bin/lxqt-config-input")
> +                           `("PATH" ":" prefix (,(string-append 
> setxkbmap "/bin/"))))
> +               #t))))))
>      (home-page "https://lxqt.github.io")
>      (synopsis "Tools to configure LXQt and the underlying operating 
> system")
>      (description "lxqt-config is providing several tools involved in 
> the

Message sent to guix-patches@HIDDEN:

Subject: [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Sep 2020 15:24:01 +0000
Resent-Message-ID: <handler.43210.B43210.160096098621668 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "Hamzeh Nasajpour" <h.nasajpour@HIDDEN>
Cc: 43210 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <2a9af2f5-62b9-45c9-bfa5-430241158521@HIDDEN>
 <48a7703f-7edf-48e0-b8a9-8e03944d5e20@HIDDEN>
Date: Thu, 24 Sep 2020 17:22:56 +0200
In-Reply-To: <48a7703f-7edf-48e0-b8a9-8e03944d5e20@HIDDEN> (Hamzeh
 Nasajpour's message of "Sat, 12 Sep 2020 16:31:33 +0430")
Message-ID: <87pn6b6vxr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

"Hamzeh Nasajpour" <h.nasajpour@HIDDEN> skribis:

> Seems that anyway we have to add `setxkbmap` to `propagated-inputs`. The =
previous commit will fix the adding `keyboard-layout` but without having th=
e `setxkbmap` in `propagated-inputs` the added layouts won't add as permane=
nt and will be reset after each reboot. So again, we need to add `setxkbmap=
` as a dependency in `propagated-inputs`.

Why is that?  I fail to see why using =E2=80=98propagated-inputs=E2=80=99 i=
nstead of
wrapping would work better.

>> +          (add-after 'install 'wrap-for-setxkbmap-path
>> +            (lambda* (#:key outputs #:allow-other-keys)
>> +              (let ((out              (assoc-ref outputs "out"))
>> +                    (setxkbmap          (assoc-ref %build-inputs=20
>> "setxkbmap")))
>> +                       (wrap-program (string-append out=20
>> "/bin/lxqt-config")
>> +                            `("PATH" ":" prefix (,(string-append=20
>> setxkbmap "/bin/"))))
>> +                       (wrap-program (string-append out=20
>> "/bin/lxqt-config-input")
>> +                           `("PATH" ":" prefix (,(string-append=20
>> setxkbmap "/bin/"))))
>> +               #t))))))

For this case, it might be easier/preferable to replace =E2=80=98setxkbmap=
=E2=80=99 in
the source code with the absolute file name of =E2=80=98setxkbmap=E2=80=99.

Thanks,
Ludo=E2=80=99.

Last modified: Thu, 24 Sep 2020 15:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.