GNU bug report logs - #43273
[PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43273 in the body.
You can then email your comments to 43273 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.
Date: Tue,  8 Sep 2020 12:48:35 +0200

* gnu/packages/mp3.scm (taglib): Add "" around the substitution of
ZLIB_LIBRARIES_FLAGS.
---
 gnu/packages/mp3.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index a7574f0cf9..2e9b023407 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -182,9 +182,9 @@ a highly stable and efficient implementation.")
                        ;; flag for zlib.
                        (substitute* "CMakeLists.txt"
                          (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)")
-                          (string-append "set(ZLIB_LIBRARIES_FLAGS -L"
+                          (string-append "set(ZLIB_LIBRARIES_FLAGS \"-L"
                                          (assoc-ref inputs "zlib")
-                                         " -lz)")))
+                                         " -lz\")")))
                        #t)))))
     (inputs `(("zlib" ,zlib)))
     (home-page "https://taglib.org")
-- 
2.28.0

Message #10 received at 43273-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 43273-done <at> debbugs.gnu.org
Subject: Re: [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L
 flag.
Date: Wed, 09 Sep 2020 09:38:57 +0200

Hi,

Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/mp3.scm (taglib): Add "" around the substitution of
> ZLIB_LIBRARIES_FLAGS.

Applied.  Thanks and sorry for the delay!

Ludo’.

Message #13 received at 43273 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 43273 <at> debbugs.gnu.org
Subject: Re: [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L
 flag.
Date: Wed, 09 Sep 2020 10:28:59 +0200

Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/mp3.scm (taglib): Add "" around the substitution of
> ZLIB_LIBRARIES_FLAGS.
> ---
>  gnu/packages/mp3.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index a7574f0cf9..2e9b023407 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -182,9 +182,9 @@ a highly stable and efficient implementation.")
>                         ;; flag for zlib.
>                         (substitute* "CMakeLists.txt"
>                           (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)")
> -                          (string-append "set(ZLIB_LIBRARIES_FLAGS -L"
> +                          (string-append "set(ZLIB_LIBRARIES_FLAGS \"-L"
>                                           (assoc-ref inputs "zlib")
> -                                         " -lz)")))
> +                                         " -lz\")")))

As it turns out, we were also missing “/lib” there…  I’ve added it, and
hopefully now we’re all fine!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.