GNU bug report logs - #43296
Gnome Builder doesn't install.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43296 in the body.
You can then email your comments to 43296 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marinus Savoritias <marinus.savoritias <at> disroot.org>
To: bug-guix <at> gnu.org
Subject: Gnome Builder doesn't install.
Date: Wed, 9 Sep 2020 21:04:20 +0200

Gnome builder fails to install with this message:

swzg5y9hnggp7aghz8q2l-gnome-builder-3.36.1.drv' failed with exit code 1
build of 
/gnu/store/w2lzd0dc6qbswzg5y9hnggp7aghz8q2l-gnome-builder-3.36.1.drv failed

The message in the log is this:

ld: 
/gnu/store/sh764z2hm5qcr4cqx4amcipcbkvg76i2-libselinux-3.0/lib/libselinux.a(setrans_client.o): 
relocation R_X86_64_32 against `.rodata.str1.8' can not be used when 
making a PIE object; recompile with -fPIE
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
command "ninja" "-j" "4" failed with status 1

Marinus Savoritias

Message #8 received at 43296 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: 43296 <at> debbugs.gnu.org
Subject: bug#43269: Gnome Builder doesn't install.
Date: Thu, 10 Sep 2020 18:58:26 +0200

Hi Marinus,

I've noticed your report and quickly found a rather crude way of fixing it.
I'm not sure, why meson tries to link gnome-builder statically against selinux
in the first place, but it should do the job.

Regards,
Leo


Leo Prikler (1):
  gnu: Fix gnome-builder build.

 gnu/packages/gnome.scm | 6 ++++++
 1 file changed, 6 insertions(+)

--
2.28.0

Message #11 received at 43296 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: 43296 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: Fix gnome-builder build.
Date: Thu, 10 Sep 2020 18:58:27 +0200

As reported in #43296, gnome-builder tries to be linked against the static
version of libselinux (propagated through glib/gio), failing to do so, as it
also wants to be a PIE.  To keep the PIE, link it against the dynamic library.
* gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
---
 gnu/packages/gnome.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 31c5b0319c..ff4cb8a383 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11336,6 +11336,12 @@ libraries.  Applications do not need to be recompiled--or even restarted.")
                 (string-append (assoc-ref inputs "python-pygobject")
                                "/lib")))
              #t))
+         (add-after 'configure 'fix-ninja
+           (lambda _
+             ;; #43296: meson(?) incorrectly assumes we want to link
+             ;;         this PIE against a static libselinux.
+             (substitute* "build.ninja"
+               (("libselinux\\.a") "libselinux.so"))))
          (add-before 'check 'pre-check
            (lambda _
              (system "Xvfb :1 &")
-- 
2.28.0

Message #14 received at 43296 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 43296 <at> debbugs.gnu.org
Subject: Re: bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build.
Date: Thu, 10 Sep 2020 14:08:19 -0400

Hi,

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> As reported in #43296, gnome-builder tries to be linked against the static
> version of libselinux (propagated through glib/gio), failing to do so, as it
> also wants to be a PIE.  To keep the PIE, link it against the dynamic library.
> * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
> ---
>  gnu/packages/gnome.scm | 6 ++++++
>  1 file changed, 6 insertions(+)

Thanks for this!  One comment, though:

> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 31c5b0319c..ff4cb8a383 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -11336,6 +11336,12 @@ libraries.  Applications do not need to be recompiled--or even restarted.")
>                  (string-append (assoc-ref inputs "python-pygobject")
>                                 "/lib")))
>               #t))
> +         (add-after 'configure 'fix-ninja
> +           (lambda _
> +             ;; #43296: meson(?) incorrectly assumes we want to link
> +             ;;         this PIE against a static libselinux.
> +             (substitute* "build.ninja"
> +               (("libselinux\\.a") "libselinux.so"))))
>           (add-before 'check 'pre-check
>             (lambda _
>               (system "Xvfb :1 &")

This new phase should end by returning #t.

      Thanks,
        Mark

Message #17 received at 43296 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 43296 <at> debbugs.gnu.org
Subject: Re: bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build.
Date: Thu, 10 Sep 2020 20:23:53 +0200

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> As reported in #43296, gnome-builder tries to be linked against the static
> version of libselinux (propagated through glib/gio), failing to do so, as it
> also wants to be a PIE.  To keep the PIE, link it against the dynamic library.
> * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
> ---
>  gnu/packages/gnome.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 31c5b0319c..ff4cb8a383 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -11336,6 +11336,12 @@ libraries.  Applications do not need to be recompiled--or even restarted.")
>                  (string-append (assoc-ref inputs "python-pygobject")
>                                 "/lib")))
>               #t))
> +         (add-after 'configure 'fix-ninja
> +           (lambda _
> +             ;; #43296: meson(?) incorrectly assumes we want to link
> +             ;;         this PIE against a static libselinux.
> +             (substitute* "build.ninja"
> +               (("libselinux\\.a") "libselinux.so"))))

Please end the phase on #t, because “substitute*” has no specified
return value.

Other than that it looks good to me, thanks!

-- 
Ricardo

Message #20 received at 43296 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: 43296 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Fix gnome-builder build.
Date: Thu, 10 Sep 2020 20:26:10 +0200

As reported in #43296, gnome-builder tries to be linked against the static
version of libselinux (propagated through glib/gio), failing to do so, as it
also wants to be a PIE.  To keep the PIE, link it against the dynamic library.
* gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
---
 gnu/packages/gnome.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 31c5b0319c..bc8e28becf 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11336,6 +11336,13 @@ libraries.  Applications do not need to be recompiled--or even restarted.")
                 (string-append (assoc-ref inputs "python-pygobject")
                                "/lib")))
              #t))
+         (add-after 'configure 'fix-ninja
+           (lambda _
+             ;; #43296: meson(?) incorrectly assumes we want to link
+             ;;         this PIE against a static libselinux.
+             (substitute* "build.ninja"
+               (("libselinux\\.a") "libselinux.so"))
+             #t))
          (add-before 'check 'pre-check
            (lambda _
              (system "Xvfb :1 &")
-- 
2.28.0

Message #25 received at 43296-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 43296-done <at> debbugs.gnu.org
Subject: Re: bug#43296: [PATCH] gnu: Fix gnome-builder build.
Date: Sat, 31 Oct 2020 12:56:33 -0400

On Thu, Sep 10, 2020 at 08:26:10PM +0200, Leo Prikler wrote:
> As reported in #43296, gnome-builder tries to be linked against the static
> version of libselinux (propagated through glib/gio), failing to do so, as it
> also wants to be a PIE.  To keep the PIE, link it against the dynamic library.
> * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.

Thanks! I tweaked the commit message and pushed as
9c69fec08e286f7486e64c2aa3110fa34974d15d

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.