GNU bug report logs - #43320
Add emacs-html-to-hiccup package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43320 in the body.
You can then email your comments to 43320 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Dowell <jesse.dowell <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Add emacs-html-to-hiccup package
Date: Thu, 10 Sep 2020 16:43:18 -0400

[Message part 1 (text/plain, inline)]

Hello,

I'm hoping the following patch can be useful for others. It's a package for
emacs-html-to-hiccup which can be very handy when working with clojure
programs that use hiccup syntax.

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ff043463cc..253e51a79c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24550,4 +24550,29 @@ publically-accessible HTTP server.")
 label references and citations in LaTeX.  It is based on RefTeX, which is
 included with Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-html-to-hiccup
+  (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1")
+        (revision "0"))
+    (package
+      (name "emacs-html-to-hiccup")
+      (version (git-version "20190909" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/plexus/html-to-hiccup")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
"1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+     `(("dash" ,emacs-dash)
+       ("s" ,emacs-s)))
+      (home-page "https://github.com/plexus/html-to-hiccup")
+      (synopsis "Emacs package that turns HTML into Hiccup syntax")
+      (description
+       "Emacs package that turns HTML into Hiccup syntax, a notation
popular
+when doing Clojure/ClojureScript web development.")
+      (license license:mpl2.0))))
--8<---------------cut here---------------end--------------->8---

Best,
Jesse

[Message part 2 (text/html, inline)]

Message #8 received at 43320 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jesse Dowell <jesse.dowell <at> gmail.com>
Cc: 43320 <at> debbugs.gnu.org
Subject: Re: [bug#43320] Add emacs-html-to-hiccup package
Date: Wed, 16 Sep 2020 22:04:34 +0200

Hello,

Jesse Dowell <jesse.dowell <at> gmail.com> writes:

> I'm hoping the following patch can be useful for others. It's a package for
> emacs-html-to-hiccup which can be very handy when working with clojure
> programs that use hiccup syntax.

Thank you.

Could you send the patch with "git format-patch" or "git send-email" ?
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ff043463cc..253e51a79c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -24550,4 +24550,29 @@ publically-accessible HTTP server.")
>  label references and citations in LaTeX.  It is based on RefTeX, which is
>  included with Emacs.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-html-to-hiccup
> +  (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1")
> +        (revision "0"))

Could you add a comment explaining why we provide a non-released version
(here because there is no release anyway).
> +    (package
> +      (name "emacs-html-to-hiccup")
> +      (version (git-version "20190909" revision commit))

It should be version "1.0" according to keyword in main file.
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/plexus/html-to-hiccup")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp"))))

Could you move the string on the line above ?

> +      (build-system emacs-build-system)
> +      (propagated-inputs
> +     `(("dash" ,emacs-dash)
> +       ("s" ,emacs-s)))

There is an indentation issue here.

> +      (home-page "https://github.com/plexus/html-to-hiccup")
> +      (synopsis "Emacs package that turns HTML into Hiccup syntax")

It could be

  "Turn HTML into Hiccup syntax"

> +      (description
> +       "Emacs package that turns HTML into Hiccup syntax, a notation
> popular
> +when doing Clojure/ClojureScript web development.")

The description should be comprised of full sentences. Calling "guix
lint" on your definition should report it. Here, it could be:

   This Emacs package turns HTML...

> +      (license license:mpl2.0))))

LICENSE file is mpl2.0, but the Elisp library has GPL3+ headers. Maybe
you should add a comment about it.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 43320 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Dowell <jesse.dowell <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 43320 <at> debbugs.gnu.org
Subject: Re: [bug#43320] Add emacs-html-to-hiccup package
Date: Sat, 19 Sep 2020 11:03:32 -0400

[Message part 1 (text/plain, inline)]

On Wed, Sep 16, 2020 at 4:04 PM Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
wrote:

> Hello,
>
> Jesse Dowell <jesse.dowell <at> gmail.com> writes:
>
> > I'm hoping the following patch can be useful for others. It's a package
> for
> > emacs-html-to-hiccup which can be very handy when working with clojure
> > programs that use hiccup syntax.
>
> Thank you.
>
> Could you send the patch with "git format-patch" or "git send-email" ?
> >
> > --8<---------------cut here---------------start------------->8---
> > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> > index ff043463cc..253e51a79c 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -24550,4 +24550,29 @@ publically-accessible HTTP server.")
> >  label references and citations in LaTeX.  It is based on RefTeX, which
> is
> >  included with Emacs.")
> >      (license license:gpl3+)))
> > +
> > +(define-public emacs-html-to-hiccup
> > +  (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1")
> > +        (revision "0"))
>
> Could you add a comment explaining why we provide a non-released version
> (here because there is no release anyway).
> > +    (package
> > +      (name "emacs-html-to-hiccup")
> > +      (version (git-version "20190909" revision commit))
>
> It should be version "1.0" according to keyword in main file.
> > +      (source
> > +       (origin
> > +         (method git-fetch)
> > +         (uri (git-reference
> > +               (url "https://github.com/plexus/html-to-hiccup")
> > +               (commit commit)))
> > +         (file-name (git-file-name name version))
> > +         (sha256
> > +          (base32
> > "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp"))))
>
> Could you move the string on the line above ?
>
> > +      (build-system emacs-build-system)
> > +      (propagated-inputs
> > +     `(("dash" ,emacs-dash)
> > +       ("s" ,emacs-s)))
>
> There is an indentation issue here.
>
> > +      (home-page "https://github.com/plexus/html-to-hiccup")
> > +      (synopsis "Emacs package that turns HTML into Hiccup syntax")
>
> It could be
>
>   "Turn HTML into Hiccup syntax"
>
> > +      (description
> > +       "Emacs package that turns HTML into Hiccup syntax, a notation
> > popular
> > +when doing Clojure/ClojureScript web development.")
>
> The description should be comprised of full sentences. Calling "guix
> lint" on your definition should report it. Here, it could be:
>
>    This Emacs package turns HTML...
>
> > +      (license license:mpl2.0))))
>
> LICENSE file is mpl2.0, but the Elisp library has GPL3+ headers. Maybe
> you should add a comment about it.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
>

Thanks for the feedback. I've attached a patch that incorporates all of
your suggestions.

Best,
Jesse

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-html-to-hiccup.patch (text/x-patch, attachment)]

Message #16 received at 43320-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jesse Dowell <jesse.dowell <at> gmail.com>
Cc: 43320-done <at> debbugs.gnu.org
Subject: Re: [bug#43320] Add emacs-html-to-hiccup package
Date: Tue, 22 Sep 2020 11:48:18 +0200

Hello,

Jesse Dowell <jesse.dowell <at> gmail.com> writes:

> Subject: [PATCH] gnu: Add emacs-html-to-hiccup.

I tweaked the commit message and applied your patch. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.