GNU bug report logs - #43328
[PATCH] Make ERC desktop notifications lenient to invalid XML

Previous Next

Package: emacs;

Reported by: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>

Date: Fri, 11 Sep 2020 09:43:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43328 in the body.
You can then email your comments to 43328 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#43328; Package emacs. (Fri, 11 Sep 2020 09:43:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 11 Sep 2020 09:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make ERC desktop notifications lenient to invalid XML
Date: Fri, 11 Sep 2020 11:41:54 +0200

[Message part 1 (text/plain, inline)]
Hi,

Currently, ‘erc-notifications-notify’ signals an error if the message
contains invalid XML characters.  These characters can be either either
IRC control codes (e.g., ^B for bold text or ^C6,12 for colored text) or
just plain invalid data.

This patch changes the behavior so that they are stripped instead.  To
test, try sending yourself a message such as

   /msg <nick> ^BHi!

where <nick> is your own nick.  The current version will signal an error
whereas this patch won’t.

The proposed patch is attached to this message.


[0001-Make-ERC-desktop-notifications-lenient-to-invalid-XM.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
Best regards,
Dario

-- 
dario.gjorgjevski <at> gmail.com :: +49 1525 8666837
%   gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \
\`>     --recv-keys '744A4F0B4F1C9371'
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#43328; Package emacs. (Thu, 15 Oct 2020 15:50:01 GMT) Full text and rfc822 format available.

Message #8 received at 43328 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Cc: 43328 <at> debbugs.gnu.org
Subject: Re: bug#43328: [PATCH] Make ERC desktop notifications lenient to
 invalid XML
Date: Thu, 15 Oct 2020 17:49:11 +0200

Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com> writes:

> The proposed patch is attached to this message.

Looks like this patch was applied to Emacs 28 about a month ago, but
apparently I neglected to tell the patch submitter.  Sorry.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 15 Oct 2020 15:50:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 43328 <at> debbugs.gnu.org and Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 15 Oct 2020 15:50:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 13 Nov 2020 12:24:08 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 158 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.