GNU bug report logs - #43338
[PATCH] gnu: Add ripmime.

Previous Next

Package: guix-patches;

Reported by: Sébastien Lerique <sl <at> eauchat.org>

Date: Fri, 11 Sep 2020 14:22:03 UTC

Severity: normal

Tags: patch

Merged with 43399

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43338 in the body.
You can then email your comments to 43338 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#43338; Package guix-patches. (Fri, 11 Sep 2020 14:22:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Sébastien Lerique <sl <at> eauchat.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 11 Sep 2020 14:22:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sébastien Lerique <sl <at> eauchat.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add ripmime.
Date: Fri, 11 Sep 2020 15:54:06 +0200
* gnu/packages/mail.scm (ripmime): New variable.
---
gnu/packages/mail.scm | 44 
+++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 7af7e8a8d7..48e9a11522 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -627,6 +627,50 @@ Extension (MIME).")
               (base32
                "0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi"))))))

+(define-public ripmime
+  (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9")
+        (revision "1"))
+    (package
+      (name "ripmime")
+      (version (git-version "1.4.0.10" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/inflex/ripMIME")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+ 
"1z8ar8flvkd9q3ax4x28sj5pyq8ykk5pq249y967lj2406lxparh"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           ;; Source has no configure script
+           (delete 'configure)
+           ;; Buildcodes make the build non-reproducible; remove 
them
+           (add-after 'unpack 'strip-buildcodes
+             (lambda _
+               (substitute* "generate-buildcodes.sh"
+                 (("`date \\+%s`") "0")
+                 (("`date`") "0")
+                 (("`uname -a`") "Guix"))))
+           ;; https://github.com/inflex/ripMIME/pull/16 makes 
`mkdir-p-bin-man unnecessary
+           (add-before 'install 'mkdir-p-bin-man
+             (lambda _
+               (mkdir-p (string-append (assoc-ref %outputs "out") 
"/bin"))
+               (mkdir-p (string-append (assoc-ref %outputs "out") 
"/man")))))
+         ;; Makefile has no tests
+         #:tests? #f
+         #:make-flags (list (string-append "LOCATION=" (assoc-ref 
%outputs "out"))
+                            "CC=gcc")))
+      (synopsis "Extract attachments from MIME-encoded email")
+      (description
+       "ripMIME is a small program which is used to extract the 
attached files
+out of a MIME-encoded email package.")
+      (home-page "https://github.com/inflex/ripMIME")
+      (license license:bsd-3))))
+
(define-public bogofilter
  (package
    (name "bogofilter")
--
2.28.0

---

Hello Guix!

This is my first contribution -- please let me know if things 
should be adapted!

Cheers,
Sébastien




Information forwarded to guix-patches <at> gnu.org:
bug#43338; Package guix-patches. (Sun, 13 Sep 2020 21:17:02 GMT) Full text and rfc822 format available.

Message #8 received at 43338 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sébastien Lerique <sl <at> eauchat.org>
Cc: 43338 <at> debbugs.gnu.org
Subject: Re: [bug#43338] [PATCH] gnu: Add ripmime.
Date: Sun, 13 Sep 2020 23:16:33 +0200
Hello Sébastien!

Sébastien Lerique <sl <at> eauchat.org> skribis:

> * gnu/packages/mail.scm (ripmime): New variable.
> ---
> gnu/packages/mail.scm | 44
> +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)

Looks like your mail client mangled the patch.  Could you send it as an
attachment or using ‘git send-email’?  (See <https://git-send-email.io/>
for a tutorial.)

> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 7af7e8a8d7..48e9a11522 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -627,6 +627,50 @@ Extension (MIME).")
>                (base32
>                 "0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi"))))))
>
> +(define-public ripmime
> +  (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9")
> +        (revision "1"))
> +    (package
> +      (name "ripmime")
> +      (version (git-version "1.4.0.10" revision commit))

In general we provide released versions, unless there’s a good reason to
pick a development snapshot.  If it falls in this category, could you
add a short comment above the commit ID explaining why?

> +           (add-after 'unpack 'strip-buildcodes
> +             (lambda _
> +               (substitute* "generate-buildcodes.sh"
> +                 (("`date \\+%s`") "0")
> +                 (("`date`") "0")
> +                 (("`uname -a`") "Guix"))))

Please return #t at the end of the phase (it’s a convention).

> +           ;; https://github.com/inflex/ripMIME/pull/16 makes
> `mkdir-p-bin-man unnecessary
> +           (add-before 'install 'mkdir-p-bin-man
> +             (lambda _
> +               (mkdir-p (string-append (assoc-ref %outputs "out")
> "/bin"))
> +               (mkdir-p (string-append (assoc-ref %outputs "out")
> "/man")))))

Likewise.

> +      (synopsis "Extract attachments from MIME-encoded email")
> +      (description
> +       "ripMIME is a small program which is used to extract the
> attached files

s/which is used//g

> +out of a MIME-encoded email package.")

Could you send an updated patch?

Thanks for this first contribution! :-)

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#43338; Package guix-patches. (Mon, 14 Sep 2020 15:48:02 GMT) Full text and rfc822 format available.

Message #11 received at 43338 <at> debbugs.gnu.org (full text, mbox):

From: Sébastien Lerique <sl <at> eauchat.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 43338 <at> debbugs.gnu.org
Subject: Re: [bug#43338] [PATCH] gnu: Add ripmime.
Date: Mon, 14 Sep 2020 10:59:15 +0200
Hello,

On 13 Sep 2020 at 23:16, Ludovic Courtès <ludo <at> gnu.org> wrote:

> Could you send an updated patch?

Thanks for the quick (and newcomer-friendly) feedback! The v2 I 
just submitted hopefully fixes all the issues.

> Thanks for this first contribution! :-)

Pretty excited as it's my first packaging experience anywhere.

Sébastien




Merged 43338 43399. Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 14 Sep 2020 19:41:01 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 13 Oct 2020 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 166 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.