GNU bug report logs - #43342
[PATCH 0/3] Fix #43303 GCC package name

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43342 in the body.
You can then email your comments to 43342 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/3] Fix #43303 GCC package name
Date: Fri, 11 Sep 2020 18:06:12 +0200

Dear,

As described in #43303 [1], the package gcc-toolchain providing the complete
GCC compilation toolchain is not easy to reach; even the manual has a
dedicated section [2].

Commit f17e1802ec325e5cc86d4908f05ac69aafdf39da fixes:

  guix install gcc

which will install instead gcc-toolchain, the expected compilation package.


However, there are still discoverability issues, e.g.,

  guix search gcc | recsel -C -P name | head

reports first the package libgccjit and second gccgo, which have both too
general synopsis and description.  The 2 first patches try to improve the
situation.

Then, because the file gnu/packages/gcc.scm exists and the relevance scoring
function weights the filename too, the query "guix search gcc" artificially
ranks first libgccjit and gccgo.  Therefore the third patch fixes this
corner-case.

[1] http://issues.guix.gnu.org/issue/43303
[2] https://guix.gnu.org/manual/devel/en/guix.html#The-GCC-toolchain

All the best,
simon

zimoun (3):
  gnu: libgccjit: Reword synopsis and description.
  gnu: gccgo: Reword synopsis and description.
  gnu: gcc-toolchain: Reword description.

 gnu/packages/commencement.scm |  3 ++-
 gnu/packages/gcc.scm          | 20 ++++++++++++++++++--
 2 files changed, 20 insertions(+), 3 deletions(-)


base-commit: 1c87536287837c19b6a7d0b5df43fdcab7e5a26e
-- 
2.28.0

Message #8 received at 43342 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 43342 <at> debbugs.gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 1/3] gnu: libgccjit: Reword synopsis and description.
Date: Fri, 11 Sep 2020 18:07:58 +0200

Fixes <https://bugs.gnu.org/43303>.
Reported by Jeffrey Walton <noloader <at> gmail.com>.

* gnu/packages/gcc.scm: (libgccjit)[synopsis,description]: Reword.
---
 gnu/packages/gcc.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
index a39ac3b84c..c74477aed9 100644
--- a/gnu/packages/gcc.scm
+++ b/gnu/packages/gcc.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2018, 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020 Joseph LaFreniere <joseph <at> lafreniere.xyz>
 ;;; Copyright © 2020 Guy Fleury Iteriteka <gfleury <at> disroot.org>
+;;; Copyright © 2020 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -759,7 +760,16 @@ as the 'native-search-paths' field."
                (for-each delete-file
                          (find-files (string-append (assoc-ref outputs "out") "/bin")
                                      ".*(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)"))
-               #t))))))))
+               #t))))))
+    (synopsis "GCC library generating machine code on-the-fly at runtime")
+    (description
+     "This package is part of the GNU Compiler Collection and provides an
+embeddable library for generating machine code on-the-fly at runtime.  This
+shared library can then be dynamically-linked into bytecode interpreters and
+other such programs that want to generate machine code on-the-fly at run-time.
+It can also be used for ahead-of-time code generation for building standalone
+compilers.  The just-in-time (jit) part of the name is now something of a
+misnomer.")))
 
 
 (define-public gccgo-4.9
-- 
2.28.0

Message #11 received at 43342 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 43342 <at> debbugs.gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 2/3] gnu: gccgo: Reword synopsis and description.
Date: Fri, 11 Sep 2020 18:07:59 +0200

Fixes <https://bugs.gnu.org/43303>.
Reported by Jeffrey Walton <noloader <at> gmail.com>.

* gnu/packages/gcc.scm: (gccgo-4.9): Add synopsis and description
---
 gnu/packages/gcc.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
index c74477aed9..4d5aaa7070 100644
--- a/gnu/packages/gcc.scm
+++ b/gnu/packages/gcc.scm
@@ -773,7 +773,13 @@ misnomer.")))
 
 
 (define-public gccgo-4.9
-  (custom-gcc gcc-4.9 "gccgo" '("go")
+  (custom-gcc (package
+                (inherit gcc-4.9)
+                (synopsis "Go frontend to GCC")
+                (description
+                 "This package is part of the GNU Compiler Collection and
+provides the GNU compiler for the Go programming language."))
+              "gccgo" '("go")
               %generic-search-paths
               ;; Suppress the separate "lib" output, because otherwise the
               ;; "lib" and "out" outputs would refer to each other, creating
-- 
2.28.0

Message #14 received at 43342 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 43342 <at> debbugs.gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 3/3] gnu: gcc-toolchain: Reword description.
Date: Fri, 11 Sep 2020 18:08:00 +0200

* gnu/packages/commencement.scm (make-gcc-toolchain)[description]: Reword.
---
 gnu/packages/commencement.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index cc86d06c65..565799c611 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -3861,7 +3861,8 @@ COREUTILS-FINAL vs. COREUTILS, etc."
       (description
        "This package provides a complete GCC tool chain for C/C++ development to
 be installed in user profiles.  This includes GCC, as well as libc (headers and
-binaries, plus debugging symbols in the @code{debug} output), and Binutils.")
+binaries, plus debugging symbols in the @code{debug} output), and Binutils.  GCC
+is the GNU Compiler Collection.")
       (home-page "https://gcc.gnu.org/")
       (outputs '("out" "debug" "static"))
 
-- 
2.28.0

Message #19 received at 43342-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 43342-done <at> debbugs.gnu.org
Subject: Re: [bug#43342] [PATCH 0/3] Fix #43303 GCC package name
Date: Sun, 13 Sep 2020 23:12:38 +0200

Hi zimoun,

zimoun <zimon.toutoune <at> gmail.com> skribis:

>   gnu: libgccjit: Reword synopsis and description.
>   gnu: gccgo: Reword synopsis and description.
>   gnu: gcc-toolchain: Reword description.

Applied all 3 patches.  We’re doing SEO!  :-)

Thanks,
Ludo’.

Message #22 received at 43342-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 43342-done <at> debbugs.gnu.org
Subject: Re: [bug#43342] [PATCH 0/3] Fix #43303 GCC package name
Date: Mon, 14 Sep 2020 12:40:24 +0200

Hi,

Thank you for the quick review. :-)

On Sun, 13 Sep 2020 at 23:12, Ludovic Courtès <ludo <at> gnu.org> wrote:

> Applied all 3 patches.  We’re doing SEO!  :-)

Yeah! :-)
Waiting for improvement of 'relevance'... my long overdue.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.