GNU bug report logs - #43346
Poezio

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43346 in the body.
You can then email your comments to 43346 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: dannym <at> scratchpost.org
Subject: Poezio
Date: Fri, 11 Sep 2020 14:26:07 -0400

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patches to add Poezio into Guix.

Regards,
RG.

[0001-gnu-Add-python-slixmpp.patch (text/x-patch, attachment)]

[0002-gnu-Add-python-potr.patch (text/x-patch, attachment)]

[0003-gnu-Add-poezio.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 43346 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 43346 <at> debbugs.gnu.org
Subject: Poezio (Revised Patches)
Date: Fri, 11 Sep 2020 14:36:22 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-python-slixmpp.patch (text/x-patch, attachment)]

[0002-gnu-Add-python-potr.patch (text/x-patch, attachment)]

[0003-gnu-Add-poezio.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #13 received at 43346-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 43346-done <at> debbugs.gnu.org
Subject: Re: [bug#43346] Poezio (Revised Patches)
Date: Sat, 12 Sep 2020 02:41:31 +0200

[Message part 1 (text/plain, inline)]

Pushed to guix master with lots of changes to what are inputs, propagated-inputs
and native-inputs.

[Message part 2 (application/pgp-signature, inline)]

Message #16 received at 43346-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 43346-done <at> debbugs.gnu.org
Subject: Re: [bug#43346] Poezio (Revised Patches)
Date: Sat, 12 Sep 2020 08:06:05 -0400

[Message part 1 (text/plain, inline)]

Hi Danny!

> Pushed to guix master with lots of changes to what are inputs, propagated-inputs
> and native-inputs.

Thanks so much.

I had to make some changes to poezio, based on your changes. Could you
push the attached patches please?

Regards,
RG.

[0085-gnu-poezio-Add-missing-dependencies.patch (text/x-patch, attachment)]

[0086-gnu-poezio-Propagated-certain-dependencies.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #19 received at 43346 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 43346 <at> debbugs.gnu.org
Subject: Re: [bug#43346] Poezio (Revised Patches)
Date: Sat, 12 Sep 2020 16:19:15 +0200

[Message part 1 (text/plain, inline)]

Hi RG,

On Sat, 12 Sep 2020 08:06:05 -0400
Raghav Gururajan <raghavgururajan <at> disroot.org> wrote:

> I had to make some changes to poezio, based on your changes. Could you
> push the attached patches please?

... why?

I've checked the source code of poezio and it does not use aiodns, aiohttp.

In order to find that out:

$ guix build python-aiodns

Check resulting directory to find 
/gnu/store/8bzk4dwhhbblz8gky9hzdnzjlsi1nk7v-python-aiodns-1.1.1/lib/python3.8/site-packages/aiodns/__init__.py

That means a user of the library would have to do 

  from aiodns import *

or

  import aiodns
.

So I grepped the whole source code of poezio, and it doesn't do that.  Hence
it is not a direct input.

It is a propagated-input in a dependency, which indeed does do the import.

You can't really trust what upstream says here.  Almost no package manager
has non-propagated inputs, so of course they wouldn't be saying "the input
such and such is propagated, and the input such and such is not propagated".

Thus you have to check it yourself.

Could you do so with the other dependencies before adding them?

Thanks.

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 43346 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 43346 <at> debbugs.gnu.org
Subject: Re: [bug#43346] Poezio (Revised Patches)
Date: Sat, 12 Sep 2020 10:22:00 -0400

[Message part 1 (text/plain, inline)]

Hi Danny!

> 
> ... why?
> 
> I've checked the source code of poezio and it does not use aiodns, aiohttp.
> 
> In order to find that out:
> 
> $ guix build python-aiodns
> 
> Check resulting directory to find 
> /gnu/store/8bzk4dwhhbblz8gky9hzdnzjlsi1nk7v-python-aiodns-1.1.1/lib/python3.8/site-packages/aiodns/__init__.py
> 
> That means a user of the library would have to do 
> 
>   from aiodns import *
> 
> or
> 
>   import aiodns
> .
> 
> So I grepped the whole source code of poezio, and it doesn't do that.  Hence
> it is not a direct input.
> 
> It is a propagated-input in a dependency, which indeed does do the import.
> 
> You can't really trust what upstream says here.  Almost no package manager
> has non-propagated inputs, so of course they wouldn't be saying "the input
> such and such is propagated, and the input such and such is not propagated".
> 
> Thus you have to check it yourself.
> 
> Could you do so with the other dependencies before adding them?

Hmm. When I grep the source, they were mentioned in requirements.txt and
requirements-plugins.txt. Also, the setup.py has install_requires and
plugins_require sections, which are similar to required section in .pc
files right?

Regards,
RG.

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.