GNU bug report logs - #43412
[FEATURE] autorevert-only-if-visible [PATCH]

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Boruch Baum <boruch_baum@HIDDEN>; Keywords: patch; dated Tue, 15 Sep 2020 04:08:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 29 Sep 2020 14:46:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 29 10:46:12 2020
Received: from localhost ([127.0.0.1]:56877 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kNGtO-0006t3-MY
	for submit <at> debbugs.gnu.org; Tue, 29 Sep 2020 10:46:12 -0400
Received: from eggs.gnu.org ([209.51.188.92]:52770)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1kNGtI-0006jN-DE
 for 43412 <at> debbugs.gnu.org; Tue, 29 Sep 2020 10:46:06 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38631)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1kNGtC-0002c1-CX; Tue, 29 Sep 2020 10:45:58 -0400
Received: from [176.228.60.248] (port=4089 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1kNGtB-00086Z-RQ; Tue, 29 Sep 2020 10:45:58 -0400
Date: Tue, 29 Sep 2020 17:45:48 +0300
Message-Id: <83v9fwk5er.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20200929130520.fub7arg7ifmgzmec@HIDDEN> (message
 from Boruch Baum on Tue, 29 Sep 2020 09:05:20 -0400)
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
 <83een37y21.fsf@HIDDEN>
 <20200916201104.ktl6aukmpe5hk6g2@HIDDEN>
 <83a6xo7dgv.fsf@HIDDEN>
 <f28c7617-f546-2689-5280-08c14629db24@HIDDEN>
 <20200929130520.fub7arg7ifmgzmec@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43412
Cc: rudalics@HIDDEN, 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 29 Sep 2020 09:05:20 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>, 43412 <at> debbugs.gnu.org
> 
> Slightly off-topic: The 'describe-*' output for these symbols all have
> an ambiguous statement "Probably introduced at or before Emacs version
> 27.1". What's that 'probably' all about? Shouldn't the statement be
> unequivocal, at least for recently added symbols?

The code which determines that uses some heuristics that can fail.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 29 Sep 2020 14:34:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 29 10:34:19 2020
Received: from localhost ([127.0.0.1]:56820 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kNGhv-0005a4-LY
	for submit <at> debbugs.gnu.org; Tue, 29 Sep 2020 10:34:19 -0400
Received: from mout.gmx.net ([212.227.17.21]:44341)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1kNGhs-0005Zn-5t
 for 43412 <at> debbugs.gnu.org; Tue, 29 Sep 2020 10:34:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1601390049;
 bh=MMFFG+rp9G3RKkNsZBIMG585NssnyofuuI640+oTtzw=;
 h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
 b=QjSDFSKmZy0oLscpgTGljBxkoSrWO5IokFAg++e63elylwlJuQTmYJZVhGB/4v9WA
 8Peiyg+OmEa/aFMqtPOIfByNS4fQ2S79nfFinZ1mm/XnaAhzE2Kvj9QjKBjWusvx7t
 1S05e+2NHao/c5wJDtwxFmH6T/Jgl8FpCn3JPD3s=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.101] ([46.125.249.51]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MLi8m-1k5bIP1OOO-00Hfbb; Tue, 29
 Sep 2020 16:34:09 +0200
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
To: Boruch Baum <boruch_baum@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
 <83een37y21.fsf@HIDDEN>
 <20200916201104.ktl6aukmpe5hk6g2@HIDDEN>
 <83a6xo7dgv.fsf@HIDDEN> <f28c7617-f546-2689-5280-08c14629db24@HIDDEN>
 <20200929130520.fub7arg7ifmgzmec@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <cf74f1f2-d895-a9e6-fd9b-6b7885e0140f@HIDDEN>
Date: Tue, 29 Sep 2020 16:34:07 +0200
MIME-Version: 1.0
In-Reply-To: <20200929130520.fub7arg7ifmgzmec@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:SZ5f1xKmJiVEiKWhq0df0oTsDyMfovA92Y0vdqq9vk3CJnk9SG/
 oIzNvGOh5PSWngWBc1ckXG6YQx/Gt+bJWDvTf3g/e972jmRFec0tUYVVw/Yu2B1NsccOC+E
 7MGLyswH0/W6J6reZri4TCYBFIBu2YFKEon/I2d+6E99UB4Pd+ZtHjLuX/07AvLvXa7cdEM
 uQHvVB/aCX1tGzN1Mr2Qg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:ZH4w484pEhI=:lXTfK4f2SEQ6Z0OkkF5uk1
 TS9dUCKeQ1IDsusy4wvAjWDvLQD7kDynRWissN9X34DAUIZzTCw9EtHNPgJHLvF1/ybpjzD8j
 huVFLOpiiMuNcxHUWIvx3VIMt1vu1Q4uo5YiLh53FxSFp5zrZpV9qL59pAfErX/QTCNM3+nPT
 12XJU6gbnKbEHGrWmz8RL8hsw9UfARQUN763a+xak1z1poEWIOckbW32PhFUa19t7HRHX+mfe
 O9zWpfqNqGv+mMV98o1ovVLsqitmAykc16HBfL6Kb5AEhZrUWzB21xy7Ji9WwDgGTM0uroCrx
 7IZ/qwdBFZjsBg0tHZCa/PlDm4aiXHQeJsWQs+SELCT+GmsABT9TqHbEtGnqJH5LO/Q/7xMJ8
 zpeQU1/YJlwZVlakT4wlzjFoEhrSv/FrxKieqiTL334IOeEaK8hhDaQqEI7lF0jjC+8Cz7N2R
 avajLqqWF88XUK8FBj15XOKvitcJbNhh0qjoSeNtOcA9Bv0DL0//rib93HusovUYrYGpC3eNn
 /n3ebBMwbSxzAG+aEaYAzIcPg92dpWsbSWjXazr4meeX2uj7o7qYNWwFncDfKAXrh9p0W0+9v
 mer9RM2d1QbGwyp1pzj4eLRrfABcXW2FiJKOYGj3+EXjZtxJIfo1zC4RQvb0Rm9GMb09Q7liU
 omwr/ivZsSYkAOT57UyIfj+6/flWm/mtzoGD69dug8ksRYrQ4proHvJ23kIV8++mvfreXdILe
 Gky4TkIwJtv3fyYyhtDrHLgZcL3s7D/DkI8dHuqV6sv39kJ3om0RjbqUyrOcZaUwwZco44Tn4
 g4dS8qDM9uMREMOuOshQtUAZvpzXN7dORtY9+RyRji72aFAz7+ZPaUXZkW5iVIVD1CRcCZyn4
 OxabaNvA0g9gpWFnhfNZ1OtAWU9fYyAqlGxgUJ8pRGC0rOorZD7hGQYSnHgabGENWSeDy3Bg4
 5RL++s4gP6cJcPujAQzkfbnPq0s8HbTvZm0QxWJVE1WkX88AEOxLPGlfpIZ743vuAiooz503A
 xRTbaT8Rl8146L9ZOfpa6JH03iYeJ3IyNwY6lksi/9sxvNMO9E50maZbmdNWbSR5xKNKOcBk+
 YHYwVwJ7HPjFI7eZiC1+dQU2lBBcC0/tlF+Sgk4ib0cz3r3erFxc+YFCkDlW++aAHrjsKhI/j
 kkVkyRyswRe9TMZWI2IzGnIKYQ99vXkL8cuXkkFm5jkUbh+N4jWyleSPoaH6JCxArDbQdwNnh
 P9gMxfvNSzu0rKZpDW8UUzujlWCnVZ2g2CDfT/w==
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 43412
Cc: Eli Zaretskii <eliz@HIDDEN>, 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

 > 1) For function `window-buffer-change-functions' when set globally: th=
e
 > docstring says that it takes an arg FRAME. During execution of those
 > functions, will that arg necessarily be `(selected-frame)'?

No.  FRAME denotes the frame where a buffer change occurred.

 > 2) For function `window-buffer-change-functions' when set buffer-local=
:
 > Is there a straightforward way to ensure that the value will be set fo=
r
 > all buffers, current and future?

No.  The term 'buffer-local' contradicts the formulation "for all
buffers".  If you want to catch changes for several buffers, you either
have to specify the buffer-local value for each of them or you have to
use the default value.

 > This would be subtly different from the
 > description of what occurs when setting the value globally, because no=

 > window-walk would be required, and it wouldn't be triggered by window
 > deletion events.

Window deletion events as well as events that remove a buffer from a
window are caught by the default value only.  Note in this context that
'window-old-buffer' might not even return a meaningful value if the old
buffer has been deleted in the meantime.

 > All I see is `buffer-list-update-hook' which is run by
 > `get-buffer-create' (OK), but it's also run by =E2=80=98make-indirect-=
buffer=E2=80=99,
 > =E2=80=98rename-buffer=E2=80=99, =E2=80=98kill-buffer=E2=80=99, =E2=80=
=98bury-buffer-internal=E2=80=99 and
 > =E2=80=98select-window=E2=80=99 (all unnecessary for setting a buffer-=
local value in
 > `window-buffer-change-functions').

Note that 'buffer-list-update-hook' is run in many locations that are
not related to window changes.

 > Slightly off-topic: The 'describe-*' output for these symbols all have=

 > an ambiguous statement "Probably introduced at or before Emacs version=

 > 27.1". What's that 'probably' all about? Shouldn't the statement be
 > unequivocal, at least for recently added symbols?

Emacs might be just cautious here.  It it finds a definition in version
27.1 and not in version 26.1, it doesn't want to deny that the variable
might have already existed in version 22.1 and was temporarily deleted
in version 25.1.

martin





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 29 Sep 2020 13:05:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 29 09:05:32 2020
Received: from localhost ([127.0.0.1]:55183 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kNFK0-00076c-H9
	for submit <at> debbugs.gnu.org; Tue, 29 Sep 2020 09:05:32 -0400
Received: from mout.gmx.net ([212.227.17.22]:49619)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kNFJy-00076N-NE
 for 43412 <at> debbugs.gnu.org; Tue, 29 Sep 2020 09:05:31 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1601384724;
 bh=fxgwf0JBCDwa7dL6f4bGD9ntAg6QqFy3uEUDIV/F4mw=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=ahppvkXYyCUUFAZBUKbeCwWqV+apwEFOQvICY5mAEmVNjUK7SUFsmdTy2xwK5i/uB
 Tw3czVv/ReXpsTYfGdh4OgmqoKt5OaGdJwFKtGFrFFT043Fngf2/Fk4WgHFg/Z3M/Z
 AqlnEiiKaq9YcLuOsI8mOZM+1FatHU+Svcq1fMWY=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1MEV3C-1kBejx3opm-00G0Bq; Tue, 29 Sep 2020 15:05:24 +0200
Date: Tue, 29 Sep 2020 09:05:20 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Message-ID: <20200929130520.fub7arg7ifmgzmec@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
 <83een37y21.fsf@HIDDEN>
 <20200916201104.ktl6aukmpe5hk6g2@HIDDEN>
 <83a6xo7dgv.fsf@HIDDEN>
 <f28c7617-f546-2689-5280-08c14629db24@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <f28c7617-f546-2689-5280-08c14629db24@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:oK9k43YrWfQ8nTrinJVtNVYmiiFlwG7sF34Dwmkpph+jn4cjf5l
 fF+FcCMVLtWwj6Ha0M4UZFknLIuvyJDSXJqLOb5tBg4GF7LhzfJZc95nKWcrDGiLUj4IWWT
 d4OPTn3LhosCZKUoSfWtyWK0IJDMnwFhaSHPptrvekzUr3+5wyH05wc0H5w0oWEqw9dwMpY
 l92rVbdFKC3Fj7jG4obiQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:DE6pRYYVE1U=:hBGOH72RrKGGQauF3MXoCd
 Zwb627QAzB+H4m1dLNYNwayTuJtU2DRSCjtQ2crxkK3i21gGh3FjASqFGNtSSqGUUt9WFAlz/
 gURdDHk8WGeqGC9++qrqMXPTyvcL/PL1Gc0NJp2RnjDpuXPlvBZPCnMfY7zSAtq8IXcIYfPsK
 /tjyuqLW7n3yW5iJkcVO0sAzGfdKZv1c5r20LhdiSiPiVued4fxr4biGS+8Skh5aFaPt12Lol
 Ea9erYQ9qULyqtrj9J63M6a+iUz9tLaUFQq6QtPcOcz6SC/kYOpVF//DkYalpJAM6DX6a2+IN
 acoR0M5GyGjxR1f0dtvgWfS25L8Uxo4WnGCaXhpr5FwV9uNENy0CjJJgwLf9iH+ZVDESCE+N0
 CdcsenDD8xaZD8Pl6OzFCURRVYSqSSYOtx5bTmjaZLhUSFSYk2QouCD+or8k87KR5RfEVX+93
 RBb8dbZ9mSaqlEiTnM9BwwGYM9AmIteJFYtG952j+dZMXNwLO5JjB32Cae26zGg8B68IfL1E5
 pGLaw8exTvQPcNjvetcohTW8yWa6egd8WPEFCANBDKNft8I0QbwApxtJQk5bbvEK2xrxZIuKS
 MR7c9GrAw3wsaIYgdabI9KY8Wb+oogu6fzD6WWqLdNE1pK8nqCfkziK+kcTd+q8ot+Ad1sGju
 W8FSxRvymcloLOgTzr35R4xhJDpBS48ZJe8x+EbWFMFKwudeqpdZ0CzQmUpZe1arnJxTufSyU
 3viAyBv9w7Gb1gIYJeVErnK0fjlUhADgp49tSMlu2teEhXQkrs8055a5FK1hLAZiiQs+luKBO
 CsjADHAWXyUWnp/SAfpW+9+cUEpPHZJ7rJ6GI7LkrFg3bhTIrS8WZXHNkh0QbxR/CVS2gBwho
 Q+/mtgKM7V0hbaSeSu339d5dw0SeH50gFKWWY9hOpV/vD3UHLU0xDYr2CkevDqg74vDr5y3gn
 iRRfb/cJAvErAtldaEBLpSArxEEtYwJA2N7iPO5l+uFJFh/LLR28o/U6M/5PUofzikKHFE7uV
 wHIHm45j1MvdJg6fE91XBatY2fRqpJZaASpnO2xAn8hLtsY0V5AKuyilINIoMKIQEvJOgovMq
 LsUIVtInBxTaxkdzMd9j6Nef0y7aERTxELt3STM7f8nL8W7AObrkmLA3fz+2N749axdQPBSvD
 FhQORFrByfnblkdLGnvxng17V/fF3QCffGPKciYYqXaBmO2TdRmw4fnUDnDfTL+fl3B/IXads
 c8hgntL2oad7KGaAoM8LbQ+2FUT6f7xlDOw24xA==
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: 43412
Cc: Eli Zaretskii <eliz@HIDDEN>, 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

On 2020-09-18 09:49, martin rudalics wrote:
> If you have any further questions, please ask.

Thanks for the informative response. None of the symbols you mentioned
are available in the emacs version I normally use, so they were all new
to me. I do have two follow-up questions that could save me some time:

1) For function `window-buffer-change-functions' when set globally: the
docstring says that it takes an arg FRAME. During execution of those
functions, will that arg necessarily be `(selected-frame)'?

2) For function `window-buffer-change-functions' when set buffer-local:
Is there a straightforward way to ensure that the value will be set for
all buffers, current and future? This would be subtly different from the
description of what occurs when setting the value globally, because no
window-walk would be required, and it wouldn't be triggered by window
deletion events. All I see is `buffer-list-update-hook' which is run by
`get-buffer-create' (OK), but it's also run by =E2=80=98make-indirect-buff=
er=E2=80=99,
=E2=80=98rename-buffer=E2=80=99, =E2=80=98kill-buffer=E2=80=99, =E2=80=98b=
ury-buffer-internal=E2=80=99 and
=E2=80=98select-window=E2=80=99 (all unnecessary for setting a buffer-loca=
l value in
`window-buffer-change-functions').

> When these added functions (probably it's one and the same function) are
> run, one can use 'window-old-buffer', 'frame-old-selected-window',
> 'old-selected-window' and 'old-selected-frame' to individually check
> what has changed since the last time.  For example, to find out whether
> a window on the frame reported by 'window-buffer-change-functions' has
> changed its buffer, 'walk-window-tree' for that frame with a function
> that checks whether 'window-buffer' for any such window differs from
> 'window-old-buffer'.  If it does differ, you probably want to check
> whether that buffer should be reverted.

> For 'window-selection-change-functions' you probably want to just check
> whether the buffer of the selected window of the reported frame should
> be reverted.  I would avoid using 'window-configuration-change-hook'
> because that hook also triggers when a window changed its size.  All
> hooks are described in detail in section "28.28 Hooks for Window
> Scrolling and Changes" of the Elisp manual.

Slightly off-topic: The 'describe-*' output for these symbols all have
an ambiguous statement "Probably introduced at or before Emacs version
27.1". What's that 'probably' all about? Shouldn't the statement be
unequivocal, at least for recently added symbols?

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 18 Sep 2020 07:49:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 18 03:49:45 2020
Received: from localhost ([127.0.0.1]:40711 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kJB9N-0006SE-1L
	for submit <at> debbugs.gnu.org; Fri, 18 Sep 2020 03:49:45 -0400
Received: from mout.gmx.net ([212.227.17.20]:48527)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1kJB9L-0006Ry-BY
 for 43412 <at> debbugs.gnu.org; Fri, 18 Sep 2020 03:49:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600415376;
 bh=4kZwAJH4Af1v9ElSBt/Ldfxa3zNvEfcHlzZ42pI9Zts=;
 h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
 b=Aelfn4TV4Unn592Qf8xg/g72qDrHWFEb318ubV6U1JsE4vWjjDuobkp8v0B2dtnTn
 HGCY2YlNMdHEPVgrDhlxoYZQ+W66YovdetZulaGzH8LpP/0hPjErHCX2OUotlAPDxk
 qEmFVUlVxsVupQax9lEinIf7RE422Xceh1oKAZ+g=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.101] ([46.125.249.44]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmDEm-1kjgDA2zui-00iAhM; Fri, 18
 Sep 2020 09:49:36 +0200
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
To: Eli Zaretskii <eliz@HIDDEN>, Boruch Baum <boruch_baum@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
 <83een37y21.fsf@HIDDEN>
 <20200916201104.ktl6aukmpe5hk6g2@HIDDEN>
 <83a6xo7dgv.fsf@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <f28c7617-f546-2689-5280-08c14629db24@HIDDEN>
Date: Fri, 18 Sep 2020 09:49:35 +0200
MIME-Version: 1.0
In-Reply-To: <83a6xo7dgv.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:pUb/KBIIabbdmRKkA3239GqGlPXIkPm8skzwq1Fskn2OhflqTRX
 ++LEKF8VB+Z3HGX5Qtm+46aoWiwMsLZmeGKRgIkzk/eRi9+/Y7h/Kf+fo4H+nyuIAhfd+3u
 1c9ivVihf19RQxF23xTd6KwSKVmev993dBVmGX8TWpFqmvMFKbl1iBVXmJJuqAzz8uBNupB
 ERsjPomAOngfUjug8gcVA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:QqaFV3ywkLI=:wxx3lBFSbzeoeRg6ketxNr
 dcm+59cVN5UUuFhDroXD3ixO7siUXwavBDHoHO2HArQKzX6kXteydbAW/TX0sYQJu6H80FGhp
 vqCgkf6JN7pw0+YWpZEL8e/xetF2IvhN9X9lwYrTxVGZT7+AZWxHHP2BjrCxsBZlRIddw7E0T
 aEIIyhWql8h5rBjhv4jNWXbP8Pa8SOyaqSAlbwEiMpVStReiFlzM373cSE+PgOrcLw29j98Pn
 AfQAPB+2uv3dWqpTQEI86CjEHw2v8cxzqffMn+xfVSlJQf47A/v4YIJQ/gs/AVSqqrVNczqay
 E+KwqjPVedBNm7bGb7Mzj9KfLn5Kh537KOnv66tzKfeVcpsA1BgT/gAP1oXX43Kp1aLez/f0m
 rKUB83Rh+Pk7rGERv/u4ckFBKWuxwRwk2vNNynmp6SoZeFXk/J50DMlY1aHZCT0XagVCTgq4U
 p22imWVoGAEcA4qV9Z5he+Q/X6snxoecwOEbe/bs+obK3R10JF88SGysGtl87Qz06eTSz4sKT
 SMdfYVSK6Q0MjysFxBUlGSfLx1MXeFRVdm8zv+GjRikhQ4D0ybi5+f8XN/L8CXZ8OiWmkDIYZ
 CksOe/puYPqvoEooYf2WLPtc1cwZdWPTvTIvlbbM5U0FweL+R4WdYzMW/MoR/rRmuWdTmVR5L
 tnOeJGHMrZhxDCWqzWqgtWaJ5/nCQjDnSsquaRQxsNw1hZf0DlelBzu1jluCuk0jM4u4QP08g
 OOtYVS1HhEF5UBijidAhLrbU27ymb1e+zj62w6AdQvWFsOb0GA2yHGfeIqjRXvbdYYvVILCaw
 7gu72Sm3nFkn4KxLYA1CpAwDYSk6gHHdFIQPPOM5aVrgCyIjFrR9uFjbdKYvQ1j+EnaC5DKyp
 2KZKuGoqHfHagdKMNOKlRHE4gz63/iC7fZY1rFJQLZn4E1wZKitGcHRaLGqVBCYZljdQh8mUB
 akoDBJv6647NBjahX2nIiLtUOlXdiK3zhchZxRlG7WkG2fl4tiFvJhnz4khzcoWwLRtlB2BBP
 Md2h06PPqyob38LBjr750pJz4LN4kUC+d5am/IQpHUozjB17qFAdK7kJ4J6qVhkaQjoqoCovr
 l20zsuz5d2jIQfy/7NNOcUfYcgHeu6TdOiqXkt0pt6HOSKyphUZIHxdBX8KmpLiqNJRDExk9b
 qjR0wQCMCKzotAbjI0y7qa+BbgLJFRvVkvVLrwzKvYxYqM+b5hdnSfOO2p2SRO8A1OYOolzGH
 F7fB3LRg7wYufaCwg
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 >> It looks to me like that's not the case: my testing seems to show that
 >> it does catch cases of changing a buffer displayed in a window but does
 >> not catch changes of frames due to functions like `other-frame' or
 >> `select-frame'.
 >>
 >> So, the good news is that I've written the code that makes the
 >> improvement for the caught cases, and I can submit that.
 >>
 >> As for the cases of changing frames, a less-desirable option would be to
 >> preempt bug-reports by documenting the limitation. Auto-revert already
 >> has other curious limitations (eg. for dired buffers it doesn't operate
 >> _at__all_ on many types of file changes), and this limitation only
 >> introduces a delay, so by comparison its a pretty mild limitation.
 >
 > If we have no better way, we could document this as a limitation,
 > yes.  But let's make one more attempt to solve this.
 >
 >> A better option would be able to catch frame-change events. I haven't
 >> found a straightforward way to trap that. Does such a method exist?
 >
 > Can you describe the problematic case in more detail?  With that in
 > hand, perhaps Martin (CC'ed) could suggest a method.

 From what I've read so far, Baruch wants to react to two events only: A
window displays another buffer and a window gets selected, where the
latter subsumes anything like frame selection or switching, or a frame
getting focus.  The former should be handled by adding a function to
'window-buffer-change-functions'.  The latter should be handled by
adding a function to 'window-selection-change-functions'.

When these added functions (probably it's one and the same function) are
run, one can use 'window-old-buffer', 'frame-old-selected-window',
'old-selected-window' and 'old-selected-frame' to individually check
what has changed since the last time.  For example, to find out whether
a window on the frame reported by 'window-buffer-change-functions' has
changed its buffer, 'walk-window-tree' for that frame with a function
that checks whether 'window-buffer' for any such window differs from
'window-old-buffer'.  If it does differ, you probably want to check
whether that buffer should be reverted.

For 'window-selection-change-functions' you probably want to just check
whether the buffer of the selected window of the reported frame should
be reverted.  I would avoid using 'window-configuration-change-hook'
because that hook also triggers when a window changed its size.  All
hooks are described in detail in section "28.28 Hooks for Window
Scrolling and Changes" of the Elisp manual.  If you have any further
questions, please ask.

martin




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 18 Sep 2020 06:35:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 18 02:35:28 2020
Received: from localhost ([127.0.0.1]:40458 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kJ9zU-0004Nb-2I
	for submit <at> debbugs.gnu.org; Fri, 18 Sep 2020 02:35:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44374)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1kJ9zS-0004NO-H3
 for 43412 <at> debbugs.gnu.org; Fri, 18 Sep 2020 02:35:27 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56959)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1kJ9zM-0005QP-Bw; Fri, 18 Sep 2020 02:35:20 -0400
Received: from [176.228.60.248] (port=2115 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1kJ9zK-0007LB-KF; Fri, 18 Sep 2020 02:35:19 -0400
Date: Fri, 18 Sep 2020 09:35:31 +0300
Message-Id: <83h7rv618s.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20200917201049.jihclkumemv4mbhz@HIDDEN> (message
 from Boruch Baum on Thu, 17 Sep 2020 16:10:49 -0400)
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
 <83een37y21.fsf@HIDDEN>
 <20200916201104.ktl6aukmpe5hk6g2@HIDDEN>
 <83a6xo7dgv.fsf@HIDDEN>
 <20200917201049.jihclkumemv4mbhz@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43412
Cc: rudalics@HIDDEN, 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Thu, 17 Sep 2020 16:10:49 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: martin rudalics <rudalics@HIDDEN>, 43412 <at> debbugs.gnu.org
> 
> > Can you describe the problematic case in more detail?  With that in
> > hand, perhaps Martin (CC'ed) could suggest a method.
> 
> I'm needing now to focus on Rosh HaShanna preparations, and can let
> emacs distract me for the next few days, but from memory, on tty emacs:

So the problems you had were only with TTY frames?

> 1) touch ~/foo
> 
> 2) find it in emacs
> 
> 3) bury the frame so it's not human-visible
> 
>    3.1) OT: I find it useful to globally bind C-x 5 b to function
>         select-frame-by-name, because I do this routinely as part of my
>         workflow. Another option might be C-x 5 2.
> 
> 4) M-! echo "bar" >> ~/foo
> 
> 5) switch to the buried frame
> 
> 6) Depending upon your timing, you'll need to wait up to
>    auto-revert-interval seconds for the buffer to be updated.

Thanks.  Hopefully, Martin will be able to help us out here.

> It maybe could all be solved if there were a hook for frame change of
> state (eg. getting/losing focus, being raised/buried). It's surprising
> to me that such events were never thought significant enough in emacs to
> merit a hook.

We do have focus-in-hook and focus-out-hook, for starters.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 17 Sep 2020 20:11:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 17 16:11:01 2020
Received: from localhost ([127.0.0.1]:39199 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kJ0FA-0007VM-Sd
	for submit <at> debbugs.gnu.org; Thu, 17 Sep 2020 16:11:01 -0400
Received: from mout.gmx.net ([212.227.15.19]:47983)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kJ0F8-0007V9-V5
 for 43412 <at> debbugs.gnu.org; Thu, 17 Sep 2020 16:10:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600373452;
 bh=rsAa29aJEdmeE7jovVVgLheG9GvhY6fJwMv1+rSKq1c=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=XYQ6x5kzVe6fyGlOpgjQkkg2DjUrQnZCK3pvMX7RbU8EsHC3YWlBn2Jeb30/7PMce
 CFLd4WUteG5RkPYy3xpcNhYB75oh2Hf+feucEkIv8yVW579wc1fzPQNEc30AtNK54g
 QzZ1H36Lbw6/Y6dPSOR9X7NICHv93jqWcMZ9qeZs=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id
 1MNKm0-1k7PNO0opu-00OsRu; Thu, 17 Sep 2020 22:10:52 +0200
Date: Thu, 17 Sep 2020 16:10:49 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Message-ID: <20200917201049.jihclkumemv4mbhz@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
 <83een37y21.fsf@HIDDEN>
 <20200916201104.ktl6aukmpe5hk6g2@HIDDEN>
 <83a6xo7dgv.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83a6xo7dgv.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:fLfRwY9lRGqxOpWzjsOaesJxhMgdloQHxixZO/DHduryw00tslO
 faxFIlxbqdzX9BChLwkAMFy7TOUcteTvzIPFiUxSR1LQZmKMg7RO0aiOgiKAwMEXHzVrop7
 erYVyONYocSFkTPjXGsc3XjfHbm9QoH5oeeQl8zlyQPsz2ZFDGre1jffAuPVMNgm8nEYQDI
 RHwHLgRgjlFqqMSMGdANA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:aMdidbtu/yo=:LxMMCmFDeFZQDRjb4it/ml
 f/gTY5j2z9raZPyyAIsSEtMFANpd90pmKnthbIko75UjDfCYOPoJlKK+bE3EKw7CtaRD9+fUn
 T9t34FacPMQbKXPQR/0ysxLzdd9DyFk24v58uXtAnbcsTfNdM4fRph9FkQD6XYvMPEB+JR9xO
 fZJFGoGr4SVmhhulrykZTDFt416p1CBPPgfhUDDPVKVvBQ0LDynKGaoOtY1g2LTC73YObCFIj
 OUmmLBms5PConYxop2chFRWDNb+adhpYk9BkVZxhgXQHp3S+sFaH7hTyUhRTST3YnAYJP4aRI
 8GEaN7I3DzM/KBMezUB5SLeM95OI2GUFiwORiY0iJcHOskKLakaoL+lDDtoXE2jSAvMc+5ZMz
 yQ38/MbNjgH1PffE862r4O9vlQMrkqR00D9S1eihhBHoXbCDfe5M3jeK/rHKx+s4Id7UuCy/0
 R/Z8sIOmovxpdNh3q/HoGPEbOK2Eq7OBVvirDOUJsV3Re7tNKT/t6t2Fdcm0c5yBO90IVYt5p
 6ZEIVOgQ/2LUecYdCt1DElakQXqxMj+sL3fh0Tim2xI0u8rCdOAyPGDbVUEihpvUOLnvQ7fLO
 cDE/xq0PMApwjuzhPSLkizn6tLgm+yWiXalQlkDFdoJA33xB3T19dOL5eGMOigwEx9Hq+RR+W
 NW9uuW89U0dhU2LuJZdziBLydhXRsDbZGg2b+Wt3GjQg8MiUVb+z1d8Tak1C/jA6UJbsf3oTZ
 IrS2s/wJs37HhL1hPOxV9sL5iuqtVKNe4rpjHdlVUhoCP/4rH9/8mwfQQsp2TMyxT9be1rely
 tK+mygfsHtWfdoj/aEv3PBhIVFtB+XtXryrZF7/6cqmnKVyqs+0Xr44SgFt3+pWAgfbfdqVCW
 yN85OiDL+jrWQFMeyEDT/ICSdf6yb74yHZVQwBgPenQfBKM6xaeInD3Da7CV+waOq2d4g2WF2
 5BrZa4kWuMJ0xFS09gzsuDvkPI2cJG7nJNE/cUW+roPsOrc2IHp3cIJ8wAJY804lNl2I597SX
 q2c4kQKtNifwccx+WNJmPmiwUmS+drb6aMFDwSHvUMEg10oy1LUeCgld/agQeqslFirj6S+2g
 e6PGjss3iRDiEnxCipUyOEa7x+Zntb9gJbRBe9N6mQV2gpe2kFZq/1sh3t0thl4mLdcpaUwf6
 TlfGEioRwYXxxaHl8n+OkTTCYpmvnHbiDHR1/eHKjMUJVntjkq5dw02dbx7iNZuef1vFdxjju
 WHiX2kSCK6Vh7PuNe+iHxfQON9VdMP3fxpXxXuQ==
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: martin rudalics <rudalics@HIDDEN>, 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2020-09-17 16:13, Eli Zaretskii wrote:
> > Date: Wed, 16 Sep 2020 16:11:04 -0400
> > From: Boruch Baum <boruch_baum@HIDDEN>
> > Cc: 43412 <at> debbugs.gnu.org
> >
> > It looks to me like that's not the case: my testing seems to show that
> > it does catch cases of changing a buffer displayed in a window but doe=
s
> > not catch changes of frames due to functions like `other-frame' or
> > `select-frame'.
> >
> > So, the good news is that I've written the code that makes the
> > improvement for the caught cases, and I can submit that.
> >
> > As for the cases of changing frames, a less-desirable option would be =
to
> > preempt bug-reports by documenting the limitation. Auto-revert already
> > has other curious limitations (eg. for dired buffers it doesn't operat=
e
> > _at__all_ on many types of file changes), and this limitation only
> > introduces a delay, so by comparison its a pretty mild limitation.
>
> If we have no better way, we could document this as a limitation,
> yes.  But let's make one more attempt to solve this.
>
> > A better option would be able to catch frame-change events. I haven't
> > found a straightforward way to trap that. Does such a method exist?
>
> Can you describe the problematic case in more detail?  With that in
> hand, perhaps Martin (CC'ed) could suggest a method.

I'm needing now to focus on Rosh HaShanna preparations, and can let
emacs distract me for the next few days, but from memory, on tty emacs:

1) touch ~/foo

2) find it in emacs

3) bury the frame so it's not human-visible

   3.1) OT: I find it useful to globally bind C-x 5 b to function
        select-frame-by-name, because I do this routinely as part of my
        workflow. Another option might be C-x 5 2.

4) M-! echo "bar" >> ~/foo

5) switch to the buried frame

6) Depending upon your timing, you'll need to wait up to
   auto-revert-interval seconds for the buffer to be updated.

> > An inelegant solution that would cover most of the remaining events
> > would be to advise :after ~4 frame functions, and to add an element to
> > variable `move-frame-functions'.
>
> Yes, I'd prefer to avoid such solutions.

It maybe could all be solved if there were a hook for frame change of
state (eg. getting/losing focus, being raised/buried). It's surprising
to me that such events were never thought significant enough in emacs to
merit a hook.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 17 Sep 2020 20:04:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 17 16:04:09 2020
Received: from localhost ([127.0.0.1]:39193 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kJ08X-0007MG-47
	for submit <at> debbugs.gnu.org; Thu, 17 Sep 2020 16:04:09 -0400
Received: from mout.gmx.net ([212.227.15.18]:57761)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kJ08U-0007Lq-Vh
 for 43412 <at> debbugs.gnu.org; Thu, 17 Sep 2020 16:04:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600373040;
 bh=hMTENVsfKUrIF4nr6z2ppIe+Zd0zilmg4B8azL3qGUE=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=H2rPf1RrphbgMlVV4hkPfuJyfLtSTmMZCRfnb4Bkty24l2OoruxgTOuo6zEZo1N8A
 zgfkRfLNTflwdjetJOzSX3LbAAbNysFQahvhuzlUYmpK92ojvkCV6+RFEIzR4rTtdc
 m0DxWGuQs4nZ08DPS0DihRvVcpJSofIGgcJowThM=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id
 1Mn2W5-1kjZqR1IpD-00k3z2; Thu, 17 Sep 2020 22:04:00 +0200
Date: Thu, 17 Sep 2020 16:03:57 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Message-ID: <20200917192925.4ponjwm7emwsoxvn@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <87o8m6ri6u.fsf@HIDDEN>
 <20200915193146.rcrylluhr7ah7dst@HIDDEN>
 <87y2l8slux.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87y2l8slux.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:8CmaTGxVM7wGs6Qe+PzkRnGVknzj4H7SailmddZr+QqIVcoWpTX
 jJOkVwo6lPtECO5wVaTOeCiHoisBM7U26xMrqeKwk1KVZoSekIJudHwf3EO5Pod8VFEeBsu
 F57QOFxDB2qFlFYeCqojpLfgOJna8oMKo7UdDduAXDcZAP5C54huLzC0RKfjCcCTiIaqPPg
 yQnsXKI5WPWDeBItUnmVg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:wPbJS1FhwDY=:vEb50VWMRHaiW9fbR0QfO6
 5wJ82YqCHJdP3KYAqwau1FWnZ7vO+gaTm6fYOFYi7Z5zWBdB+m3UuYcq8qg2b4er0uCxIb4+j
 6lgG+YyAo/zaUTzR9vZUv30Gi0sEUBQyKvS8KbjHW8wjUjodzBzSteQnpAryXB7wIWU+41HOv
 8u/a67vSPNcqbFvJftfyZf++IUsektgePlGIN8sngSnFttht0dGWDYjGAeg4oHNCW7WzGhS3T
 Lwv3aPV5nACRAA1e3yysFGHocU8tpum41PVEqAuxME3MXVyiMAUKJjLmlHBND4kdyHzCVTpRT
 WZpCafJcwTgpmt9xirPzqZqz6oD+5WMBUOiWVgW+3kZi33z/rylzbd6O9D6w9ShOXNlhGV9WA
 5WDQT/iFJcZFQBhTAlHnv1ubbcSEDDNrdwa2H7zqvzMgH/mIrKyYGGUDfyAxPMmQJ5I1Xsu12
 FqdeU/qPGl3C+6innQkVP70qAMOusHYiSmmOWjbz0AANMkN9Iigv4qbDPw3OmRHaz8En3hRLv
 cf9sWY0g+Oc6nqS+hftLAydR9efl2cnuE76egwpUxFfmPopQblCShsaZDv61nF5oWdwcknzqd
 l+vOp1HSeySoYd/wVqKfU8tRIX5mBfmaD9GP2vCqOe5OWKqZRFZDXHzU2ha5AsXY/7n74DIQM
 QxcnMggqfHi4RsL8586BO9KSGMiqFDZBy+Kvv2VOtEGO+agg+AFjN/L6vgBstMSV1O6Z9Pn4M
 v5Y6S+gvk8zCfGCmaj5X9wM8TvEBzBBGcju5jJUsO8Nyyzwh1rXgKJ+UO3Y0n9axqy7Wi8fCP
 FE/3T2HQhDFwt8jZTO62SQVxI9Kc+Myp3953I6J21oElvJvTb73un9ArEhpssR6865JlFFfbf
 WYF4O76XyVk2pqYt7CN6UpYK8mKqJii9bLSwIBPCtygAy1/nauZ+11VdZv9urXganmwQqjjm2
 gvjLzmXlMivkx9WhNXfFm6OMhRBODbvneBBa3t7nLhULdCl48Ee2lKaDyfkKcD7cQSzBecGl1
 8lpLwPN3m4dbHF0kSoGSOQ/hlWkCdD/7uAOYQFYjoSjP7nEkNCGyCiFkZ20hLWAiAqOyQxNWP
 Qnt43C5lOth/NqijA5T72Fn1Jl3Uu1Veur06InMHJWHzX10XE3c5uYHsDLZvP/T1tvBSJYf1H
 +650lwvoKMNN+Ux54vheOypJ0yGGNVgMIA0+YIvZa57YqmkWkkdHnRRqHphzOAiczU3XJlZqI
 kOsPo/WXWPuXEpys84iGFk1m7tXRZtBBq7yZfuA==
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2020-09-17 13:07, Michael Albinus wrote:
> Boruch Baum <boruch_baum@HIDDEN> writes:
>
> Hi Boruch,
>
> >> I haven't tested your patch, but I'm asking myself whether it coopera=
tes
> >> with autorevert triggered by file notifications.
> >> ...
> >> Have you tested this scenario?
> >
> > YES! In fact, that was a major motivation for the submission, and
> > the primary method of testing it.
> >
> > Please do test the patch, and report back.
>
> I see (still haven't tested, just reviewing).

Actually testing the code would be helpful. I'm beginning to feel the
'crunch' in pre-holiday preparations for Jewish New Years, so you're on
your own until at least sometime Monday.

> I don't understand yet, why it is necessary to move "(setq
> auto-revert-notify-modified-p nil)" into the "(when (and revert ..."
> form.

The reset was being applied too broadly and preventing auto-reverts from
occurring when they needed to be. I don't have the specific key-sequence
handy, but it should be clear if you try the code with/without it in
common auto-revert-if-not-visible scenarios.

> Furthermore, I see a problem to call auto-revert functionality in
> files.el. autorevert.el is not dumped into the emacs binary.

I don't understand what you mean. What's the problem?

> Wouldn't it be better to add a function to find-file-hook?

Tried it, and it was insufficient.

> I understand the problem with adding a newline at file end

I don't. AFAIK, it has nothing to do with my patch.

> but maybe this could be solved differently?

Don't know what you mean. What are you suggesting?

Like I mentioned earlier, I need a few days for the Holiday. If you can
test the patch, that would be great.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 17 Sep 2020 13:13:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 17 09:13:59 2020
Received: from localhost ([127.0.0.1]:37524 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kItjb-0004ah-DK
	for submit <at> debbugs.gnu.org; Thu, 17 Sep 2020 09:13:59 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43522)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1kItjW-0004aL-6u
 for 43412 <at> debbugs.gnu.org; Thu, 17 Sep 2020 09:13:57 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:35701)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1kItjQ-00020u-RI; Thu, 17 Sep 2020 09:13:48 -0400
Received: from [176.228.60.248] (port=1940 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1kItjL-0003Ks-5Z; Thu, 17 Sep 2020 09:13:48 -0400
Date: Thu, 17 Sep 2020 16:13:52 +0300
Message-Id: <83a6xo7dgv.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>, martin rudalics <rudalics@HIDDEN>
In-Reply-To: <20200916201104.ktl6aukmpe5hk6g2@HIDDEN> (message
 from Boruch Baum on Wed, 16 Sep 2020 16:11:04 -0400)
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
 <83een37y21.fsf@HIDDEN>
 <20200916201104.ktl6aukmpe5hk6g2@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Wed, 16 Sep 2020 16:11:04 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: 43412 <at> debbugs.gnu.org
> 
> It looks to me like that's not the case: my testing seems to show that
> it does catch cases of changing a buffer displayed in a window but does
> not catch changes of frames due to functions like `other-frame' or
> `select-frame'.
> 
> So, the good news is that I've written the code that makes the
> improvement for the caught cases, and I can submit that.
> 
> As for the cases of changing frames, a less-desirable option would be to
> preempt bug-reports by documenting the limitation. Auto-revert already
> has other curious limitations (eg. for dired buffers it doesn't operate
> _at__all_ on many types of file changes), and this limitation only
> introduces a delay, so by comparison its a pretty mild limitation.

If we have no better way, we could document this as a limitation,
yes.  But let's make one more attempt to solve this.

> A better option would be able to catch frame-change events. I haven't
> found a straightforward way to trap that. Does such a method exist?

Can you describe the problematic case in more detail?  With that in
hand, perhaps Martin (CC'ed) could suggest a method.

> An inelegant solution that would cover most of the remaining events
> would be to advise :after ~4 frame functions, and to add an element to
> variable `move-frame-functions'.

Yes, I'd prefer to avoid such solutions.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 17 Sep 2020 11:07:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 17 07:07:15 2020
Received: from localhost ([127.0.0.1]:37396 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kIrkx-0007kM-05
	for submit <at> debbugs.gnu.org; Thu, 17 Sep 2020 07:07:15 -0400
Received: from mout.gmx.net ([212.227.17.20]:48189)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1kIrks-0007k7-67
 for 43412 <at> debbugs.gnu.org; Thu, 17 Sep 2020 07:07:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600340824;
 bh=+WQjBWqnnz3h4X0Iao6CZc1dvuKm+advAgC1g5dqmOg=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=FGd7txDP+oAUVbKS1uYAo1mXsTXL87+hnE87MtgTWzel1SdiMJTdJ+JJMC0zQ27oA
 qE0E1Q5uuTSE3f0ujrq93JRdSZpqss3683YCPY9BANo+t8VUqOvUyXSJ4IXovWghq+
 UQJB1U33blFqHQRes1vqYB/OmoirXfzfrCvbuBlY=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from gandalf.gmx.de ([212.86.37.67]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8obG-1kWjoH3KJa-015uUW; Thu, 17
 Sep 2020 13:07:03 +0200
From: Michael Albinus <michael.albinus@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <87o8m6ri6u.fsf@HIDDEN>
 <20200915193146.rcrylluhr7ah7dst@HIDDEN>
Date: Thu, 17 Sep 2020 13:07:02 +0200
In-Reply-To: <20200915193146.rcrylluhr7ah7dst@HIDDEN> (Boruch
 Baum's message of "Tue, 15 Sep 2020 15:31:47 -0400")
Message-ID: <87y2l8slux.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:PVBneNqTFjzd6ceO++Qp2UROpU0tpuFjVYoIaywWTFegs6ChrgQ
 xdAjBNhvSOqwGEfc7op3o/YexFdw/+EXvoZYzWVt3zkMmgLqNDKn22bBRzcnm97Hr6AA2s0
 hsfKXjzUlyevj2AO7c34oWbXq+lg8Vpjt6/U82Y2uqTNJtIfxYqzEaGFg/JCHq0WvE1tmv2
 aSqcrqWbPuFiQrZJfLhgg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:GWiw02y5MS0=:pGnx21KYtPSZAk3s3qzotm
 FL1jL6zW34HKQOeSPock3juHtWeRNlDcC4Ai80pAHMkHs019XUAV2xmR0vg/IQ4nCBxVXunru
 CA05qe/QxqJMCAJV5KNUzXHX9KAwwZKXO61PHpFEUDENjcvTb0wHnn3xWhpQbCsDPSFU2IkD6
 bxmpBedZZM5NWXFmLiJM2XNxfQOXzHEPHmqn/4UHMarlkwUq+I0bUEEUjPvLCC//b9i4qoMXo
 AoQ+EfmoH9iwvfuHZIFwgIxXxTzlch/pHWmuR7fuH1RFN6VlSm3WjiSC1M00YW5Rtg4S85VU8
 ERspSr4wOzM5h2ftWSDjgCplox6EES2CZZa28EyL24xjBFcIDVHeXancdg07n+vlHHDmA5++5
 hL+3VUl6Rc6wxnsbL4AqJPGHkO441hqAXC5R9Ucj6Dd+Ss6bJd4Aq5vMTlYsjNSHroH8dUj1B
 8Vyy3wpzHMsXv1C8kYS+dbo7Ux84W3iY/3yFtkKOS42Wh2Ot0kqj5/MtKSkxbqNmrew8HFJ6H
 wHSteRaOtA65aqJeOZEhbcYMfDRVZpSGAbILtjnpnJv5sUhPNU5BPcvMQcYN4UvpFIyZLYmfN
 CS+BDabzxbhrDMYD5XJV2bId9G2IjcB2d0/lCScjeVjDSxET1YcNK3pHF/S/gLRoM2kR8xpwo
 zSs6tLOSeBXyAMXrDEbGwpzM/JA4K03U1miceCpLFD0q6pMOQ9GBF+t9te2Qw9uCEbak05Ijj
 prEa/vMFAYZi/037QXU+0bm7+PnB65BdPJgKx6EB8gC5i9/ABrzDs2bYeklAmlcws6dpozkzz
 kNETjcGSHFdjRljwYFFqX5mcHd5KXqgBk/DNdZs+sSYaXLHn8oeX8fvFI2uBmOVBHXDL7TenD
 HAjDn6vMszLn71bJSIhILatD7B/lzTT0tmasirX7urd0nKBHltHK1UdqokWbjf7JbhT2+yoqm
 0kZGZkqsoW1rJU3t1e3VbbgQjwRMBMB6CNK2Atiq+gMMYLw929QkPSleii7U/R9OS0y4h/y8B
 Oj0298wp2ATEeJupqGw54YX07xxEB81ujromEvg+2/t0DCBhOKfqYey8ElSqwyeG7bpR0ZrHP
 TL7EnqMw3qY4fc+iFxP2OISJnP1adrQYUjZLmSBXCHkVkUKO8xNPABbxdSzplhopmT7Irxf5g
 91+8UnoBUq40IUp/u8YFOZQHqHd1BP7vJ05qCHuC0H2PyqF4TCDoSExkgeaXM4nvj6AZZUGXw
 z7W0OqURyyvto3hn2NwjIf5PHlQ/hdLnjwqAeMw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Boruch Baum <boruch_baum@HIDDEN> writes:

Hi Boruch,

>> I haven't tested your patch, but I'm asking myself whether it cooperates
>> with autorevert triggered by file notifications.
>> ...
>> Have you tested this scenario?
>
> YES! In fact, that was a major motivation for the submission, and
> the primary method of testing it.
>
> Please do test the patch, and report back.

I see (still haven't tested, just reviewing). I don't understand yet,
why it is necessary to move "(setq auto-revert-notify-modified-p nil)"
into the "(when (and revert ..." form.

Furthermore, I see a problem to call auto-revert functionality in
files.el. autorevert.el is not dumped into the emacs binary. Wouldn't it
be better to add a function to find-file-hook? I understand the problem
with adding a newline at file end, but maybe this could be solved differently?

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 16 Sep 2020 20:11:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 16 16:11:21 2020
Received: from localhost ([127.0.0.1]:36603 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kIdlr-0002ZX-Db
	for submit <at> debbugs.gnu.org; Wed, 16 Sep 2020 16:11:21 -0400
Received: from mout.gmx.net ([212.227.15.18]:58859)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kIdlp-0002ZL-S2
 for 43412 <at> debbugs.gnu.org; Wed, 16 Sep 2020 16:11:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600287067;
 bh=j5FR0DT6KAf34Q7SPL+yIW5PmOisT8dpsevkiMvjnBA=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=cEunjfLGws06p2LQ7UFVmQuk1Swg8ZJhHZYGioDwoqxZKZuRDHBGusm9VwkVIxkBY
 vFTMt7ORLBOmoBRfqgq79E/HlyHHv6qOyK0s/kgNlih46hnwApZEHd2Wj/0DkV0+3b
 dwS09sLuHcqfggjSh/DMVOPE2nqk5r2zOj4dFLCw=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id
 1MnJlW-1kkFMV0vJc-00jJgB; Wed, 16 Sep 2020 22:11:07 +0200
Date: Wed, 16 Sep 2020 16:11:04 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Message-ID: <20200916201104.ktl6aukmpe5hk6g2@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
 <83een37y21.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83een37y21.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:arBvntkAxmUxDHlC1gAXawIqw6Aa0701bKv2xsVGX8Z74nKmDjR
 sjZEt9zI/i7hgQvrbV7HKebp5a5tcSuE53uUU4Eu81PczTmgXDHtKiNsnV7c8YSATODno4a
 0uhDwu7vBdoUYX4KlB9Gsldaz8Yd7nnbwCdu2J/cbglhEohDEY6VldaolXezu9mH9gs69VE
 RQNMOinFMcMMYws55ATOA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:LClv7VUHvbc=:E9YnBUmerZ4Oj3g0MemwN0
 jME7f5Gkis+3xTGtxj8k33BnoiITSHg/ZzH4Eit3DlbSsOFa/skFMowYzSLMt3ilz//afiPMM
 OJXC3qNr2yy8iC2P6rSxqvCaRxLPsr7C8Rqxenakt7r8VLAomgV7L8T2BGjcZ1gr1UllCdakE
 fHhz5knkgzUa7jQSOjWx0gU7UhLX/ZNUWA7l0CIpqG81N4meYnMsH5+VT3HrkcpMz3tHBvrBo
 SxhyZC5RmTFbbtxZPOj6S53fnwN5kBP8lMydG3O+ttHmmSs6SPqPMxxhtHxRYn+XEJJ2hBVgZ
 4XyuzuRnG9AKCXCrA9jr4XczIhAvYT8ZY7cERDJkDR8qIslbM6ZBKxx/AZXURvBqhNRqcBEPC
 ihv27BTYulyK0fX4y9UrhsCn1q6XxV/gggt0zNK9WkDKb7rREOPjr9BIONRXfdirNEex2KhKK
 25KcNmfnoizOKsQKlqNwEkKAO/oIqQ0Lhe4p/ZyTbHUF030Ra+2UBuCX4xdOp1fSCdK02lpjp
 rgWdcINIS0QbNeDDKFbvgIl3WAHzDYINww3y2EwIkNJZiCb/tJOYhIN5MfeJVdB9DJZEoDCa6
 Cfp7n4ldbKfKp2EnBPGX57dOl2oZ8G2v1yd9+8vgA/28nSohhui/x8ygqVlQm0UEJm4nz+zeF
 ikoBZLsbrJeHdDFiZFrNKmIvX7kF8KYhWCES1G/TqoOrXPqViqICsrW5xJBIbzXkBKLOXrV+V
 zA3Yb2cHaOW5HhxVpwjW4isJUbIyuNJjKCSz8mdM7vWyjQbpVtmOWWlhOHm2iW6GOUmfKdjvE
 CIzW6/EQXn4aaFoYoC4dymdmTYZngaycJru+vmCqTPfFzeiRRDD9quhUHds1SzCK9NlheLAXO
 noU+Ak0Dkl1RBYThyFO0TNaIkFFCXzKoDBH+26uClokPxvb+H2J7gnHDncfkt94rNbDX8exfq
 POAxdKbswuxJv8ieSndCbUimewcPxW5+hVkx4HKjCZmDaBg8OufnrpsuG+2lh/jOA61hMmfnn
 PEzwVMo7dNl+1Xt3FeZXPnQ0f24BGpFwrTZyzOXXGbsKwQVShOo29HTD8IJDyDfYt+eMDMsqD
 ZQYcsDhRvaNuQNCLmd/XYw/Geosbyf3mztPmbjp8/wIZ1CAt1eZyps2NYiEY9enwThKT4eKl4
 q0VSA2TnSOHTZFoYmnpdIJ5TiLTEUO5eS80XNxs9Xc+JXCwL1CQNjs+xL2Fv381cPZWT+Pt29
 fp+Zi4biZJiS7Rpj013qpP5pnqPHTA+rwxOUbWg==
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2020-09-15 20:24, Eli Zaretskii wrote:
> > Date: Tue, 15 Sep 2020 12:12:39 -0400
> > From: Boruch Baum <boruch_baum@HIDDEN>
> > Cc: 43412 <at> debbugs.gnu.org
> >
> > > Maybe we should arrange it to actually auto-revert before being
> > > displayed.  I envision bug reports if we don't.
> >
> > Do you have a strategy or implementation in mind? Would adding a
> > function to `window-configuration-change-hook' do the trick (ie. catch
> > all relevant events)?
>
> Yes, I think so.

It looks to me like that's not the case: my testing seems to show that
it does catch cases of changing a buffer displayed in a window but does
not catch changes of frames due to functions like `other-frame' or
`select-frame'.

So, the good news is that I've written the code that makes the
improvement for the caught cases, and I can submit that.

As for the cases of changing frames, a less-desirable option would be to
preempt bug-reports by documenting the limitation. Auto-revert already
has other curious limitations (eg. for dired buffers it doesn't operate
_at__all_ on many types of file changes), and this limitation only
introduces a delay, so by comparison its a pretty mild limitation.

A better option would be able to catch frame-change events. I haven't
found a straightforward way to trap that. Does such a method exist?

An inelegant solution that would cover most of the remaining events
would be to advise :after ~4 frame functions, and to add an element to
variable `move-frame-functions'.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 19:32:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 15 15:32:00 2020
Received: from localhost ([127.0.0.1]:60617 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kIGgK-0001CB-0P
	for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 15:32:00 -0400
Received: from mout.gmx.net ([212.227.17.21]:40665)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kIGgG-0001Bv-CN
 for 43412 <at> debbugs.gnu.org; Tue, 15 Sep 2020 15:31:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600198310;
 bh=0C/tgGsUiOj53wDDTo/aORFgqz+V0NDeVSHP8k2Odz0=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=VSr4S3+rGy3FroCmsvQfjSZlddbCOttSypINPoEqRKyn1QVIBvEkrsoEB7BioiBYh
 T1FhQa4GiOw89u+LKdM+9Ae15V+YKz6r3SHk/QX+XoDu7tJius1G2MqyqoVP/O5qiZ
 +w9WFzeCVAqpIt9Z1WR+01Dko3L2roWDAqPBbBBk=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1N4Qwg-1kSx1v2j5C-011Sm9; Tue, 15 Sep 2020 21:31:49 +0200
Date: Tue, 15 Sep 2020 15:31:47 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Message-ID: <20200915193146.rcrylluhr7ah7dst@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <87o8m6ri6u.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87o8m6ri6u.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:bb6yEJcYruf7W4cEkgetSvfC8bjzixad24HavnkK85YW0VMlMjG
 +Kh77GW6hZxzNdF7SixNXXxxImCDyohi82/QUZ3Q0KyuSqSzn7bquovq+gpSRAEO7ddMLcb
 8DvjERWViNO8RF+cIZbatg896296/Y181pY8a9clxeXrg567QKv1HT/Ii/EXEo91T5Hj9n4
 1vN5tnwhtb8KdRtPGeM4w==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:ihJ1kWMj5aI=:/PlP3J55Pf3eAptKUgd36S
 YMtVEq7/nRUeoB6AXDG/DfITGTgHk0bI6ICuHXdeEs5/1raPgnC81bj0gTBaXh4Ie4MsXV/lh
 UqmBSnZ8+j1mzHhngO+Kxp9Dn2kaSP7yzmCMJzwn7cjdKImFi97yhbwaCwhB6zINtBxTjRRVV
 NxsfZY1zOTjx2aOSxxxKlJwqmHv05KIWcQ7O8NjcH11y7QYWAGrw/k+QUZTpWb+Rjl7M98oGn
 CFqhihVchfcqR8jSpfZoSs15RSYCFK5Q+dN4AoI1GTPv5JNyB2F/A1lh8itNv5o+f35VJnPHr
 pW/XZxQb6X7ydimvYnysTxQI5AUkZl5qxZiwZ3OK9GSmR/o7zD3aJY+25oSiUP2B7zYHcOT0Y
 0jMzZhioasLRT7m/3M85LiNjPWXjv4W1f7KekPXZkDnB3vtxtbv6s+b1Trqshi3mYXSu6tjCX
 80kIgStmIow72lJwx8sUXlzviKVjW/mlUqNIIl6USy4S6ZRxqTgYqa+iAmwypQ+LFgdWwrNyy
 GUDZhznuwoITsT09Ov9dg85r2Qt85ZStvW8Aegx1o7R7xWqAstOm+GSZDwbKMqUYvlIDXelo8
 tgFkbu2+OKFSaB/FCd5KrXNGOVJW2W8EWIVaRQoYiz+gt3yU5KwxoxwqcHmYEzEByvr/rizJT
 8ilmozPsJnWJ7mVydJxijiCIIHOAo5jVUcdlaPoLYJrrtCcRqFgJEJdm4u2dUluUR0nPWbDso
 GWG7eQunT6InUBeV1sqox9qzFEYtFCEQec2+tbIBMTlgnKBNhP1zZIRhNqpH1YZnXm9dPbuok
 NUFkpKZpjSw0wZzLNiOs7+Qy019rc0Al6FT0uQxoWo5Z9nMAq+b+Kd519LVqdVXiMgpF75f+E
 bPpMzGawsLvirA0Iu2T9lUcSeeSg+QuzCFiobiGaG3PZmq8APbe289nOYm5V5S5nv1IVYs1xe
 XgXv3PjkDB571N8BHsFTSZWLkWju+Lycx4meomBuAjMMEfRsijOCyqIyOI2LeAsDe2Fm9Pnmy
 m7hc6ERx5EqdRosBndfKnnBFfB256GmNHc3P0UqVP/jLGE+nuwgacikkrMU2aHDIyACEw/OlH
 JgbiHOyGPpvOVcRySWiWk928srJ1n3GIR6t5Rs3E1bVJOHiMWeNCfMlrveBeD2AIi34N2oNPX
 wD5ckxdIKJImaGj0DhZH2h2UwcSEXLNYZXQkX9m7gdF/TsFeyA4A/9TzZGZV8Ln8xb06bIu2H
 S8Lx1DeoPx89yIy0iIoJOzFZpE9zW0poDAt+E/A==
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2020-09-15 20:47, Michael Albinus wrote:
> I haven't tested your patch, but I'm asking myself whether it cooperates
> with autorevert triggered by file notifications.
> ...
> Have you tested this scenario?

YES! In fact, that was a major motivation for the submission, and
the primary method of testing it.

Please do test the patch, and report back.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 18:47:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 15 14:47:15 2020
Received: from localhost ([127.0.0.1]:60571 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kIFz1-00006B-6u
	for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 14:47:15 -0400
Received: from mout.gmx.net ([212.227.15.19]:58589)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1kIFyz-00005x-6R
 for 43412 <at> debbugs.gnu.org; Tue, 15 Sep 2020 14:47:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600195626;
 bh=espwa/NglIJZSxJcAgMz7FStX+OHTtQOHxlhqo4ZwIY=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=DxEVHKK08qfIxusg7aWaZR2e2nvZZZytKdx70qRw3AT3rTXGkYvPonB6Rn28OnlsD
 M2g/DfVZwp+CxECoxknzbMpVgEfzUQb0clrHijkUuGq0ZM4U73sLH7H0AmiEi8j6Fd
 fZgs0V4ShoShY/g6IJt/u8b1+tBsguUswHBGcsMo=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from gandalf.gmx.de ([212.86.40.68]) by mail.gmx.com (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N1OXZ-1kTlbt2RMx-012m3Y; Tue, 15
 Sep 2020 20:47:06 +0200
From: Michael Albinus <michael.albinus@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
Date: Tue, 15 Sep 2020 20:47:05 +0200
In-Reply-To: <20200915040728.77ufv7g6bekvrzqa@HIDDEN> (Boruch
 Baum's message of "Tue, 15 Sep 2020 00:07:28 -0400")
Message-ID: <87o8m6ri6u.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:SYzCequkWVgoC0JVN5fX8VR1+15cMfljI9agY1EcsTgCUEDfWsM
 AcrtATyfx1ndfbYFVPf864maxuYlbY+KhTSJSJhX+KzqJS/0HbMxtavbUUJF5xBNXdCrEJA
 iH8HCxCDoB7K4VS+SBcjmv6maDP4rHCQnngGT0HjwjKOcn1cSdKIRIfy21AlbW67qJKiv1z
 MdAknvmYWWQtfJAKJe9yQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:8+TmEPnaSJQ=:TZ/p/oktswuuuOJjZlsGXH
 OZPIec1ocpvyj9mShnpxfAIi2jSlwu4O/AWeKOEBIvxCeG2zi7YjYmDrZcGxUnLOpCereqvJe
 ufCSrCltevkMko61w+4LKlKOV7S0hOqccD3s4JY6WWbj1iPI/hzulSc3xpm8CqmIGM153CsKl
 aDr6jRyuoPkk6s2mnB2ZnWoJ8RNady8ZscbPTLrx5qeqxlPgYR318IZzy3odLfQMjy07WQ4HD
 oBiTg/KLsQiQnBIWNeasiyEfkI3kFYqmgQHUGQOQbipr+Dvwo0iNKGtfeeU4J/6ySj01bLbN7
 5W8Tfiod4pNznzEqGYA1cNw5UEkm1ftG+h4mODF9dFCbIMlI5WxgLgU6WlV3R2ZyIWO73X3x3
 QdfTBqqUm3jZlj2EQ7y6Z3qjOlrD4bmlpo4vrMRgA2QI8zvVh7GgLpc/MtmCPbd7JR+7Sbm2n
 FuMYWkVpT8UcRrlbfePmDINGSoKpF+ETMopuWvYC/L3ijgMOnRykXoDhC3Eyy8oF6wgMgWQ3u
 7D3hdgcrxRPaxjMIDnaaMR+Nl6lNM1kaeJXAkBNsVdSS48Au/JupiaRaiZj87qjT1Hdge3csI
 VbEOhiRVrveHjZMa8b+GmPqcpdV3qvuydeLgqbW+ftuusKpGPXnRPOHPxuBORd22FPOpw3Xgt
 u2npl6xZwwGwX1lJvFcKnopJ1l9jTbNnvol5vqRrMZF8Qv68rPUC+fVN6tTLGW+xd6CjCw7NH
 u4vb+tregMJPAnRaDuz5MhThxbB22t1mz8c/QvcBMECQe8IvlNza5ofW5JnOUI3wdSFG8yGsi
 YWBCxYREVq25Y43YKvbybZ8HWATf421Pkge56oBMCD+0yK2GW98I5nOpRwwAvkE4kl4pWuOR9
 8RhWpSMIQkMoKKPwKP60T6oYgkU7qOJBI0ba/G3V4iJzBKoIXXGgKLWSvIskC5pHQYipfRbU6
 9AWWoME4yvK+Zbp84G+3MSCIKL7dR/CjR5q/eFFbnzdhBqvy/KLfCcdO/q0TtrkV7385UoKCU
 TP75++ds93FaZE7srgGtePIlWKaUxxcnSyvO1/6i2AhQvubQ2awjQ3h5gkv7kE9fvV6k3/iIW
 9jKUOus23ONYS3Oy/imWMYFMxQPW3EoezU8xJvJJ07B7cKbC8o/VPKCV+NvJMW/XJAcMHfqHC
 AJ4s9LWAHmIVcaWPmUprUpJOk2XQslb+iMWVwmJV0pa3HASa+9JC+D+Af4EshwQWuYHDqdpvL
 mWWGL1ZOBHnFMD+yKXnMY9V6kDojvvcJAeJSUyA==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Boruch Baum <boruch_baum@HIDDEN> writes:

Hi Boruch,

> The attached proposed patch adds a defcustom and makes a change to two
> existing functions in order to allow a user the option to only have
> autorevert mode operate on visible buffers. The change to function
> 'after-find-files' may also fix a bug (or change behavior) in that
> sometimes when being prompted to manually revert a buffer that had been
> in auto-revert-mode, the auto-revert-mode status would be lost, ie. set
> to nil.

I haven't tested your patch, but I'm asking myself whether it cooperates
with autorevert triggered by file notifications. That is, if a file
changes on disk, a notification event is sent, and autovert happens. If
autorevert does not happen because the buffer is not visible, this event
will be lost, and no autorevert will happen later on when the buffer
becomes visible.

Have you tested this scenario?

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 17:24:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 15 13:24:42 2020
Received: from localhost ([127.0.0.1]:60472 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kIEh7-0006ag-TC
	for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 13:24:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:39624)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1kIEh4-0006aR-A4
 for 43412 <at> debbugs.gnu.org; Tue, 15 Sep 2020 13:24:41 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:49960)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1kIEgz-00043o-1J; Tue, 15 Sep 2020 13:24:33 -0400
Received: from [176.228.60.248] (port=3956 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1kIEgy-0006FI-BX; Tue, 15 Sep 2020 13:24:32 -0400
Date: Tue, 15 Sep 2020 20:24:38 +0300
Message-Id: <83een37y21.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20200915161239.f3fb74daihpon64w@HIDDEN> (message
 from Boruch Baum on Tue, 15 Sep 2020 12:12:39 -0400)
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
 <20200915161239.f3fb74daihpon64w@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 15 Sep 2020 12:12:39 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: 43412 <at> debbugs.gnu.org
> 
> > Maybe we should arrange it to actually auto-revert before being
> > displayed.  I envision bug reports if we don't.
> 
> Do you have a strategy or implementation in mind? Would adding a
> function to `window-configuration-change-hook' do the trick (ie. catch
> all relevant events)?

Yes, I think so.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 16:12:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 15 12:12:52 2020
Received: from localhost ([127.0.0.1]:60397 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kIDZb-0000XG-OV
	for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 12:12:51 -0400
Received: from mout.gmx.net ([212.227.17.22]:50881)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kIDZZ-0000X1-0q
 for 43412 <at> debbugs.gnu.org; Tue, 15 Sep 2020 12:12:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600186362;
 bh=kdd6STReBqGt+yp3k1NOR56lu+hMvX/4mwzpnDIxzEk=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=j7tYvDGpy/eaTfaOB1SbGHixHK6Up+pRIxr3mUt0wYZlyI74owYa8kRz3Z4eX9EEG
 knIYZbqoH8upyoUIjFdJDZUJUfxhCM5GwFrtQP7NGgmLyjQmVj/4mhCXwx9zpnBlUQ
 tkgSZ/2m+R44KCn7y9ZPgVzgOt7XZ8Z9Q54mXwPU=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1MfYPY-1kxu2U0W8e-00fz9v; Tue, 15 Sep 2020 18:12:42 +0200
Date: Tue, 15 Sep 2020 12:12:39 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Message-ID: <20200915161239.f3fb74daihpon64w@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
 <83imcf82fy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83imcf82fy.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:jO/tGxk+ALC8g1YcieFRu6E2rlZEs7Anb92Ki2+bWZBv3WQFATn
 ZyjLpfnBOU6F0cdZgj5aHMGyrO9A8gbyOP7O/GkHCBBM9XDIG+/K6dkVFe0MmAAdTTG2bZK
 9t4SyTm8shLSfbHxw7SwkluAApKhgunRAjwIy03Q6/nT0k20yr1YSV3J546D2qS0c/ArNgn
 vpob+Wy7F0WDhwluPE8Xw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:akqwnl/IIbc=:+b9xr/M8wPoBdcnTyoLs4S
 YSOrrHIiPamRHi1bdh9przfNZOBL/rNKMXG40O9xKpCgygcj8jwaB7VSlI3YIbKsDdcrEJJsS
 1QdUUBbg/KdMxOWF/Wfw6Uwbw3FHn6xf6aQP7Wvi/wtNYccZwwSsT3Ia+ZyVs6z31VZJehRHk
 Q21rtbbETfXp7lQJT2fBv+WtedqhnnxUtJOYYWRxOgaCja0IVd5Ld2OmrrZoXhhGb1uL7+OW6
 buWNL+3iPIjLnPpwiYqNx38IwLWZRp0hGQn7EYDXZO6fsMQgvtVIDdc+PaA47ntg1M8r3Hjgl
 eeH06x82o2at2yeoPuFO54hw9xQUempJz372A57c5EavYFPSKM7jg6XuMUNpeq0BrIFj/Tz6x
 rl3Z12mZffr4ks6sSOP9IqlQj1/QWqOSmkGhT0vpQW9YMJv+i6fPSeW2ie87YDcL8VW4OSKqq
 lv5mXfgJQ/WswQSu2uOS9vQGyjfZ3EPTFikaiOUl8ezMMc+Q/erahDDvllSuUjkpo69pb6FL5
 LbzX21+FP6H6kptTTwrhGpB/kQtXL+240e4FTVtoCeRz91nHEyxOANv+cfj9b/mXvSJtsWV63
 XMbWaxhkv8/Xrsy2E6cRSzQlwzCDkx1fIEm8Iv0s3a7ASPkWBHsmtlhiKhCSEtNhPrK+COYEI
 cgAzvAEWSNFjocDtbepa5GWGO5pYu6ldzAuINZkP/zhS3CWneCejI6gB3qu+jn4vo8mziPfUe
 1Aw0IOk5VwgSXXxvlkZP3iiGpn6BSGXB3iWJYtT9At/G1BMpZA5HiKcaaLqCqVJQuYtpZGDDF
 BxdPIQ1zAnkZ54IzlH31DpdFOs7nlmhtHAteN81fMtLTwSZ2OVuh6s+fimZvy7qM5D2lnbg38
 czwT9jXvjDYI5cC2LOWi278+eoYWKKLaNAcTLLXmzOHn9o5ovZ/30kX2LpVkuRdsBnMRLO8s6
 v9snL57CVs2oyju6yjkQsWoc+jHpUtr1U5L2g/QFQ/0bV7PnXmybPPcAiX/rJ5WtyMTIvtlGJ
 /woWiSljKGnfqkxMAwl2RNU+DC7ZhZXmbYbUukgxI6dgycyaNCke8dY0zAuqWspfQxQeaPCML
 dM7J6rFV9rGdd/IQcxzAisU7XQfEOyrcG+/F1KckSKcPDfCeHZ8XmXAjN0Gmf5yEDDSyMxNHs
 eVeOiNyHcos5FtR4JPIA98dKQ7WYeLSFjOCQQj5AVl9ocWYRN3pAVagC7uiac7NajqAT/KEUZ
 TLVc4NGEBGS6d7ManFf0mMpM+Mhgz5wyWEAilOA==
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2020-09-15 18:49, Eli Zaretskii wrote:
> > Date: Tue, 15 Sep 2020 11:39:58 -0400
> > From: Boruch Baum <boruch_baum@HIDDEN>
> > Cc: 43412 <at> debbugs.gnu.org
> >
> > > Btw, what will be the effect of this option?  Suppose some buffer wa=
s
> > > not displayed and missed its auto-revert opportunity.  Then I switch
> > > to it in some window -- will it appear with stale contents, or will =
it
> > > auto-revert before being displayed in the window?
> >
> > I kind of mentioned this in my note: From my testing, at the instant a=
n
> > un-reverted buffer is displayed, it is in its 'stale' state but is als=
o
> > instantly considered for auto-revert.
>
> Maybe we should arrange it to actually auto-revert before being
> displayed.  I envision bug reports if we don't.

Do you have a strategy or implementation in mind? Would adding a
function to `window-configuration-change-hook' do the trick (ie. catch
all relevant events)?

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 15:50:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 15 11:50:02 2020
Received: from localhost ([127.0.0.1]:60346 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kIDDW-0006Da-Cj
	for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 11:50:02 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44650)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1kIDDV-0006D2-2r
 for 43412 <at> debbugs.gnu.org; Tue, 15 Sep 2020 11:50:01 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:47909)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1kIDDO-0006Yp-2k; Tue, 15 Sep 2020 11:49:54 -0400
Received: from [176.228.60.248] (port=2138 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1kIDDH-0005wK-BT; Tue, 15 Sep 2020 11:49:48 -0400
Date: Tue, 15 Sep 2020 18:49:53 +0300
Message-Id: <83imcf82fy.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20200915153958.e2nry7dxl3pmu3k6@HIDDEN> (message
 from Boruch Baum on Tue, 15 Sep 2020 11:39:58 -0400)
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
 <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 15 Sep 2020 11:39:58 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: 43412 <at> debbugs.gnu.org
> 
>   Off-topic: would anything constructive result if I submit a separate
>   'complaint' about that behavior / judgment / decision that 'Such
>   frames are always considered visible'?

That's why I said "visible" is ambiguous.  "Frame visibility" is a
concept in Emacs, so changing it now, and for TTY displays on top of
that, is next to unimaginable, IMO.

> > Btw, what will be the effect of this option?  Suppose some buffer was
> > not displayed and missed its auto-revert opportunity.  Then I switch
> > to it in some window -- will it appear with stale contents, or will it
> > auto-revert before being displayed in the window?
> 
> I kind of mentioned this in my note: From my testing, at the instant an
> un-reverted buffer is displayed, it is in its 'stale' state but is also
> instantly considered for auto-revert.

Maybe we should arrange it to actually auto-revert before being
displayed.  I envision bug reports if we don't.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 15:40:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 15 11:40:11 2020
Received: from localhost ([127.0.0.1]:60292 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kID3y-0003jK-Vg
	for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 11:40:11 -0400
Received: from mout.gmx.net ([212.227.17.21]:55847)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kID3w-0003j3-OL
 for 43412 <at> debbugs.gnu.org; Tue, 15 Sep 2020 11:40:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600184402;
 bh=3+uXRWuJWawr9RkjIqN9d9hGcuNFxgk1m9FEalx6cow=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=NKh37AmcpqagYZXfsmytBjjvaShWUMXIXYWqP5g5mcmsPw0SjWOvvjip5/tL/hgYG
 i7BA+Eg12+zV2R2lDsnaKHL0xkepXgjk9TQWx1U2Jisnlk2aVGoavdY4q19+sd09/1
 +xk4S//0bFGlKT1v3Ac5d+rBSsUHsuJdh2b8k+Po=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1MKbkC-1k3r2b2JKu-00L0c0; Tue, 15 Sep 2020 17:40:01 +0200
Date: Tue, 15 Sep 2020 11:39:58 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Message-ID: <20200915153958.e2nry7dxl3pmu3k6@HIDDEN>
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
 <83y2lb8648.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <83y2lb8648.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:8JVunSH8lXCS3mmHvzwvwWKHzGIHUlclyLO6Om4/owjdGHTqj/a
 W5+mn4BOBNo45cY24wTzF4+sQPxKpM7/H3iHoGsvXRYSEa3qHp88RtxpXZjX80QWK2K2vkV
 aHyXSNpD2WK33zKKHrJ0claBMQozR3y+kC32ZBQ92osBP8OZxLIJGPARv5D1nNNmvtMjb+r
 gSivx1Wy8KJOO8tNz+0rQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:mW2Y/kXXtkA=:LAUqQbIR+TwWie9Ilcae11
 WQdMOxpmh5ofXwwqq6EfJlD1/x/RGrpWfzxdCtUEujLqYOmrYbpju/DamK+F7RWiHlridRPeA
 gyqF9dqeBzR6rfQOEcWFS6ztdhWIyI/gmhOyJeJeK1nA379tsuDfbMkYlzdCD1OQqndx11ZGO
 LcPDdVB9DcuNLtg/elsa9P9RGsSXbhR7AiCWOz7ofb7Bm2sUMO9V16+acBFeBoEUdLWL1b+xx
 7fhnwnjuvA9kLm9PXvl1chs7iJnQbPGrNlvQR/qdVuTve2QwcQiPUGHJs0Fe/PQE16Tj3IELM
 eSs6S5ohv/wYWn/MjGgGo7d6O2lmR34NsuN8tKChCHTHTCEmqwECDXjfsx3NJXPBk7xviR+Z2
 fKqPf0ct100tk2OlkfjFHxS7wlMhXvp+P//xrqr3pyfxt57oBtnNYKAUled8yvqpZxOEslV7a
 A7f0mggm0SSyU91g+Jrxn7XFEUMKuRmNaQqBLgiC6tGLYMWkBmugegUX/PkwfvbwsrjGc3VcP
 IyomoB99Hm8l5MN2f3ftCjHb9lfHoYb9xMbsRbLKtc2irAmSJjtwV0vW4Xqe6JzSbO7zaYleb
 Y3wvICUeLu0Swn8f7R1QfYc+hwLsGKsDj6TYxE10p3UF+R67Rh4DvGMIJdLw9265izuPj9L9/
 zvvI4/CPBfIZT9ItyFvy/YpIG0CUzSxu5Glq1PW64Vy/5HVMUBZPmB81B0npG7aaxZAE/LKxI
 sDEekQe/CIZDUM3Yi/X7IAcDcxs+65aWG/UxhV2Jq+zdS/xItx7g9QkxO0ArgEhKQB3Xde6zy
 q7BK2pcNnu1A6DEIhuX0TUA43ShDH9lnpeLELPOT3dP/rz6qN8XuOISSb1v8uUWuCb40k8+ts
 A1vk1dj/XMH4DzbcJv+1oZc0DTyJGSZpEHr6E7qyUFxFNJFlLDXahnu5dSbQZJLngUiUkz1GF
 ImBordoSHZZl0uqmxmvmHRIRgV3oBW+aVG/ieluQAMiNYeulQ5lvjrmFED3Fe1PUnSz3VRt5L
 xrZ4YH4FCbP7jhzSHKOBTtySv1J/5cFnsM2sQqReYWtHdsiumeSZwgfaYoKNgL0GzVNBlSFfB
 tnWGGQPi9QID+APayGozdQOXCH87lcev1rj/FUPNl66Kwp4qjYf9TsAZNxaKrDj19vk9h46ZU
 aa5IOwkEnjAHuHZ7n2ZTFhZLq11AsJdVVlesrBQkSDJiG5C6CUL9DK/18QeVfPsCnS7lAYzEN
 fvU1cBBX51SVCBC5LFYnHtaLnqgb7iJLmaiFtqw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2020-09-15 17:30, Eli Zaretskii wrote:
> > Date: Tue, 15 Sep 2020 00:07:28 -0400
> > From: Boruch Baum <boruch_baum@HIDDEN>
> >
> > +(defcustom auto-revert-only-if-visible nil
> > +  "If non-nil, suppress Auto-Revert Mode when a buffer isn't visible.=
"
>
> "Visible" is ambiguous in this context.  I suggest "not displayed in
> any window" instead.  Or, better, just "auto-revert only if buffer is
> displayed" (which also solved a problem with double negation).

In the case of TTY emacs, only one frame seems possible to ever be
visible, but each and every frame seems to be considered, let's say
'displayed'. In that situation, this patch only auto-reverts buffers
displayed on windows of the actually 'displayed' TTY frame.

> > +  :version "28")
>               ^^^^
> "28.1"

Thanks. I had just taken a guess.

> > +                         (if (display-graphic-p) 'visible (window-nor=
malize-frame nil)))))))
>
> Is the different treatment of GUI and TTY frames necessary here?

For users of TTY emacs (ahem, me), most assuredly. In TTY emacs, AFAICT
only one frame can ever be 'displayed' (actually visible), but function
`get-buffer-window-list' with argument ALL-FRAMES set to 'visible
returns all windows on all frames. From that function's docstring:

  --8<--cut here-(start)------------------------------------------- >8
  - =E2=80=98visible=E2=80=99 means consider all windows on all visible fr=
ames on
    the current terminal.
  --8<--cut here-(end)--------------------------------------------- >8

That behavior of function `get-buffer-window-list' may in turn be
because of the behavior of function `frame-visible-p', whose docstring
begins with:

  --8<--cut here-(start)------------------------------------------- >8
  Return t if FRAME is "visible" (actually in use for display).
  --8<--cut here-(end)--------------------------------------------- >8

But ends with the punch-line:

  --8<--cut here-(start)------------------------------------------- >8
  If FRAME is a text terminal frame, this always returns t.
  Such frames are always considered visible, whether or not they are
  currently being displayed on the terminal.
  --8<--cut here-(end)--------------------------------------------- >8

So since for the purposes of this patch, what matters is the actual user
experience, the distinction *was* needed.

  Off-topic: would anything constructive result if I submit a separate
  'complaint' about that behavior / judgment / decision that 'Such
  frames are always considered visible'?

> Btw, what will be the effect of this option?  Suppose some buffer was
> not displayed and missed its auto-revert opportunity.  Then I switch
> to it in some window -- will it appear with stale contents, or will it
> auto-revert before being displayed in the window?

I kind of mentioned this in my note: From my testing, at the instant an
un-reverted buffer is displayed, it is in its 'stale' state but is also
instantly considered for auto-revert. The *theoretical* maximum delay to
the auto-revert then being performed is based upon defcustom
`auto-revert-interval', whose default is five seconds. In practice, the
possible downsides are that: 1) it might be visually surprising to the
user to see the auto-revert occur; 2) if the user was very hurried to
type at wherever POINT was in the buffer, then the auto-revert would be
further delayed if defcustom `auto-revert-stop-on-user-input' was non-nil
(the default), and would only happen once the hurried typist pauses. In
my anecdotal use / testing / debugging, this has only every happened
when I consciously made the effort to race the auto-revert, but the
experience of a caffeinated or adrenaline-d user might be different.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at 43412 <at> debbugs.gnu.org:


Received: (at 43412) by debbugs.gnu.org; 15 Sep 2020 14:30:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 15 10:30:45 2020
Received: from localhost ([127.0.0.1]:60076 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kIByn-0005ys-4d
	for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 10:30:45 -0400
Received: from eggs.gnu.org ([209.51.188.92]:51072)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1kIByl-0005yf-Ak
 for 43412 <at> debbugs.gnu.org; Tue, 15 Sep 2020 10:30:43 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:46078)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1kIByf-0002Bh-A6; Tue, 15 Sep 2020 10:30:37 -0400
Received: from [176.228.60.248] (port=1228 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1kIByV-0005Sg-Bj; Tue, 15 Sep 2020 10:30:35 -0400
Date: Tue, 15 Sep 2020 17:30:31 +0300
Message-Id: <83y2lb8648.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20200915040728.77ufv7g6bekvrzqa@HIDDEN> (message
 from Boruch Baum on Tue, 15 Sep 2020 00:07:28 -0400)
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
References: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43412
Cc: 43412 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 15 Sep 2020 00:07:28 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> 
> +(defcustom auto-revert-only-if-visible nil
> +  "If non-nil, suppress Auto-Revert Mode when a buffer isn't visible."

"Visible" is ambiguous in this context.  I suggest "not displayed in
any window" instead.  Or, better, just "auto-revert only if buffer is
displayed" (which also solved a problem with double negation).

> +  :version "28")
              ^^^^
"28.1"

> +                         (if (display-graphic-p) 'visible (window-normalize-frame nil)))))))

Is the different treatment of GUI and TTY frames necessary here?

Btw, what will be the effect of this option?  Suppose some buffer was
not displayed and missed its auto-revert opportunity.  Then I switch
to it in some window -- will it appear with stale contents, or will it
auto-revert before being displayed in the window?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 15 Sep 2020 04:07:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 15 00:07:40 2020
Received: from localhost ([127.0.0.1]:56843 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kI2Fo-0003dP-FB
	for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 00:07:40 -0400
Received: from lists.gnu.org ([209.51.188.17]:54332)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kI2Fl-0003dG-MN
 for submit <at> debbugs.gnu.org; Tue, 15 Sep 2020 00:07:38 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:57526)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <boruch_baum@HIDDEN>)
 id 1kI2Fl-000448-Ff
 for bug-gnu-emacs@HIDDEN; Tue, 15 Sep 2020 00:07:37 -0400
Received: from mout.gmx.net ([212.227.17.22]:47345)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <boruch_baum@HIDDEN>)
 id 1kI2Fj-0005Dv-8F
 for bug-gnu-emacs@HIDDEN; Tue, 15 Sep 2020 00:07:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1600142852;
 bh=h7C1u/UJqrsh/YJgL2Ekk6h0NvqMGwscE6E0+0pNm/0=;
 h=X-UI-Sender-Class:Date:From:To:Subject;
 b=A3/QNmjvsLdqQYkq3eZD6dkOlgf8dSf2UlAUhj0/xBP1f/6CGL6yMoVC/usLHWG/L
 FuEfxkaNKT6q8ggw9n3H96XPX5imcJNOCO2uB4n9iNBZ7W9GGsXP4eyBwOfHwLi75T
 g6i5VM7jHXcxEDo2zqnSGj2zvVUdiCUrLmtwba2U=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1MeCtj-1ktI4y2DI7-00bLKM for <bug-gnu-emacs@HIDDEN>; Tue, 15 Sep 2020
 06:07:31 +0200
Date: Tue, 15 Sep 2020 00:07:28 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Emacs Bug Reporting <bug-gnu-emacs@HIDDEN>
Subject: [FEATURE] autorevert-only-if-visible [PATCH]
Message-ID: <20200915040728.77ufv7g6bekvrzqa@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="c3dgevwv4k6pvmht"
Content-Disposition: inline
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:RBLT1cKDuXMPg4V9lJ8da97wxws9aKjxLbe/PD0Gdh4C5GFvp1X
 gxpZp1SUCTpZqs1/pwhz5k1pSWPiX33T1sBUOB47EhIedA45o837LUnyAJbizGq90HZmAGm
 VlSa/2x2+Yawl4wu1Omm9T320DbFk5WfqUYyr5TXKIFT7SUionlhrrKM6miXfyvfHXHh7cO
 3+nbCjqUbfabRr6gv2SPQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:/aeqbMjveZ8=:XdqreI/yFfZqghlfED0cJd
 TCAHY3Zn3fnwjmkFiWlZ7CBHNzxJq/89iJldXyr0QNgaOlQtcINT0Ju1DPEkemq7Msvd5x9rH
 XrCsDyV7ovY+cAjEM2A/PUCptZXJsikMsWBWeeerJ8Fy2XjvmBP/2yQiqF5Pkjokihd9iJwfh
 chHISfLfMOhyuPntCNljHEj4HG9XFvm1tPTDuiq8bePAAkOrcPo4veAvmzneOKi7qDOD8Np50
 CYbKv7qM/dWVB+1CKyv+COWMpgQtCNKSnpYPjIycZrNbh/F7OqnbaAtlcCsx8zhFkbw8RY+sN
 c1z76BU/TxAfX97qnYvE8i40f3ZC2EQEFYPn3nbamUiZ096tDBSJhJpwAbFlwzko1LCPgYpmk
 KqvF7xghp5bU5gV5hYdJ+Uh6qOwc8Vt6yMZ2lOgfWvBUSUX7ilDo+4b2fxHHPAADBc5Qs+Ovf
 V9C2z5rl3FCQb+QHa7iB/Jw+Zrzfua28Rjf45w/ic2d/3MY4h1Id2qbigdtQe7HHbugvFNRM/
 UoL7ja9hFWqVjS8rvK5Uin0mk01XJwtG3HFZrTBaRGAseFJEVO81FFoeocYzViowp0Anek0Uh
 4kx37PZNsW7hlWCQe6qmj3/Ec07N808RBCMSkgyv7IlvcBOsR5fDfrFXiTHHKQURoQZyHu7AJ
 s/Lzgzfn61Dsqp+3DCwAjX3P7/2etkdAXSev5C/ayf3p76uiki/wIn+wdVPVhBSjwG4YGVTFi
 HSPMDrJGh4gJ0vRUy8xUP76Gi8lv3gtpJB1bH0ne2myO+O8s7NYA5N7fyEyjqJku8gWFyjpk9
 vsmKa9HLAcQroBi20VyWBJvM9CyyKHxRyq2xU6kWWZkMOr2ZbLhZyNBvdAmhgqj7qvIw8x1tf
 rkarlVYmXehgLqE3EJiSVV3R9pN74iTTTgXAiZgPjTnYV+5I7BIpfgwcLqz6fE2GrTOo+OYRR
 8WrWZ5FrrNfix3yR10+L4jaL2wJ7mDOFix051F8n4raURy1Z3vfXUehp9xxRDnT6jJdO4TExi
 kb+4Ye2/vHuUc6zhR80MgAlUhHYPOEhiZv2ifSWOKfmTCspRt+aXe5pbQaTPVw+12CJkQIkUM
 wxj7hHi6XXF+2/EDMV7jjVHZxjexam9I6gmXlkmc0YSp0Ua+smBpRbuwRI7/Roo/05D9Gkfba
 y1MyY6pKLcEJQKDTbkmhXEXa5Cfn0YqmqjW1sFH+L5b4pHlf6ut4lwdhXtNBW/pgHylgs4mj4
 4Ontpva3P4n7HVlpkKmTWDhWKH2vzBvtkcqSB0g==
Received-SPF: pass client-ip=212.227.17.22; envelope-from=boruch_baum@HIDDEN;
 helo=mout.gmx.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 00:07:32
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic]
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.6 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)


--c3dgevwv4k6pvmht
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The attached proposed patch adds a defcustom and makes a change to two
existing functions in order to allow a user the option to only have
autorevert mode operate on visible buffers. The change to function
'after-find-files' may also fix a bug (or change behavior) in that
sometimes when being prompted to manually revert a buffer that had been
in auto-revert-mode, the auto-revert-mode status would be lost, ie. set
to nil.

Use of this feature:

1) Reduces CPU workload when using autorevert

2) Reduces messages when using `auto-revert-verbose'

Possible disadvantage:

1) When making a buffer visible, it might take as long as
   'auto-revert-interval' seconds for any accumulated changes to
   auto-revert. The default for that value is five seconds.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

--c3dgevwv4k6pvmht
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="autorevert.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/autorevert.el b/autorevert.el
index 7b83026..ace010e 100644
=2D-- a/autorevert.el
+++ b/autorevert.el
@@ -302,6 +302,12 @@ You should set this variable through Custom."
   :type 'regexp
   :version "24.4")

+(defcustom auto-revert-only-if-visible nil
+  "If non-nil, suppress Auto-Revert Mode when a buffer isn't visible."
+  :group 'auto-revert
+  :type 'boolean
+  :version "28")
+
 ;; Internal variables:

 (defvar auto-revert-buffer-list ()
@@ -686,8 +692,14 @@ This is an internal function used by Auto-Revert Mode=
."
                               #'buffer-stale--default-function)
                           t))))
          eob eoblist)
-    (setq auto-revert-notify-modified-p nil)
-    (when revert
+    (when (and revert
+               (or (not auto-revert-only-if-visible)
+                   (member buffer
+                     (mapcar 'window-buffer
+                       (get-buffer-window-list
+                         nil nil
+                         (if (display-graphic-p) 'visible (window-normali=
ze-frame nil)))))))
+      (setq auto-revert-notify-modified-p nil)
       (when (and auto-revert-verbose
                  (not (eq revert 'fast)))
         (message "Reverting buffer `%s'." (buffer-name)))

--c3dgevwv4k6pvmht
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="files.patch"

diff --git a/files.el b/files.el
index e6629d2..2cdf451 100644
--- a/files.el
+++ b/files.el
@@ -2570,7 +2570,10 @@ unless NOMODES is non-nil."
   (unless nomodes
     (when (and view-read-only view-mode)
       (view-mode -1))
-    (normal-mode t)
+    (let ((auto-revert auto-revert-mode))
+      (normal-mode t)
+      (when auto-revert
+        (auto-revert-mode 1)))
     ;; If requested, add a newline at the end of the file.
     (and (memq require-final-newline '(visit visit-save))
 	 (> (point-max) (point-min))

--c3dgevwv4k6pvmht
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="NEWS.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/NEWS b/NEWS
index 4076630..579f1f9 100644
=2D-- a/NEWS
+++ b/NEWS
@@ -1157,6 +1157,12 @@ type symbols.
 messages, contain the error name of that message now.  They can be
 made visible by setting user variable 'dbus-show-dbus-errors' to
 non-nil, even if protected by 'dbus-ignore-errors' otherwise.
+** Autorevert
+
++++
+*** autorevert can be restricted to act only when a buffer is visible
+
+Enable the feature using defcustom variable 'auto-revert-only-if-visible'=
.

 =0C
 * New Modes and Packages in Emacs 28.1

--c3dgevwv4k6pvmht--




Acknowledgement sent to Boruch Baum <boruch_baum@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#43412; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 29 Sep 2020 15:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.