GNU bug report logs - #43504
[PATCH] gnu: Add scantailor-advanced.

Previous Next

Package: guix-patches;

Reported by: Brendan Tildesley <mail <at> brendan.scot>

Date: Sat, 19 Sep 2020 05:54:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43504 in the body.
You can then email your comments to 43504 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#43504; Package guix-patches. (Sat, 19 Sep 2020 05:54:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brendan Tildesley <mail <at> brendan.scot>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 19 Sep 2020 05:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add scantailor-advanced.
Date: Sat, 19 Sep 2020 15:52:30 +1000
* gnu/packages/image-processing.scm (scantailor-advanced): New variable.
---
 gnu/packages/image-processing.scm | 50 +++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index 9158e14938..c480fae05a 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2020 Pierre Neidhardt <mail <at> ambrevar.xyz>
+;;; Copyright © 2020 Brendan Tildesley <mail <at> brendan.scot>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33,6 +34,7 @@
   #:use-module (guix utils)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (guix build-system qt)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
@@ -1015,3 +1017,51 @@ substitued, as well as collage-style photomosaics, in which rectangular parts
 of the source image at arbitrary positions (i.e. not aligned to a matrix) are
 substituted by matching images.")
       (license license:gpl2))))
+
+(define-public scantailor-advanced
+  (let ((commit "df1f8e25d16e08594d530c18de58f44b1fd7b0a5"))
+    (package
+      (name "scantailor-advanced")
+      (version (string-append "1.0.16-" (string-take commit 7)))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/brendan-t/scantailor-advanced")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0jycvw39yg17zrd2fdmihskkwb3jx2j50479bnqh50jcndligb3f"))))
+      (build-system qt-build-system)
+      (native-inputs
+       `(("qttools" ,qttools)))
+      (inputs
+       `(("boost" ,boost)
+         ("libjpeg" ,libjpeg-turbo)
+         ("libpng" ,libpng)
+         ("libtiff" ,libtiff)
+         ("qtbase" ,qtbase)
+         ("qtsvg" ,qtsvg)
+         ("zlib" ,zlib)))
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           ;; Some tests require a display and fail with offscreen mode.
+           (add-after 'unpack 'disable-failing-tests
+             (lambda _
+               (setenv "ARGS" "--exclude-regex \"imageproc_.*\"")
+               #t)))))
+      (home-page "https://github.com/4lex4/scantailor-advanced")
+      (synopsis "Clean up scanned pages")
+      (description "Scan Tailor is an interactive post-processing tool for
+scanned pages.  It performs operations such as page splitting, deskewing,
+adding/removing borders, and others.  You give it raw scans, and you get pages
+ready to be printed or assembled into a PDF or DJVU file.  Scanning, optical
+character recognition, and assembling multi-page documents are out of scope of
+this project.
+
+Scan Tailer Advanced is a development of Scan Tailer that merges features and
+bug fixes from Scan Tailor Featured and Scan Tailor Enhanced versions.  Guix's
+version additionally includes a Korean translation.")
+      (license license:gpl3+))))
-- 
2.28.0





Information forwarded to guix-patches <at> gnu.org:
bug#43504; Package guix-patches. (Fri, 25 Sep 2020 12:31:02 GMT) Full text and rfc822 format available.

Message #8 received at 43504 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 43504 <at> debbugs.gnu.org
Subject: Re: [bug#43504] [PATCH] gnu: Add scantailor-advanced.
Date: Fri, 25 Sep 2020 14:29:48 +0200
Hello,

> +         (uri (git-reference
> +               (url "https://github.com/brendan-t/scantailor-advanced")
> +               (commit commit)))

What's the reason for not using the upstream 1.0.16 release? Is the only
reason the addition of the Korean translation? In that case, it could be
contributed upstream or added as a side patch I guess.

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#43504; Package guix-patches. (Fri, 25 Sep 2020 20:47:01 GMT) Full text and rfc822 format available.

Message #11 received at 43504 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 43504 <at> debbugs.gnu.org
Subject: Re: [bug#43504] [PATCH] gnu: Add scantailor-advanced.
Date: Sat, 26 Sep 2020 06:46:34 +1000
[Message part 1 (text/plain, inline)]
On September 25, 2020 10:29:48 PM GMT+10:00, Mathieu Othacehe <othacehe <at> gnu.org> wrote:
>
>Hello,
>
>> +         (uri (git-reference
>> +               (url
>"https://github.com/brendan-t/scantailor-advanced")
>> +               (commit commit)))
>
>What's the reason for not using the upstream 1.0.16 release? Is the
>only
>reason the addition of the Korean translation? In that case, it could
>be
>contributed upstream or added as a side patch I guess.
>
>Thanks,
>
>Mathieu

Well I saw the merge request for it and it was ignored, so I just added it manually. Also I wasn't using the latest tag release but the latest commit because the release is 2 years old and there are many fixes and changes afterwards. This is not just the latest release plus the translation but the latest commit plus it, in my own repo. It didn't look like the channel owner was planning to make a release any time soon. Do you think I should just use the latest release then and not worry about it?
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#43504; Package guix-patches. (Thu, 01 Oct 2020 07:38:01 GMT) Full text and rfc822 format available.

Message #14 received at 43504 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 43504 <at> debbugs.gnu.org
Subject: Re: [bug#43504] [PATCH] gnu: Add scantailor-advanced.
Date: Thu, 01 Oct 2020 09:37:01 +0200
Hello Brendan,

> Well I saw the merge request for it and it was ignored, so I just added it manually. Also I wasn't using the latest tag release but the latest commit because the release is 2 years old and there
> are many fixes and changes afterwards. This is not just the latest release plus the translation but the latest commit plus it, in my own repo. It didn't look like the channel owner was planning
> to make a release any time soon. Do you think I should just use the latest release then and not worry about it?

The project is not explicitly discontinued, so maybe you could package
the latest upstream commit. Regarding your translation commit, I saw you
submitted a MR a few days ago, let's see if it gets a review.

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#43504; Package guix-patches. (Thu, 01 Oct 2020 10:24:01 GMT) Full text and rfc822 format available.

Message #17 received at 43504 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 43504 <at> debbugs.gnu.org
Subject: Re: [bug#43504] [PATCH] gnu: Add scantailor-advanced.
Date: Thu, 1 Oct 2020 10:23:04 +0000
[Message part 1 (text/plain, inline)]
On 1/10/20 7:37 am, Mathieu Othacehe wrote:
> Hello Brendan,
>
>> Well I saw the merge request for it and it was ignored, so I just added it manually. Also I wasn't using the latest tag release but the latest commit because the release is 2 years old and there
>> are many fixes and changes afterwards. This is not just the latest release plus the translation but the latest commit plus it, in my own repo. It didn't look like the channel owner was planning
>> to make a release any time soon. Do you think I should just use the latest release then and not worry about it?
> The project is not explicitly discontinued, so maybe you could package
> the latest upstream commit. Regarding your translation commit, I saw you
> submitted a MR a few days ago, let's see if it gets a review.
>
> Thanks,
>
> Mathieu

I attached a new one that uses up stream's latest. By the way, to test 
it, just take a photo of a page from a book, and try load it in. if you 
can go through the steps processing it to a clean output then it should 
be working ok.

[0001-gnu-Add-scantailor-advanced.patch (text/x-patch, attachment)]

Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Thu, 01 Oct 2020 12:25:02 GMT) Full text and rfc822 format available.

Notification sent to Brendan Tildesley <mail <at> brendan.scot>:
bug acknowledged by developer. (Thu, 01 Oct 2020 12:25:02 GMT) Full text and rfc822 format available.

Message #22 received at 43504-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 43504-done <at> debbugs.gnu.org
Subject: Re: [bug#43504] [PATCH] gnu: Add scantailor-advanced.
Date: Thu, 01 Oct 2020 14:23:55 +0200
Hey Brendan,

> I attached a new one that uses up stream's latest. By the way, to test it,
> just take a photo of a page from a book, and try load it in. if you can go
> through the steps processing it to a clean output then it should be working
> ok.

Pushed as a76e9d13e9b5cad2bbfc0433d2f8d0eae2af0b05.

Thanks,

Mathieu




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 30 Oct 2020 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 151 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.