X-Loop: help-debbugs@HIDDEN Subject: bug#43506: 26.1; line-height sometimes has no effect on the line height Resent-From: Markus Triska <triska@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 19 Sep 2020 07:22:01 +0000 Resent-Message-ID: <handler.43506.B.160050009219355 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 43506 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 43506 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.160050009219355 (code B ref -1); Sat, 19 Sep 2020 07:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Sep 2020 07:21:32 +0000 Received: from localhost ([127.0.0.1]:45565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kJXBb-000526-Np for submit <at> debbugs.gnu.org; Sat, 19 Sep 2020 03:21:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:57032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <triska@HIDDEN>) id 1kJXBa-00051x-15 for submit <at> debbugs.gnu.org; Sat, 19 Sep 2020 03:21:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <triska@HIDDEN>) id 1kJXBZ-00079i-Rx for bug-gnu-emacs@HIDDEN; Sat, 19 Sep 2020 03:21:29 -0400 Received: from [78.47.144.35] (port=58146 helo=metalevel.at) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <triska@HIDDEN>) id 1kJXBY-0006xU-4i for bug-gnu-emacs@HIDDEN; Sat, 19 Sep 2020 03:21:29 -0400 Received: from mt-mbpro.localdomain (localhost [127.0.0.1]) by metalevel.at (Postfix) with ESMTP id 01D6D9E759 for <bug-gnu-emacs@HIDDEN>; Sat, 19 Sep 2020 09:21:24 +0200 (CEST) Received: by mt-mbpro.localdomain (Postfix, from userid 501) id 0CCDA1189D6C; Sat, 19 Sep 2020 09:21:38 +0200 (CEST) From: Markus Triska <triska@HIDDEN> Date: Sat, 19 Sep 2020 09:21:38 +0200 Message-ID: <m21riyjkot.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 78.47.144.35 (failed) Received-SPF: none client-ip=78.47.144.35; envelope-from=triska@HIDDEN; helo=metalevel.at X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/19 03:21:25 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) To reproduce this issue, please start Emacs with "emacs -Q" and then evaluate the following form: (progn (goto-char (point-max)) (insert "\n") (insert (propertize "\n" 'line-height 3)) (forward-line -1) (line-pixel-height)) In my case, the minibuffer then states "17". The expected result is 3, because documentation states: A newline can have a =E2=80=98line-height=E2=80=99 text or overlay p= roperty that controls the total height of the display line ending in that newline. For comparison, it works exactly as expected if I change "3" to "300" in the snippet above, yielding "300" in the minibuffer. If possible, could you please make line-height control the total height of the display line also in the original example, or alternatively consider changing the documentation to mention all relevant exceptions? Thank you and all the best! Markus In GNU Emacs 26.1 (build 1, x86_64-apple-darwin15.3.0, X toolkit, Xaw scrol= l bars) of 2018-09-22 built on mt-laptop Windowing system distributor 'The X.Org Foundation', version 11.0.11502000
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Markus Triska <triska@HIDDEN> Subject: bug#43506: Acknowledgement (26.1; line-height sometimes has no effect on the line height) Message-ID: <handler.43506.B.160050009219355.ack <at> debbugs.gnu.org> References: <m21riyjkot.fsf@HIDDEN> X-Gnu-PR-Message: ack 43506 X-Gnu-PR-Package: emacs Reply-To: 43506 <at> debbugs.gnu.org Date: Sat, 19 Sep 2020 07:22:01 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 43506 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 43506: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43506 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#43506: 26.1; line-height sometimes has no effect on the line height Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 19 Sep 2020 08:46:02 +0000 Resent-Message-ID: <handler.43506.B43506.160050510427350 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 43506 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Markus Triska <triska@HIDDEN> Cc: 43506 <at> debbugs.gnu.org Received: via spool by 43506-submit <at> debbugs.gnu.org id=B43506.160050510427350 (code B ref 43506); Sat, 19 Sep 2020 08:46:02 +0000 Received: (at 43506) by debbugs.gnu.org; 19 Sep 2020 08:45:04 +0000 Received: from localhost ([127.0.0.1]:45626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kJYUR-00076c-Aw for submit <at> debbugs.gnu.org; Sat, 19 Sep 2020 04:45:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1kJYUP-00074v-1q; Sat, 19 Sep 2020 04:45:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41797) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1kJYUJ-0007Nm-77; Sat, 19 Sep 2020 04:44:55 -0400 Received: from [176.228.60.248] (port=3202 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1kJYUF-0007Dc-D4; Sat, 19 Sep 2020 04:44:51 -0400 Date: Sat, 19 Sep 2020 11:45:06 +0300 Message-Id: <83r1qy2m0d.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <m21riyjkot.fsf@HIDDEN> (message from Markus Triska on Sat, 19 Sep 2020 09:21:38 +0200) References: <m21riyjkot.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) tags 43506 notabug thanks > From: Markus Triska <triska@HIDDEN> > Date: Sat, 19 Sep 2020 09:21:38 +0200 > > (progn > (goto-char (point-max)) > (insert "\n") > (insert (propertize "\n" 'line-height 3)) > (forward-line -1) > (line-pixel-height)) > > In my case, the minibuffer then states "17". The expected result is 3, > because documentation states: > > A newline can have a ‘line-height’ text or overlay property that > controls the total height of the display line ending in that newline. That's not all the documentation says about 'line-height'. It also says this (in the "Line Height" node referenced from the place you cite): There are several ways to explicitly specify a larger line height, either by specifying an absolute height for the display line, or by specifying vertical space. However, no matter what you specify, the actual line height can never be less than the default. [...] Finally, a newline can have a ‘line-spacing’ text or overlay property that can enlarge the default frame line spacing and the buffer local ‘line-spacing’ variable: if its value is larger than the buffer or frame defaults, that larger value is used instead, for the display line ending in that newline. IOW, this property can only enlarge the line's height, which is confirmed by the fact that using 300 in your example does work as expected. This is not a bug. This property exists so a Lisp program could produce higher lines than the default. To produce lower lines, you can use a face with a low :height attribute, and arrange for the newline to have that face. You can find an example of doing that in log-edit.el. > If possible, could you please make line-height control the total height > of the display line also in the original example, or alternatively > consider changing the documentation to mention all relevant exceptions? The documentation already mentions the limitations, see above.
Received: (at control) by debbugs.gnu.org; 19 Sep 2020 08:45:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 19 04:45:03 2020 Received: from localhost ([127.0.0.1]:45624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1kJYUR-00076J-0B for submit <at> debbugs.gnu.org; Sat, 19 Sep 2020 04:45:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1kJYUP-00074v-1q; Sat, 19 Sep 2020 04:45:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41797) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1kJYUJ-0007Nm-77; Sat, 19 Sep 2020 04:44:55 -0400 Received: from [176.228.60.248] (port=3202 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1kJYUF-0007Dc-D4; Sat, 19 Sep 2020 04:44:51 -0400 Date: Sat, 19 Sep 2020 11:45:06 +0300 Message-Id: <83r1qy2m0d.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Markus Triska <triska@HIDDEN> In-Reply-To: <m21riyjkot.fsf@HIDDEN> (message from Markus Triska on Sat, 19 Sep 2020 09:21:38 +0200) Subject: Re: bug#43506: 26.1; line-height sometimes has no effect on the line height References: <m21riyjkot.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 43506 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) tags 43506 notabug thanks > From: Markus Triska <triska@HIDDEN> > Date: Sat, 19 Sep 2020 09:21:38 +0200 > > (progn > (goto-char (point-max)) > (insert "\n") > (insert (propertize "\n" 'line-height 3)) > (forward-line -1) > (line-pixel-height)) > > In my case, the minibuffer then states "17". The expected result is 3, > because documentation states: > > A newline can have a ‘line-height’ text or overlay property that > controls the total height of the display line ending in that newline. That's not all the documentation says about 'line-height'. It also says this (in the "Line Height" node referenced from the place you cite): There are several ways to explicitly specify a larger line height, either by specifying an absolute height for the display line, or by specifying vertical space. However, no matter what you specify, the actual line height can never be less than the default. [...] Finally, a newline can have a ‘line-spacing’ text or overlay property that can enlarge the default frame line spacing and the buffer local ‘line-spacing’ variable: if its value is larger than the buffer or frame defaults, that larger value is used instead, for the display line ending in that newline. IOW, this property can only enlarge the line's height, which is confirmed by the fact that using 300 in your example does work as expected. This is not a bug. This property exists so a Lisp program could produce higher lines than the default. To produce lower lines, you can use a face with a low :height attribute, and arrange for the newline to have that face. You can find an example of doing that in log-edit.el. > If possible, could you please make line-height control the total height > of the display line also in the original example, or alternatively > consider changing the documentation to mention all relevant exceptions? The documentation already mentions the limitations, see above.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.