GNU bug report logs - #43576
[PATCH] gnu: nng: Update to build as shared library

Previous Next

Package: guix-patches;

Reported by: "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>

Date: Wed, 23 Sep 2020 08:13:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43576 in the body.
You can then email your comments to 43576 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#43576; Package guix-patches. (Wed, 23 Sep 2020 08:13:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 23 Sep 2020 08:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: nng: Update to build as shared library
Date: Wed, 23 Sep 2020 11:41:25 +0330

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 89e47a6726..a5aac7b878 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -419,7 +419,9 @@ at the link-layer level.")
     (arguments
      `(#:configure-flags
        (list "-DNNG_ENABLE_COVERAGE=ON"
-             "-DNNG_ENABLE_TLS=ON")
+             "-DNNG_ENABLE_TLS=ON"
+             ;; To building as shared library
+             "-DBUILD_SHARED_LIBS=ON")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'disable-failing-tests
Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Wed, 23 Sep 2020 09:15:01 GMT) Full text and rfc822 format available.
Notification sent to "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>:
bug acknowledged by developer. (Wed, 23 Sep 2020 09:15:02 GMT) Full text and rfc822 format available.

Message #10 received at 43576-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Hamzeh Nasajpour <h.nasajpour <at> pantherx.org>
Cc: 43576-done <at> debbugs.gnu.org
Subject: Re: [bug#43576] [PATCH] gnu: nng: Update to build as shared library
Date: Wed, 23 Sep 2020 12:14:12 +0300

[Message part 1 (text/plain, inline)]
On Wed, Sep 23, 2020 at 11:41:25AM +0330, Hamzeh Nasajpour wrote:
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 89e47a6726..a5aac7b878 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -419,7 +419,9 @@ at the link-layer level.")
>      (arguments
>       `(#:configure-flags
>         (list "-DNNG_ENABLE_COVERAGE=ON"
> -             "-DNNG_ENABLE_TLS=ON")
> +             "-DNNG_ENABLE_TLS=ON"
> +             ;; To building as shared library

This comment isn't really necessary

> +             "-DBUILD_SHARED_LIBS=ON")
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'disable-failing-tests
> 

I created a whole commit message, added a copyright line for you
and pushed the patch. Thanks!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 21 Oct 2020 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 188 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.