GNU bug report logs - #43644
Double quote missing from exec-shell-cmd button command when run

Previous Next

Package: hyperbole;

Reported by: Natalie Jones <devnat212 <at> gmail.com>

Date: Sun, 27 Sep 2020 09:43:02 UTC

Severity: normal

Tags: confirmed

Done: Bob Weiner <rsw <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43644 in the body.
You can then email your comments to 43644 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-hyperbole <at> gnu.org:
bug#43644; Package hyperbole. (Sun, 27 Sep 2020 09:43:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Natalie Jones <devnat212 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-hyperbole <at> gnu.org. (Sun, 27 Sep 2020 09:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Natalie Jones <devnat212 <at> gmail.com>
To: bug-hyperbole <at> gnu.org
Subject: Double quote missing from exec-shell-cmd button command when run
Date: Sun, 27 Sep 2020 02:15:43 -0400
I'm using hyperbole 7.1.3 on Emacs 26.1 on Debian buster.

To reproduce

1. Create new personal button file

2. Create a new explicit button, action type: exec-shell-command, shell 
cmd: notify-send "test", select no for the rest of the questions

3. Activate the button

What you see:

notify-send "test

What you should see:

notify-send "test"


The second double quote is missing for some reason and the notification 
won't send.





Information forwarded to bug-hyperbole <at> gnu.org:
bug#43644; Package hyperbole. (Sun, 27 Sep 2020 16:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 43644 <at> debbugs.gnu.org (full text, mbox):

From: Robert Weiner <rswgnu <at> gmail.com>
To: Natalie Jones <devnat212 <at> gmail.com>
Cc: 43644 <at> debbugs.gnu.org
Subject: Re: bug#43644: Double quote missing from exec-shell-cmd button
 command when run
Date: Sun, 27 Sep 2020 12:47:55 -0400
Thanks for the report.  We will look into fixing this.

> On Sep 27, 2020, at 5:43 AM, Natalie Jones <devnat212 <at> gmail.com> wrote:
> 
> I'm using hyperbole 7.1.3 on Emacs 26.1 on Debian buster.
> 
> To reproduce
> 
> 1. Create new personal button file
> 
> 2. Create a new explicit button, action type: exec-shell-command, shell cmd: notify-send "test", select no for the rest of the questions
> 
> 3. Activate the button
> 
> What you see:
> 
> notify-send "test
> 
> What you should see:
> 
> notify-send "test"
> 
> 
> The second double quote is missing for some reason and the notification won't send.
> 
> 
> 
> 
> _______________________________________________
> Bug-hyperbole mailing list
> Bug-hyperbole <at> gnu.org
> https://lists.gnu.org/mailman/listinfo/bug-hyperbole




Added tag(s) confirmed. Request was from Mats Lidell <matsl <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 14 Oct 2020 21:08:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-hyperbole <at> gnu.org:
bug#43644; Package hyperbole. (Sun, 22 Nov 2020 17:49:01 GMT) Full text and rfc822 format available.

Message #13 received at 43644 <at> debbugs.gnu.org (full text, mbox):

From: Robert Weiner <rsw <at> gnu.org>
To: Natalie Jones <devnat212 <at> gmail.com>
Cc: 43644 <at> debbugs.gnu.org
Subject: Re: bug#43644: Double quote missing from exec-shell-cmd button
 command when run
Date: Sun, 22 Nov 2020 12:47:42 -0500
[Message part 1 (text/plain, inline)]
This has been resolved in the latest master git branch of Hyperbole and
will be integrated into the next release.

If you replace this function in "${hyperb:dir}/hpath.el" with this version,
reload and
then modify your global button, {C-h h g m}, so the shell command is
correct, and then re-activate the button it should work.

-- Bob

(defun hpath:trim (path)
  "Return PATH with any [\" \t\n\r] characters trimmed from its start and
end."
  ;; Trim only matching starting and ending quoted double quotes (must
  ;; be a single line string).
  (setq path (string-trim path))
  (when (string-match "\\`\".*\"\\'" path)
    (setq path (string-trim path "\"" "\"")))
  path)

On Sun, Sep 27, 2020 at 12:47 PM Robert Weiner <rswgnu <at> gmail.com> wrote:

> Thanks for the report.  We will look into fixing this.
>
> > On Sep 27, 2020, at 5:43 AM, Natalie Jones <devnat212 <at> gmail.com> wrote:
> >
> > I'm using hyperbole 7.1.3 on Emacs 26.1 on Debian buster.
> >
> > To reproduce
> >
> > 1. Create new personal button file
> >
> > 2. Create a new explicit button, action type: exec-shell-command, shell
> cmd: notify-send "test", select no for the rest of the questions
> >
> > 3. Activate the button
> >
> > What you see:
> >
> > notify-send "test
> >
> > What you should see:
> >
> > notify-send "test"
> >
> >
> > The second double quote is missing for some reason and the notification
> won't send.
> >
> >
> >
> >
> > _______________________________________________
> > Bug-hyperbole mailing list
> > Bug-hyperbole <at> gnu.org
> > https://lists.gnu.org/mailman/listinfo/bug-hyperbole
>
[Message part 2 (text/html, inline)]

bug closed, send any further explanations to 43644 <at> debbugs.gnu.org and Natalie Jones <devnat212 <at> gmail.com> Request was from Bob Weiner <rsw <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 29 Nov 2020 15:45:01 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 28 Dec 2020 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 91 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.