GNU bug report logs - #43781
[PATCH 0/2] gnu: Add cgoban

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Tomás Ortín Fernández <tomasortin@HIDDEN>; Keywords: patch; dated Sat, 3 Oct 2020 18:40:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 43781 <at> debbugs.gnu.org:


Received: (at 43781) by debbugs.gnu.org; 26 Oct 2020 10:44:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 26 06:44:23 2020
Received: from localhost ([127.0.0.1]:38575 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kWzzC-0004OH-OV
	for submit <at> debbugs.gnu.org; Mon, 26 Oct 2020 06:44:23 -0400
Received: from eggs.gnu.org ([209.51.188.92]:47524)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1kWzzA-0004O3-JK
 for 43781 <at> debbugs.gnu.org; Mon, 26 Oct 2020 06:44:20 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:51874)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1kWzz4-0003L0-3F; Mon, 26 Oct 2020 06:44:14 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60814 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1kWzz0-0005fk-BG; Mon, 26 Oct 2020 06:44:13 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: =?utf-8?B?VG9tw6FzIE9ydMOtbg==?= <tomasortin@HIDDEN>
Subject: Re: [bug#43781] [PATCH 2/2] gnu: Add cgoban
References: <d735688d-2268-5da4-afb2-368aa10b257f@HIDDEN>
 <9f324abb-f935-b748-526b-467113e87670@HIDDEN>
 <871rhqtimt.fsf@HIDDEN>
 <264BCB13-4FA2-4713-810E-2704D3E45A15@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 5 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Mon, 26 Oct 2020 11:44:09 +0100
In-Reply-To: <264BCB13-4FA2-4713-810E-2704D3E45A15@HIDDEN>
 (=?utf-8?Q?=22Tom=C3=A1s=09Ort=C3=ADn=22's?= message of "Thu, 22 Oct 2020
 15:07:43 +0000")
Message-ID: <87v9exb72e.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43781
Cc: 43781 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Tom=C3=A1s,

(Please keep the bug Cc=E2=80=99d.)

Tom=C3=A1s Ort=C3=ADn <tomasortin@HIDDEN> skribis:

> About the patch: it's taken from the Gentoo package. I first tried packag=
ing cgoban without any package and it consistently failed at configure phas=
e, no matter the flags I passed. I decided to check the Gentoo package to s=
ee how they built it, as I have used cgoban in that distribution before and=
 works well, and saw they just added this patch. Tried adding it, and it wo=
rks. But I won't pretend to understand why.

I tested it: it builds just fine without the =E2=80=98configure.in=E2=80=99=
 patch.  :-)

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.





Information forwarded to guix-patches@HIDDEN:
bug#43781; Package guix-patches. Full text available.

Message received at 43781 <at> debbugs.gnu.org:


Received: (at 43781) by debbugs.gnu.org; 26 Oct 2020 10:40:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 26 06:40:48 2020
Received: from localhost ([127.0.0.1]:38571 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kWzvj-0004Ii-VL
	for submit <at> debbugs.gnu.org; Mon, 26 Oct 2020 06:40:48 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46608)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tomasortin@HIDDEN>) id 1kWzvi-0004IV-0O
 for 43781 <at> debbugs.gnu.org; Mon, 26 Oct 2020 06:40:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:51872)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tomasortin@HIDDEN>) id 1kWzvc-00024g-Oa
 for 43781 <at> debbugs.gnu.org; Mon, 26 Oct 2020 06:40:40 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60784 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <tomasortin@HIDDEN>)
 id 1kWzvb-0005Xp-Cr
 for 43781 <at> debbugs.gnu.org; Mon, 26 Oct 2020 06:40:40 -0400
Resent-To: 43781 <at> debbugs.gnu.org
Resent-From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Resent-Date: Mon, 26 Oct 2020 11:40:38 +0100
Resent-Message-ID: <874kmhclsp.fsf@HIDDEN>
Received: from solo.fdn.fr ([unix socket])
 by solo (Cyrus 2.5.10-Debian-2.5.10-3.2) with LMTPA;
 Thu, 22 Oct 2020 17:08:08 +0200
X-Sieve: CMU Sieve 2.4
Received: by solo.fdn.fr (Postfix)
 id 6983AD0EC1; Thu, 22 Oct 2020 17:08:08 +0200 (CEST)
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by solo.fdn.fr (Postfix) with ESMTPS id 51250D0EBF
 for <ludovic.courtes@HIDDEN>; Thu, 22 Oct 2020 17:08:08 +0200 (CEST)
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44896)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tomasortin@HIDDEN>) id 1kVcCD-0000w9-H2
 for ludovic.courtes@HIDDEN; Thu, 22 Oct 2020 11:08:05 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:36888)
 by fencepost.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <tomasortin@HIDDEN>)
 id 1kVcCC-0006wW-WC for ludo@HIDDEN; Thu, 22 Oct 2020 11:08:05 -0400
Received: from mout-p-103.mailbox.org ([80.241.56.161]:40714)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <tomasortin@HIDDEN>)
 id 1kVcCA-0000uK-AC for ludo@HIDDEN; Thu, 22 Oct 2020 11:08:04 -0400
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:105:465:1:2:0])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)
 server-digest SHA256) (No client certificate requested)
 by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4CH9hp4xRLzQjgR
 for <ludo@HIDDEN>; Thu, 22 Oct 2020 17:07:54 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h=
 message-id:from:from:reply-to:subject:subject
 :content-transfer-encoding:content-type:content-type
 :mime-version:references:in-reply-to:date:date:received; s=
 mail20150812; t=1603379271; bh=Jbw0WbcRiNgn1eAHT+LMD3lfMyabYte09
 wSGCNigeiM=; b=GpxCcAikLny5Q0taIev2nJLLAYxIs/tXzXz5J4FGvpnpDd8f5
 i/asb7GdK+ixUOdUab5YxEUt2eXXzaYAo8jCS1dzdV7SOGZvxgZ1p/HfEw1kxWWc
 Qv0t3ywFW1lfgaKvfU8M/JxMqE74rlVNptQYX23EVQBui24kS097enW/1FAO+gpB
 e/gkylq3jU+zDpsASq25m3ebZZUVq51JsKsZXU9N83jLzWzAbWaFH1n8I7Zm/edJ
 kyabYZBsiHnyh8lA2dbX/Ixi4uzUyoK330sSO5+da8uxAO1WWw0AYdS/NqFjr5ld
 SDh7TZpIElEDeWPpnTHx4Mm5GjmZaWsISB7fA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812;
 t=1603379272; h=from:from:reply-to:reply-to:subject:subject:date:date:
 message-id:message-id:to:to:cc:mime-version:mime-version:
 content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;
 bh=oyPulrdGjPE9a4Euu16LWI8cZkaOtcGKlfOEr2aiGJQ=;
 b=cRuZ1JhCx7usaqao3yYCGHLxjxHtdYPJbP0gpBHAmUpuvxpbLHCqN8ms+1FazQqKRkr6Zj
 29lmI2rDd8lCpRYVW2rgS0yRh4y4OC+i8EVJAdebx720611/KjiZVTk9esU+Vwz07RuTAc
 AOygy06ancTKuW4K8rQq5qj0gaAP7ryrX68rQQ6pY/YDHr+/1r1fQRlFFkqLEp0uFrUZGU
 ydQgBf+oz7/4zpHq/zCaGSNjX0avYKI56ErQ7RTO1EUiDBefOGWCgKQ2jvsSRzRB+4JNYm
 tP43s6MnMBiww11B9N59K+zDbdF5i4sglhjxZtL31f2b/pe2Ha/4C7ADNrY3Pg==
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp2.mailbox.org ([80.241.60.241])
 by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de
 [80.241.56.117]) (amavisd-new, port 10030)
 with ESMTP id OYWEbmDAzvvl for <ludo@HIDDEN>;
 Thu, 22 Oct 2020 17:07:51 +0200 (CEST)
Date: Thu, 22 Oct 2020 15:07:43 +0000
In-Reply-To: <871rhqtimt.fsf@HIDDEN>
References: <d735688d-2268-5da4-afb2-368aa10b257f@HIDDEN>
 <9f324abb-f935-b748-526b-467113e87670@HIDDEN>
 <871rhqtimt.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary="----VBO8B94DN398MZ1CXDYBF8CT6FDEI4"
Content-Transfer-Encoding: 7bit
Autocrypt: addr=tomasortin@HIDDEN; keydata=
 mDMEXzVXOhYJKwYBBAHaRw8BAQdAeV1PZETqdYSWKXvjaQvW/ZxH1qzGPj6VOUSfb8NrwZe0Fjxx
 dWFucm9uZ0BtYWlsYm94Lm9yZz6IiwQQFggAMwIZAQUCXzVXOgIbAwQLCQgHBhUICQoLAgMWAgEW
 IQSzlJJOBRtHeAIgnZD2jh7SIrkW/AAKCRD2jh7SIrkW/BJqAQDElzT+1zLmB6ea1W4rCdXb24ix
 tS3eMJMc3SOs+B67ygD/VfM1sLuDr68Bruvxz5JLSfRnbfHPzMOTOD0AXKRj3g+4OARfNVc6Egor
 BgEEAZdVAQUBAQdAcPfPBXKr57IFDIfZtWPGRWiYIGcSASTJ2BlrkVzvRE4DAQgHiHgEGBYIACAF
 Al81VzoCGwwWIQSzlJJOBRtHeAIgnZD2jh7SIrkW/AAKCRD2jh7SIrkW/Aq0AQDIQcD+w8jgbGrx
 sq8A1AeGhWc26fGkh6Bs7Vp/deUxfgD/REXV5Xq9QJfdhi/Rd1vF/xjFvKSOHUQ+fUGipDg3pgs=
Subject: Re: [bug#43781] [PATCH 2/2] gnu: Add cgoban
To: =?ISO-8859-1?Q?Ludovic_Court=E8s?= <ludo@HIDDEN>
From: =?ISO-8859-1?Q?Tom=E1s_Ort=EDn?= <tomasortin@HIDDEN>
Message-ID: <264BCB13-4FA2-4713-810E-2704D3E45A15@HIDDEN>
X-MBO-SPAM-Probability: 
X-Rspamd-Score: -6.23 / 15.00 / 15.00
X-Rspamd-Queue-Id: 952781710
X-Rspamd-UID: a7a253
Received-SPF: pass client-ip=80.241.56.161;
 envelope-from=tomasortin@HIDDEN; helo=mout-p-103.mailbox.org
X-detected-operating-system: by eggs.gnu.org: First seen    = 2020/10/22
 11:07:54
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic] [fuzzy]
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ)
 BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
 DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7,
 RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: 43781
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: tomasortin@HIDDEN
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

------VBO8B94DN398MZ1CXDYBF8CT6FDEI4
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hello,

Thank you for your feedback=2E I will add a comment about the tests=2E

About the patch: it's taken from the Gentoo package=2E I first tried packa=
ging cgoban without any package and it consistently failed at configure pha=
se, no matter the flags I passed=2E I decided to check the Gentoo package t=
o see how they built it, as I have used cgoban in that distribution before =
and works well, and saw they just added this patch=2E Tried adding it, and =
it works=2E But I won't pretend to understand why=2E

If adding the patch is not a good solution, could someone help me figure o=
ut how to properly pack cgoban? Sorry about the inconvenience=2E

Tom=C3=A1s Ort=C3=ADn

On October 22, 2020 2:55:38 PM UTC, "Ludovic Court=C3=A8s" <ludo@gnu=2Eorg=
> wrote:
>Hi,
>
>Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez <tomasortin@mailbox=2Eorg> skribis:
>
>> Sorry, I see I should have sent it all in one email=2E
>>
>> * gnu/packages/games=2Escm (cgoban): New variable=2E
>
>Sorry for the delay!  Some comments:
>
>> +    (arguments
>> +     `(#:tests? #t))
>
>Please add a short comment explaining why tests are disabled=2E
>
>> --- /dev/null
>> +++ b/gnu/packages/patches/cgoban-1=2E9=2E14-cflags=2Epatch
>> @@ -0,0 +1,40 @@
>> +--- a/configure=2Ein
>> ++++ b/configure=2Ein
>
>Patches should start with a couple lines stating the origin, their
>upstream status, and what they do=2E
>
>Patches also need to be listed in =E2=80=98gnu/local=2Emk=E2=80=99 and me=
ntioned in the
>commit log=2E
>
>However, I suspect this patch has no effect: since =E2=80=98autoconf=E2=
=80=99 is not an
>input of the package, its =E2=80=98configure=E2=80=99 script cannot be re=
built to take
>those changes into account=2E
>
>Perhaps you can just remove it?
>
>Could you send a second version?
>
>Thanks!
>
>Ludo=E2=80=99=2E

------VBO8B94DN398MZ1CXDYBF8CT6FDEI4
Content-Type: text/html;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head></head><body>Hello,<br><br>Thank you for your feedback=2E I wil=
l add a comment about the tests=2E<br><br>About the patch: it's taken from =
the Gentoo package=2E I first tried packaging cgoban without any package an=
d it consistently failed at configure phase, no matter the flags I passed=
=2E I decided to check the Gentoo package to see how they built it, as I ha=
ve used cgoban in that distribution before and works well, and saw they jus=
t added this patch=2E Tried adding it, and it works=2E But I won't pretend =
to understand why=2E<br><br>If adding the patch is not a good solution, cou=
ld someone help me figure out how to properly pack cgoban? Sorry about the =
inconvenience=2E<br><br>Tom=C3=A1s Ort=C3=ADn<br><br><div class=3D"gmail_qu=
ote">On October 22, 2020 2:55:38 PM UTC, "Ludovic Court=C3=A8s" &lt;ludo@gn=
u=2Eorg&gt; wrote:<blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0p=
t 0pt 0=2E8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex=
;">
<pre class=3D"k9mail">Hi,<br><br>Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez &lt;=
tomasortin@mailbox=2Eorg&gt; skribis:<br><br><blockquote class=3D"gmail_quo=
te" style=3D"margin: 0pt 0pt 1ex 0=2E8ex; border-left: 1px solid #729fcf; p=
adding-left: 1ex;"> Sorry, I see I should have sent it all in one email=2E<=
br><br> * gnu/packages/games=2Escm (cgoban): New variable=2E<br></blockquot=
e><br>Sorry for the delay!  Some comments:<br><br><blockquote class=3D"gmai=
l_quote" style=3D"margin: 0pt 0pt 1ex 0=2E8ex; border-left: 1px solid #729f=
cf; padding-left: 1ex;">+    (arguments<br>+     `(#:tests? #t))<br></block=
quote><br>Please add a short comment explaining why tests are disabled=2E<b=
r><br><blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 1ex 0=2E8e=
x; border-left: 1px solid #729fcf; padding-left: 1ex;">--- /dev/null<br>+++=
 b/gnu/packages/patches/cgoban-1=2E9=2E14-cflags=2Epatch<br>@@ -0,0 +1,40 @=
@<br>+--- a/configure=2Ein<br>++++ b/configure=2Ein<br></blockquote><br>Pat=
ches should start with a couple lines stating the origin, their<br>upstream=
 status, and what they do=2E<br><br>Patches also need to be listed in =E2=
=80=98gnu/local=2Emk=E2=80=99 and mentioned in the<br>commit log=2E<br><br>=
However, I suspect this patch has no effect: since =E2=80=98autoconf=E2=80=
=99 is not an<br>input of the package, its =E2=80=98configure=E2=80=99 scri=
pt cannot be rebuilt to take<br>those changes into account=2E<br><br>Perhap=
s you can just remove it?<br><br>Could you send a second version?<br><br>Th=
anks!<br><br>Ludo=E2=80=99=2E<br></pre></blockquote></div></body></html>
------VBO8B94DN398MZ1CXDYBF8CT6FDEI4--




Information forwarded to guix-patches@HIDDEN:
bug#43781; Package guix-patches. Full text available.

Message received at 43781 <at> debbugs.gnu.org:


Received: (at 43781) by debbugs.gnu.org; 22 Oct 2020 14:55:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 22 10:55:52 2020
Received: from localhost ([127.0.0.1]:53480 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kVc0N-0008UT-U5
	for submit <at> debbugs.gnu.org; Thu, 22 Oct 2020 10:55:52 -0400
Received: from eggs.gnu.org ([209.51.188.92]:56856)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1kVc0L-0008UF-RG
 for 43781 <at> debbugs.gnu.org; Thu, 22 Oct 2020 10:55:50 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44566)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1kVc0E-0007XZ-UE; Thu, 22 Oct 2020 10:55:43 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51364 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1kVc0D-0001jQ-9v; Thu, 22 Oct 2020 10:55:42 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: =?utf-8?Q?Tom=C3=A1s_Ort=C3=ADn_Fern=C3=A1ndez?= <tomasortin@HIDDEN>
Subject: Re: [bug#43781] [PATCH 2/2] gnu: Add cgoban
References: <d735688d-2268-5da4-afb2-368aa10b257f@HIDDEN>
 <9f324abb-f935-b748-526b-467113e87670@HIDDEN>
Date: Thu, 22 Oct 2020 16:55:38 +0200
In-Reply-To: <9f324abb-f935-b748-526b-467113e87670@HIDDEN>
 (=?utf-8?Q?=22Tom=C3=A1s_Ort=C3=ADn=09Fern=C3=A1ndez=22's?= message of
 "Sat, 3 Oct 2020 21:05:46 +0200")
Message-ID: <871rhqtimt.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43781
Cc: 43781 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez <tomasortin@HIDDEN> skribis:

> Sorry, I see I should have sent it all in one email.
>
> * gnu/packages/games.scm (cgoban): New variable.

Sorry for the delay!  Some comments:

> +    (arguments
> +     `(#:tests? #t))

Please add a short comment explaining why tests are disabled.

> --- /dev/null
> +++ b/gnu/packages/patches/cgoban-1.9.14-cflags.patch
> @@ -0,0 +1,40 @@
> +--- a/configure.in
> ++++ b/configure.in

Patches should start with a couple lines stating the origin, their
upstream status, and what they do.

Patches also need to be listed in =E2=80=98gnu/local.mk=E2=80=99 and mentio=
ned in the
commit log.

However, I suspect this patch has no effect: since =E2=80=98autoconf=E2=80=
=99 is not an
input of the package, its =E2=80=98configure=E2=80=99 script cannot be rebu=
ilt to take
those changes into account.

Perhaps you can just remove it?

Could you send a second version?

Thanks!

Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#43781; Package guix-patches. Full text available.

Message received at 43781 <at> debbugs.gnu.org:


Received: (at 43781) by debbugs.gnu.org; 3 Oct 2020 19:06:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 03 15:06:08 2020
Received: from localhost ([127.0.0.1]:44499 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kOmr6-0002BR-DC
	for submit <at> debbugs.gnu.org; Sat, 03 Oct 2020 15:06:08 -0400
Received: from mout-p-202.mailbox.org ([80.241.56.172]:60052)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tomasortin@HIDDEN>) id 1kOmr3-0002At-D4
 for 43781 <at> debbugs.gnu.org; Sat, 03 Oct 2020 15:06:02 -0400
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:105:465:1:2:0])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4C3btB6nmSzQlKH
 for <43781 <at> debbugs.gnu.org>; Sat,  3 Oct 2020 21:05:54 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h=
 content-transfer-encoding:content-language:content-type
 :content-type:mime-version:date:date:message-id:subject:subject
 :from:from:received; s=mail20150812; t=1601751948; bh=TDojLN878G
 /lJ4K+VeQ17tK6xyUylOo3HGmSJTOdL80=; b=ldTPtqprjCEnS4KLR0mdVzm5WN
 sfjmDHjuJByVieyMR9LY6tKiFfh/NJ//l1BIeQCzl0KIpQrl7ClZqgAz9vE/r8BM
 AavcEq9s7YKiWyJL+ckiRaPrJbfK4UJIsw0xaEPxNFlsusDahQP2DsRIsgoTKAo+
 1T6OnfRt803kt8h931bEWn5R+yVNUmoy5kadVEJYE2WOdvBtU7TFITeC7QDvpjYY
 RPaOuV2iUg4gi9dO0Ynripf1aGsklP15YT6GfD0oTdpn3UKbpBvve1B48cWGDDOp
 XU75Q8Azew5CXs6skfwhC6kmw+bFpYA+2Tr391sxVE9R//D6f2liKzFhek6A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812; t=1601751950;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding;
 bh=fvKwPIeqJvdtbCitmg8x0Ek6cdanavjnMJ9tOYt363w=;
 b=NHUUiLL0G53jc+1gryMXl0gXaion3s/7jOn1JKgzYJDnZneQuuOXDJ3E/CFq7sERGjDvuZ
 j4m+e4CIqRS65wtr1HkyujLMgIYFl+r6e4Ys3XF9c5sadX3H/rzSZVUJzkIsR4uFlEnD2B
 iWyEVLMAyENDI7NGEFZTKms3q6GgUI83o5ZIphtQTYnf7i/Jw4wbubvk2FvTwbn2x84q/G
 flJo6ZwGmZCu8gw7Ed5LfotOEaEL6BzqLz+YwBzsErYtWZs1rnONIQfuhRKy5ScYVYrRpg
 RC7xb9JlDNmr40g8Eokxxf1UtLuW/9NUA5wW/8qNnrcWtHsl1i+ldydqosA58Q==
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp2.mailbox.org ([80.241.60.241])
 by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de
 [80.241.56.122]) (amavisd-new, port 10030)
 with ESMTP id cw8IdOn6B7zM for <43781 <at> debbugs.gnu.org>;
 Sat,  3 Oct 2020 21:05:48 +0200 (CEST)
From: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= <tomasortin@HIDDEN>
Subject: [PATCH 2/2] gnu: Add cgoban
To: 43781 <at> debbugs.gnu.org
Message-ID: <9f324abb-f935-b748-526b-467113e87670@HIDDEN>
Date: Sat, 3 Oct 2020 21:05:46 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-MBO-SPAM-Probability: 
X-Rspamd-Score: -5.86 / 15.00 / 15.00
X-Rspamd-Queue-Id: 2BE4F1704
X-Rspamd-UID: 8d8939
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 43781
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Sorry, I see I should have sent it all in one email.

* gnu/packages/games.scm (cgoban): New variable.
---
2 files changed, 71 insertions(+), 1 deletion(-)
gnu/packages/games.scm                          | 32 +++++++++++++++++++-
gnu/packages/patches/cgoban-1.9.14-cflags.patch | 40 +++++++++++++++++++++++++

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 28c1492b26..c2fefd6812 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -54,7 +54,8 @@
 ;;; Copyright © 2020 Michael Rohleder <mike@HIDDEN>
 ;;; Copyright © 2020 Trevor Hass <thass@HIDDEN>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler@HIDDEN>
-;;;
+;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@HIDDEN>
+;;; 
 ;;; This file is part of GNU Guix.
 ;;;
 ;;; GNU Guix is free software; you can redistribute it and/or modify it
@@ -11790,3 +11791,32 @@ inside the Zenith Colony.")
 X11 that won't set your CPU on fire, drain your laptop battery, or lower video
 game FPS.")
       (license license:unlicense))))
+
+(define-public cgoban
+  (package
+    (name "cgoban")
+    (version "1.9.14")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://sourceforge.net/projects/cgoban1/files/"
+                           "cgoban1/1.9.14/cgoban-1.9.14.tar.gz"))
+       (sha256
+        (base32 "0qlvkiaglqq0izfph3l04mp4rqqqm9ks6rcsrmzrggw9x706z2iv"))
+       (patches (search-patches "cgoban-1.9.14-cflags.patch"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #t))
+    (inputs
+     `(("xorgproto", xorgproto)
+       ("libx11", libx11)
+       ("libxt", libxt)))
+    (home-page "http://cgoban1.sourceforge.net/")
+    (synopsis "Go client for X11")
+    (description "CGoban provides a large set of Go-related services for X11:
+-Local games with precise implementation of the Chinese and Japanese rulesets
+-Edition and visualization of SGF files
+-Connection to the NNGS or IGS Go servers
+-Bridge to Go modem protocol, including playing against Go modem capable AIs,
+such as GnuGo")
+    (license license:gpl2+)))

diff --git a/gnu/packages/patches/cgoban-1.9.14-cflags.patch b/gnu/packages/patches/cgoban-1.9.14-cflags.patch
new file mode 100644
index 0000000000..dc5e9ef15d
--- /dev/null
+++ b/gnu/packages/patches/cgoban-1.9.14-cflags.patch
@@ -0,0 +1,40 @@
+--- a/configure.in
++++ b/configure.in
+@@ -1,8 +1,9 @@
+ #for autoconf 2.1x start configure script with next three lines
+ 
+ AC_PREREQ(2.13)
+-AC_INIT(src/cgoban.c)
+-AM_INIT_AUTOMAKE(cgoban, 1.9.14)
++AC_INIT([cgoban], [1.9.14])
++AC_CONFIG_SRCDIR([src/cgoban.c])
++AM_INIT_AUTOMAKE([no-define])
+ 
+ #for autoconf 2.5x start configure script with next four lines
+ # AC_PREREQ(2.50)
+@@ -145,7 +146,7 @@
+ ######################################################################
+ 
+ export VERSION
+-AC_DEFINE_UNQUOTED(VERSION,$VERSION)
++AC_DEFINE_UNQUOTED(VERSION,["$VERSION"])
+ AC_PREFIX_DEFAULT(/usr/games)
+ 
+ dayNum=`echo $date | awk '{ print $1 }'`
+@@ -160,6 +161,7 @@
+ AC_DEFINE_UNQUOTED(DATE,$DATE)
+ AC_DEFINE_UNQUOTED(DATE_FRENCH,$DATE_FRENCH)
+ 
++AM_PROG_AR
+ AC_PROG_MAKE_SET
+ AC_PROG_INSTALL
+ AC_PROG_CC
+@@ -168,7 +170,6 @@
+ AC_MINIX
+ AC_PROG_CPP
+ AC_EXEEXT
+-WMS_GET_CFLAGS
+ 
+ AM_CONFIG_HEADER(configure.h)
+ AC_SUBST(LIBS)dnl
+ 




Information forwarded to guix-patches@HIDDEN:
bug#43781; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 3 Oct 2020 18:39:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 03 14:39:29 2020
Received: from localhost ([127.0.0.1]:44465 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kOmRI-0001Xh-Ig
	for submit <at> debbugs.gnu.org; Sat, 03 Oct 2020 14:39:29 -0400
Received: from lists.gnu.org ([209.51.188.17]:32928)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tomasortin@HIDDEN>) id 1kOlg7-0000NY-Ts
 for submit <at> debbugs.gnu.org; Sat, 03 Oct 2020 13:50:43 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49366)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tomasortin@HIDDEN>)
 id 1kOlg7-0001bo-J5
 for guix-patches@HIDDEN; Sat, 03 Oct 2020 13:50:39 -0400
Received: from mout-p-102.mailbox.org ([80.241.56.152]:50454)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <tomasortin@HIDDEN>)
 id 1kOlg2-000493-2Y
 for guix-patches@HIDDEN; Sat, 03 Oct 2020 13:50:38 -0400
Received: from smtp1.mailbox.org (smtp1.mailbox.org
 [IPv6:2001:67c:2050:105:465:1:1:0])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4C3ZC75BghzQlJR
 for <guix-patches@HIDDEN>; Sat,  3 Oct 2020 19:50:27 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h=
 content-transfer-encoding:content-language:content-type
 :content-type:mime-version:date:date:message-id:subject:subject
 :from:from:received; s=mail20150812; t=1601747424; bh=FUGAwAy13R
 GEo+fQFDYwziLOLAgNuR7D1PnVkeviVhw=; b=APU6Y7Xlfnekc9dSFwLcdYU6gV
 ntXw8SbM6SJlpxVrOsqEktrs6ASk6Yshm7bOn7+Po+qaqc1GTCxbzHDiHWek4u2y
 dW+g9ujgjeTYdNSioAMZYg0vGJJhFKhbWlRcmxDtXJmJcN2yXitGuofzXH2bq/SH
 8ztaQ96xesZlevW7QCM4ihO7hh7VbioRWzGBalHZz7jpPcMqurR52gdf8SqQ/BWy
 PgX0R6BVDneW0fAckgl8o2hWL7BlqDfpFWWm0TCFT+LxGgDywvmP8BLvFVPv79tw
 1f8cKWF4W54sYk5SOGuJ1QFP3XaNEfMZzFerbrJnB5FDCtxNGFkJ0zgGAFjA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812; t=1601747425;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding;
 bh=FUGAwAy13RGEo+fQFDYwziLOLAgNuR7D1PnVkeviVhw=;
 b=gLbOgCvq+8Q/SAvmkf8cYmtDuPOVFq5WBeAeppl0Drt+BFxqmOUPCsJGnrryeG4pTucU4Y
 KINPfcohVvRyvIwEWRjehgxABcjxUK7yNM5f5cpjJs02vCY6edEcKhtd4catXoYZYWIg1s
 NPFXqMCGAYCVSWl/N225b1fy3p5kHJznLHniKyXcn7HY9iXriELw37IW0/aoplO6ZUrjkd
 ZbLpYTcxvbi+F8WrOMjCdChKD2B8lBrhOP/Ye7OXgJ3zEPWYO15xlucf8JUN268pXrT/O+
 X+PSSBeBF+w1P/n9eVgWAPxZkE4mmyEsFd+6Lx8I4SYeJ+NLMwaq56vUH6bGbA==
X-Virus-Scanned: amavisd-new at heinlein-support.de
Received: from smtp1.mailbox.org ([80.241.60.240])
 by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de
 [80.241.56.123]) (amavisd-new, port 10030)
 with ESMTP id hSRhC2VpMvzo for <guix-patches@HIDDEN>;
 Sat,  3 Oct 2020 19:50:24 +0200 (CEST)
To: guix-patches@HIDDEN
From: =?UTF-8?B?VG9tw6FzIE9ydMOtbiBGZXJuw6FuZGV6?= <tomasortin@HIDDEN>
Subject: [PATCH 0/2] gnu: Add cgoban
Message-ID: <d735688d-2268-5da4-afb2-368aa10b257f@HIDDEN>
Date: Sat, 3 Oct 2020 19:50:11 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MBO-SPAM-Probability: 
X-Rspamd-Score: -2.64 / 15.00 / 15.00
X-Rspamd-Queue-Id: C2BE417D9
X-Rspamd-UID: db6aed
Received-SPF: pass client-ip=80.241.56.152;
 envelope-from=tomasortin@HIDDEN; helo=mout-p-102.mailbox.org
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/03 13:50:27
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic] [fuzzy]
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sat, 03 Oct 2020 14:39:23 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hello Guix! This is a set of two patches to add CGoban, a Go (as in the boardgame) client. This is just my second contribution and I'm not a programmer, so please provide any feedback and I will improve it. Thanks!




Acknowledgement sent to Tomás Ortín Fernández <tomasortin@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#43781; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 26 Oct 2020 11:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.