GNU bug report logs - #43818
search-patches fails when there is a trailing slash on the Guix load path

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix; Reported by: Maxim Cournoyer <maxim.cournoyer@HIDDEN>; Keywords: patch; dated Mon, 5 Oct 2020 17:37:01 UTC; Maintainer for guix is bug-guix@HIDDEN.
Changed bug title to 'search-patches fails when there is a trailing slash on the Guix load path' from 'Use of local-file in icecat-source definition breaks REPL' Request was from Maxim Cournoyer <maxim.cournoyer@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Added tag(s) patch. Request was from Maxim Cournoyer <maxim.cournoyer@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 43818 <at> debbugs.gnu.org:


Received: (at 43818) by debbugs.gnu.org; 25 Oct 2020 05:53:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 25 01:53:22 2020
Received: from localhost ([127.0.0.1]:35619 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kWYy2-0000Zw-Ly
	for submit <at> debbugs.gnu.org; Sun, 25 Oct 2020 01:53:22 -0400
Received: from mail-io1-f66.google.com ([209.85.166.66]:47078)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1kWYxz-0000Zg-Sa
 for 43818 <at> debbugs.gnu.org; Sun, 25 Oct 2020 01:53:20 -0400
Received: by mail-io1-f66.google.com with SMTP id b15so6587767iod.13
 for <43818 <at> debbugs.gnu.org>; Sat, 24 Oct 2020 22:53:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=HbDeNY4V9OEDsf6cun2TsuVlfBvGmcMKH7x1NI183K4=;
 b=lqBIzpBD4LZx0Tkq6duhqsFK9QIzoKlfBeE28olSElkaFznzJHkxPpJNZD7lXt2y+T
 vgqHUAX98QL/ihdhhE8pYsnW/ZD/qm8G8gaXyUBOiNlVwHGD+2qsmykVa9dpLcbvPoyQ
 KogWo/y7SC6jHLsxJOhfhF/l6zh4xAVDDGGFFPA4HmcDmwUjVYfXPfhqviW0tj137R4U
 JFhFPeZ1+kDCYP7JQW4/H9mPNy4UfSR6AH9pp4AqddLyD3sHsgjwYwzcEi0IApuf+gYX
 sKVrJzgv3f+rBsoVK5XseqXdAVpKftIFcMOQFFMAc8ZJvUA+ksb+SxDDoejM5pMYsU6I
 lpwQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=HbDeNY4V9OEDsf6cun2TsuVlfBvGmcMKH7x1NI183K4=;
 b=AR/SBFPt/cwlwbHL21VgSt8F6IVwupg0bl+IsQ62wBBV7dTVD1VT1umnQ6TImbhmUa
 VKHMNunJ+PZyAwdqvefFk4fj8LrSqUqhvZVMTQrTHaCWJAOTwwJQgTs8j4slC4MG5tfG
 hmfsMoYR/GTc0X79kkuXFlfSOe8w6KJ595XMlE/mmDcdz/NSOTrcm30IbmUR1YSxNZhN
 z1f6wWzI4iTZ1OhKspNlQimrr8vcb1XX6BYA8CLaDs2xd5E3Gsx4CVUQDdrZOam67GvG
 9dtLjWbJ8h2+FJNlq64BdBL8IjvDtCkftXzX66QT0p2anQcUsinbC1yG67LqLHRRsWd/
 xjyw==
X-Gm-Message-State: AOAM530kMJwbViAE/fqlduVzDcLStqXFbj+J5oE0XcrmU0bWVv/ixQeJ
 YdbVLAN1DaMpRpmoXDUKs6z59UwP1U/adg==
X-Google-Smtp-Source: ABdhPJxtlpV+r+ntGi4SiMAvSccc2KxBmj+9/lq0aWHtqfwfWdgWFIebSp1+nFA9NjjD688k/diAiQ==
X-Received: by 2002:a05:6602:2b90:: with SMTP id
 r16mr6835800iov.31.1603605194086; 
 Sat, 24 Oct 2020 22:53:14 -0700 (PDT)
Received: from localhost.localdomain (dsl-159-173.b2b2c.ca. [66.158.159.173])
 by smtp.gmail.com with ESMTPSA id
 p4sm3761561ilg.79.2020.10.24.22.53.13
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 24 Oct 2020 22:53:13 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 43818 <at> debbugs.gnu.org
Subject: [PATCH] packages: Fix a bug in %patch-path.
Date: Sun, 25 Oct 2020 01:52:34 -0400
Message-Id: <20201025055234.19912-1-maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.28.0
MIME-Version: 1.0
Content-Type: text/plain; charset=yes
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43818
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Fixes <https://issues.guix.gnu.org/43818>.

Having the Guix root trailed by a slash in the GUILE_LOAD_PATH would
previously cause %patch-path to not return an entry with the patches
sub-directory, leading to errors such as:

   While executing meta-command:
   ERROR:
     1. &formatted-message:
         format: "~a: patch not found\n"
         arguments: ("icecat-use-older-reveal-hidden-html.patch")

* gnu/packages.scm (strip-trailing-slash): New procedure.
(%patch-path): Use it to strip any trailing slash from the %load-path entries.
---
 gnu/packages.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages.scm b/gnu/packages.scm
index ccfc83dd11..f5acbda897 100644
--- a/gnu/packages.scm
+++ b/gnu/packages.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2014 Eric Bavier <bavier@HIDDEN>
 ;;; Copyright © 2016, 2017 Alex Kost <alezost@HIDDEN>
 ;;; Copyright © 2016 Mathieu Lirzin <mthl@HIDDEN>
+;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -159,6 +160,12 @@ flags."
              %default-package-module-path
              channels-scm))))
 
+(define (strip-trailing-slash s)
+  ;; Strip the trailing slash of a string, if present.
+  (if (string-suffix? "/" s)
+      (string-drop-right s 1)
+      s))
+
 (define %patch-path
   ;; Define it after '%package-module-path' so that '%load-path' contains user
   ;; directories, allowing patches in $GUIX_PACKAGE_PATH to be found.
@@ -167,7 +174,7 @@ flags."
           (if (string=? directory %distro-root-directory)
               (string-append directory "/gnu/packages/patches")
               directory))
-        %load-path)))
+        (map strip-trailing-slash %load-path))))
 
 ;; This procedure is used by Emacs-Guix up to 0.5.1.1, so keep it for now.
 ;; See <https://github.com/alezost/guix.el/issues/30>.
-- 
2.28.0
Information forwarded to bug-guix@HIDDEN:
bug#43818; Package guix. Full text available.
Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 43818 <at> debbugs.gnu.org:


Received: (at 43818) by debbugs.gnu.org; 25 Oct 2020 02:14:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 24 22:14:44 2020
Received: from localhost ([127.0.0.1]:35554 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kWVYR-0007jy-Kg
	for submit <at> debbugs.gnu.org; Sat, 24 Oct 2020 22:14:43 -0400
Received: from mail-qk1-f173.google.com ([209.85.222.173]:35731)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1kWVYN-0007je-Iz; Sat, 24 Oct 2020 22:14:42 -0400
Received: by mail-qk1-f173.google.com with SMTP id 140so5337927qko.2;
 Sat, 24 Oct 2020 19:14:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=lTcQLxr+Fw5eoGi0bi2aZX/wwH03qxphM+zHOUk2Z08=;
 b=Jqme5rA6OSHvgw213dTYrGZru1+X8PsTQ8izeM/K3+2nfnSptTyXtUSMrqXtREx2fC
 4Azk2Btl3EYLUnrh83mi57KL63jHZhUzfLPw5iOKEVBPwbiQJB8R+sqqbnVndBFlFbKB
 9oZuvPuKwnW8ndVwJNssu+DpV0mwxfEcHlh1QDLS3uUDIzLnW0e1qOxl4mr6pzlbHd2d
 HEwrBBWUx+IB63Hev1nMe0KWuRaTTHwEdIaxop/Yg3NQcxzZixNi5lqFd4gBh8CS9OwE
 ESC8/SRrIaOOKdoCiVtN6uM82GJuMkySpJilf5LSW7brwwzjOPAnui8YFPfuPRan0NTt
 Xa7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=lTcQLxr+Fw5eoGi0bi2aZX/wwH03qxphM+zHOUk2Z08=;
 b=EfMbHgZr4CNgTFIwYp0mTcQuJFudQBFOBCAXLHLOhVGEqAtu447ir0B8sc+6y9nqfQ
 npuwjfdOpgHAB1U0bgk7oijyidaHtMcm3Q/m+jDzLpsBwXNHGBMhdRVPul/jpmfmbCSP
 6DRbVEASZeGTMAX5TaGbavJA7xktR71HwAnOTn2zyHxE7vw1w3uPm4t4UvQoOFpiBXi+
 fIGXHIURBZUst0CmmoWFbL9qxEWMZbDr5f4/4Qq0p5zkUQcduPy5fQqiGismryUKaCRg
 imYVc7NrgXvIirxsKTUwMciBoqAUOZP6WGteB74R1mtarTUQz4T9OBY2CYNdhcrTULil
 L4wQ==
X-Gm-Message-State: AOAM532TZfIAHHaJu3ja2Ly/gmocFW45nDUqKxyfp4jEUABCLTuuZ6P9
 //c1s2wb16IdIDi80LEPOmZhLQbdBqE=
X-Google-Smtp-Source: ABdhPJwtuqWBx5wJm6PdS1A5ETNOVFzOKFh0k4Yi9+28bFhU/JC9tf4UwP4oKAtPxbdM+41HbQ7Sbg==
X-Received: by 2002:ae9:e60c:: with SMTP id z12mr9545367qkf.392.1603592073824; 
 Sat, 24 Oct 2020 19:14:33 -0700 (PDT)
Received: from hurd (dsl-159-173.b2b2c.ca. [66.158.159.173])
 by smtp.gmail.com with ESMTPSA id i20sm2140569qtw.66.2020.10.24.19.14.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 24 Oct 2020 19:14:33 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 43818 <at> debbugs.gnu.org
Subject: bug#43818: Use of local-file in icecat-source definition breaks REPL)
References: <87k0vg5ikr.fsf@HIDDEN> <878sckk22g.fsf@HIDDEN>
 <handler.43818.D43818.160351533211096.notifdone <at> debbugs.gnu.org>
Date: Sat, 24 Oct 2020 22:14:32 -0400
In-Reply-To: <handler.43818.D43818.160351533211096.notifdone <at> debbugs.gnu.org>
 (GNU bug Tracking System's message of "Sat, 24 Oct 2020 04:56:04
 +0000")
Message-ID: <87wnzf2gs7.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43818
Cc: GNU Debbugs <control <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

reopen
thanks

I thought I had this understood, but there is still an issue.  At least
this time I could pinpoint precisely what makes it fail.  It had nothing
to do with the use of `eval-after-load' in my .dir-locals file.

To reproduce the problem, it suffices to append a trailing slash to the Guix entry in the
GUILE_LOAD_PATH:

--8<---------------cut here---------------start------------->8---
maxim@hurd ~/src/guix$ GUILE_LOAD_PATH=$PWD:$GUILE_LOAD_PATH GUILE_LOAD_COMPILED_PATH=$PWD:$GUILE_LOAD_COMPILED_PATH guile
GNU Guile 3.0.4
Copyright (C) 1995-2020 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> %load-path
$1 = ("/home/maxim/src/guix" "/home/maxim/src/guile-hacks" "/home/maxim/.guix-profile/share/guile/site/3.0" "/run/current-system/profile/share/g0.4/share/guile/3.0" "/gnu/store/ah16zr8mmfkqy23rr7jy5a842ca1q9h1-guile-3.0.4/share/guile/site/3.0" "/gnu/store/ah16zr8mmfkqy23rr7jy5a842ca1q9h1ca1q9h1-guile-3.0.4/share/guile")
scheme@(guile-user)> ,use (gnu packages linux)
scheme@(guile-user)> 

maxim@hurd ~/src/guix$ GUILE_LOAD_PATH=$PWD/:$GUILE_LOAD_PATH GUILE_LOAD_COMPILED_PATH=$PWD/:$GUILE_LOAD_COMPILED_PATH guile
GNU Guile 3.0.4
Copyright (C) 1995-2020 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> %load-path
$1 = ("/home/maxim/src/guix/" "/home/maxim/src/guile-hacks" "/home/maxim/.guix-profile/share/guile/site/3.0" "/run/current-system/profile/share/.0.4/share/guile/3.0" "/gnu/store/ah16zr8mmfkqy23rr7jy5a842ca1q9h1-guile-3.0.4/share/guile/site/3.0" "/gnu/store/ah16zr8mmfkqy23rr7jy5a842ca1q9h2ca1q9h1-guile-3.0.4/share/guile")
scheme@(guile-user)> ,use (gnu packages linux)
While executing meta-command:
ERROR:
  1. &formatted-message:
      format: "~a: patch not found\n"
      arguments: ("icecat-use-older-reveal-hidden-html.patch")
scheme@(guile-user)>
--8<---------------cut here---------------end--------------->8---

To be continued...

Maxim
Information forwarded to bug-guix@HIDDEN:
bug#43818; Package guix. Full text available.

Message received at 43818-done <at> debbugs.gnu.org:


Received: (at 43818-done) by debbugs.gnu.org; 24 Oct 2020 04:55:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 24 00:55:31 2020
Received: from localhost ([127.0.0.1]:58859 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kWBaV-0002su-Jo
	for submit <at> debbugs.gnu.org; Sat, 24 Oct 2020 00:55:31 -0400
Received: from mail-il1-f194.google.com ([209.85.166.194]:44664)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1kWBaS-0002sg-RK
 for 43818-done <at> debbugs.gnu.org; Sat, 24 Oct 2020 00:55:29 -0400
Received: by mail-il1-f194.google.com with SMTP id z2so3369500ilh.11
 for <43818-done <at> debbugs.gnu.org>; Fri, 23 Oct 2020 21:55:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=rnZ/BcaBf4HxrOM1QPzFYIPbM/7YEE+R1QXUxMkYuck=;
 b=NwksZ2emTpEpzvh873RxbG3C3n3SzxA0dv1mPYTGSJEKeBTN5BTcmaw9mPjhZyBc2w
 dDRZ9Sv5iqLPgFdWnFK31Cn+FwJmUkU/3+LJRDwMWNMUiUOPb/t/+T2kENzIU1O0ukGW
 Snc9vemKcZ5HuH6IQzW9eGUhFo25i+PY71aMQEuZBMYJ3DHmA0prplCyqGThHSx/XB9A
 ayys9C1dVQnQNrx7ERDGJPzhTYpZPhz72i3Qy+NKZhFsJ0HwPOZbn33cffReH11ddqnP
 1vJypkic7JtKi9jSrHWOInbIbf4h9WcWSwKHF6eeA4/hIesQ3GNTSvCT2Yllr7DlPRkn
 Kf1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=rnZ/BcaBf4HxrOM1QPzFYIPbM/7YEE+R1QXUxMkYuck=;
 b=dYEl098K87fG1bLuoLUQGhFFKQ9Y0PAKXsp/CvyrfbouESaAACj5RqxvN6lIYWEPdz
 /wnMtL2bmZt/uompGeFQfjVf6S9yP5PIpgdw0RKDDOT7mNFmZ0ClZq+qnBYjjPqeCC4L
 DYLA9pKz77swbcB/Uc+f015oH0xbmXen/qfg5vZU3awHd1goQbIh9Bki645A7HD13uQG
 XQWHjcs/YkVuvGkNK8E5hpEdaKNEY9qZyYgDuryKyMnDke2KcJ5mhr34ws+jN8ArwGU6
 B9SskIwFJ0KrosS2/A5Fg3mnsqTk65gDLq+PTKCxy0nV+k0/+Lat0+z6MyuA9a56pHBi
 xgZA==
X-Gm-Message-State: AOAM5330uJn6KECz4e/OIAQh7tetVLRWCRewW0BxvjjGgIywj27iyTCa
 +NN03fF6eaBH9fRCzNJ4U5b6Lh4RRvs=
X-Google-Smtp-Source: ABdhPJyv7lE+u+aNJcxr+NcywqG1N7rRPL+1VYxTQ+GbMGnosxgVn3TYOOdLM8c71ThyQlVKwTSNMw==
X-Received: by 2002:a05:6e02:df4:: with SMTP id
 m20mr4304716ilj.180.1603515323022; 
 Fri, 23 Oct 2020 21:55:23 -0700 (PDT)
Received: from hurd (dsl-159-173.b2b2c.ca. [66.158.159.173])
 by smtp.gmail.com with ESMTPSA id m66sm2069914ill.69.2020.10.23.21.55.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 23 Oct 2020 21:55:22 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 43818-done <at> debbugs.gnu.org
Subject: Re: bug#43818: Use of local-file in icecat-source definition breaks
 REPL
References: <878sckk22g.fsf@HIDDEN>
Date: Sat, 24 Oct 2020 00:55:16 -0400
In-Reply-To: <878sckk22g.fsf@HIDDEN> (Maxim Cournoyer's message of "Mon, 05
 Oct 2020 13:36:07 -0400")
Message-ID: <87k0vg5ikr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43818-done
Cc: "Mark H. Weaver" <mhw@HIDDEN>, Christopher Baines <mail@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:

> CC: Mark H Weaver, one of the Icecat maintainer.
>
> Hello,
>
> The problem is that local-file doesn't work in Geiser.  This breaks
> working at the REPL:
>
> Enter `,help' for help.
> scheme@(guile-user)> ,m (gnu packages linux)
> While executing meta-command:
> ERROR:
>   1. &formatted-message:
>       format: "~a: patch not found\n"
>       arguments: ("icecat-use-older-reveal-hidden-html.patch")

Thanks for Christopher Baines on #guix who pointed that local-file
seemed to behave correctly at the REPL and Geiser (indeed!).  It made me
try to reproduce it in a --pure environment and I couldn't.

After a couple hours digging, I found that this snippet in my modified
.dir-locals file:

--8<---------------cut here---------------start------------->8---
(with-eval-after-load 'geiser-guile
  (let ((root-dir (locate-dominating-file
                   default-directory ".dir-locals.el")))
    (setq geiser-guile-load-path
          (cons root-dir
                (delete root-dir geiser-guile-load-path)))))
--8<---------------cut here---------------end--------------->8---

Was the culprit, especially the use of with-eval-after-load (which
turned out to be unnecessary).

This snippet allows to switch between git worktrees and always have the
geiser-guile-load-path (which configures both the Guile %load-path and
the %load-compiled-path) set correctly.

Here's the diff of my (fixed) .dir-locals in my Guix git checkout:

--8<---------------cut here---------------start------------->8---
~/src/guix$ git diff .dir-locals.el
diff --git a/.dir-locals.el b/.dir-locals.el
index 19f15b3e1a..0869fbaa20 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -8,7 +8,17 @@
      ;; For use with 'bug-reference-prog-mode'.
      (bug-reference-url-format . "http://bugs.gnu.org/%s")
      (bug-reference-bug-regexp
-      . "<https?://\\(debbugs\\|bugs\\)\\.gnu\\.org/\\([0-9]+\\)>")))
+      . "<https?://\\(debbugs\\|bugs\\)\\.gnu\\.org/\\([0-9]+\\)>")
+
+     ;; Emacs-Guix
+     (eval . (setq guix-directory
+                   (locate-dominating-file default-directory ".dir-locals.el")))
+     ;; Geiser
+     (eval . (let ((root-dir (locate-dominating-file
+                              default-directory ".dir-locals.el")))
+               (setq geiser-guile-load-path
+                     (cons root-dir
+                           (delete root-dir geiser-guile-load-path)))))))
  (c-mode          . ((c-file-style . "gnu")))
  (scheme-mode
   .
--8<---------------cut here---------------end--------------->8---

I am closing this issue, sorry for the noise!

Maxim
Notification sent to Maxim Cournoyer <maxim.cournoyer@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Maxim Cournoyer <maxim.cournoyer@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 43818 <at> debbugs.gnu.org:


Received: (at 43818) by debbugs.gnu.org; 5 Oct 2020 17:39:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 05 13:39:44 2020
Received: from localhost ([127.0.0.1]:50471 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kPUSe-0006h7-Id
	for submit <at> debbugs.gnu.org; Mon, 05 Oct 2020 13:39:44 -0400
Received: from mail-qt1-f179.google.com ([209.85.160.179]:34276)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1kPUSb-0006gt-M1
 for 43818 <at> debbugs.gnu.org; Mon, 05 Oct 2020 13:39:43 -0400
Received: by mail-qt1-f179.google.com with SMTP id 19so10335346qtp.1
 for <43818 <at> debbugs.gnu.org>; Mon, 05 Oct 2020 10:39:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=g1C+JpDIbDoKNrAB1HPUT6wFYCLUwtP/hpvQUi/evr4=;
 b=fHbcou/6F7PIyoDgecf7gbwDdYtoS6MMXQbKyS8uxYt6JvpnqwaygtZZt0cUP06yld
 lncRduUePaYOiViDeypX4Nzz2iR7EGSLndCKNGFdEfOhR+U3XpsROx5SQz1fWSh3QSRh
 GHsj7Zce04L5MHyueHq25LwysS+0uxUubwUe9gvXLDpP2o1/rb6oDdw6jeMah6k8v8o6
 9Ru0FiT7aGEWG1GhSOqzuPftMhnG2xgYADjCJzD6wZr79HdsgKB9upjsJqy5Axkr5OyR
 Kv0Ig1D0oA6n1Y5w6RVx5ssfyEVLsG1ox1OkoJD/2Y7p6n1gUUKu0BQYSA69P3l6hDec
 aNfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=g1C+JpDIbDoKNrAB1HPUT6wFYCLUwtP/hpvQUi/evr4=;
 b=gDhARlFjWxJXA58tLHB3kk3y8na43biMXlQFyAm8VHNMaboOfdxx6TjGk7LiV6skET
 KrMbTEnNyPL7WKD2alTN0/lFiqSEQExWUiluVuwzl+Y8GFgmXXH4yNW9ybtJTP+JZ7yH
 U1PZ97I+lzYB0ab8yFkG/j4BDpUZt4hrgQ7yxsiha7KpRJcWNoZod9z4nZ6JdWHZRORD
 WOsm5i8h3YgBo55uvRmSdfMUlyZMysU3moXpO67cSGgik5KCV+FMxaIUhubr4t18ADp1
 aQnOe2/9wDBALkd0rFVwPLi2vrF6JomocCYspe+5e8PjcjJSf/KRWG96cDlciqVMawXv
 02rA==
X-Gm-Message-State: AOAM531+VTxSjzMfI7dG7eyiV44vIEcbHUdtmZFbTwCYcqw9V48ihGYb
 CHqJZyQtkQBhYFO0VFp3qqg=
X-Google-Smtp-Source: ABdhPJzWIWYmpqwpq5jrj7CDEzptH5QewSJxysw+pK3z1mODkgth6IhqJV7MtE0d+z/tVf+t6pxwtg==
X-Received: by 2002:aed:3bf1:: with SMTP id s46mr936515qte.389.1601919575938; 
 Mon, 05 Oct 2020 10:39:35 -0700 (PDT)
Received: from hurd (dsl-10-141-84.b2b2c.ca. [72.10.141.84])
 by smtp.gmail.com with ESMTPSA id e17sm267605qte.11.2020.10.05.10.39.35
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 05 Oct 2020 10:39:35 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 43818 <at> debbugs.gnu.org
Subject: Re: bug#43818: Use of local-file in icecat-source definition breaks
 REPL
References: <878sckk22g.fsf@HIDDEN>
Date: Mon, 05 Oct 2020 13:39:34 -0400
In-Reply-To: <878sckk22g.fsf@HIDDEN> (Maxim Cournoyer's message of "Mon, 05
 Oct 2020 13:36:07 -0400")
Message-ID: <874kn8k1wp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43818
Cc: "Mark H. Weaver" <mhw@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:

> CC: Mark H Weaver, one of the Icecat maintainer.
>
> Hello,
>
> The problem is that local-file doesn't work in Geiser.  This breaks
> working at the REPL:
>
> Enter `,help' for help.
> scheme@(guile-user)> ,m (gnu packages linux)
> While executing meta-command:
> ERROR:
>   1. &formatted-message:
>       format: "~a: patch not found\n"
>       arguments: ("icecat-use-older-reveal-hidden-html.patch")
>
> Any ideas of what could be done about it?
>
> Maxim

The same also occurs for linux-libre patches:

While executing meta-command:
ERROR:
  1. &formatted-message:
      format: "~a: patch not found\n"
      arguments: ("linux-libre-support-for-Pinebook-Pro.patch")

I'll try progressing on the Gexp as a thunked field experiment; this
should allow us to rewrite the orgins in a more straight forward way,
hopefully eschewing this issue.

Maxim
Information forwarded to bug-guix@HIDDEN:
bug#43818; Package guix. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 5 Oct 2020 17:36:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 05 13:36:14 2020
Received: from localhost ([127.0.0.1]:50466 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kPUPG-0006bd-0n
	for submit <at> debbugs.gnu.org; Mon, 05 Oct 2020 13:36:14 -0400
Received: from lists.gnu.org ([209.51.188.17]:45040)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1kPUPE-0006bV-0U
 for submit <at> debbugs.gnu.org; Mon, 05 Oct 2020 13:36:12 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55698)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1kPUPD-00042j-OA
 for bug-guix@HIDDEN; Mon, 05 Oct 2020 13:36:11 -0400
Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:44239)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1kPUPC-0006zF-Eu
 for bug-guix@HIDDEN; Mon, 05 Oct 2020 13:36:11 -0400
Received: by mail-qk1-x731.google.com with SMTP id s7so6962075qkh.11
 for <bug-guix@HIDDEN>; Mon, 05 Oct 2020 10:36:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version;
 bh=AZcLF9EwIE24p1km3E7ByJngWGUfChtg2iH40y4ZizY=;
 b=bu80f/4Mb/mLhhU2XYVcfY6SvzkQ/Gds93DJpKnIYP3Vski47o3i3wimk7HE49DNgh
 i1QprSOHjyaRV38UHPmmCmi6JR/y9OtUeMXglga+4uE33rUSsxZHs8zFxvmwj9aJlsKV
 Tkeyf/8v40fmzHAx6+YQpXXe3Kk0mZmlyfkoono3Jp2Bj1NBkxrouihIX1xhVbfZ4j26
 JIV0PXP9y08ub+zWEQhAAcrtyRtSHG2K6kXRLaRId5/bIH7L19u774l2WEh8Sd0yjZQY
 rYAJFa+EkQ4dKN+UVEr8t5DEY2v/AXdVDI/a0/iN6eszVlxs6xoW7G1IOqa6nkKidh7o
 2NzA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version;
 bh=AZcLF9EwIE24p1km3E7ByJngWGUfChtg2iH40y4ZizY=;
 b=r9g4WtNMjMWP2CCxwxnWY/s4OA/k0VjTk0SXV5hogDgXiEVf48OPT5wVXWz6kJ3Jod
 iqvo59aFk0VFeZ9HJMSrv3a130lR8beAU+wDi/XpKHPCs/SFI761HkOuseI7bhrlLfNy
 xayLEOTJC3G8oNf5zUl19tJ7Sxcp39K3N3i6AMNsTrQIz0PhBoPc9qoq9N3h08wN7jQB
 vaoZ2JdHkr7JisjN4mwthu8AxvS7r241R449rkxpHwKgChPDj7OYCH4W3/tr4kMiAWoM
 z8mRGlB7gVOWQQDgFkBnP33wERVkIwCveW/f75hK67h0kuoN83mesD9teEWWZB0CDN3W
 f85w==
X-Gm-Message-State: AOAM533JQRiavy9MBs6QDDWy+qqX0Xbtg3JjLqJrNWxR2Lm/kx64NKuM
 5oc+B38Ji+yA5spwzpVB8LGx0hYmDxoajw==
X-Google-Smtp-Source: ABdhPJywBafIQbhiabsnPdL6rcITOvm12sw+zVQYKZlBe5leE3cEEykbtokuTN1yYu2F2XkVWvkR1A==
X-Received: by 2002:a05:620a:c07:: with SMTP id l7mr1179716qki.9.1601919369247; 
 Mon, 05 Oct 2020 10:36:09 -0700 (PDT)
Received: from hurd (dsl-10-141-84.b2b2c.ca. [72.10.141.84])
 by smtp.gmail.com with ESMTPSA id a3sm271042qtp.63.2020.10.05.10.36.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 05 Oct 2020 10:36:08 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: bug-guix <bug-guix@HIDDEN>
Subject: Use of local-file in icecat-source definition breaks REPL
Date: Mon, 05 Oct 2020 13:36:07 -0400
Message-ID: <878sckk22g.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2607:f8b0:4864:20::731;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qk1-x731.google.com
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: 0
X-Spam_score: -0.1
X-Spam_bar: /
X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 PDS_TONAME_EQ_TOLOCAL_SHORT=1.997, RCVD_IN_DNSWL_NONE=-0.0001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  CC: Mark H Weaver, one of the Icecat maintainer. Hello, The
 problem is that local-file doesn't work in Geiser. This breaks working at
 the REPL: 
 Content analysis details:   (2.5 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (maxim.cournoyer[at]gmail.com)
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,
 medium trust [209.51.188.17 listed in list.dnswl.org]
 0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
 [209.51.188.17 listed in wl.mailspike.net]
 2.0 PDS_TONAME_EQ_TOLOCAL_SHORT Short body with To: name matches
 everything in local email
 0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 1.8 SPOOFED_FREEMAIL       No description available.
X-Debbugs-Envelope-To: submit
Cc: "Mark H. Weaver" <mhw@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

CC: Mark H Weaver, one of the Icecat maintainer.

Hello,

The problem is that local-file doesn't work in Geiser.  This breaks
working at the REPL:

Enter `,help' for help.
scheme@(guile-user)> ,m (gnu packages linux)
While executing meta-command:
ERROR:
  1. &formatted-message:
      format: "~a: patch not found\n"
      arguments: ("icecat-use-older-reveal-hidden-html.patch")

Any ideas of what could be done about it?

Maxim
Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.
Report forwarded to bug-guix@HIDDEN:
bug#43818; Package guix. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 25 Oct 2020 06:00:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.