GNU bug report logs - #43837
28.0.50; [NS] Internal border of inactive frame loses color

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43837 in the body.
You can then email your comments to 43837 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [NS] Internal border of inactive frame loses color
Date: Tue, 06 Oct 2020 22:40:33 +0300

In 'emacs -Q':

1. M-: (setq test-frame (make-frame '((left . 50) (top . 50))))
2. C-x 5 o
3. M-: (set-face-background 'internal-border "blue" test-frame)
4. M-: (modify-frame-parameters test-frame '((background-color . "black")))

Now (face-background 'internal-border test-frame) returns nil.
If we skip step 2, then the internal border color remains.


In GNU Emacs 28.0.50 (build 2, x86_64-apple-darwin19.6.0, NS appkit-1894.60 Version 10.15.6 (Build 19G2021))
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.6

Message #8 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 43837 <at> debbugs.gnu.org
Subject: Re: bug#43837: 28.0.50; [NS] Internal border of inactive frame loses
 color
Date: Tue, 6 Oct 2020 21:37:15 +0100

[Message part 1 (text/plain, inline)]

On Tue, Oct 06, 2020 at 10:40:33PM +0300, Andrii Kolomoiets wrote:
> In 'emacs -Q':
> 
> 1. M-: (setq test-frame (make-frame '((left . 50) (top . 50))))
> 2. C-x 5 o
> 3. M-: (set-face-background 'internal-border "blue" test-frame)
> 4. M-: (modify-frame-parameters test-frame '((background-color . "black")))
> 
> Now (face-background 'internal-border test-frame) returns nil.
> If we skip step 2, then the internal border color remains.

This isn't an NS specific problem. Eli actually spotted the bug last
year and put in a FIXME.

I can't think of a good reason for the code to use the selected frame,
but perhaps I'm missing something.

Patch attached.
-- 
Alan Third

[0001-Prevent-mixing-of-faces-from-different-frames-bug-43.patch (text/plain, attachment)]

Message #11 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Alan Third <alan <at> idiocy.org>
Cc: 43837 <at> debbugs.gnu.org
Subject: Re: bug#43837: 28.0.50; [NS] Internal border of inactive frame
 loses color
Date: Wed, 07 Oct 2020 09:46:16 +0300

Alan Third <alan <at> idiocy.org> writes:

> This isn't an NS specific problem. Eli actually spotted the bug last
> year and put in a FIXME.

Sorry, was too lazy to check on other OS :)

> I can't think of a good reason for the code to use the selected frame,
> but perhaps I'm missing something.
>
> Patch attached.

Looks great and works perfect!

Message #14 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 43837 <at> debbugs.gnu.org
Subject: Re: bug#43837: 28.0.50;
 [NS] Internal border of inactive frame loses color
Date: Wed, 07 Oct 2020 10:03:34 +0300

> From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
> Date: Tue, 06 Oct 2020 22:40:33 +0300
> 
> In 'emacs -Q':
> 
> 1. M-: (setq test-frame (make-frame '((left . 50) (top . 50))))
> 2. C-x 5 o
> 3. M-: (set-face-background 'internal-border "blue" test-frame)
> 4. M-: (modify-frame-parameters test-frame '((background-color . "black")))
> 
> Now (face-background 'internal-border test-frame) returns nil.
> If we skip step 2, then the internal border color remains.

I think I fixed this on the master branch now.

Thanks.

Message #17 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: 43837 <at> debbugs.gnu.org, andreyk.mad <at> gmail.com
Subject: Re: bug#43837: 28.0.50;
 [NS] Internal border of inactive frame loses color
Date: Wed, 07 Oct 2020 10:19:35 +0300

> Date: Tue, 6 Oct 2020 21:37:15 +0100
> From: Alan Third <alan <at> idiocy.org>
> Cc: 43837 <at> debbugs.gnu.org
> 
> > 1. M-: (setq test-frame (make-frame '((left . 50) (top . 50))))
> > 2. C-x 5 o
> > 3. M-: (set-face-background 'internal-border "blue" test-frame)
> > 4. M-: (modify-frame-parameters test-frame '((background-color . "black")))
> > 
> > Now (face-background 'internal-border test-frame) returns nil.
> > If we skip step 2, then the internal border color remains.
> 
> This isn't an NS specific problem. Eli actually spotted the bug last
> year and put in a FIXME.

It was me?

> I can't think of a good reason for the code to use the selected frame,
> but perhaps I'm missing something.

Heh, I went through the rabbit hole and arrived at the same fix, now
installed on master.  Let's see what will it break, and then perhaps
we will understand why the old code used selected-frame there...

Thanks.

Message #20 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Alan Third <alan <at> idiocy.org>, 43837 <at> debbugs.gnu.org
Subject: Re: bug#43837: 28.0.50; [NS] Internal border of inactive frame
 loses color
Date: Wed, 07 Oct 2020 10:42:13 +0300

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Alan Third <alan <at> idiocy.org>
>> I can't think of a good reason for the code to use the selected frame,
>> but perhaps I'm missing something.
>
> Heh, I went through the rabbit hole and arrived at the same fix, now
> installed on master.  Let's see what will it break, and then perhaps
> we will understand why the old code used selected-frame there...

Well, with recent master:

1. M-: (custom-set-faces '(default ((t :foreground "white" :background "black"))))
2. C-x 5 2

And to fix the colors in the created frame:
M-: (frame-set-background-mode (selected-frame))

Message #23 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: alan <at> idiocy.org, 43837 <at> debbugs.gnu.org
Subject: Re: bug#43837: 28.0.50; [NS] Internal border of inactive frame
 loses color
Date: Wed, 07 Oct 2020 11:27:25 +0300

> From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
> Cc: Alan Third <alan <at> idiocy.org>,  43837 <at> debbugs.gnu.org
> Date: Wed, 07 Oct 2020 10:42:13 +0300
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Heh, I went through the rabbit hole and arrived at the same fix, now
> > installed on master.  Let's see what will it break, and then perhaps
> > we will understand why the old code used selected-frame there...
> 
> Well, with recent master:
> 
> 1. M-: (custom-set-faces '(default ((t :foreground "white" :background "black"))))
> 2. C-x 5 2
> 
> And to fix the colors in the created frame:
> M-: (frame-set-background-mode (selected-frame))

So are you okay with reverting the fix and enduring the lesser problem
we had before?

Message #26 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43837 <at> debbugs.gnu.org, andreyk.mad <at> gmail.com
Subject: Re: bug#43837: 28.0.50; [NS] Internal border of inactive frame loses
 color
Date: Wed, 7 Oct 2020 09:32:37 +0100

On Wed, Oct 07, 2020 at 10:19:35AM +0300, Eli Zaretskii wrote:
> > Date: Tue, 6 Oct 2020 21:37:15 +0100
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: 43837 <at> debbugs.gnu.org
> > 
> > This isn't an NS specific problem. Eli actually spotted the bug last
> > year and put in a FIXME.
> 
> It was me?

Yup! 6a1dcf594a8b6aa72820f04b529aa3454cf3fc61 :)

-- 
Alan Third

Message #29 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: andreyk.mad <at> gmail.com
Cc: alan <at> idiocy.org, 43837 <at> debbugs.gnu.org
Subject: Re: bug#43837: 28.0.50;
 [NS] Internal border of inactive frame loses color
Date: Wed, 07 Oct 2020 11:37:59 +0300

> Date: Wed, 07 Oct 2020 11:27:25 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: alan <at> idiocy.org, 43837 <at> debbugs.gnu.org
> 
> > From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
> > Cc: Alan Third <alan <at> idiocy.org>,  43837 <at> debbugs.gnu.org
> > Date: Wed, 07 Oct 2020 10:42:13 +0300
> > 
> > 1. M-: (custom-set-faces '(default ((t :foreground "white" :background "black"))))
> > 2. C-x 5 2
> > 
> > And to fix the colors in the created frame:
> > M-: (frame-set-background-mode (selected-frame))
> 
> So are you okay with reverting the fix and enduring the lesser problem
> we had before?

Never mind, I fixed this now, I think.

Message #32 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: alan <at> idiocy.org, 43837 <at> debbugs.gnu.org
Subject: Re: bug#43837: 28.0.50; [NS] Internal border of inactive frame
 loses color
Date: Wed, 07 Oct 2020 11:45:52 +0300

Eli Zaretskii <eliz <at> gnu.org> writes:

> Never mind, I fixed this now, I think.

Can confirm.

Thanks!

Message #35 received at 43837 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 43837 <at> debbugs.gnu.org, alan <at> idiocy.org
Subject: Re: bug#43837: 28.0.50;
 [NS] Internal border of inactive frame loses color
Date: Sun, 18 Oct 2020 04:52:52 -0700

close 43837 28.1
thanks

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> Never mind, I fixed this now, I think.
>
> Can confirm.

It seems like this was fixed, but the bug was never closed.  I'm
therefore closing this bug report.

If this conclusion is incorrect and this is still an issue, please reply
to this email (use "Reply to all" in your email client) and we can
reopen the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.