GNU logs - #43847, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Corwin Brust <corwin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 07 Oct 2020 14:13:01 +0000
Resent-Message-ID: <handler.43847.B.160207992617778 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 43847 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Corwin Brust <corwin@HIDDEN>
Date: Wed, 7 Oct 2020 09:11:48 -0500
Message-ID: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=209.85.208.49; envelope-from=mplscorwin@HIDDEN;
 helo=mail-ed1-f49.google.com
X-Spam_score_int: -13
X-Spam_score: -1.4
X-Spam_bar: -
X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9,
 FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001,
 HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

I hate it when I accidentally paste multi-line text into ERC.  I
*never* actually intend to do this.

This patch provides erc-yank and binds it to C-y for erc-mode buffers.
This does the same as `yank'; however, the text is unfilled (collapsed
to a single line) before it is inserted.

It might make sense to have a defcustom to get back the old behavior
but I haven't included that.  This is my second attempt at sharing a
patch for Emacs; I sent one about an hour ago.  I believe, taking both
patches together, I should be pretty close to the max for tiny-change.
I've started the copyright assignment process.

All feedback gratefully received :)


In GNU Emacs 27.1 (build 1, x86_64-w64-mingw32)
 of 2020-08-21 built on CIRROCUMULUS
Repository revision: 86d8d76aa36037184db0b2897c434cdaab1a9ae8
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.18363
System Description: Microsoft Windows 10 Home (v10.0.1909.18363.1082)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads w32notify w32 lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 46659 8583)
 (symbols 48 6075 1)
 (strings 32 16982 2021)
 (string-bytes 1 519943)
 (vectors 16 9274)
 (vector-slots 8 123598 13156)
 (floats 8 22 312)
 (intervals 56 222 0)
 (buffers 1000 12))

Corwin

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Corwin Brust <corwin@HIDDEN>
Subject: bug#43847: Acknowledgement (ERC - prevent yanking multiple lines
 into IRC (feature request) *patch*)
Message-ID: <handler.43847.B.160207992617778.ack <at> debbugs.gnu.org>
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
X-Gnu-PR-Message: ack 43847
X-Gnu-PR-Package: emacs
Reply-To: 43847 <at> debbugs.gnu.org
Date: Wed, 07 Oct 2020 14:13:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 43847 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
43847: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43847
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Noam Postavsky <npostavs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 07 Oct 2020 15:28:02 +0000
Resent-Message-ID: <handler.43847.B43847.160208444525103 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Corwin Brust <corwin@HIDDEN>
Cc: 43847 <at> debbugs.gnu.org
From: Noam Postavsky <npostavs@HIDDEN>
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
Date: Wed, 07 Oct 2020 11:27:14 -0400
In-Reply-To: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
 (Corwin Brust's message of "Wed, 7 Oct 2020 09:11:48 -0500")
Message-ID: <85mu0yxdil.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Corwin Brust <corwin@HIDDEN> writes:

> I hate it when I accidentally paste multi-line text into ERC.  I
> *never* actually intend to do this.
>
> This patch provides erc-yank and binds it to C-y for erc-mode buffers.
> This does the same as `yank'; however, the text is unfilled (collapsed
> to a single line) before it is inserted.

> All feedback gratefully received :)

I think you may have forgotten to include the patch :)

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Corwin Brust <corwin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 07 Oct 2020 15:32:01 +0000
Resent-Message-ID: <handler.43847.B43847.160208466725551 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Noam Postavsky <npostavs@HIDDEN>
Cc: 43847 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
 <85mu0yxdil.fsf@HIDDEN>
In-Reply-To: <85mu0yxdil.fsf@HIDDEN>
From: Corwin Brust <corwin@HIDDEN>
Date: Wed, 7 Oct 2020 10:30:47 -0500
Message-ID: <CAJf-WoRXFFBXA-mkGcv_-W6g2j3qt6fqS4YD20b8zwfmPuAR5Q@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000f6b9c405b11666d1"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--000000000000f6b9c405b11666d1
Content-Type: text/plain; charset="UTF-8"

Goldarn.

On Wed, Oct 7, 2020 at 10:27 AM Noam Postavsky <npostavs@HIDDEN> wrote:
>
> Corwin Brust <corwin@HIDDEN> writes:
>
> > All feedback gratefully received :)
>
> I think you may have forgotten to include the patch :)
>

Thanks so much Noam.

Corwin

--000000000000f6b9c405b11666d1
Content-Type: application/octet-stream; name="erc-yank.patch"
Content-Disposition: attachment; filename="erc-yank.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kfzjtvp10>
X-Attachment-Id: f_kfzjtvp10

ZGlmZiAtdSAiYzovZW1hY3Mvc2hhcmUvZW1hY3MvMjcuMS9saXNwL2VyYy9lcmMuZWwtMjcuMSIg
ImM6L2VtYWNzL3NoYXJlL2VtYWNzLzI3LjEvbGlzcC9lcmMvZXJjLmVsIg0KLS0tIGM6L2VtYWNz
L3NoYXJlL2VtYWNzLzI3LjEvbGlzcC9lcmMvZXJjLmVsLTI3LjEJMjAyMC0xMC0wNyAwODoxMDoz
NS4wMDAwMDAwMDAgLTA1MDANCisrKyBjOi9lbWFjcy9zaGFyZS9lbWFjcy8yNy4xL2xpc3AvZXJj
L2VyYy5lbAkyMDIwLTEwLTA3IDA4OjE5OjM2LjIwNTcwMDYwMCAtMDUwMA0KQEAgLTExNTQsNiAr
MTE1NCw3IEBADQogICAgIChkZWZpbmUta2V5IG1hcCAiXEMtbSIgJ2VyYy1zZW5kLWN1cnJlbnQt
bGluZSkNCiAgICAgKGRlZmluZS1rZXkgbWFwICJcQy1hIiAnZXJjLWJvbCkNCiAgICAgKGRlZmlu
ZS1rZXkgbWFwIFtob21lXSAnZXJjLWJvbCkNCisgICAgKGRlZmluZS1rZXkgbWFwICJcQy15IiAn
ZXJjLXlhbmspDQogICAgIChkZWZpbmUta2V5IG1hcCAiXEMtY1xDLWEiICdlcmMtYm9sKQ0KICAg
ICAoZGVmaW5lLWtleSBtYXAgIlxDLWNcQy1iIiAnZXJjLXN3aXRjaC10by1idWZmZXIpDQogICAg
IChkZWZpbmUta2V5IG1hcCAiXEMtY1xDLWMiICdlcmMtdG9nZ2xlLWludGVycHJldC1jb250cm9s
cykNCkBAIC00MDg0LDYgKzQwODUsMTkgQEANCiAgICAgICAgIChzZXRxIGVyYy1pbnB1dC1yaW5n
LWluZGV4IG5pbCkpDQogICAgIChraWxsLWxpbmUpKSkNCiANCisoZGVmdW4gZXJjLXlhbmsgKCZv
cHRpb25hbCBhcmcpDQorICAiVW5maWxsIHRoZW4geWFuay4gIEFSRyBpcyBoYW5kbGVkIGJ5IGB5
YW5rJywgd2hpY2ggc2VlLiINCisgIChpbnRlcmFjdGl2ZSkNCisgIChpbnNlcnQNCisgICAoc2F2
ZS1leGN1cnNpb24NCisgICAgICh3aXRoLXRlbXAtYnVmZmVyDQorICAgICAgICh5YW5rIGFyZykN
CisgICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkNCisgICAgICAgKGxldCAoKGZpbGwtY29s
dW1uIChwb2ludC1tYXgpKQ0KKwkgICAgIChlbWFjcy1saXNwLWRvY3N0cmluZy1maWxsLWNvbHVt
biB0KSkNCisJIChmaWxsLXBhcmFncmFwaCkpDQorICAgICAgIChidWZmZXItc3RyaW5nKSkpKSkN
CisNCiAoZGVmdW4gZXJjLWNvbXBsZXRlLXdvcmQtYXQtcG9pbnQgKCkNCiAgIChydW4taG9vay13
aXRoLWFyZ3MtdW50aWwtc3VjY2VzcyAnZXJjLWNvbXBsZXRlLWZ1bmN0aW9ucykpDQogDQoNCkRp
ZmYgZmluaXNoZWQuICBXZWQgT2N0ICA3IDA4OjIwOjAxIDIwMjANCg==
--000000000000f6b9c405b11666d1--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Noam Postavsky <npostavs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 07 Oct 2020 16:06:02 +0000
Resent-Message-ID: <handler.43847.B43847.160208671328911 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 43847
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Corwin Brust <corwin@HIDDEN>
Cc: 43847 <at> debbugs.gnu.org
Received: via spool by 43847-submit <at> debbugs.gnu.org id=B43847.160208671328911
          (code B ref 43847); Wed, 07 Oct 2020 16:06:02 +0000
Received: (at 43847) by debbugs.gnu.org; 7 Oct 2020 16:05:13 +0000
Received: from localhost ([127.0.0.1]:57795 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kQBwG-0007WF-R8
	for submit <at> debbugs.gnu.org; Wed, 07 Oct 2020 12:05:13 -0400
Received: from mail-qt1-f169.google.com ([209.85.160.169]:41937)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <npostavs@HIDDEN>) id 1kQBwD-0007Vl-W7
 for 43847 <at> debbugs.gnu.org; Wed, 07 Oct 2020 12:05:10 -0400
Received: by mail-qt1-f169.google.com with SMTP id j22so2308778qtj.8
 for <43847 <at> debbugs.gnu.org>; Wed, 07 Oct 2020 09:05:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=yzM9gyHIrLVwQI5GtPX9/SNJ459CBvFT3IUOr24G3z8=;
 b=pp+v9EBv+Chpe3P0h6Sb4PBQQC18qtrCp0K26voqaPaeP10hqXupKP2XMRBcbYEHkz
 uEdb8yy1HY+DQ6QMlYL5mds79Ru96ITAskQ/Ys60XCE7ZkZbYUxLBLwavAA1UDTDObxQ
 tdPs4vVHoKfXNjAEoPIrF5jIYC82igQotpfDEvjSga4RvcFPWsfWSF7XevwLXcuGRbZs
 1CDxZ10rPEyk0/wDoe4HAJkyc5roCW4ic9PprGVmmKfn9qX5443QTlYwQgLvqDjPlX/f
 XdAt8f5zcBbnwpniyNZ3jB6Fd49S0O5JFlco4bqiRB+rpgfDLlgx02P6RqUTNmud2Eqt
 +oHw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=yzM9gyHIrLVwQI5GtPX9/SNJ459CBvFT3IUOr24G3z8=;
 b=ZKQZgWLypZfLK9eFWph7+BiSXwxslAsVbbc2OXpY09NrCI8A+CEbk9DtU6Y1ZgYoW4
 WCu3/SkJylZpN4BmEaspCjzLH20FzipDU7e2Wj8PYh2tTRV0ahBwC7CorlnWi3wvo/95
 j2/dzUzBfw6yTj3g2MLhiGW4Y64MN7vcXZ5vlIIsgzzff0ToFiRo6k10TTUtNj1u9f6f
 QQAvfEWOH6jl0MAr9nzrIDKzhD4XAn2Da5knBF0ksR128soOCEyY6Gy4vqjzxHz38teg
 +LFPfSfRjLYxxYuRrV1TF99rC1Twh0H+slBOZXiJWWO2nXEn4cEn3dlhmQTH0C2JVorE
 Km/A==
X-Gm-Message-State: AOAM531IwI4DpsUucMmUdG4jmP91lO0WX4b5Luj6qlSXvYt+M44ByJSI
 7Sw7KqZTPJuylNe77dM1I6ByYHaxxOA=
X-Google-Smtp-Source: ABdhPJx3CaRLWSnQsGHPYRBJciPrjLP5w8tCUSKt91D7pQhjX1XFs3dL8hiMDHJfceh5RX3RiL+QXQ==
X-Received: by 2002:ac8:46c2:: with SMTP id h2mr3878954qto.154.1602086704217; 
 Wed, 07 Oct 2020 09:05:04 -0700 (PDT)
Received: from vhost2
 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42])
 by smtp.gmail.com with ESMTPSA id 11sm771793qkc.91.2020.10.07.09.05.03
 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 07 Oct 2020 09:05:03 -0700 (PDT)
From: Noam Postavsky <npostavs@HIDDEN>
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
 <85mu0yxdil.fsf@HIDDEN>
 <CAJf-WoRXFFBXA-mkGcv_-W6g2j3qt6fqS4YD20b8zwfmPuAR5Q@HIDDEN>
Date: Wed, 07 Oct 2020 12:05:01 -0400
In-Reply-To: <CAJf-WoRXFFBXA-mkGcv_-W6g2j3qt6fqS4YD20b8zwfmPuAR5Q@HIDDEN>
 (Corwin Brust's message of "Wed, 7 Oct 2020 10:30:47 -0500")
Message-ID: <85k0w2xbrm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

I hope an ERC user will follow up (I think Bandali was going over ERC
patches at some point?), but just some general comments:

> diff -u "c:/emacs/share/emacs/27.1/lisp/erc/erc.el-27.1" "c:/emacs/share/emacs/27.1/lisp/erc/erc.el"

> +(defun erc-yank (&optional arg)
> +  "Unfill then yank.  ARG is handled by `yank', which see."
> +  (interactive)
> +  (insert
> +   (save-excursion

I believe the save-excursion is redundant since all the movement happens
inside a temp buffer.

> +     (with-temp-buffer
> +       (yank arg)
> +       (goto-char (point-min))
> +       (let ((fill-column (point-max))
> +	     (emacs-lisp-docstring-fill-column t))

I don't think binding emacs-lisp-docstring-fill-column should be needed?

> +	 (fill-paragraph))

The TAB character should be spaces instead.  I recommend (setq-default
indent-tabs-mode nil), or at least

    (defun my-lisp-mode-hook ()
      (setq-local indent-tabs-mode nil))
    (add-hook 'emacs-lisp-mode-hook #'my-lisp-mode-hook)

Note that if you edit the git repo, it comes with an indent-tabs-mode=nil
setting for emacs-lisp-mode in .dir-locals.el.

> +       (buffer-string)))))

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Brett Gilio <brettg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 07 Oct 2020 16:57:02 +0000
Resent-Message-ID: <handler.43847.B43847.160208977717694 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 43847
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Corwin Brust <corwin@HIDDEN>
Cc: 43847 <at> debbugs.gnu.org
Received: via spool by 43847-submit <at> debbugs.gnu.org id=B43847.160208977717694
          (code B ref 43847); Wed, 07 Oct 2020 16:57:02 +0000
Received: (at 43847) by debbugs.gnu.org; 7 Oct 2020 16:56:17 +0000
Received: from localhost ([127.0.0.1]:57963 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kQCjh-0004bJ-68
	for submit <at> debbugs.gnu.org; Wed, 07 Oct 2020 12:56:17 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44318)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <brettg@HIDDEN>) id 1kQCjc-0004b4-CQ
 for 43847 <at> debbugs.gnu.org; Wed, 07 Oct 2020 12:56:15 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:48289)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <brettg@HIDDEN>)
 id 1kQCjW-0003k6-MU; Wed, 07 Oct 2020 12:56:06 -0400
Received: from [2605:6000:1a0d:48fb::8e5] (port=47398 helo=debian)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <brettg@HIDDEN>)
 id 1kQCjU-0005Ir-4W; Wed, 07 Oct 2020 12:56:05 -0400
From: Brett Gilio <brettg@HIDDEN>
In-Reply-To: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
 (Corwin Brust's message of "Wed, 7 Oct 2020 09:11:48 -0500")
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Date: Wed, 07 Oct 2020 11:56:02 -0500
Message-ID: <87sgaqgel9.fsf@debian>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Corwin Brust <corwin@HIDDEN> writes:

> I hate it when I accidentally paste multi-line text into ERC.  I
> *never* actually intend to do this.
>
> This patch provides erc-yank and binds it to C-y for erc-mode buffers.
> This does the same as `yank'; however, the text is unfilled (collapsed
> to a single line) before it is inserted.
>
> It might make sense to have a defcustom to get back the old behavior
> but I haven't included that.  This is my second attempt at sharing a
> patch for Emacs; I sent one about an hour ago.  I believe, taking both
> patches together, I should be pretty close to the max for tiny-change.
> I've started the copyright assignment process.
>
> All feedback gratefully received :)
>

A possible alternative behavior could be somewhat similar to what CIRCE
does, but may be more intensive to implement. CIRCE, when pasting
multiline content offers to send the content to a paste-service, and
then kills the URL to the buffer and sends that instead.

What if we had a paste.emacs.org that ERC could utilize here?

Just a thought.

Brett Gilio

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Corwin Brust <corwin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 09 Oct 2020 01:34:01 +0000
Resent-Message-ID: <handler.43847.B43847.16022071932661 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 43847
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Brett Gilio <brettg@HIDDEN>
Cc: 43847 <at> debbugs.gnu.org
Received: via spool by 43847-submit <at> debbugs.gnu.org id=B43847.16022071932661
          (code B ref 43847); Fri, 09 Oct 2020 01:34:01 +0000
Received: (at 43847) by debbugs.gnu.org; 9 Oct 2020 01:33:13 +0000
Received: from localhost ([127.0.0.1]:33530 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kQhHV-0000gq-5E
	for submit <at> debbugs.gnu.org; Thu, 08 Oct 2020 21:33:13 -0400
Received: from mail-ed1-f65.google.com ([209.85.208.65]:38430)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mplscorwin@HIDDEN>) id 1kQhHT-0000gd-88
 for 43847 <at> debbugs.gnu.org; Thu, 08 Oct 2020 21:33:12 -0400
Received: by mail-ed1-f65.google.com with SMTP id i5so7746941edr.5
 for <43847 <at> debbugs.gnu.org>; Thu, 08 Oct 2020 18:33:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=9uXH2uQghHOfE0w13Ym5EM4BLirknqdv8QrzrEPAOBg=;
 b=Z/a2+/rUFkumgHDCndXWvnRVxgaE4muGQUNyNS1OAgl5V9Zwl6NElNmbHACxa9i2Vd
 315Aro1++LTnYBXw1rr/WXdPjSEe7jzbGDT3+5cwXGd5ApNVZ75UcW+5SD2Cnbk5gbrY
 edU+Ta/Krg5GOUubRZQ1H4ElaWhf9G4Ts8o+kNCHbJHzMZnafw7c+bxhJiPiAkkCc5np
 +Ow061vpKTSHhT3CtHQ1gz3+5PBd+eu6lA75D+FPSgHfY1NExKHC71RrzJiVjytKvYwz
 7r/2954UrSrSGdl8fYbiDiI+c5jepALrlqZXN4MDFxw3crPYlVM2E1obSnUziUnFfp2O
 fibA==
X-Gm-Message-State: AOAM5339qINPTYZPn4iWuJnflBBWwaRj0HpsX+lRnw+9tSVNJuQIwcMW
 B+7CDzDXu5sDlEpOKHPU+TroBmyEK5iIaAI6ukKE2Sfr+6vPWg==
X-Google-Smtp-Source: ABdhPJyXzvZ5OhT/4tMDbJidEd9p3pOhWPh3p0RikTrGSBvwfHKRiU/cWj8kvRUH/bltO+hJrLgGY8kwXJn4egzP3BE=
X-Received: by 2002:a05:6402:1446:: with SMTP id
 d6mr12045909edx.244.1602207185378; 
 Thu, 08 Oct 2020 18:33:05 -0700 (PDT)
MIME-Version: 1.0
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
 <87sgaqgel9.fsf@debian>
In-Reply-To: <87sgaqgel9.fsf@debian>
From: Corwin Brust <corwin@HIDDEN>
Date: Thu, 8 Oct 2020 20:32:54 -0500
Message-ID: <CAJf-WoSHEzg0_3q_MQMxGCiX3yM6vAjepLUqUKZzAOJV5TqS9g@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Hi Brett!  Thanks so much for the reply!

On Wed, Oct 7, 2020 at 11:56 AM Brett Gilio <brettg@HIDDEN> wrote:
>
> Corwin Brust <corwin@HIDDEN> writes:
>
> > I hate it when I accidentally paste multi-line text into ERC.  I
> > *never* actually intend to do this.
> >
> > This patch provides erc-yank and binds it to C-y for erc-mode buffers.
> > This does the same as `yank'; however, the text is unfilled (collapsed
> > to a single line) before it is inserted.
> >
> > It might make sense to have a defcustom to get back the old behavior
> > but I haven't included that.  This is my second attempt at sharing a
> > patch for Emacs; I sent one about an hour ago.  I believe, taking both
> > patches together, I should be pretty close to the max for tiny-change.
> > I've started the copyright assignment process.
> >
> > All feedback gratefully received :)
> >
>
> A possible alternative behavior could be somewhat similar to what CIRCE
> does, but may be more intensive to implement. CIRCE, when pasting
> multiline content offers to send the content to a paste-service, and
> then kills the URL to the buffer and sends that instead.

This is a wonderful suggestion.  Speaking for myself, personally, I'd
like to see it as somewhat of a secondary behavior, what sending a
prefix arg does, or something.  In any case a very fine feature,
indeed.

A quick perusal of CIRCE[1] (which looks lovely), suggests the present
approach there involves having various paste-services explicitly
supported.  Perhaps this could be implemented in terms of a
def-paste-service macro, of some sort.  I would expect some amount of
discussion may be involved in selecting an initial service or services
to support, as it were, of the the box.  Maybe that conversation would
be approprite to Emacs devel, in case this feature would be
interesting to a more general cross-section of users vs ERC/IRC.

> What if we had a paste.emacs.org that ERC could utilize here?

I think that's an excellet idea in several regards.  In addition to
simplifying, potentially trivializing the decision of what service to
support, it also leads to a bunch of links getting shared around which
point into the fsfverse.  It's a tiny bit of mind-share, but I'd be
inclined to take it.  That said, having a "branded" paste-service
"baked in" to Emacs would seem to me to stengthen the argument to
formalize the interface for people to setup their own; to make ours
easy and others hard would be very off-brand.

This is something I'd be happy to work on, but I'm not how we would
approach something like requesting a http facing new service, going
forward.

> Just a thought.

As I hope I made clear, I love it.

I'm tempted tho, to suggest we might move forward with my more trival
suggested change in the mean-time.

It seems like having something special at C-y in `erc-mode' is
probably on the road-map for any of this, and may make live easier for
ERC users somewhat more quickly than some of the other ideas discussed
so far can move.

>
> Brett Gilio


Regards,
Corwin

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Corwin Brust <corwin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 09 Oct 2020 02:01:02 +0000
Resent-Message-ID: <handler.43847.B43847.16022088105299 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 43847
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Brett Gilio <brettg@HIDDEN>
Cc: 43847 <at> debbugs.gnu.org
Received: via spool by 43847-submit <at> debbugs.gnu.org id=B43847.16022088105299
          (code B ref 43847); Fri, 09 Oct 2020 02:01:02 +0000
Received: (at 43847) by debbugs.gnu.org; 9 Oct 2020 02:00:10 +0000
Received: from localhost ([127.0.0.1]:33570 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kQhhZ-0001NP-Md
	for submit <at> debbugs.gnu.org; Thu, 08 Oct 2020 22:00:09 -0400
Received: from mail-ej1-f41.google.com ([209.85.218.41]:44040)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mplscorwin@HIDDEN>) id 1kQhhW-0001Ll-UT
 for 43847 <at> debbugs.gnu.org; Thu, 08 Oct 2020 22:00:08 -0400
Received: by mail-ej1-f41.google.com with SMTP id a3so10776349ejy.11
 for <43847 <at> debbugs.gnu.org>; Thu, 08 Oct 2020 19:00:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=W7kxVh6njMJ3NGW5dIZdZ1ksy5HtCIwro+iCgZ7jeGU=;
 b=Mrwyjfwjif2M7wO1P41K9KfEuVYXMe9N9BzH+35aQaKfVkIVZ/bvojAkSfgWCOtlG3
 s4MgzwE7EmhE0WbYK6ckZwYlBd9HYBYugxY7pWLqoUhEpxVvxWN3tMbYvz9Xchuj1CXT
 dxWzKrfOfeILPALM/h81lnPzFibuNWerrQgbEb8M1iLt1IKju9ITF+WUC1JgFilC1dmI
 FZzDYhfJz+NR0KN6d6JlXjrWJk4M6bUR19lah8BIi3tNRNVIZEANrxfWdvhgnKVu2WK5
 yhxOMMW0W91sx/LVVXyBLg/JV5Ibd4MiHhF1XE0ur6KjTbQQrPHzjJis0tq/lHHUHUlV
 TnOQ==
X-Gm-Message-State: AOAM532OdXIt1Z2VC8n53VtpQnVnhQWYclj4DWu4S4c/Ji/tqTgZTB4W
 TT6hxbR15CKDvn3LwUOtm/RT5QmKndx2Y74I6Nc=
X-Google-Smtp-Source: ABdhPJx4JhZYEnU3YNPm67/URsyjdIBXz7V3xD3ZixcyvTmIQN5Q4mbStupfyk7vDTKvDJFalxsMVSy4NtxiJbyeES4=
X-Received: by 2002:a17:906:17c6:: with SMTP id
 u6mr11940062eje.95.1602208800990; 
 Thu, 08 Oct 2020 19:00:00 -0700 (PDT)
MIME-Version: 1.0
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
 <87sgaqgel9.fsf@debian>
 <CAJf-WoSHEzg0_3q_MQMxGCiX3yM6vAjepLUqUKZzAOJV5TqS9g@HIDDEN>
In-Reply-To: <CAJf-WoSHEzg0_3q_MQMxGCiX3yM6vAjepLUqUKZzAOJV5TqS9g@HIDDEN>
From: Corwin Brust <corwin@HIDDEN>
Date: Thu, 8 Oct 2020 20:59:49 -0500
Message-ID: <CAJf-WoTscwX1YE6O2zsFC+VtSH7bc-T0EZhMLX8ytj5T6EWL9g@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Hi again.

On Thu, Oct 8, 2020 at 8:32 PM Corwin Brust <corwin@HIDDEN> wrote:
>

>
> A quick perusal of CIRCE[1] (which looks lovely), suggests the present

I see that I forgot the link for the source I looked at.  Here it is:

[1] https://github.com/jorgenschaefer/circe/blob/master/lui-autopaste.el

Corwin

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Corwin Brust <corwin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 09 Oct 2020 02:02:01 +0000
Resent-Message-ID: <handler.43847.B43847.16022088985447 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 43847
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Noam Postavsky <npostavs@HIDDEN>
Cc: 43847 <at> debbugs.gnu.org
Received: via spool by 43847-submit <at> debbugs.gnu.org id=B43847.16022088985447
          (code B ref 43847); Fri, 09 Oct 2020 02:02:01 +0000
Received: (at 43847) by debbugs.gnu.org; 9 Oct 2020 02:01:38 +0000
Received: from localhost ([127.0.0.1]:33574 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kQhj0-0001Pn-26
	for submit <at> debbugs.gnu.org; Thu, 08 Oct 2020 22:01:38 -0400
Received: from mail-ed1-f47.google.com ([209.85.208.47]:33941)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mplscorwin@HIDDEN>) id 1kQhiy-0001Pb-94
 for 43847 <at> debbugs.gnu.org; Thu, 08 Oct 2020 22:01:36 -0400
Received: by mail-ed1-f47.google.com with SMTP id x1so7792692eds.1
 for <43847 <at> debbugs.gnu.org>; Thu, 08 Oct 2020 19:01:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=4FxytFT808NbtC9UecGY1gEE7LMzR5iLwiBjLR1lMk4=;
 b=LIk8RXsRRZYzCgKVWZq8OhlRnJbnCAOODU5A81paY2oiM8EI6uT8WMusESff+lkWTW
 YHbu/aEjxdKuRFKZnRdBJy3ucqwDy3fmNvOe/fv3t6KM+xOFuY/4Ru5u0IrSZJPOiynV
 0f1S4+P2YDOyw3SWtUn6Kc26kjDxo8jFMz3aPKjW59thR903ZhtN/Ptvp7I3tQoWYNt/
 ZCRBQHyPN4KvGTlisH7M2ts0cOogCV9M1NWeSoHncD0Eas+QsKXVm+UfnSlrccvO+94i
 Fbeu0eLrIAu5+58ZPIaHbVV0f7uPG/H/ofVsZtEYKs6BNoCVXTIgzHVSddeueQKxIGjS
 R4NA==
X-Gm-Message-State: AOAM531WRFm/C/mwEezalkPdKfCnyP+1NK1/Vlr16IZTOKUm2BRwtH4H
 un7V+00j9bnp64nK2KtM5OFrhBdNSVfgE65W1/g=
X-Google-Smtp-Source: ABdhPJwfjDqalptHKpylitYEqjh/Qn/ICc1Ja57DJJ6/eJv8AKgj/e+CMf38qaWkuIy3L4dhfBf/76dqLaLhmOJgMFE=
X-Received: by 2002:aa7:c608:: with SMTP id h8mr11907163edq.16.1602208890409; 
 Thu, 08 Oct 2020 19:01:30 -0700 (PDT)
MIME-Version: 1.0
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
 <85mu0yxdil.fsf@HIDDEN>
 <CAJf-WoRXFFBXA-mkGcv_-W6g2j3qt6fqS4YD20b8zwfmPuAR5Q@HIDDEN>
 <85k0w2xbrm.fsf@HIDDEN>
In-Reply-To: <85k0w2xbrm.fsf@HIDDEN>
From: Corwin Brust <corwin@HIDDEN>
Date: Thu, 8 Oct 2020 21:01:19 -0500
Message-ID: <CAJf-WoQqPZaWGtzUhLKWG0p=Hz1VfO8jRUwh+87G-tcFe3zRKg@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000c5055405b13353c5"
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

--000000000000c5055405b13353c5
Content-Type: text/plain; charset="UTF-8"

Many thanks, Noam.

On Wed, Oct 7, 2020 at 11:05 AM Noam Postavsky <npostavs@HIDDEN> wrote:
>
> I hope an ERC user will follow up (I think Bandali was going over ERC
> patches at some point?), but just some general comments:

I'm hoping Bandali and other ERC users will look, also.  I spoke to
someone on ERC today who is using the (prior version), I believe and
has agreed to mention any issues or suggestions.  (They agreed with
you about e-l-d-f-c being irrelevant, which seems pretty darned
obvious to me now too.)

> > diff -u "c:/emacs/share/emacs/27.1/lisp/erc/erc.el-27.1" "c:/emacs/share/emacs/27.1/lisp/erc/erc.el"
>
> > +(defun erc-yank (&optional arg)
> > +  "Unfill then yank.  ARG is handled by `yank', which see."
> > +  (interactive)
> > +  (insert
> > +   (save-excursion
>
> I believe the save-excursion is redundant since all the movement happens
> inside a temp buffer.

Removed save-excursion, thank you.

>
> > +     (with-temp-buffer
> > +       (yank arg)
> > +       (goto-char (point-min))
> > +       (let ((fill-column (point-max))
> > +          (emacs-lisp-docstring-fill-column t))
>
> I don't think binding emacs-lisp-docstring-fill-column should be needed?

*Smacking of forehead*  Right you are.


> > +      (fill-paragraph))
>
> The TAB character should be spaces instead.  I recommend (setq-default
> indent-tabs-mode nil), or at least
>
>     (defun my-lisp-mode-hook ()
>       (setq-local indent-tabs-mode nil))
>     (add-hook 'emacs-lisp-mode-hook #'my-lisp-mode-hook)
>
> Note that if you edit the git repo, it comes with an indent-tabs-mode=nil
> setting for emacs-lisp-mode in .dir-locals.el.
>
> > +       (buffer-string)))))

I'm pulling master now.  This version was created after evaling your
suggested one-liner in my erc.el buffer & please let me know if that's
got it.

Again, thanks

Corwin

--000000000000c5055405b13353c5
Content-Type: application/octet-stream; 
	name="erc-yank_002_rm_save-excusrion-and-elsip-docstring-col.patch"
Content-Disposition: attachment; 
	filename="erc-yank_002_rm_save-excusrion-and-elsip-docstring-col.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kg1lsnmz0>
X-Attachment-Id: f_kg1lsnmz0

ZGlmZiAtdSAiYzovZW1hY3Mvc2hhcmUvZW1hY3MvMjcuMS9saXNwL2VyYy9lcmMuZWwtMjcuMSIg
ImM6L2VtYWNzL3NoYXJlL2VtYWNzLzI3LjEvbGlzcC9lcmMvZXJjLmVsIg0KLS0tIGM6L2VtYWNz
L3NoYXJlL2VtYWNzLzI3LjEvbGlzcC9lcmMvZXJjLmVsLTI3LjEJMjAyMC0xMC0wNyAwODoxMDoz
NS4wMDAwMDAwMDAgLTA1MDANCisrKyBjOi9lbWFjcy9zaGFyZS9lbWFjcy8yNy4xL2xpc3AvZXJj
L2VyYy5lbAkyMDIwLTEwLTA4IDIwOjQyOjI2LjIwNzY4NDEwMCAtMDUwMA0KQEAgLTExNTUsNiAr
MTE1NSw3IEBADQogICAgIChkZWZpbmUta2V5IG1hcCAiXEMtYSIgJ2VyYy1ib2wpDQogICAgIChk
ZWZpbmUta2V5IG1hcCBbaG9tZV0gJ2VyYy1ib2wpDQogICAgIChkZWZpbmUta2V5IG1hcCAiXEMt
Y1xDLWEiICdlcmMtYm9sKQ0KKyAgICAoZGVmaW5lLWtleSBtYXAgIlxDLXkiICdlcmMteWFuaykN
CiAgICAgKGRlZmluZS1rZXkgbWFwICJcQy1jXEMtYiIgJ2VyYy1zd2l0Y2gtdG8tYnVmZmVyKQ0K
ICAgICAoZGVmaW5lLWtleSBtYXAgIlxDLWNcQy1jIiAnZXJjLXRvZ2dsZS1pbnRlcnByZXQtY29u
dHJvbHMpDQogICAgIChkZWZpbmUta2V5IG1hcCAiXEMtY1xDLWQiICdlcmMtaW5wdXQtYWN0aW9u
KQ0KQEAgLTQwODQsNiArNDA4NSwxNiBAQA0KICAgICAgICAgKHNldHEgZXJjLWlucHV0LXJpbmct
aW5kZXggbmlsKSkNCiAgICAgKGtpbGwtbGluZSkpKQ0KIA0KKyhkZWZ1biBlcmMteWFuayAoJm9w
dGlvbmFsIGFyZykNCisgICJVbmZpbGwgdGhlbiB5YW5rLiAgQVJHIGlzIGhhbmRsZWQgYnkgYHlh
bmsnLCB3aGljaCBzZWUuIg0KKyAgKGludGVyYWN0aXZlKQ0KKyAgKHdpdGgtdGVtcC1idWZmZXIN
CisgICAgKHlhbmsgYXJnKQ0KKyAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQ0KKyAgICAobGV0
ICgoZml4LWNvbHVtbiAocG9pbnQtbWF4KSkpDQorICAgICAgKGZpbGwtcGFyYWdyYXBoKSkNCisg
ICAgKGJ1ZmZlci1zdHJpbmcpKSkNCisNCiAoZGVmdW4gZXJjLWNvbXBsZXRlLXdvcmQtYXQtcG9p
bnQgKCkNCiAgIChydW4taG9vay13aXRoLWFyZ3MtdW50aWwtc3VjY2VzcyAnZXJjLWNvbXBsZXRl
LWZ1bmN0aW9ucykpDQogDQoNCkRpZmYgZmluaXNoZWQuICBUaHUgT2N0ICA4IDIwOjQzOjExIDIw
MjANCg==
--000000000000c5055405b13353c5--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 09 Oct 2020 04:55:01 +0000
Resent-Message-ID: <handler.43847.B43847.160221929630727 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 43847
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Corwin Brust <corwin@HIDDEN>
Cc: 43847 <at> debbugs.gnu.org
Received: via spool by 43847-submit <at> debbugs.gnu.org id=B43847.160221929630727
          (code B ref 43847); Fri, 09 Oct 2020 04:55:01 +0000
Received: (at 43847) by debbugs.gnu.org; 9 Oct 2020 04:54:56 +0000
Received: from localhost ([127.0.0.1]:33904 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kQkQh-0007zV-Op
	for submit <at> debbugs.gnu.org; Fri, 09 Oct 2020 00:54:56 -0400
Received: from quimby.gnus.org ([95.216.78.240]:34264)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1kQkQf-0007zG-3b
 for 43847 <at> debbugs.gnu.org; Fri, 09 Oct 2020 00:54:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=hCYerOA4iJUJ+2UxmEPYD6m/RZ0L+1PGf4tgzoJWKA4=; b=lrAtHKS5LCg5X0g+7AnjWh5cFS
 8XNcApQ9nUgqBivBYSBkCrcBcr+nhMbDKr87uJaYD1YmQ/eclqocjEQ/zinBtqos6rR+GAE6nT13A
 scX8LY2ke2U9iuNYHAUyeZyRstQuaZ+4HgZrvUglqzDTRgXdFdUyufTGQW2EjMasnHpw=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1kQkQW-00087w-48; Fri, 09 Oct 2020 06:54:46 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
X-Now-Playing: Alva Noto and Ryuichi Sakamoto's _Vrioon_: "Duoon"
Date: Fri, 09 Oct 2020 06:54:42 +0200
In-Reply-To: <CAJf-WoTnOztBmxk1M88vWffcRqFK1UHuy044XVOGkU1TKeAm3Q@HIDDEN>
 (Corwin Brust's message of "Wed, 7 Oct 2020 09:11:48 -0500")
Message-ID: <87tuv43sod.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Corwin Brust <corwin@HIDDEN> writes: > I hate it when I
 accidentally
 paste multi-line text into ERC. I > *never* actually intend to do this. I
 sometimes want to, and sometimes I don't want to. I think it would be pretty
 surprising for users if we rebind `C-y' in this way. 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Corwin Brust <corwin@HIDDEN> writes:

> I hate it when I accidentally paste multi-line text into ERC.  I
> *never* actually intend to do this.

I sometimes want to, and sometimes I don't want to.  I think it would be
pretty surprising for users if we rebind `C-y' in this way.

I'm using a command that fixes whitespace and removes newlines from the
kill ring, which is perhaps more generally useful.  Let's see...

(global-set-key
 [(hyper y)]
 (lambda ()
   (interactive)
   (insert
    (with-temp-buffer
      (yank)
      (goto-char (point-min))
      (while (re-search-forward "[\t\n ]+" nil t)
        (replace-match " "))
      (goto-char (point-min))
      (when (re-search-forward " +$" nil t)
        (replace-match ""))
      (buffer-string)))))

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Last modified: Fri, 9 Oct 2020 05:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.