GNU bug report logs - #43860
[PATCH] gnu: python: Disable failing tests for the Hurd.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43860 in the body.
You can then email your comments to 43860 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python: Disable failing tests for the Hurd.
Date: Thu, 08 Oct 2020 08:26:26 +0200

[Message part 1 (text/plain, inline)]

Hi!

This patch disables 27 additional tests for the Hurd, and enabled me to
build (a copy of) python-minimal natively

--8<---------------cut here---------------start------------->8---
/gnu/store/9xm1idqyvyyz6xcqaa20aw2p8ap9zxcj-python-hurd-minimal-3.8.2
--8<---------------cut here---------------end--------------->8---

That sounds bad, but Debian disables ~15 tests by default (varies per
platform), where we only disable test_socket, and 17 additional for the
Hurd:

    https://salsa.debian.org/cpython-team/python3/-/raw/python3.8/debian/rules

and our exclude sets have some overlap, but also some "underlap"...

It's tempting to do

--8<---------------cut here---------------start------------->8---
#:tests? ,(not (hurd-target?))
--8<---------------cut here---------------end--------------->8---

just like https://bugs.gnu.org/43857 suggests:

    "rather not fiddle too much with test suites until we have defined
     what’s available in the default build environment."

on the other hand, now some 350 tests run and pass.  (It would be nice
if Python had a less fragile test suite, or if packages (the GNU
standard?) defined a "smoke test" we could run.)

Then there is also this 2013 bug report in Debian

    https://bugs.debian.org/708652
    "hurd has several tests disabled because they hang the testsuite, at
     least on the buildds. These should be investigated..."

and we/they probably will, when someone finds the time.

One last thing: pushing this patch rebuilds world for the Hurd; probably
not the best timing to push today?  Ideas?

Greetings,
Janneke

[0001-gnu-python-Disable-failing-tests-for-the-Hurd.patch (text/x-patch, inline)]

From 66eb46ed2f7166bff6d17dcbfe64f195ec1bb6b3 Mon Sep 17 00:00:00 2001
From: "Jan (janneke) Nieuwenhuizen" <janneke <at> gnu.org>
Date: Wed, 7 Oct 2020 23:01:26 +0200
Subject: [PATCH] gnu: python: Disable failing tests for the Hurd.
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8

* gnu/packages/python.scm (python-3.8)[arguments]: When building for the Hurd,
disable more tests.
---
 gnu/packages/python.scm | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8f2651decf..43704bccae 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -395,7 +395,39 @@ data types.")
                 " --exclude test_mmap"
                 ;; test_socket may hang and eventually run out of memory
                 ;; on some systems: <https://bugs.python.org/issue34587>.
-                " test_socket")))
+                " test_socket"
+                ,@(if (hurd-target?)
+                      '(" test_posix"      ;multiple errors
+                        " test_time"
+                        " test_pty"
+                        " test_shutil"
+                        " test_tempfile"   ;chflags: invalid argument:
+                                           ;  tbv14c9t/dir0/dir0/dir0/test0.txt
+                        " test_asyncio"    ;runs over 10min
+                        " test_os"         ;stty: 'standard input':
+                                           ;  Inappropriate ioctl for device
+                        " test_openpty"    ;No such file or directory
+                        " test_selectors"  ;assertEqual(NUM_FDS // 2, len(fds))
+                                           ;  32752 != 4
+                        " test_compileall" ;multiple errors
+                        " test_poll"       ;list index out of range
+                        " test_subprocess" ;runs over 10min
+                        " test_asyncore"   ;multiple errors
+                        " test_threadsignals"
+                        " test_eintr"      ;Process return code is -14
+                        " test_io"         ;multiple errors
+                        " test_logging"
+                        " test_signal"
+                        " test_threading"  ;runs over 10min
+                        " test_flags"      ;ERROR
+                        " test_bidirectional_pty"
+                        " test_create_unix_connection"
+                        " test_unix_sock_client_ops"
+                        " test_open_unix_connection"
+                        " test_open_unix_connection_error"
+                        " test_read_pty_output"
+                        " test_write_pty")
+                      '()))))
        ((#:phases phases)
        `(modify-phases ,phases
           ,@(if (hurd-system?)
-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

[Message part 3 (text/plain, inline)]

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Message #8 received at 43860 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>, 43860 <at> debbugs.gnu.org
Subject: Re: [bug#43860] [PATCH] gnu: python: Disable failing tests for the
 Hurd.
Date: Tue, 13 Oct 2020 22:51:22 +0200

[Message part 1 (text/plain, inline)]

Jan Nieuwenhuizen <janneke <at> gnu.org> writes:

> Hi!
>
> This patch disables 27 additional tests for the Hurd, and enabled me to
> build (a copy of) python-minimal natively
>
> --8<---------------cut here---------------start------------->8---
> /gnu/store/9xm1idqyvyyz6xcqaa20aw2p8ap9zxcj-python-hurd-minimal-3.8.2
> --8<---------------cut here---------------end--------------->8---

Yaay!  I thought it would be much worse...

[...]

> One last thing: pushing this patch rebuilds world for the Hurd; probably
> not the best timing to push today?  Ideas?

It has been a few days, so I guess you can go ahead and push.  Hopefully
the build farm catches up quickly for those who haven't gotten around to
try the new Hurd VM yet (like me!).

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 43860-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Marius Bakke <marius <at> gnu.org>
Cc: 43860-done <at> debbugs.gnu.org
Subject: Re: [bug#43860] [PATCH] gnu: python: Disable failing tests for the
 Hurd.
Date: Mon, 26 Oct 2020 15:55:49 +0100

Marius Bakke writes:

Hello,

> Jan Nieuwenhuizen <janneke <at> gnu.org> writes:
>
>> Hi!
>>
>> This patch disables 27 additional tests for the Hurd, and enabled me to
>> build (a copy of) python-minimal natively
>>
>> --8<---------------cut here---------------start------------->8---
>> /gnu/store/9xm1idqyvyyz6xcqaa20aw2p8ap9zxcj-python-hurd-minimal-3.8.2
>> --8<---------------cut here---------------end--------------->8---
>
> Yaay!  I thought it would be much worse...

:-)

Oops, I missed your reply (thanks for sending!) and found it just now as
I was about to push another version of this using a blanket

    #:tests? (not (hurd-target?))

However, your ack+remark inspire me to leave the patch as is.  Let's
just keep this in mind whenever this starts causing troubles.

>> One last thing: pushing this patch rebuilds world for the Hurd; probably
>> not the best timing to push today?  Ideas?
>
> It has been a few days, so I guess you can go ahead and push.  Hopefully
> the build farm catches up quickly for those who haven't gotten around to
> try the new Hurd VM yet (like me!).

Thanks!  Pushed to master as e6320ba20404d4a6d81e42f96c3792b7122871b0.

Janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.