GNU bug report logs - #43863
[PATCH] grep: remove unusable code

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43863 in the body.
You can then email your comments to 43863 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: <bug-grep <at> gnu.org>
Subject: [PATCH] grep: remove unusable code
Date: Thu, 08 Oct 2020 18:55:50 +0900

[Message part 1 (text/plain, inline)]

Codes described in attached patch in this mail is dead.

These codes make sense when a maltibyte character is returned in case
conversion for single byte character, but I believe that their cases are
removed in commit 016e590a8198009bce0e1078f6d4c7e037e2df3c.

[0001-grep-remove-unusable-code.patch (text/plain, attachment)]

Message #8 received at 43863 <at> debbugs.gnu.org (full text, mbox):

From: Shlomi Fish <shlomif <at> shlomifish.org>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 43863 <at> debbugs.gnu.org
Subject: Re: bug#43863: [PATCH] grep: remove unusable code
Date: Fri, 9 Oct 2020 12:53:47 +0300

Hi Norihiro Tanaka!

On Thu, 08 Oct 2020 18:55:50 +0900
Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:

> Codes described in attached patch in this mail is dead.
> 
> These codes make sense when a maltibyte character is returned in case
> conversion for single byte character, but I believe that their cases are
> removed in commit 016e590a8198009bce0e1078f6d4c7e037e2df3c.

Do you mean the code is "unusable" (= "cannot be used";
https://en.wiktionary.org/wiki/unusable ) or is it "unused" (= "not being
used": https://en.wiktionary.org/wiki/unused )?

-- 

Shlomi Fish       https://www.shlomifish.org/
Beginners Site for the Vim text editor - https://vim.begin-site.org/

Chuck Norris is the reason why OpenBSD is called OpenBSD. They wanted to
call it LockedDownBSD but couldn't find a way to keep Chuck Norris out!
(By Andrew Brehm) — https://www.shlomifish.org/humour/bits/facts/Chuck-Norris/

Please reply to list if it's a mailing list post - https://shlom.in/reply .

Message #11 received at 43863 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Shlomi Fish <shlomif <at> shlomifish.org>
Cc: 43863 <at> debbugs.gnu.org
Subject: Re: bug#43863: [PATCH] grep: remove unusable code
Date: Sat, 10 Oct 2020 16:02:53 +0900

[Message part 1 (text/plain, inline)]

On Fri, 9 Oct 2020 12:53:47 +0300
Shlomi Fish <shlomif <at> shlomifish.org> wrote:

> Hi Norihiro Tanaka!
> 
> On Thu, 08 Oct 2020 18:55:50 +0900
> Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:

Thanks, not 'unusable' but 'unused' is right.

[0001-grep-remove-unused-code.patch (text/plain, attachment)]

Message #14 received at 43863 <at> debbugs.gnu.org (full text, mbox):

From: Shlomi Fish <shlomif <at> shlomifish.org>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 43863 <at> debbugs.gnu.org
Subject: Re: bug#43863: [PATCH] grep: remove unusable code
Date: Sat, 10 Oct 2020 11:45:48 +0300

Hi!

On Sat, 10 Oct 2020 16:02:53 +0900
Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:

> On Fri, 9 Oct 2020 12:53:47 +0300
> Shlomi Fish <shlomif <at> shlomifish.org> wrote:
> 
> > Hi Norihiro Tanaka!
> > 
> > On Thu, 08 Oct 2020 18:55:50 +0900
> > Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:  
> 
> Thanks, not 'unusable' but 'unused' is right.

Thanks for correcting it. GNU grep's git master passes all tests here (mageia
linux x86-64 v8) with or without your patch applied, and seems to run fine
after "make install" with it applied.

-- 

Shlomi Fish       https://www.shlomifish.org/
https://shlomifishswiki.branchable.com/Encourage_criticism_and_try_to_get_offended/

Bill Gates, CEO of Microsoft decides to use Richard Stallman’s Emacs as the
basis of his company’s state‐of‐the‐art product Microsoft Editing Macros™
Enterprise Edition XP .NET Professional.

Please reply to list if it's a mailing list post - https://shlom.in/reply .

Message #19 received at 43863-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, Shlomi Fish <shlomif <at> shlomifish.org>
Cc: 43863-done <at> debbugs.gnu.org
Subject: Re: bug#43863: [PATCH] grep: remove unusable code
Date: Sun, 11 Oct 2020 09:56:36 -0700

[Message part 1 (text/plain, inline)]

Thanks for the patch. I installed it, and also installed the attached minor 
cleanups of related code that I discovered while reviewing it.

[0001-grep-minor-kwset-cleanups.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.