GNU bug report logs - #43925
28.0.50; fido-mode can't find-file further back than ~/

Previous Next

Package: emacs;

Reported by: Rasmus <rasmus <at> gmx.us>

Date: Sun, 11 Oct 2020 15:31:01 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43925 in the body.
You can then email your comments to 43925 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#43925; Package emacs. (Sun, 11 Oct 2020 15:31:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Rasmus <rasmus <at> gmx.us>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 11 Oct 2020 15:31:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rasmus <rasmus <at> gmx.us>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; fido-mode can't find-file further back than ~/
Date: Sun, 11 Oct 2020 17:30:21 +0200
[Message part 1 (text/plain, inline)]
Hi,

I am trying to replace ido with fido.

One heuristic that I miss from ido is the ability to easily get to 
root via find(ing)-file.

In particular, from emacs -q, I might do something like this

   (let ((default-directory "~/")) 
     (fido-mode) (call-interactively 'find-file) ;; click 
     <backspace><backspace> to get to root )

Being an ido-user, I would expect to be able to go to /home/ by 
clicking backspace and then to root.  But I doesn’t work with 
fido.

I don’t know if I have missed some obvious configuration-step 
here?  I looked through the customization groups of both icomplete 
and minibuffer.

The attached patch expand the file-name if it is “~/”.

I am not really familiar with this part of Emacs so I am not sure 
it’s the right way to go about it.  In particular, I am really not 
sure whether the internal functions (e.g. ‘icomplete--field-beg’) 
are used correctly.


Aside: Another annoyance with fido is that $HOME isn’t being 
abbreviated
to “~” when browsing from root.  E.g.

   (let ((default-directory "/home/")) 
     (fido-mode) (call-interactively 'find-file) ;; now select 
     your username ) 

I would like “/home/$USER” to be abbreviated to “~” (like ido) to 
conserve space.

Any ideas as to where such a change migh be injected to fido?  I 
didn’t see an obvious place.

Thanks in advance,
Rasmus

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 
3.24.23, cairo version 1.17.3) 
of 2020-10-06 built on X260 
Repository revision: d36cfa21b6b695862dae772a94c63ce3aca8467e 
Repository branch: makepkg Windowing system distributor 'The X.Org 
Foundation', version 11.0.12009000 System Description: Arch Linux 

-- 
Tack, ni svenska vakttorn. Med plutonium tvingar vi dansken på 
knä!
[0001-lisp-icomplete.el-icomplete-fido-backward-updir-Expa.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#43925; Package emacs. (Fri, 11 Jun 2021 23:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 43925 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Rasmus <rasmus <at> gmx.us>
Cc: 43925 <at> debbugs.gnu.org
Subject: Re: bug#43925: 28.0.50; fido-mode can't find-file further back than ~/
Date: Sat, 12 Jun 2021 00:07:10 +0100
Rasmus <rasmus <at> gmx.us> writes:

> Hi,
>
> I am trying to replace ido with fido.
>
> One heuristic that I miss from ido is the ability to easily get to
> root via find(ing)-file.
>
> In particular, from emacs -q, I might do something like this
>
>    (let ((default-directory "~/"))       (fido-mode)
>    (call-interactively 'find-file) ;; click
>    <backspace><backspace> to get to root )
>
> Being an ido-user, I would expect to be able to go to /home/ by
> clicking backspace and then to root.  But I doesn’t work with fido.
>
> I don’t know if I have missed some obvious configuration-step here?  I
> looked through the customization groups of both icomplete and
> minibuffer.
>
> The attached patch expand the file-name if it is “~/”.
>
> I am not really familiar with this part of Emacs so I am not sure it’s
> the right way to go about it.  In particular, I am really not sure
> whether the internal functions (e.g. ‘icomplete--field-beg’) are used
> correctly.
>
>
> Aside: Another annoyance with fido is that $HOME isn’t being
> abbreviated
> to “~” when browsing from root.  E.g.
>
>    (let ((default-directory "/home/"))       (fido-mode)
>    (call-interactively 'find-file) ;; now select       your username )
>    I would like “/home/$USER” to be abbreviated to “~” (like ido) to
>    conserve space.
>
> Any ideas as to where such a change migh be injected to fido?  I
> didn’t see an obvious place.
>
> Thanks in advance,
> Rasmus

Thanks for the report and sorry for the long delay.  Indeed it would be
nice to have this in fido.  I remember this behaviour in ido, too.  I've
tried your patch and I don't have anything against it, so feel free to
push it if you want.  The second idea is also welcome, but I don't know
where to put it either.  Maybe in a fido-specific post-command hook that
adds the string "~/" to the input.  Then the current "rfn-shadow"
behaviour in icomplete.el would do the rest.

João





Added tag(s) patch. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Mon, 11 Oct 2021 12:54:04 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#43925; Package emacs. (Fri, 12 Nov 2021 08:04:01 GMT) Full text and rfc822 format available.

Message #13 received at 43925 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: 43925 <at> debbugs.gnu.org, Rasmus <rasmus <at> gmx.us>
Subject: Re: bug#43925: 28.0.50; fido-mode can't find-file further back than ~/
Date: Fri, 12 Nov 2021 09:03:14 +0100
João Távora <joaotavora <at> gmail.com> writes:

> Thanks for the report and sorry for the long delay.  Indeed it would be
> nice to have this in fido.  I remember this behaviour in ido, too.  I've
> tried your patch and I don't have anything against it, so feel free to
> push it if you want.

Since João approved the patch, I've pushed it to Emacs 29 now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 43925 <at> debbugs.gnu.org and Rasmus <rasmus <at> gmx.us> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 12 Nov 2021 08:04:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#43925; Package emacs. (Sat, 13 Nov 2021 11:09:01 GMT) Full text and rfc822 format available.

Message #18 received at 43925 <at> debbugs.gnu.org (full text, mbox):

From: Rasmus <rasmus <at> gmx.us>
To: larsi <at> gnus.org
Cc: 43925 <at> debbugs.gnu.org, joaotavora <at> gmail.com
Subject: Re: fido-mode can't find-file further back than ~/
Date: Sat, 13 Nov 2021 12:08:43 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> João Távora <joaotavora <at> gmail.com> writes:
>
>> Thanks for the report and sorry for the long delay.  Indeed it would be
>> nice to have this in fido.  I remember this behaviour in ido, too.  I've
>> tried your patch and I don't have anything against it, so feel free to
>> push it if you want.
>
> Since João approved the patch, I've pushed it to Emacs 29 now.

Thanks, Lars, I don’t seem to have push access to savannah any more; maybe
due to inactivity...

Forgot to reply to the João’s email after I discovered I didn’t have push access.

Rasmus 

-- 
Enough with the blah blah!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 11 Dec 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 109 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.