GNU bug report logs - #43929
gnu: Add pijul.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43929 in the body.
You can then email your comments to 43929 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: gnu: Add pijul.
Date: Sun, 11 Oct 2020 09:58:15 -0700

[Message part 1 (text/plain, inline)]

Hi Guix,

I've had these patches for a while and debated whether they should be
merged. Pijul works but 2.0 is reportedly being worked on. I haven't
seen much news on version 2 so I think 1.0 should be made available to
try.

Kindly,

John

[0001-gnu-Add-rust-termios-0.2.patch (text/x-patch, attachment)]

[0002-Add-lld-to-rust-inputs.patch (text/x-patch, attachment)]

[0002-gnu-Add-rust-rust-base58-0.0.patch (text/x-patch, attachment)]

[0003-gnu-Add-rust-base58-0.1.patch (text/x-patch, attachment)]

[0004-gnu-Add-rust-bs58-0.2.patch (text/x-patch, attachment)]

[0005-gnu-Add-rust-cryptovec-0.4.patch (text/x-patch, attachment)]

[0006-gnu-Add-rust-getch-0.2.patch (text/x-patch, attachment)]

[0007-gnu-Add-rust-diffs-0.3.patch (text/x-patch, attachment)]

[0008-gnu-Add-rust-sanakirja-0.10.patch (text/x-patch, attachment)]

[0009-gnu-Add-rust-buffered-reader-0.9.patch (text/x-patch, attachment)]

[0010-gnu-Add-rust-sequoia-rfc2822-0.9.patch (text/x-patch, attachment)]

[0011-gnu-rust-nettle-sys-2-do-not-skip-build.patch (text/x-patch, attachment)]

[0012-gnu-Add-rust-nettle-5.patch (text/x-patch, attachment)]

[0013-gnu-Add-rust-sequoia-openpgp-0.9.patch (text/x-patch, attachment)]

[0014-gnu-Add-rust-libpijul-0.12.patch (text/x-patch, attachment)]

[0015-gnu-Add-rust-line-0.1.patch (text/x-patch, attachment)]

[0016-gnu-Add-rust-pathdiff-0.1.patch (text/x-patch, attachment)]

[0017-gnu-Add-rust-progrs-0.1.patch (text/x-patch, attachment)]

[0018-gnu-Add-rust-rpassword-2.1.0.patch (text/x-patch, attachment)]

[0019-gnu-Add-rust-cookie-0.12.patch (text/x-patch, attachment)]

[0020-gnu-Add-rust-publicsuffix-1.5.patch (text/x-patch, attachment)]

[0021-gnu-Add-rust-cookie-store-0.7.patch (text/x-patch, attachment)]

[0022-gnu-Add-rust-hyper-old-types-0.11.patch (text/x-patch, attachment)]

[0023-gnu-Add-rust-ct-logs-0.6.patch (text/x-patch, attachment)]

[0024-gnu-Add-rust-hyper-rustls-0.18.patch (text/x-patch, attachment)]

[0025-gnu-Add-rust-mime-guess-2.0.patch (text/x-patch, attachment)]

[0026-gnu-Add-rust-serde-urlencoded-0.5.patch (text/x-patch, attachment)]

[0027-gnu-Add-rust-socks-0.3.patch (text/x-patch, attachment)]

[0028-gnu-Add-rust-ipconfig-0.2.patch (text/x-patch, attachment)]

[0029-gnu-Add-rust-enum-as-inner-0.3.patch (text/x-patch, attachment)]

[0030-gnu-Add-rust-typed-headers-0.1.patch (text/x-patch, attachment)]

[0031-gnu-Add-rust-trust-dns-proto-0.8.patch (text/x-patch, attachment)]

[0032-gnu-Add-rust-trust-dns-rustls-0.7.patch (text/x-patch, attachment)]

[0033-gnu-Add-rust-trust-dns-https-0.4.patch (text/x-patch, attachment)]

[0034-gnu-Add-rust-tokio-openssl-0.4.patch (text/x-patch, attachment)]

[0035-gnu-Add-rust-trust-dns-openssl-0.7.patch (text/x-patch, attachment)]

[0036-gnu-Add-rust-tracing-log-0.1.patch (text/x-patch, attachment)]

[0037-gnu-Add-rust-matchers-0.0.patch (text/x-patch, attachment)]

[0038-gnu-Add-rust-tracing-subscriber-0.1.patch (text/x-patch, attachment)]

[0039-gnu-Add-rust-tracing-fmt-0.1.patch (text/x-patch, attachment)]

[0040-gnu-Add-rust-tracing-attributes-0.1.patch (text/x-patch, attachment)]

[0041-gnu-Add-rust-tracing-0.1.patch (text/x-patch, attachment)]

[0042-gnu-Add-rust-tokio-net-0.2.patch (text/x-patch, attachment)]

[0043-gnu-Add-rust-tokio-tls-0.3.patch (text/x-patch, attachment)]

[0044-gnu-Add-rust-trust-dns-native-tls-0.7.patch (text/x-patch, attachment)]

[0045-gnu-Add-rust-trust-dns-resolver-0.12.patch (text/x-patch, attachment)]

[0046-gnu-Add-rust-take-mut-0.2.patch (text/x-patch, attachment)]

[0047-gnu-Add-rust-libflate-0.1.patch (text/x-patch, attachment)]

[0048-gnu-Add-rust-reqwest-0.9.patch (text/x-patch, attachment)]

[0049-gnu-Add-rust-shell-escape-0.1.patch (text/x-patch, attachment)]

[0050-gnu-Add-rust-thrussh-libsodium-0.1.patch (text/x-patch, attachment)]

[0051-gnu-Add-rust-yasna-0.1.patch (text/x-patch, attachment)]

[0052-gnu-Add-rust-thrussh-keys-0.11.patch (text/x-patch, attachment)]

[0053-gnu-Add-rust-thrussh-0.21.patch (text/x-patch, attachment)]

[0054-gnu-Add-rust-thrussh-config-0.2.patch (text/x-patch, attachment)]

[0055-gnu-Add-rust-advapi32-sys-0.2.patch (text/x-patch, attachment)]

[0056-gnu-Add-rust-username-0.2.patch (text/x-patch, attachment)]

[0057-gnu-Add-pijul.patch (text/x-patch, attachment)]

Message #8 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: John Soo <jsoo1 <at> asu.edu>,43929 <at> debbugs.gnu.org
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Sun, 11 Oct 2020 13:40:27 -0400

[Message part 1 (text/plain, inline)]

Oh that is great! I've been wanting to try pijul out since more than a year but never found the time to package it. Thanks!

I'm not sure I know rust enough to review this, and I'm a bit busy. If nobody else has started a review by next saturday, please ping me again!

Le 11 octobre 2020 12:58:15 GMT-04:00, John Soo <jsoo1 <at> asu.edu> a écrit :
>Hi Guix,
>
>I've had these patches for a while and debated whether they should be
>merged. Pijul works but 2.0 is reportedly being worked on. I haven't
>seen much news on version 2 so I think 1.0 should be made available to
>try.
>
>Kindly,
>
>John

[Message part 2 (text/html, inline)]

Message #11 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 43929 <at> debbugs.gnu.org, John Soo <jsoo1 <at> asu.edu>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Wed, 28 Oct 2020 15:57:29 +0100

Hi Julien,

Julien Lepiller <julien <at> lepiller.eu> skribis:

> Oh that is great! I've been wanting to try pijul out since more than a
> year but never found the time to package it. Thanks!
>
> I'm not sure I know rust enough to review this, and I'm a bit busy. If
> nobody else has started a review by next saturday, please ping me
> again!

Are you taking a look?  If not, let’s call for help from the Rust-savvy
people among us.  :-)

Thanks,
Ludo’.

Message #14 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 43929 <43929 <at> debbugs.gnu.org>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Wed, 28 Oct 2020 08:13:29 -0700

[Message part 1 (text/plain, inline)]

     Hey everyone, 

 
Quick update.
 

 
I have been busy rebasing these patches.    I may have a new set this week.
 

 
Also pijul 2 is coming very soon. Should I wait to submit that instead?
 

 
- John
     

[Message part 2 (text/html, inline)]

Message #17 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: John Soo <jsoo1 <at> asu.edu>, Ludovic Courtès <ludo <at> gnu.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 43929 <43929 <at> debbugs.gnu.org>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Wed, 28 Oct 2020 16:42:07 +0100

Hi,

On Wed, 28 Oct 2020 at 08:13, John Soo <jsoo1 <at> asu.edu> wrote:
  
> I have been busy rebasing these patches.  I may have a new set this
> week

It could be cool if it could be included in the v1.2. :-)


> Also pijul 2 is coming very soon. Should I wait to submit that
> instead? 

From my point of view, because of the “time-machine”, it is nice to
include any version – especially when it is already done. :-)


Cheers,
simon

Message #20 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: zimoun <zimon.toutoune <at> gmail.com>, John Soo <jsoo1 <at> asu.edu>,
 Ludovic Courtès <ludo <at> gnu.org>
Cc: 43929 <43929 <at> debbugs.gnu.org>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Wed, 28 Oct 2020 13:37:31 -0400

Le 28 octobre 2020 11:42:07 GMT-04:00, zimoun <zimon.toutoune <at> gmail.com> a écrit :
>Hi,
>
>On Wed, 28 Oct 2020 at 08:13, John Soo <jsoo1 <at> asu.edu> wrote:
>  
>> I have been busy rebasing these patches.  I may have a new set this
>> week
>
>It could be cool if it could be included in the v1.2. :-)
>
>
>> Also pijul 2 is coming very soon. Should I wait to submit that
>> instead? 
>
>From my point of view, because of the “time-machine”, it is nice to
>include any version – especially when it is already done. :-)

Yeah I agree, you don't have to wait, since you already have everything available :)

Sorry I didn't do a review, I ended up being busy with work and other things.

>
>
>Cheers,
>simon

Message #23 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 43929 <43929 <at> debbugs.gnu.org>, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Sat, 31 Oct 2020 11:15:19 -0700

[Message part 1 (text/plain, inline)]

Hi everyone,

Julien Lepiller <julien <at> lepiller.eu> writes:

> Le 28 octobre 2020 11:42:07 GMT-04:00, zimoun
>>From my point of view, because of the “time-machine”, it is nice to
>>include any version – especially when it is already done. :-)
>
> Yeah I agree, you don't have to wait, since you already have
> everything available :)

I agree.

Attached the updated patches. I rebased them this morning.

However, during the rebase, I found some that do not build.

I marked these with [WIP]. I believe this to be something amiss with the
rust-openssl-sys <at> 0.9 dependency.

Thanks!

- John

[0001-gnu-Add-rust-rust-base58-0.0.patch (text/x-patch, attachment)]

[0002-gnu-Add-rust-base58-0.1.patch (text/x-patch, attachment)]

[0003-gnu-Add-rust-bs58-0.2.patch (text/x-patch, attachment)]

[0004-gnu-Add-rust-cryptovec-0.4.patch (text/x-patch, attachment)]

[0005-gnu-Add-rust-getch-0.2.patch (text/x-patch, attachment)]

[0006-gnu-Add-rust-diffs-0.3.patch (text/x-patch, attachment)]

[0007-gnu-Add-rust-sanakirja-0.10.patch (text/x-patch, attachment)]

[0008-gnu-Add-rust-buffered-reader-0.9.patch (text/x-patch, attachment)]

[0009-gnu-Add-rust-sequoia-rfc2822-0.9.patch (text/x-patch, attachment)]

[0010-gnu-rust-nettle-sys-2-do-not-skip-build.patch (text/x-patch, attachment)]

[0011-gnu-Add-rust-nettle-5.patch (text/x-patch, attachment)]

[0012-gnu-Add-rust-sequoia-openpgp-0.9.patch (text/x-patch, attachment)]

[0013-gnu-Add-rust-libpijul-0.12.patch (text/x-patch, attachment)]

[0014-gnu-Add-rust-line-0.1.patch (text/x-patch, attachment)]

[0015-gnu-Add-rust-pathdiff-0.1.patch (text/x-patch, attachment)]

[0016-gnu-Add-rust-progrs-0.1.patch (text/x-patch, attachment)]

[0017-gnu-Add-rust-rpassword-2.1.0.patch (text/x-patch, attachment)]

[0018-gnu-Add-rust-cookie-0.12.patch (text/x-patch, attachment)]

[0019-gnu-Add-rust-cookie-store-0.7.patch (text/x-patch, attachment)]

[0020-gnu-Add-rust-hyper-old-types-0.11.patch (text/x-patch, attachment)]

[0021-gnu-Add-rust-socks-0.3.patch (text/x-patch, attachment)]

[0022-gnu-Add-rust-trust-dns-rustls-0.6.patch (text/x-patch, attachment)]

[0023-gnu-Add-rust-tracing-log-0.1.patch (text/x-patch, attachment)]

[0024-gnu-Add-rust-matchers-0.0.patch (text/x-patch, attachment)]

[0025-gnu-Add-rust-tracing-subscriber-0.1.patch (text/x-patch, attachment)]

[0026-gnu-Add-rust-tracing-fmt-0.1.patch (text/x-patch, attachment)]

[0027-gnu-Add-rust-tokio-net-0.2.patch (text/x-patch, attachment)]

[0028-gnu-Add-rust-trust-dns-resolver-0.11.patch (text/x-patch, attachment)]

[0029-gnu-Add-rust-shell-escape-0.1.patch (text/x-patch, attachment)]

[0030-gnu-Add-rust-thrussh-libsodium-0.1.patch (text/x-patch, attachment)]

[0031-gnu-Add-rust-yasna-0.1.patch (text/x-patch, attachment)]

[0032-gnu-Add-rust-thrussh-keys-0.11.patch (text/x-patch, attachment)]

[0033-gnu-Add-rust-thrussh-0.21.patch (text/x-patch, attachment)]

[0034-gnu-Add-rust-thrussh-config-0.2.patch (text/x-patch, attachment)]

[0035-gnu-Add-rust-advapi32-sys-0.2.patch (text/x-patch, attachment)]

[0036-gnu-Add-rust-username-0.2.patch (text/x-patch, attachment)]

[0037-gnu-Add-rust-ct-logs-0.6.patch (text/x-patch, attachment)]

[0038-gnu-Add-rust-tokio-rustls-0.10.patch (text/x-patch, attachment)]

[0039-gnu-Add-rust-hyper-rustls-0.17.patch (text/x-patch, attachment)]

[0040-gnu-Add-rust-serde-urlencoded-0.5.patch (text/x-patch, attachment)]

[0041-gnu-Add-rust-openssl-0.9.patch (text/x-patch, attachment)]

[0042-gnu-Add-rust-core-foundation-sys-0.2.patch (text/x-patch, attachment)]

[0043-WIP-gnu-Add-rust-core-foundation-0.2.patch (text/x-patch, attachment)]

[0044-gnu-Add-rust-security-framework-sys-0.1.patch (text/x-patch, attachment)]

[0045-gnu-Add-rust-security-framework-0.1.patch (text/x-patch, attachment)]

[0046-WIP-gnu-Add-rust-native-tls-0.1.patch (text/x-patch, attachment)]

[0047-gnu-Add-rust-slab-0.3.patch (text/x-patch, attachment)]

[0048-gnu-Add-rust-smallvec-0.2.patch (text/x-patch, attachment)]

[0049-gnu-Add-rust-take-0.1.patch (text/x-patch, attachment)]

[0050-gnu-Add-rust-lazycell-0.4.patch (text/x-patch, attachment)]

[0051-gnu-Add-rust-tokio-service-0.1.patch (text/x-patch, attachment)]

[0052-gnu-Add-rust-tokio-proto-0.1.patch (text/x-patch, attachment)]

[0053-gnu-Add-rust-pretty-env-logger-0.2.patch (text/x-patch, attachment)]

[0054-gnu-Add-rust-spmc-0.2.patch (text/x-patch, attachment)]

[0055-gnu-Add-rust-relay-0.1.patch (text/x-patch, attachment)]

[0056-gnu-Add-rust-try-lock-0.1.patch (text/x-patch, attachment)]

[0057-gnu-Add-rust-want-0.0.patch (text/x-patch, attachment)]

[0058-gnu-Add-rust-hyper-0.11.patch (text/x-patch, attachment)]

[0059-WIP-gnu-Add-rust-tokio-tls-0.1.patch (text/x-patch, attachment)]

[0060-gnu-Add-rust-typed-headers-0.1.patch (text/x-patch, attachment)]

[0061-gnu-Add-rust-enum-as-inner-0.2.patch (text/x-patch, attachment)]

[0062-gnu-Update-rust-tokio-executor-0.1-to-0.1.8.patch (text/x-patch, attachment)]

[0063-gnu-Update-rust-tokio-0.1-to-0.1.22.patch (text/x-patch, attachment)]

[0064-gnu-Add-rust-trust-dns-proto-0.7.patch (text/x-patch, attachment)]

[0065-gnu-Add-rust-trust-dns-https-0.3.patch (text/x-patch, attachment)]

[0066-gnu-Add-rust-tokio-tls-0.2.patch (text/x-patch, attachment)]

[0067-gnu-Add-rust-trust-dns-native-tls-0.6.patch (text/x-patch, attachment)]

[0068-gnu-Add-rust-tokio-openssl-0.3.patch (text/x-patch, attachment)]

[0069-gnu-Add-rust-trust-dns-openssl-0.6.patch (text/x-patch, attachment)]

[0070-gnu-Put-rust-trust-dns-rustls-0.19-in-alphabetical-o.patch (text/x-patch, attachment)]

[0071-gnu-Add-rust-ring-0.14.patch (text/x-patch, attachment)]

[0072-gnu-Add-rust-sct-0.5.patch (text/x-patch, attachment)]

[0073-gnu-Add-rust-webpki-roots-0.16.patch (text/x-patch, attachment)]

[0074-gnu-Add-rust-webpki-0.19.patch (text/x-patch, attachment)]

[0075-gnu-Add-rust-rustls-0.15.patch (text/x-patch, attachment)]

[0076-gnu-Add-rust-tokio-rustls-0.9.patch (text/x-patch, attachment)]

[0077-gnu-Add-rust-reqwest-0.9.patch (text/x-patch, attachment)]

[0078-gnu-Remove-punctuation-in-rust-rustls-0.18-synopsis.patch (text/x-patch, attachment)]

[0079-gnu-Fix-rust-trust-dns-openssl-0.19-home-page.patch (text/x-patch, attachment)]

[0080-gnu-Fix-rust-tokio-openssl-0.4-home-page.patch (text/x-patch, attachment)]

[0081-gnu-Fix-rust-trust-dns-native-tls-0.19-synopsis-and-.patch (text/x-patch, attachment)]

[0082-gnu-Fix-rust-trust-dns-https-0.19-home-page.patch (text/x-patch, attachment)]

[0083-gnu-Fix-rust-hyper-0.13-synopsis-punctuation.patch (text/x-patch, attachment)]

[0084-gnu-Fix-rust-security-framework-1-home-page.patch (text/x-patch, attachment)]

[0085-gnu-Add-detail-to-rust-serde-urlencoded-0.6-descript.patch (text/x-patch, attachment)]

[0086-gnu-Fix-rust-trust-dns-resolver-0.19-home-page.patch (text/x-patch, attachment)]

[0087-gnu-Fix-rust-trust-dns-rustls-0.19-home-page.patch (text/x-patch, attachment)]

[0088-gnu-Capitalize-synopsis-of-rust-trust-dns-openssl-0..patch (text/x-patch, attachment)]

[0089-gnu-Add-pijul.patch (text/x-patch, attachment)]

Message #26 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 43929 <43929 <at> debbugs.gnu.org>, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Sat, 31 Oct 2020 11:31:04 -0700

[Message part 1 (text/plain, inline)]

Hello guix,

Here are the patches with [WIP] that "build" but with #:skip-build #t
and [WIP] removed.

- John

[0001-gnu-Add-rust-core-foundation-0.2.patch (text/x-patch, attachment)]

[0001-gnu-Add-rust-native-tls-0.1.patch (text/x-patch, attachment)]

[0001-gnu-Add-rust-tokio-tls-0.1.patch (text/x-patch, attachment)]

Message #29 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 43929 <43929 <at> debbugs.gnu.org>, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Thu, 05 Nov 2020 08:16:01 -0800

[Message part 1 (text/plain, inline)]

Hello again,

I just added more detail to pijul's description which was previously
lacking a lot.

- John

[0001-gnu-Add-pijul.patch (text/x-patch, attachment)]

Message #32 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: John Soo <jsoo1 <at> asu.edu>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 43929 <43929 <at> debbugs.gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Sun, 22 Nov 2020 18:34:05 +0200

[Message part 1 (text/plain, inline)]

I made it as far as rust-trust-dns-resolver-0.11, but then I had to stop
because there were a couple of cargo-inputs which weren't packaged.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 43929 <43929 <at> debbugs.gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Sun, 22 Nov 2020 08:45:44 -0800

Efraim Flashner <efraim <at> flashner.co.il> writes:

> I made it as far as rust-trust-dns-resolver-0.11, but then I had to stop
> because there were a couple of cargo-inputs which weren't packaged.

I am so sorry! That was my mistake. The second patchset should apply and
build ok.

Message #38 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 43929 <43929 <at> debbugs.gnu.org>, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Wed, 25 Nov 2020 07:43:18 -0800

Hello,

I saw some of the patches were applied. Is there more work I should do
to improve them? Seems like some were incomplete in some way or other.

Thanks again,

John

Message #41 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 43929 <43929 <at> debbugs.gnu.org>, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: bug#43929: gnu: Add pijul.
Date: Mon, 15 Feb 2021 14:18:42 -0800

[Message part 1 (text/plain, inline)]

Hello again,

I rebased these patches on master. Pijul definitely works.

Thanks!

John

[0001-gnu-Add-rust-trust-dns-rustls-0.7.patch (text/x-patch, attachment)]

[0002-gnu-Add-rust-yasna-0.1.patch (text/x-patch, attachment)]

[0003-gnu-Add-rust-thrussh-keys-0.11.patch (text/x-patch, attachment)]

[0004-gnu-Add-rust-thrussh-0.21.patch (text/x-patch, attachment)]

[0005-gnu-Add-rust-thrussh-config-0.2.patch (text/x-patch, attachment)]

[0006-gnu-Add-rust-advapi32-sys-0.2.patch (text/x-patch, attachment)]

[0007-gnu-Add-rust-username-0.2.patch (text/x-patch, attachment)]

[0008-gnu-Add-rust-lazycell-0.4.patch (text/x-patch, attachment)]

[0009-gnu-Add-rust-pretty-env-logger-0.2.patch (text/x-patch, attachment)]

[0010-gnu-Add-rust-spmc-0.2.patch (text/x-patch, attachment)]

[0011-gnu-Add-rust-tokio-tls-0.1.patch (text/x-patch, attachment)]

[0012-gnu-Update-rust-tokio-executor-0.1-to-0.1.8.patch (text/x-patch, attachment)]

[0013-gnu-Fix-rust-tokio-0.1-dependencies.patch (text/x-patch, attachment)]

[0014-gnu-Add-pijul.patch (text/x-patch, attachment)]

Message #44 received at 43929 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 43929 <43929 <at> debbugs.gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Tue, 16 Feb 2021 10:31:41 +0100

Hello,

John Soo <jsoo1 <at> asu.edu> writes:

Thank you. I'm adding my grain of salt, if you don't mind!

> +(define-public rust-trust-dns-rustls-0.6
> +  (package
> +    (inherit rust-trust-dns-rustls-0.7)
> +    (name "rust-trust-dns-rustls")

AFAICT, rust-trust-dns-rustls-0.6 already inherits from 0.19, so it is
not strictly necessary to change this inheritance.

> +(define-public rust-yasna-0.1
> +  (package
> +    (name "rust-yasna")
> +    (version "0.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (crate-uri "yasna" version))
> +       (file-name
> +        (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1frcd79rzi6dlly7lldjn2avnhfmj6yxrjsgvb2p1k2zbxdzyc9s"))))
> +    (build-system cargo-build-system)
> +    (arguments
> +     `(#:cargo-inputs
> +       (("rust-bit-vec" ,rust-bit-vec-0.4)
> +        ("rust-chrono" ,rust-chrono-0.4)
> +        ("rust-num" ,rust-num-0.1)
> +        ("rust-num-bigint" ,rust-num-bigint-0.1))
> +       #:cargo-development-inputs
> +       (("rust-num-traits" ,rust-num-traits-0.2))))

This should have #:skip-build #t as any non-leaf package.

> +(define-public rust-thrussh-keys-0.11

[...]

> +        ("rust-thrussh-libsodium"
> +         ,rust-thrussh-libsodium-0.1)

Nitpick: indentation.

> +        ("rust-tokio" ,rust-tokio-0.1)
> +        ("rust-yasna" ,rust-yasna-0.1))
> +       #:cargo-development-inputs
> +       (("rust-env-logger" ,rust-env-logger-0.6)
> +        ("rust-tempdir" ,rust-tempdir-0.3)
> +        ("rust-tokio-uds" ,rust-tokio-uds-0.2))))

See above about #:skip-build?

> +    (home-page "https://pijul.org/thrussh")
> +    (synopsis
> +     "Deal with SSH keys in Rust")
> +    (description
> +     "This package provides a rust library to deal with SSH keys.

Nitpick: rust -> Rust

> +        ("rust-thrussh-libsodium"
> +         ,rust-thrussh-libsodium-0.1)

Indentation nitpick and #skip-build again :)

I will not repeat those in the rest of the message.

> +    (synopsis
> +     "Contains function definitions for the Windows API library advapi32")

s/Contains //

> +    (description
> +     "Contains function definitions for the Windows API library advapi32.
> +The winapi crate's types and constants has more details about this
> API.")

The description needs to be a complete sentence.

> +    (synopsis
> +     "Portably retrieve the username of the user running the current thread")

s/Portably //

> +    (description
> +     "Portably retrieve the user name (and possibly other information in
> +future versions) of the user running the current thread.")

Could you write it as a full sentence?

> +(define-public rust-spmc-0.2
> +  (package
> +    (inherit rust-spmc-0.3)
> +    (name "rust-spmc")
> +    (version "0.2.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (crate-uri "spmc" version))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "1nhbjc65avbb4nffk6b49spbv7rsmmnrppj2qnx39mhwi57spgiw"))))
> +    (arguments
> +     `(#:tests? #f ;; tests hang
> +       #:cargo-development-inputs
> +       (("rust-loom" ,rust-loom-0.2))))
> +    ;; This package is broken before 0.3
> +    ;; Only included for pijul <at> 1
> +    (properties `((hidden? . #t)))))

I suggest to not bother and use #:skip-build?

> +(define-public rust-tokio-tls-0.1
> +  (package
> +    (inherit rust-tokio-tls-0.3)
> +    (version "0.1.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (crate-uri "tokio-tls" version))
> +       (file-name
> +        (string-append
> +         (package-name rust-tokio-tls-0.3) "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "04yrdscn8m9qza8ms09pqipbmj6x2q64jgm5n3ipy4b0wl24nbvp"))))
> +    (arguments
> +     `(#:skip-build? #t
> +       #:cargo-inputs
> +       (("rust-futures" ,rust-futures-0.1)
> +        ("rust-native-tls" ,rust-native-tls-0.1)
> +        ("rust-tokio-core" ,rust-tokio-core-0.1)
> +        ("rust-tokio-io" ,rust-tokio-io-0.1)
> +        ("rust-tokio-proto" ,rust-tokio-proto-0.1))
> +       #:cargo-development-inputs
> +       (("rust-cfg-if" ,rust-cfg-if-0.1)
> +        ("rust-env-logger" ,rust-env-logger-0.4)
> +        ("rust-hyper" ,rust-hyper-0.11)
> +        ("rust-openssl" ,rust-openssl-0.9)
> +        ("rust-schannel" ,rust-schannel-0.1)
> +        ("rust-security-framework"
> +         ,rust-security-framework-0.1)
> +        ("rust-tokio-service" ,rust-tokio-service-0.1)
> +        ("rust-winapi" ,rust-winapi-0.3))))))

Since you use skip-build?, development inputs are not necessary.

> +(define-public pijul
> +  (package
> +    (name "pijul")
> +    (version "0.12.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (crate-uri "pijul" version))
> +       (file-name
> +        (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "12aqpfd2si70qbvfnn9kvznxyd5g5gsb1kk1q52wm077cd03yapr"))))
> +    (build-system cargo-build-system)
> +    (inputs
> +     `(("clang" ,clang)
> +       ("libressl" ,libressl)
> +       ("libsodium" ,libsodium)
> +       ("nettle" ,nettle)
> +       ("pkg-config" ,pkg-config)))

Shouldn't pgk-config and clang be native-inputs instead?

Regards,
-- 
Nicolas Goaziou

Message #51 received at 43929-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 43929-done <at> debbugs.gnu.org
Subject: Re: [bug#43929] gnu: Add pijul.
Date: Sun, 12 Jan 2025 08:12:28 +0200

[Message part 1 (text/plain, inline)]

We now have pijul packaged in Guix, so I'm going to close this bug.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.