GNU bug report logs - #43930
gnu: Add emacs-graphql-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43930 in the body.
You can then email your comments to 43930 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: gnu: Add emacs-graphql-mode.
Date: Sun, 11 Oct 2020 09:59:44 -0700

[Message part 1 (text/plain, inline)]

Hi Guix,

I've been writing some graphql recently and graphql-mode has been
invaluable.

Thanks!

John

[0001-gnu-Add-emacs-graphql-mode.patch (text/x-patch, attachment)]

Message #8 received at 43930 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 43930 <at> debbugs.gnu.org
Subject: Re: [bug#43930] gnu: Add emacs-graphql-mode.
Date: Tue, 13 Oct 2020 09:15:36 +0200

Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> I've been writing some graphql recently and graphql-mode has been
> invaluable.

Thank you. Some comments follow.

> +(define-public emacs-graphql-mode
> +  (let ((commit "9bed568ec86242dbe30bdbab324aa0eb2cd9bf08")

Could you add a comment explaining why you don't use a tagged commit
(in this case, there is none)?

> +        (revision "1"))
> +    (package
> +      (name "emacs-graphql-mode")
> +      (version commit)
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/davazp/graphql-mode")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "0x9y7qq6y0zg8ncamzvk68ccmdyzh7xsj0xs0ykyl20d5wdpplj4"))))

Nitpick: please move the string on the same line as `base32'.

> +      (build-system emacs-build-system)
> +      (home-page
> +       "https://github.com/davazp/graphql-mode")

Nitpick: please move the string on the same line as `home-page'.

> +      (synopsis "Emacs mode to edit GraphQL schema and queries")
> +      (description
> +       "This package provides an Emacs mode for editing graphql queries and
> +schemas.")

I suggest to expound the description a bit. For example, using
commentary section of the library, it could be something along the lines
of:

    This package implements a major mode to edit GraphQL schemas and
    query. The basic functionality includes syntax highlight and
    indentation. Additionally, it is able to send GraphQL queries to an
    end-point URL.

    Files with the @file{.graphql} and @file{.gql} extensions are
    automatically opened with this mode.


Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 43930 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 43930 <at> debbugs.gnu.org
Subject: Re: [bug#43930] gnu: Add emacs-graphql-mode.
Date: Mon, 19 Oct 2020 10:44:30 -0700

[Message part 1 (text/plain, inline)]

Hi Nicolas,

Thanks for the review.

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Could you add a comment explaining why you don't use a tagged commit
> (in this case, there is none)?

Done.

>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-graphql-mode")
>> +      (version commit)
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://github.com/davazp/graphql-mode")
>> +               (commit commit)))
>> +         (file-name (git-file-name name version))
>> +         (sha256
>> +          (base32
>> +           "0x9y7qq6y0zg8ncamzvk68ccmdyzh7xsj0xs0ykyl20d5wdpplj4"))))
>
> Nitpick: please move the string on the same line as `base32'.

Done.

>> +      (build-system emacs-build-system)
>> +      (home-page
>> +       "https://github.com/davazp/graphql-mode")
>
> Nitpick: please move the string on the same line as `home-page'.

Done.

>> +      (synopsis "Emacs mode to edit GraphQL schema and queries")
>> +      (description
>> +       "This package provides an Emacs mode for editing graphql queries and
>> +schemas.")
>
> I suggest to expound the description a bit. For example, using
> commentary section of the library, it could be something along the lines
> of:
>
>     This package implements a major mode to edit GraphQL schemas and
>     query. The basic functionality includes syntax highlight and
>     indentation. Additionally, it is able to send GraphQL queries to an
>     end-point URL.
>
>     Files with the @file{.graphql} and @file{.gql} extensions are
>     automatically opened with this mode.

Done. I missed the description in graphql-mode.el.

Thanks again,

John

[0001-gnu-Add-emacs-graphql-mode.patch (text/x-patch, attachment)]

Message #16 received at 43930-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 43930-done <at> debbugs.gnu.org
Subject: Re: [bug#43930] gnu: Add emacs-graphql-mode.
Date: Mon, 19 Oct 2020 22:45:05 +0200

Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> Subject: [PATCH] gnu: Add emacs-graphql-mode.
>
> * gnu/packages/emacs-xyz.scm (emacs-graphql-mode): New variable.

Applied. Thank you.

I sticked to the description I suggested because I thinks lists are not
warranted in this case.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.