GNU bug report logs - #43944
28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43944 in the body.
You can then email your comments to 43944 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0
Date: Mon, 12 Oct 2020 09:37:02 +0300

[Message part 1 (text/plain, inline)]

Commit c1b0515952 to Emacs 'master' on August 27 added two new themes.
Their version was 0.12.0.  A new version is now available, as well as a
texinfo file that documents all their customisation options.  Please see
the attached patch.

Now some administrative considerations:

+ The two themes are also available in GNU ELPA.  What is the best way
  to ensure that we sync between emacs.git and elpa.git?  GNU ELPA has
  hitherto pulled from dedicated branches on my upstream git repository.
  Maybe it would be better/easier to start building directly from the
  Emacs source?  This would reduce the overall workload.

+ Sending attachments with large diffs has the downside of losing the
  commit history.  Do Emacs maintainers wish to keep track of it?  If
  so, what would be the best way to preserve it, seeing as I am
  developing them on my own upstream?  For context, the Leuven theme,
  which is also developed externally, only gets updated in relatively
  large increments, such as in commits to Emacs 'master' 99f8a1c917,
  b5ccc1beb3, and 95e509140e.

+ Should the texinfo file be mentioned in the NEWS entry about the two
  themes?  The attached patch does not include such a change.

I am prepared to do whatever the maintainers consider necessary.  Thank
you for your time!

Best regards,
Protesilaos

-- 
Protesilaos Stavrou
protesilaos.com

[0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch (text/x-patch, attachment)]

Message #8 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>, 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Fri, 16 Oct 2020 03:50:26 -0700

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Commit c1b0515952 to Emacs 'master' on August 27 added two new themes.
> Their version was 0.12.0.  A new version is now available, as well as a
> texinfo file that documents all their customisation options.  Please see
> the attached patch.

Thanks.

The patch doesn't apply cleanly here, I guess due to some ^M characters
that sneaked in:

128 git … apply --3way --
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:25:
trailing whitespace.
\input texinfo    @c -*- texinfo -*-
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:26:
trailing whitespace.
@c %**start of header
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:27:
trailing whitespace.
@setfilename modus-themes.info
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:28:
trailing whitespace.
@settitle Modus themes for GNU Emacs
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:29:
trailing whitespace.
@documentencoding UTF-8
error: corrupt patch at line 2867

(This could be fixed using something like `tr -d '^M'`, I think.)

Message #11 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>, 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Fri, 16 Oct 2020 06:46:31 -0700

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> Commit c1b0515952 to Emacs 'master' on August 27 added two new themes.
>> Their version was 0.12.0.  A new version is now available, as well as a
>> texinfo file that documents all their customisation options.  Please see
>> the attached patch.
>
> Thanks.
>
> The patch doesn't apply cleanly here, I guess due to some ^M characters
> that sneaked in:

I fixed that, reviewed the changes and pushed your patch to master as
commit ad0643e580.

I also made the followup commit 6d4f57dbdf that adapts the new Info
manual to better fit Emacs conventions.  Please see the attached patch.

[0001-Fix-building-modus-themes-Info-manual.patch (text/x-diff, attachment)]

Message #14 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: info <at> protesilaos.com, 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50;
 Update modus-operandi, modus-vivendi themes to v0.13.0
Date: Fri, 16 Oct 2020 18:30:09 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Fri, 16 Oct 2020 06:46:31 -0700
> 
> I also made the followup commit 6d4f57dbdf that adapts the new Info
> manual to better fit Emacs conventions.  Please see the attached patch.

Please note that I made further changes to the manual, to adapt it to
our conventions and standards.

Message #17 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>, 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Fri, 16 Oct 2020 10:13:58 -0700

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> + The two themes are also available in GNU ELPA.  What is the best way
>   to ensure that we sync between emacs.git and elpa.git?  GNU ELPA has
>   hitherto pulled from dedicated branches on my upstream git repository.
>   Maybe it would be better/easier to start building directly from the
>   Emacs source?  This would reduce the overall workload.

What does "start building directly from the Emacs source" mean here?

FWIW, I don't think we should feel too bound to any particular process;
this seems like a practical matter where we should try to do whatever
is most practical.

> + Sending attachments with large diffs has the downside of losing the
>   commit history.  Do Emacs maintainers wish to keep track of it?  If
>   so, what would be the best way to preserve it, seeing as I am
>   developing them on my own upstream?

I don't think we generally worry about preserving history for packages
managed externally.  We just sync the latest version.

(If one really would like to preserve it, it could perhaps be done with
some git magic.  I'm not sure it's worth the extra effort.)

> + Should the texinfo file be mentioned in the NEWS entry about the two
>   themes?  The attached patch does not include such a change.

We could of course add a NEWS entry for it.  Would you like to propose
one?

Message #20 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43944 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Fri, 16 Oct 2020 23:39:55 +0300

On 2020-10-16, 18:30 +0300, Eli Zaretskii <eliz <at> gnu.org> wrote:

>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Fri, 16 Oct 2020 06:46:31 -0700
>> 
>> I also made the followup commit 6d4f57dbdf that adapts the new Info
>> manual to better fit Emacs conventions.  Please see the attached patch.
>
> Please note that I made further changes to the manual, to adapt it to
> our conventions and standards.

Thanks to both of you for the changes!  I will make sure to include them
in my version.

With regard to British English, there is more of it in the *.el files I
shared: "colour" probably is the most common one.  Shall I prepare a
patch?

-- 
Protesilaos Stavrou
protesilaos.com

Message #23 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Fri, 16 Oct 2020 17:07:55 -0700

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> With regard to British English, there is more of it in the *.el files I
> shared: "colour" probably is the most common one.  Shall I prepare a
> patch?

Sure!  Or it could wait until you release the next version, if you
prefer that option.

Message #26 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Sat, 17 Oct 2020 10:13:12 +0300

[Message part 1 (text/plain, inline)]

On 2020-10-16, 10:13 -0700, Stefan Kangas <stefankangas <at> gmail.com> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> + The two themes are also available in GNU ELPA.  What is the best way
>>   to ensure that we sync between emacs.git and elpa.git?  GNU ELPA has
>>   hitherto pulled from dedicated branches on my upstream git repository.
>>   Maybe it would be better/easier to start building directly from the
>>   Emacs source?  This would reduce the overall workload.
>
> What does "start building directly from the Emacs source" mean here?

"Build" is the wrong term here.  Sorry about that!  My intent is to find
an easy way/workflow to get the files from Emacs into GNU ELPA.

And by "easy" I mean not to duplicate the work we do here.  So I would
not have to contact the GNU ELPA maintainers separately and have them
pull from my git source.

> FWIW, I don't think we should feel too bound to any particular process;
> this seems like a practical matter where we should try to do whatever
> is most practical.

Good to know.  I have no particular preference on the matter and shall
adapt to whatever you and others may recommend.

>> + Sending attachments with large diffs has the downside of losing the
>>   commit history.  Do Emacs maintainers wish to keep track of it?  If
>>   so, what would be the best way to preserve it, seeing as I am
>>   developing them on my own upstream?
>
> I don't think we generally worry about preserving history for packages
> managed externally.  We just sync the latest version.
>
> (If one really would like to preserve it, it could perhaps be done with
> some git magic.  I'm not sure it's worth the extra effort.)

Syncing the latest version works fine for me.

I have thus far published tagged releases on a monthly cadence.  Expect
the next one in mid to late November.

>> + Should the texinfo file be mentioned in the NEWS entry about the two
>>   themes?  The attached patch does not include such a change.
>
> We could of course add a NEWS entry for it.  Would you like to propose
> one?

I attach a possible rewording that also corrects "colour" and adds an
explicit reference to the WCAG AAA accessibility spec.  Please note that
I do not know how to properly reference an Info node: I used 'C-u 0 x',
which calls 'Info-copy-current-node-name'.

-- 
Protesilaos Stavrou
protesilaos.com

[0001-Update-Modus-themes-NEWS-entry.patch (text/x-patch, attachment)]

Message #29 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43944 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Sat, 17 Oct 2020 10:13:37 +0300

> From: Protesilaos Stavrou <info <at> protesilaos.com>
> Cc: Stefan Kangas <stefankangas <at> gmail.com>,  43944 <at> debbugs.gnu.org
> Date: Fri, 16 Oct 2020 23:39:55 +0300
> 
> With regard to British English, there is more of it in the *.el files I
> shared: "colour" probably is the most common one.  Shall I prepare a
> patch?

Yes, please.

Note that I didn't change a couple of those UK English spellings where
they affected too many places, for example one node that is referenced
from many places.  If you could take care of that as well, it would be
perfect.

Thanks.

Message #32 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Sat, 17 Oct 2020 10:15:42 +0300

On 2020-10-16, 17:07 -0700, Stefan Kangas <stefankangas <at> gmail.com> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> With regard to British English, there is more of it in the *.el files I
>> shared: "colour" probably is the most common one.  Shall I prepare a
>> patch?
>
> Sure!  Or it could wait until you release the next version, if you
> prefer that option.

I prefer to wait until the next version (coming mid to late November).
Just to be sure that we capture everything.

Thanks again!

-- 
Protesilaos Stavrou
protesilaos.com

Message #35 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 43944 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Sat, 17 Oct 2020 11:09:04 +0300

On 2020-10-17, 10:13 +0300, Eli Zaretskii <eliz <at> gnu.org> wrote:

>> From: Protesilaos Stavrou <info <at> protesilaos.com>
>> Cc: Stefan Kangas <stefankangas <at> gmail.com>,  43944 <at> debbugs.gnu.org
>> Date: Fri, 16 Oct 2020 23:39:55 +0300
>> 
>> With regard to British English, there is more of it in the *.el files I
>> shared: "colour" probably is the most common one.  Shall I prepare a
>> patch?
>
> Yes, please.
>
> Note that I didn't change a couple of those UK English spellings where
> they affected too many places, for example one node that is referenced
> from many places.  If you could take care of that as well, it would be
> perfect.
>
> Thanks.

Thanks!  I shall take care of those as well.  I prefer to do it for the
next release (to be published in about a month from now).  Just to be
sure that we catch everything.

-- 
Protesilaos Stavrou
protesilaos.com

Message #38 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 43944 <at> debbugs.gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Sat, 17 Oct 2020 09:59:08 +0100

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Thanks!  I shall take care of those as well.  I prefer to do it for the
> next release (to be published in about a month from now).  Just to be
> sure that we catch everything.

Sorry to give you more work, but while you're at it, could you please
also change the spelling of my surname from Contovounisios to
Contovounesios in the changelog and manual?  Not because I care about
attribution, but for consistency ;).

Thanks,

-- 
Basil

Message #41 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Sat, 17 Oct 2020 16:23:30 +0000

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> "Build" is the wrong term here.  Sorry about that!  My intent is to find
> an easy way/workflow to get the files from Emacs into GNU ELPA.
>
> And by "easy" I mean not to duplicate the work we do here.  So I would
> not have to contact the GNU ELPA maintainers separately and have them
> pull from my git source.

Right.  Hmm, it's a bit tricky to be honest, because there are several
options and AFAICT the workflows are not exactly 100 % streamlined in
all cases.  Maybe you could bring this question to emacs-devel?

> Syncing the latest version works fine for me.
>
> I have thus far published tagged releases on a monthly cadence.  Expect
> the next one in mid to late November.

Great.

> I attach a possible rewording that also corrects "colour" and adds an
> explicit reference to the WCAG AAA accessibility spec.  Please note that
> I do not know how to properly reference an Info node: I used 'C-u 0 x',
> which calls 'Info-copy-current-node-name'.

Great, thanks.  I made some minor changes and pushed it to master as
commit 00c4d982e8.

Message #44 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 11:08:56 +0300

On 2020-10-17, 09:59 +0100, "Basil L. Contovounesios" <contovob <at> tcd.ie> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> Thanks!  I shall take care of those as well.  I prefer to do it for the
>> next release (to be published in about a month from now).  Just to be
>> sure that we catch everything.
>
> Sorry to give you more work, but while you're at it, could you please
> also change the spelling of my surname from Contovounisios to
> Contovounesios in the changelog and manual?  Not because I care about
> attribution, but for consistency ;).
>
> Thanks,

I just fixed the spelling of your name on my end.  Is it okay if I defer
the submission of this change until mid-November, when the new version
of the themes will be available?  Otherwise feel free to fix it now.

-- 
Protesilaos Stavrou
protesilaos.com

Message #47 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 11:12:01 +0300

On 2020-10-17, 16:23 +0000, Stefan Kangas <stefankangas <at> gmail.com> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> "Build" is the wrong term here.  Sorry about that!  My intent is to find
>> an easy way/workflow to get the files from Emacs into GNU ELPA.
>>
>> And by "easy" I mean not to duplicate the work we do here.  So I would
>> not have to contact the GNU ELPA maintainers separately and have them
>> pull from my git source.
>
> Right.  Hmm, it's a bit tricky to be honest, because there are several
> options and AFAICT the workflows are not exactly 100 % streamlined in
> all cases.  Maybe you could bring this question to emacs-devel?

Yes, I shall post on emacs-devel.

>> I attach a possible rewording that also corrects "colour" and adds an
>> explicit reference to the WCAG AAA accessibility spec.  Please note that
>> I do not know how to properly reference an Info node: I used 'C-u 0 x',
>> which calls 'Info-copy-current-node-name'.
>
> Great, thanks.  I made some minor changes and pushed it to master as
> commit 00c4d982e8.

Thank you!

-- 
Protesilaos Stavrou
protesilaos.com

Message #50 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 14:18:44 +0200

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Yes, I shall post on emacs-devel.

Excellent.  Do we have anything more to discuss in this bug report or
should it be closed?

Message #53 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 15:31:56 +0300

On 2020-10-19, 14:18 +0200, Stefan Kangas <stefankangas <at> gmail.com> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> Yes, I shall post on emacs-devel.
>
> Excellent.  Do we have anything more to discuss in this bug report or
> should it be closed?

I did find some more references in the manual to package archives that
do not conform with the Emacs conventions.

Please give me some extra time while I prepare another patch (instead of
deferring it to the next release, as I had initially suggested).

-- 
Protesilaos Stavrou
protesilaos.com

Message #56 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 15:57:19 +0300

[Message part 1 (text/plain, inline)]

On 2020-10-19, 15:31 +0300, Protesilaos Stavrou <info <at> protesilaos.com> wrote:

> On 2020-10-19, 14:18 +0200, Stefan Kangas <stefankangas <at> gmail.com> wrote:
>
>> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>>
>>> Yes, I shall post on emacs-devel.
>>
>> Excellent.  Do we have anything more to discuss in this bug report or
>> should it be closed?
>
> I did find some more references in the manual to package archives that
> do not conform with the Emacs conventions.
>
> Please give me some extra time while I prepare another patch (instead of
> deferring it to the next release, as I had initially suggested).

Please find attached the patch that should address the remaining issues
with the manual (in line with what was reported by Eli and Basil).  Once
it is merged, I think the bug report can be closed.

Note that I did not correct "greyscale" to "grayscale" because there is
a symbol involved.  This will definitely be changed ahead of the next
tagged release.

P.S. As always, feel free to amend the patch.  Thanks again!

-- 
Protesilaos Stavrou
protesilaos.com

[0001-Fix-documentation-of-the-Modus-Themes.patch (text/x-patch, attachment)]

Message #59 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 15:42:04 +0000

close 43944 28.1
thanks

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Please find attached the patch that should address the remaining issues
> with the manual (in line with what was reported by Eli and Basil).  Once
> it is merged, I think the bug report can be closed.

Thanks!  Pushed to master as commit 4970e2c7ea.

I'm closing this bug report with this message.

Message #64 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 17:34:30 +0100

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Is it okay if I defer
> the submission of this change until mid-November, when the new version
> of the themes will be available?  Otherwise feel free to fix it now.

AFAICT the Modus sources have since been updated in both Emacs and on
GitLab, so does this still apply?

I'm in no hurry - the only reason I asked you instead of fixing it
myself, is that I saw you were already in the process of applying
feedback, and I didn't have the time to look into regenerating the
Texinfo manual from Org.

Thanks,

-- 
Basil

Message #67 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 19:55:56 +0300

On 2020-10-19, 17:34 +0100, "Basil L. Contovounesios" <contovob <at> tcd.ie> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> Is it okay if I defer
>> the submission of this change until mid-November, when the new version
>> of the themes will be available?  Otherwise feel free to fix it now.
>
> AFAICT the Modus sources have since been updated in both Emacs and on
> GitLab, so does this still apply?
>
> I'm in no hurry - the only reason I asked you instead of fixing it
> myself, is that I saw you were already in the process of applying
> feedback, and I didn't have the time to look into regenerating the
> Texinfo manual from Org.
>
> Thanks,

I changed my mind because I noticed some references that had to be
addressed in a timely fashion.  So I also updated your name in the
process.  Sorry for not notifying you in advance.

-- 
Protesilaos Stavrou
protesilaos.com

Message #70 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>,
 Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 16:59:23 +0000

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> I'm in no hurry - the only reason I asked you instead of fixing it
> myself, is that I saw you were already in the process of applying
> feedback, and I didn't have the time to look into regenerating the
> Texinfo manual from Org.

This was fixed in Protesilaos' follow-up commit 4970e2c7ea.

Message #73 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 18:11:58 +0100

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> On 2020-10-19, 17:34 +0100, "Basil L. Contovounesios" <contovob <at> tcd.ie> wrote:
>
>> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>>
>>> Is it okay if I defer
>>> the submission of this change until mid-November, when the new version
>>> of the themes will be available?  Otherwise feel free to fix it now.
>>
>> AFAICT the Modus sources have since been updated in both Emacs and on
>> GitLab, so does this still apply?
>>
>> I'm in no hurry - the only reason I asked you instead of fixing it
>> myself, is that I saw you were already in the process of applying
>> feedback, and I didn't have the time to look into regenerating the
>> Texinfo manual from Org.
>>
>> Thanks,
>
> I changed my mind because I noticed some references that had to be
> addressed in a timely fashion.  So I also updated your name in the
> process.  Sorry for not notifying you in advance.

No need to apologise; I was just clarifying.

Thanks for working on this,

-- 
Basil

Message #76 received at 43944 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Protesilaos Stavrou <info <at> protesilaos.com>, 43944 <at> debbugs.gnu.org
Subject: Re: bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes
 to v0.13.0
Date: Mon, 19 Oct 2020 18:12:01 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> I'm in no hurry - the only reason I asked you instead of fixing it
>> myself, is that I saw you were already in the process of applying
>> feedback, and I didn't have the time to look into regenerating the
>> Texinfo manual from Org.
>
> This was fixed in Protesilaos' follow-up commit 4970e2c7ea.

Yep, that's what my preceding paragraph was alluding to, thanks.

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.