GNU bug report logs - #43946
[PATCH] doc: Add item to "Submitting Patches" section.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: zimoun <zimon.toutoune@HIDDEN>; Keywords: patch; dated Mon, 12 Oct 2020 08:21:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 43946 <at> debbugs.gnu.org:


Received: (at 43946) by debbugs.gnu.org; 21 Sep 2021 09:59:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 21 05:59:20 2021
Received: from localhost ([127.0.0.1]:44982 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mScYa-0003E8-6c
	for submit <at> debbugs.gnu.org; Tue, 21 Sep 2021 05:59:20 -0400
Received: from mail-wr1-f41.google.com ([209.85.221.41]:42591)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1mScYX-0003Dl-H5
 for 43946 <at> debbugs.gnu.org; Tue, 21 Sep 2021 05:59:18 -0400
Received: by mail-wr1-f41.google.com with SMTP id q11so37377083wrr.9
 for <43946 <at> debbugs.gnu.org>; Tue, 21 Sep 2021 02:59:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=ztmCAsQ5pCXHCAzvXaElKWQZ+M5923uM3HmpWIJzI2c=;
 b=XfGJcumIknHk3IFrC/mNpc/PyCOc5WFDBFdDpCDXV5zehSLcQZ3hnCJHto6RcV/SXU
 z8hOe5N22Bav0cc0JZWwdtn3vujQoVgIX43nHnGJXn2ze5b5bVHMMO8jZyxXlubNzCb+
 W8svquo4byP6j+bv0zqbYkdGZ2+MEOL3zd/k9kgwiUxio8eBkbtSssE11go7aMmR95c1
 BchcVFXQ12qbvUQ2vGjTyL3ysla8Z437N17kUBKshAQlva9wAAjhXjujJpzb4yj+Q2Mo
 62tZ34qEqfRzBHZ1qpYTuHuvq2b0qUKbfP0V/jH3qWyI/Q6B/fPiKRtlXQ5eHF+pA+Z2
 RGSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=ztmCAsQ5pCXHCAzvXaElKWQZ+M5923uM3HmpWIJzI2c=;
 b=6cSjZgg1Xq39QbCKOYGfsjxxLoAXsWB3xRbXMpujkqoNagxyQvd+bxMAXoljbO+gUx
 laU9QZ3+HpVFJ3XBulw41TZB/l0Oh1pSD66OjhqsePKNwmGbeeNShWg0KyE05S/+5Y4r
 uty4aTUeMFE0T15uCJWP44Pt+R6Ou+S+66d+iB9p9bSYU8nQ6VhNdnQwl8SS6R8lr+4q
 44LdRRZml/NNbV+NdU/pmQOwgoZWXwOSv/Z5PX5DLz+LDLQN6vhJ9SUyqHCM82Q+hd6o
 xWtdk8FY6gvXjayQbfAXHXCMNPD8asgeBGkE6VJz7B2lH1DQT+K6FXhjl/mqIeGYkYyp
 sk8A==
X-Gm-Message-State: AOAM53273iHcWWCCOkE7tOI/2V4iwtRS7Wd7FuocLoTrB8Qsyyjwv6Gm
 OH1XkoMtS08L5rxd50A22n5SP0hNsNY17A==
X-Google-Smtp-Source: ABdhPJz9yAhQZNOAOFwUTJiVGOoF6cB2/DVcIUu6gEvd+7JNjYT6DAZe5ln6uLtagOhREi7RISC7PA==
X-Received: by 2002:adf:f481:: with SMTP id l1mr2928322wro.411.1632218351506; 
 Tue, 21 Sep 2021 02:59:11 -0700 (PDT)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id l21sm2286925wmh.31.2021.09.21.02.59.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 21 Sep 2021 02:59:11 -0700 (PDT)
From: zimoun <zimon.toutoune@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
References: <20201012082003.19936-1-zimon.toutoune@HIDDEN>
 <87zh1axr7c.fsf@HIDDEN>
Date: Tue, 21 Sep 2021 11:53:57 +0200
In-Reply-To: <87zh1axr7c.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
 =?utf-8?Q?s?= message of "Fri, 15 Jan 2021 14:30:47 +0100")
Message-ID: <8635pyb6fe.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43946
Cc: 43946 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludo,

On Fri, 15 Jan 2021 at 14:30, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:
> zimoun <zimon.toutoune@HIDDEN> skribis:
>
>> * doc/contributing.texi (Submitting Patches): Add item about 'git-format=
-patch
>> --base'.
>> ---
>>  doc/contributing.texi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/doc/contributing.texi b/doc/contributing.texi
>> index af3601442e..5ea3cb1899 100644
>> --- a/doc/contributing.texi
>> +++ b/doc/contributing.texi
>> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a p=
ackage definition,
>>  please run through this check list:
>>=20=20
>>  @enumerate
>> +@cindex @code{git format-patch}
>> +@cindex @code{git-format-patch}
>> +@item
>> +We recommend to use the command @code{git format-patch --base} to
>> +include the commit where your patch applies.
>
> I=E2=80=99m not entirely convinced TBH, in part because I know I often pi=
le a
> couple of WIP branches on top of one another, =E2=80=9Cknowing what I=E2=
=80=99m doing=E2=80=9D
> (actually hoping that I do), and so the base commit would be useless in
> this case.

Could you explain more?  Here [#,@], I argument:

--8<---------------cut here---------------start------------->8---
It is not because <name> does not use this information that it cannot be
a recommendation, i.e., a suggestion or advice on what seems helpful.
Other said, it is not because it is "useless in this case" that it
isuseless in other cases.

For example, this information about which known commit that patch
applies is helping for the automation of testing patches.  Well,
see [1,2] for instance.  Discussions of such tooling happened in
#44625 [3] and Emacs helper [4].

1: https://git.kernel.org/pub/scm/utils/b4/b4.git/tree/README.rst
2: https://docs.kyleam.com/piem/Using-b4-to-apply-patches.html
3: http://issues.guix.gnu.org/44625
4: https://inbox.kyleam.com/piem/20201115061518.22191-1-kyle@HIDDEN/

[..]

I still think that recommending to provide the commit on which it
isknown that the patch (or patch set) applies is a good recommendation.
Especially when the submission rate is greater than the review rate
andthe tree is moving really quickly (yeah!).

It is no extra work for the submitter and really helps for the
reviewer.  They applies at base-commit, checks, rebases and resolves
conflicts if they are.  Otherwise, the patch is useless or it needs to
be rewritten by hand (or please indicate me how to do :-)).

BTW, it helps automation tools.

Sometimes, this base-commit is useless for the reviewer workflow but
having it does not interfere.  Having an information does not mean it
must be used.  However, not having an information implies it cannot be
used. ;-)
--8<---------------cut here---------------end--------------->8---

#: <http://issues.guix.gnu.org/issue/43946#5>
@: <http://issues.guix.gnu.org/issue/43946#6>


Seeing the number of patches in the patch tracker, most of them does not
apply anymore.  It is not encouraging to review and decrease the queue
when first the reviewer has to guess onto which commit the patch
applies.


Cheers,
simon




Information forwarded to guix-patches@HIDDEN:
bug#43946; Package guix-patches. Full text available.

Message received at 43946 <at> debbugs.gnu.org:


Received: (at 43946) by debbugs.gnu.org; 26 Mar 2021 05:49:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 26 01:49:03 2021
Received: from localhost ([127.0.0.1]:40157 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lPfLD-0007A6-1u
	for submit <at> debbugs.gnu.org; Fri, 26 Mar 2021 01:49:03 -0400
Received: from mail-wr1-f50.google.com ([209.85.221.50]:42967)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1lPfLB-00079c-NS
 for 43946 <at> debbugs.gnu.org; Fri, 26 Mar 2021 01:49:02 -0400
Received: by mail-wr1-f50.google.com with SMTP id x13so4435053wrs.9
 for <43946 <at> debbugs.gnu.org>; Thu, 25 Mar 2021 22:49:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=TkTU12trXelzpvCPBaM6DhGoOcXdIikjkN1vd1E7yN4=;
 b=ZCf6k1zIIpyhD+ynKlmJr+qBKbjo0YcewkHHDPhl31U28k3UHj3kUCWuihj9PyZ3eJ
 KtdVhBE9ckVyCKhzLh4dRMO+ecQIOOBL1lYzFkPqux8EYZTXemt2gjptmNmVT3bzCVZQ
 e+DrDETa71VEPbP1VyrAUDZVIpLyGCvbUSBTixG/+Ak5nxYW93mxzBncSLz2Fh8P9P2Y
 CAdyNPUajKptEpSqf1LXAZHDb+NKGOCMWEb0IsMJ1AV2MaqiiZZ3kqKgrI1XojKHY8+w
 q0Xoj3frBMe0GvKXJWY/6Y1G9BHPUCd94QVEfwchh1E7UPWIbRbMQEygyO5qsFDCqpSr
 AF+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=TkTU12trXelzpvCPBaM6DhGoOcXdIikjkN1vd1E7yN4=;
 b=BjckMLflbvWTxTgQeoPFzJto701HDQK8B0evFqAg6pzIyms/i2ieGKng3wGnggziiY
 lmRQlS+jhDGXLnG9pHiqELcVcKKFc9OJad1NlkOi6miklFwtL7rrKhRBc10daQTgx4XN
 S+3zefP9Aa2dwx9w1ihx0bVVgHnPqeoLcycgla29hIZohACcU+CVH1nqFmjN/eRjMJnN
 QQ//utwFUdSYffW50jrIMC/UeZ8spIceaCVh1IjsOwqnc7L9N/p/nJpjYSdyqVpml/M6
 6m44ZONzUcve/2TZZ2S6ZwxckfZqHWm1JCNRS/FKZV9Y1hXvjvdNDceK3RC9hi1b9Oid
 ZhoQ==
X-Gm-Message-State: AOAM533ye48rgz8jmeAjlWms7RP2D9ybGAetZNTRxzdIkp2yjUfZkr/7
 q9ym84f+Yuev1y1noNJWTjOoDunn/JU=
X-Google-Smtp-Source: ABdhPJywJUtk7JVN1onwtzGfD0qUnSfbOFogUNx+jt6uMoSXmYQ4DD/RschEZD8kdboVGK7g3k1G0w==
X-Received: by 2002:adf:8151:: with SMTP id 75mr12504390wrm.152.1616737735726; 
 Thu, 25 Mar 2021 22:48:55 -0700 (PDT)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id p17sm8667754wmd.42.2021.03.25.22.48.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 25 Mar 2021 22:48:55 -0700 (PDT)
From: zimoun <zimon.toutoune@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
References: <20201012082003.19936-1-zimon.toutoune@HIDDEN>
 <87zh1axr7c.fsf@HIDDEN>
 <CAJ3okZ316hbOsXJ3R8UCpEs--yqdVaw8pm3qp0p138JTDox6-w@HIDDEN>
Date: Fri, 26 Mar 2021 06:40:29 +0100
In-Reply-To: <CAJ3okZ316hbOsXJ3R8UCpEs--yqdVaw8pm3qp0p138JTDox6-w@HIDDEN>
 (zimoun's message of "Fri, 15 Jan 2021 15:00:20 +0100")
Message-ID: <867dlucw1e.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43946
Cc: 43946 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludo,


On Fri, 15 Jan 2021 at 15:00, zimoun <zimon.toutoune@HIDDEN> wrote:
> On Fri, 15 Jan 2021 at 14:30, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:
>
>> > +We recommend to use the command @code{git format-patch --base} to
>> > +include the commit where your patch applies.
>>
>> I=E2=80=99m not entirely convinced TBH, in part because I know I often p=
ile a
>> couple of WIP branches on top of one another, =E2=80=9Cknowing what I=E2=
=80=99m doing=E2=80=9D
>> (actually hoping that I do), and so the base commit would be useless in
>> this case.

[...]

>> Closing?  :-)
>
> As you want. :-)
> But, I think "qui peut le plus peut le moins".  Even if maybe my
> wording is not the good one, I still think that the "base-commit"
> where the patch applies should be provided, at least suggested.

I still think that recommending to provide the commit on which it is
known that the patch (or patch set) applies is a good recommendation.
Especially when the submission rate is greater than the review rate and
the tree is moving really quickly (yeah!).

It is no extra work for the submitter and really helps for the reviewer.
They applies at base-commit, checks, rebases and resolves conflicts if
they are.  Otherwise, the patch is useless or it needs to be rewritten
by hand (or please indicate me how to do :-)).

BTW, it helps automation tools.

Sometimes, this base-commit is useless for the reviewer workflow but
having it does not interfere.  Having an information does not mean it
must be used.  However, not having an information implies it cannot be
used. ;-)


Cheers,
simon




Information forwarded to guix-patches@HIDDEN:
bug#43946; Package guix-patches. Full text available.

Message received at 43946 <at> debbugs.gnu.org:


Received: (at 43946) by debbugs.gnu.org; 15 Jan 2021 14:00:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 15 09:00:40 2021
Received: from localhost ([127.0.0.1]:40145 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1l0Pea-0002B9-KX
	for submit <at> debbugs.gnu.org; Fri, 15 Jan 2021 09:00:40 -0500
Received: from mail-qv1-f47.google.com ([209.85.219.47]:32771)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1l0PeY-0002Av-2p
 for 43946 <at> debbugs.gnu.org; Fri, 15 Jan 2021 09:00:39 -0500
Received: by mail-qv1-f47.google.com with SMTP id a13so3966164qvv.0
 for <43946 <at> debbugs.gnu.org>; Fri, 15 Jan 2021 06:00:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=Oc4OhbpU65PcXL9WwaqfoX63BCLIggAiU1/UaJdzrnE=;
 b=YxdHmwLSkZVQRF9JiVVPaHsGkTc6APhEYx2DndXmZn+gHal6R6jbM5jydawjBYAU+Z
 p14oX5BwCCJ5okwjgjUuCv+hRp+xBMlWN/lj11jpejluahVw04Xbry61oOgP1OjCH9Kj
 iDRAmvT+K3P6NjEihCRXCkAj+a0GOeZvZL2529GDSTmz3o1rJtNyNhxsdYLbauHUsTRr
 m6cu/LKp5jaNUSbqKa7iFjdiVAbxEoxzsGSQdaBDgfDVLdKdI0s2x26YPl8ICpWZ/m9/
 jH3l0qArFKQdtrUv5Lk7jBRQjWy+hytQhkMQ8t7u72zdLilRdLyQv423YBtobhsi6p+o
 djFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=Oc4OhbpU65PcXL9WwaqfoX63BCLIggAiU1/UaJdzrnE=;
 b=nFShRMk+Jo3SjGSrAsLBELNdkNKy+LPq9mCupsoAc7H4sCPLFBGqZscWmk0ap+gpoT
 geLPCUlf1nt4I33KR1w1mAUXoUveHgZGnYsY6pQHGxJ4J+xZt1EnWHOThX9XxQIplL/E
 FPwk1YqvkIrbnG4zgY8fmw8uK99XqDHljCScqCn+pMHz37Zu384dPOBtzn1RFy5C5/6I
 FOcKQ81HJIOhEBg/2tRLP0pbzHFHncPXvSBhvPWv97JhvatnU4FtzzNY3tVsRAVyJWb3
 5jHuO41IhSfn92A+vXAOV/NMWZC5REKl39pl72JAJcQAAkYDPrCXI8Ms3abCrUEf1q+i
 pJbw==
X-Gm-Message-State: AOAM531tCP9fHol7ni4frPQr3+XgacKYtjiyyx2TI+kzloPm8t3IoQAc
 eImN/gwpJtbGkUQ45uQrIGEw5c9U+1n/hviYYso=
X-Google-Smtp-Source: ABdhPJwa0mHPABmXrPUX2l1+VAW/0/O20inzKMnzH8BbFE3RIr2Ojp9jl4EYXfuWuKiQ7yoD9Vvnv2ARP1yCP1VjNW8=
X-Received: by 2002:a0c:df94:: with SMTP id w20mr11939825qvl.33.1610719232387; 
 Fri, 15 Jan 2021 06:00:32 -0800 (PST)
MIME-Version: 1.0
References: <20201012082003.19936-1-zimon.toutoune@HIDDEN>
 <87zh1axr7c.fsf@HIDDEN>
In-Reply-To: <87zh1axr7c.fsf@HIDDEN>
From: zimoun <zimon.toutoune@HIDDEN>
Date: Fri, 15 Jan 2021 15:00:20 +0100
Message-ID: <CAJ3okZ316hbOsXJ3R8UCpEs--yqdVaw8pm3qp0p138JTDox6-w@HIDDEN>
Subject: Re: bug#43946: [PATCH] doc: Add item to "Submitting Patches" section.
To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43946
Cc: 43946 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Ludo,

On Fri, 15 Jan 2021 at 14:30, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:

> > +We recommend to use the command @code{git format-patch --base} to
> > +include the commit where your patch applies.
>
> I=E2=80=99m not entirely convinced TBH, in part because I know I often pi=
le a
> couple of WIP branches on top of one another, =E2=80=9Cknowing what I=E2=
=80=99m doing=E2=80=9D
> (actually hoping that I do), and so the base commit would be useless in
> this case.

I am not buying your argument. :-)
It is not because <name> does not use this information that it cannot
be a recommendation, i.e., a suggestion or advice on what seems
helpful.
Other said, it is not because it is "useless in this case" that it is
useless in other cases.

For example, this information about which known commit that patch
applies is helping for the automation of testing patches.  Well, see
[1,2] for instance.  Discussions of such tooling happened in #44625
[3] and Emacs helper [4].


1: <https://git.kernel.org/pub/scm/utils/b4/b4.git/tree/README.rst>
2: <https://docs.kyleam.com/piem/Using-b4-to-apply-patches.html>
3: <http://issues.guix.gnu.org/44625>
4: <https://inbox.kyleam.com/piem/20201115061518.22191-1-kyle@HIDDEN/>

> Closing?  :-)

As you want. :-)
But, I think "qui peut le plus peut le moins".  Even if maybe my
wording is not the good one, I still think that the "base-commit"
where the patch applies should be provided, at least suggested.

Cheers,
simon




Information forwarded to guix-patches@HIDDEN:
bug#43946; Package guix-patches. Full text available.

Message received at 43946 <at> debbugs.gnu.org:


Received: (at 43946) by debbugs.gnu.org; 15 Jan 2021 13:30:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 15 08:30:56 2021
Received: from localhost ([127.0.0.1]:40141 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1l0PBo-0001V3-7R
	for submit <at> debbugs.gnu.org; Fri, 15 Jan 2021 08:30:56 -0500
Received: from eggs.gnu.org ([209.51.188.92]:48978)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1l0PBm-0001Um-R9
 for 43946 <at> debbugs.gnu.org; Fri, 15 Jan 2021 08:30:55 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:57464)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1l0PBg-0006uL-Jh; Fri, 15 Jan 2021 08:30:48 -0500
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39224 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1l0PBg-0004eM-7e; Fri, 15 Jan 2021 08:30:48 -0500
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: zimoun <zimon.toutoune@HIDDEN>
Subject: Re: bug#43946: [PATCH] doc: Add item to "Submitting Patches" section.
References: <20201012082003.19936-1-zimon.toutoune@HIDDEN>
Date: Fri, 15 Jan 2021 14:30:47 +0100
In-Reply-To: <20201012082003.19936-1-zimon.toutoune@HIDDEN> (zimoun's
 message of "Mon, 12 Oct 2020 10:20:03 +0200")
Message-ID: <87zh1axr7c.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43946
Cc: 43946 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Simon!

zimoun <zimon.toutoune@HIDDEN> skribis:

> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-=
patch
> --base'.
> ---
>  doc/contributing.texi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index af3601442e..5ea3cb1899 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a pa=
ckage definition,
>  please run through this check list:
>=20=20
>  @enumerate
> +@cindex @code{git format-patch}
> +@cindex @code{git-format-patch}
> +@item
> +We recommend to use the command @code{git format-patch --base} to
> +include the commit where your patch applies.

I=E2=80=99m not entirely convinced TBH, in part because I know I often pile=
 a
couple of WIP branches on top of one another, =E2=80=9Cknowing what I=E2=80=
=99m doing=E2=80=9D
(actually hoping that I do), and so the base commit would be useless in
this case.

Closing?  :-)

Thanks,
Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#43946; Package guix-patches. Full text available.
Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 43946-done <at> debbugs.gnu.org:


Received: (at 43946-done) by debbugs.gnu.org; 24 Oct 2020 09:17:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 24 05:17:27 2020
Received: from localhost ([127.0.0.1]:58975 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kWFfy-0005KQ-Ll
	for submit <at> debbugs.gnu.org; Sat, 24 Oct 2020 05:17:27 -0400
Received: from mail-qv1-f66.google.com ([209.85.219.66]:46684)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1kWFft-0005I0-PF
 for 43946-done <at> debbugs.gnu.org; Sat, 24 Oct 2020 05:17:24 -0400
Received: by mail-qv1-f66.google.com with SMTP id s1so2058121qvm.13
 for <43946-done <at> debbugs.gnu.org>; Sat, 24 Oct 2020 02:17:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=Z7IApHdqppembymsbkzzY31q1IDDwt1J7Ui4EFiulqw=;
 b=H/K/5fFSToqrXY+e1KeX9/3VbwlFoW/WrY1kVDTLJGvmUviVDFlHS8N/ODfwzsOmHW
 ongOrms9z5tx1m1o+1BxHtVDFs61UsEWrPSf7mstdWmjWFr8NIIiJCEN3BYVXvPcih/T
 NIv5W1/gn0fey/tMxb5lfudzQtHwFyWotjJr0MBDxRVWyzmu4N/vNXMLNqdB0Q3k2N7N
 KMd/T+KxkTIpBl23c52izNmKYWWa5C1OJ3MZK68nzgHu6M6E3dVGdOvkD4LeFSMbdDBz
 IP0erZ/EbjvOxnwedaeRhMSCUZQeU1Ys3MVxRTvCdcc9Eiq1PgOwHbBy/Wu5JDhEHtm6
 htug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=Z7IApHdqppembymsbkzzY31q1IDDwt1J7Ui4EFiulqw=;
 b=J7GnHjISioEXS7MKbpVefSOJxSpVo/Z7avXDqoDxRewkmM5asfXwEpXpZKxELKq1se
 SaPrFACGPThICuDwsbEkzPWcJjbb44bzHBktxd56U0magQ0XPBn21spCIyHWaS1wBC6h
 ZHaHXU7XsvsVgxhObL6OB+t6qjm0zXQ9skdORUYGOh4MAu/pJL5rZK1A7loGF6iCsGgS
 Y/kgOT9kZakPwT4yuzmsQJ6rH219O5gPIdEjeR2Usdd8ED/nR5YdEbOy8lVE1fKEjB6N
 moJdzuCExaTdf5q8MCeSuI/yitTDRKFoWDuBTlfpynkp/Rd5WwhAUiA/e4w6sk7eFR29
 EYpQ==
X-Gm-Message-State: AOAM5325QW8gGecYoc3J4jdmSrg9vNyZD2mOwCzVt3UL+EaS/YiVm8Kb
 d26LwBCDJGgIqAO+9L1i4hBZr9IiS4+WMeCxCV4=
X-Google-Smtp-Source: ABdhPJy8C068IhoRE5aklViPFFipPeFIryR1VW3P5PrQU6NpSehTt0a1YonwU1dJ8Ro/jmQJC2gzE1Rm3tAVxAIxQ4s=
X-Received: by 2002:a05:6214:1268:: with SMTP id
 r8mr471809qvv.40.1603531036152; 
 Sat, 24 Oct 2020 02:17:16 -0700 (PDT)
MIME-Version: 1.0
References: <20201012082003.19936-1-zimon.toutoune@HIDDEN>
 <87d0189ev4.fsf@HIDDEN>
In-Reply-To: <87d0189ev4.fsf@HIDDEN>
From: zimoun <zimon.toutoune@HIDDEN>
Date: Sat, 24 Oct 2020 11:17:03 +0200
Message-ID: <CAJ3okZ0ANAfyWVbgUEe1Ryv35C9OA7CS-4bx_ey5YTmisi_tPQ@HIDDEN>
Subject: Re: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
To: Oleg Pykhalov <go.wigust@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43946-done
Cc: 43946-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Dear,

Thank you for the review.

On Sat, 24 Oct 2020 at 11:01, Oleg Pykhalov <go.wigust@HIDDEN> wrote:
> zimoun <zimon.toutoune@HIDDEN> writes:
>
> > * doc/contributing.texi (Submitting Patches): Add item about 'git-forma=
t-patch
> > --base'.
> > ---
> >  doc/contributing.texi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/contributing.texi b/doc/contributing.texi
> > index af3601442e..5ea3cb1899 100644
> > --- a/doc/contributing.texi
> > +++ b/doc/contributing.texi
> > @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a =
package definition,
> >  please run through this check list:
> >
> >  @enumerate
> > +@cindex @code{git format-patch}
> > +@cindex @code{git-format-patch}
> > +@item
> > +We recommend to use the command @code{git format-patch --base} to
> > +include the commit where your patch applies.
>
> =E2=80=9Cgit format-patch=E2=80=9D already mentioned in the documentation=
 in the first
> paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.htm=
l

The point of the patch is:
 - the addition of the cindex
 - the addition of the option --base
and AFAITC it is not already in the manual.  If it is the wrong place,
please let me know where it could be better.

All the best,
simon




Information forwarded to guix-patches@HIDDEN:
bug#43946; Package guix-patches. Full text available.

Message received at 43946-done <at> debbugs.gnu.org:


Received: (at 43946-done) by debbugs.gnu.org; 24 Oct 2020 09:02:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 24 05:02:07 2020
Received: from localhost ([127.0.0.1]:58966 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kWFR8-0001of-85
	for submit <at> debbugs.gnu.org; Sat, 24 Oct 2020 05:02:07 -0400
Received: from mail-lf1-f68.google.com ([209.85.167.68]:45932)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <go.wigust@HIDDEN>) id 1kWFR3-0001mC-TU
 for 43946-done <at> debbugs.gnu.org; Sat, 24 Oct 2020 05:02:03 -0400
Received: by mail-lf1-f68.google.com with SMTP id r127so5025941lff.12
 for <43946-done <at> debbugs.gnu.org>; Sat, 24 Oct 2020 02:02:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=gZeZSxz0nEepIDjeS3LeJJ/f9mflqzZidREkY+svBQo=;
 b=XuMtm+9CSmg83FMnswubCghazFubA4rBW3j2nGggN83n+WOdHcZdbiukR5x0nh2ehn
 tNd5qz4LlUTnu4NjZbN05ABxaJoM5X5veqL9Cg9RFTIxKlbWDQOQaFUCRGkzdeJcfOwr
 NJZafgwRDaUxDMYgCUngy+rvC0wLlw5i+GXD7xGth2Ub+M0sPtFvc1NitE7FJL6lVwN6
 OS2ur1kyDKDJDazmWUVCPda56qeKfJovuVWz1Tb96xsYwerZTmC/nrUDjjRLAd96rhLy
 79XAMal71MWm5Bp9uncYPONnSTVBLr2I/DL8Yk3bGXZ51XJnbn0KV/oQtSud+EirQkAr
 UwYA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=gZeZSxz0nEepIDjeS3LeJJ/f9mflqzZidREkY+svBQo=;
 b=MjEE+wkk6twJOOqRO1/i5wSY2cnY4uuykh+6gDm51O1APPoOl85Gu2DhwPjfT5UWVi
 Lm+lbxIFn+lubKHgHnTVIyYZvfmRcgR+XljAca/+miPId1rUi3jN+N737WPb4k0ckm85
 Q6xdqVCvF5AENivQRQMvlS9ki2+8p8p5riKepwF3UShj+vFiRFHWpSdlMV+mPLVYeefJ
 QFrQbEQZ2xyzHK97ijqUWMeXF0hOHWs8PBin82w2NxY1M0yp2X2T1s0/EbZdP0hbR0Xl
 bPL7k6nJKYoyu6zwPfqShEpcw+RPlMTUlIgylwTaERFXl3W9jhqoECk3CKJKC8nZ/o0x
 y8zQ==
X-Gm-Message-State: AOAM532wZ9B3LPapjI92RiibqExW/ZdyAg54IeuuVX7oucHjXEeOYpZJ
 vFwVTaeawPXDbC3Rw4jzwjSHzhXcr/Q=
X-Google-Smtp-Source: ABdhPJxaM6Ix7GuzlGFVWovBMjsciPlbQs2IIvfMgCZUMB7bPbSEPa2vtKIHBAmT2Di0KiBGAGyJBg==
X-Received: by 2002:ac2:4428:: with SMTP id w8mr2225256lfl.563.1603530115320; 
 Sat, 24 Oct 2020 02:01:55 -0700 (PDT)
Received: from guixsd ([178.71.226.25])
 by smtp.gmail.com with ESMTPSA id n3sm377517lfd.223.2020.10.24.02.01.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 24 Oct 2020 02:01:54 -0700 (PDT)
From: Oleg Pykhalov <go.wigust@HIDDEN>
To: zimoun <zimon.toutoune@HIDDEN>
Subject: Re: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
References: <20201012082003.19936-1-zimon.toutoune@HIDDEN>
Date: Sat, 24 Oct 2020 12:01:51 +0300
In-Reply-To: <20201012082003.19936-1-zimon.toutoune@HIDDEN> (zimoun's
 message of "Mon, 12 Oct 2020 10:20:03 +0200")
Message-ID: <87d0189ev4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 43946-done
Cc: 43946-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

zimoun <zimon.toutoune@HIDDEN> writes:

> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-=
patch
> --base'.
> ---
>  doc/contributing.texi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index af3601442e..5ea3cb1899 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a pa=
ckage definition,
>  please run through this check list:
>=20=20
>  @enumerate
> +@cindex @code{git format-patch}
> +@cindex @code{git-format-patch}
> +@item
> +We recommend to use the command @code{git format-patch --base} to
> +include the commit where your patch applies.

=E2=80=9Cgit format-patch=E2=80=9D already mentioned in the documentation i=
n the first
paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

Do I miss something?  Fill free to reopen the issue ;-)

Oleg.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl+T7X8UHGdvLndpZ3Vz
dEBnbWFpbC5jb20ACgkQFn+OpQAa+pyudBAArBS4ldmCP+57vXlefi6pc75gWORp
EQRlqggeykpj8wxAxybD4cjYyLTiZuoDzxMeusnm/QoW1efEo9QYYKXb7V2z0JJI
aN3u2nSN5dOmzDYJZZ1cXZCiCcOKPuTctE+lm/A+6dOJnRjWsvI3j3MK+uaGRyeY
LLgXr8Fdp7QD/SLUNYJh+dOnx5LwA/nohyrjJkH+f1a2sCeEQrcdJz+FRKgF/nK7
mm143NWEAOvOxBa252K1NtGB9FF6KzjewHVyh/9O+8bDBoNoFSGgeMcn1FeDxpli
2ecX7b+7ndLbDuw2kO69cGxSR3iz8YOA2Va71CnFBntmWqMouegAuOL7BNdj4ZvP
e3QPd2u8fl0hcrBEXFSbmiKygODGN/wL50Kp5WguF917LoxWo9hy6qNSUP6LoDje
NC7olHR+iRK2PZt/BhRwDTZ2KYuJlrzn4I5nyA9geUtrvCYtWxbfsi51afOZARML
8bHJgLeNjlSyHOUKgOmPj2n1gO1VxMoJKrXdehjY9vf15FJOyT5TIcJFYoqONZWf
mky7X5R8pKWQItfD8uiQdaxukFTMh7VzFJsIqYw5UEzO4wn1noQA8g/ayhJmsnwA
6pOVujOi33NzouP4ShMuL0FeBOopUE4FHsSyqPwNSyCozm2QIiBm0LZLN9U6hCcn
ejWEBrszF1aHiIA=
=Tcqj
-----END PGP SIGNATURE-----
--=-=-=--




Notification sent to zimoun <zimon.toutoune@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Oleg Pykhalov <go.wigust@HIDDEN>:
You have taken responsibility. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Oct 2020 08:20:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 12 04:20:24 2020
Received: from localhost ([127.0.0.1]:41627 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kRt4C-0006st-8c
	for submit <at> debbugs.gnu.org; Mon, 12 Oct 2020 04:20:24 -0400
Received: from lists.gnu.org ([209.51.188.17]:51516)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1kRt4A-0006sm-Um
 for submit <at> debbugs.gnu.org; Mon, 12 Oct 2020 04:20:23 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49650)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
 id 1kRt4A-0004Bc-PM
 for guix-patches@HIDDEN; Mon, 12 Oct 2020 04:20:22 -0400
Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:39471)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
 id 1kRt45-0006Na-Ck
 for guix-patches@HIDDEN; Mon, 12 Oct 2020 04:20:22 -0400
Received: by mail-wm1-x341.google.com with SMTP id d3so16634257wma.4
 for <guix-patches@HIDDEN>; Mon, 12 Oct 2020 01:20:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=vKbv431BVHe/xNWQEZIqLikYdYTL9Vkh35qD/TqlJ1w=;
 b=tDILq2+GHW4JLa3jgJ8hBRGEqXLZTnsOWHL94DnEkak5MTWzGauUWK01iNybCLhFzC
 VeQNr1300YO/co+ymTcrti+KDT9w6vEMIjiArQsJOhk+A+RlnVJxgAvVUjtJTjCBHgEp
 qywr8j8UVlE3kAz8P3z92wJ7l7oUuQFNfxW7gdbVd/Jc5ZL+nzi5idz3chEARIeYzydc
 v2Vilavl1lrMjS4yXff1gYlaanCTIDga5OalMbeUsqbuP3geWtgVoJpk0KzcPQnog33i
 Q3m53IvQ5laWnboyAc26BQmWi5ahJXw7p8lq+eWS1Ago8elS0z71v2INpSbw4SISm/rl
 syPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=vKbv431BVHe/xNWQEZIqLikYdYTL9Vkh35qD/TqlJ1w=;
 b=e8Tao0QpEZC7eb2HPXi8x1Zlx4zetJvWGqUkSG2wR9TMRKXRIgpYWAlOylYdEUi5h6
 1V4826+vyMHcnMMwXttVkXIv3RPMvndDA2Fg+z6/VehiIayZWnfur48WwIWQFKRbbOdG
 Jg7JhnUafmznC6W6OJEs22Ess8WNpEaqVbC/jkNiOr+rStIIOiLGn+SyinP1PkiPXpWe
 EhI89yvOW2XzMncoCSKK36S0YqA6w3VefM9Lr7OSN+Uk2ZEfMccwUZM//07/UcEml38n
 sFg5GcZq9wTZtsRLFCWGF2oOOd9+oNCDZ6yPlaThgDFt+96eV2jIqv1LwL8uClGmb3qS
 aDGg==
X-Gm-Message-State: AOAM533J8DQSTdS+8hpptJ/+V0XzxP7V/KCi98rJZTAn8uUb08e8ufGX
 S7I2Nvb7s9WdxYBn4Jp2Wo9iE3jztsg=
X-Google-Smtp-Source: ABdhPJxPx1Yh46qcGvTxGr3yUOnVtvJJQZT6IUIBPrfpImsxsfOcULL5eNzB/PGxuw1H/z/ARn5c6g==
X-Received: by 2002:a1c:4887:: with SMTP id v129mr10304512wma.13.1602490815735; 
 Mon, 12 Oct 2020 01:20:15 -0700 (PDT)
Received: from localhost.localdomain ([88.126.110.68])
 by smtp.gmail.com with ESMTPSA id v17sm12421886wru.44.2020.10.12.01.20.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 12 Oct 2020 01:20:15 -0700 (PDT)
From: zimoun <zimon.toutoune@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] doc: Add item to "Submitting Patches" section.
Date: Mon, 12 Oct 2020 10:20:03 +0200
Message-Id: <20201012082003.19936-1-zimon.toutoune@HIDDEN>
X-Mailer: git-send-email 2.28.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::341;
 envelope-from=zimon.toutoune@HIDDEN; helo=mail-wm1-x341.google.com
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: submit
Cc: zimoun <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
--base'.
---
 doc/contributing.texi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index af3601442e..5ea3cb1899 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
 please run through this check list:
 
 @enumerate
+@cindex @code{git format-patch}
+@cindex @code{git-format-patch}
+@item
+We recommend to use the command @code{git format-patch --base} to
+include the commit where your patch applies.
+
 @item
 If the authors of the packaged software provide a cryptographic
 signature for the release tarball, make an effort to verify the

base-commit: e746d30ec15852ec50e4247ea0a07ab2a9a69aa8
-- 
2.28.0





Acknowledgement sent to zimoun <zimon.toutoune@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#43946; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 21 Sep 2021 10:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.