GNU bug report logs - #43957
remove process-kill-buffer-query-function from kill-buffer-query-functions

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Boruch Baum <boruch_baum@HIDDEN>; dated Mon, 12 Oct 2020 14:08:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 43957 <at> debbugs.gnu.org:


Received: (at 43957) by debbugs.gnu.org; 12 Oct 2020 15:14:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 12 11:14:45 2020
Received: from localhost ([127.0.0.1]:43698 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kRzXB-0005HU-Gj
	for submit <at> debbugs.gnu.org; Mon, 12 Oct 2020 11:14:45 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44938)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1kRzX9-0005HH-0T
 for 43957 <at> debbugs.gnu.org; Mon, 12 Oct 2020 11:14:43 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44754)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1kRzX3-0004of-KA; Mon, 12 Oct 2020 11:14:37 -0400
Received: from [176.228.60.248] (port=3318 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1kRzX2-0001fG-Rx; Mon, 12 Oct 2020 11:14:37 -0400
Date: Mon, 12 Oct 2020 18:14:38 +0300
Message-Id: <83pn5n328x.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20201012140714.3omumvzypamrdiv6@HIDDEN> (message
 from Boruch Baum on Mon, 12 Oct 2020 10:07:14 -0400)
Subject: Re: bug#43957: remove process-kill-buffer-query-function from
 kill-buffer-query-functions
References: <20201012140714.3omumvzypamrdiv6@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 43957
Cc: 43957 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Mon, 12 Oct 2020 10:07:14 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> 
> When explicitly killing a shell/eshell or terminal-emulator
> ansi-term/term buffer, a user shouldn't have to take an extra step to
> respond to the prompt of process-kill-buffer-query-function. In such
> cases, the process for which function process-kill-buffer-query-function
> is activated is the foreground shell process, so of course the conscious
> user intent is to kill it.

FWIW, I'm not sure an unconditional change in behavior here is TRT.
Killing a buffer doesn't necessarily imply the user is aware that the
process will be killed as well.

I wouldn't object to an opt-in option, though.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#43957; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Oct 2020 14:07:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 12 10:07:26 2020
Received: from localhost ([127.0.0.1]:43566 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kRyU2-0001OK-3Q
	for submit <at> debbugs.gnu.org; Mon, 12 Oct 2020 10:07:26 -0400
Received: from lists.gnu.org ([209.51.188.17]:33074)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1kRyTz-0001OB-Sh
 for submit <at> debbugs.gnu.org; Mon, 12 Oct 2020 10:07:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:57976)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <boruch_baum@HIDDEN>)
 id 1kRyTz-0006N9-LG
 for bug-gnu-emacs@HIDDEN; Mon, 12 Oct 2020 10:07:23 -0400
Received: from mout.gmx.net ([212.227.17.21]:57379)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <boruch_baum@HIDDEN>)
 id 1kRyTw-0003Pa-0S
 for bug-gnu-emacs@HIDDEN; Mon, 12 Oct 2020 10:07:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1602511637;
 bh=SUsjFFlChHv44Vfb5W0A+3m2JEocPF47Txo4BsToZqU=;
 h=X-UI-Sender-Class:Date:From:To:Subject;
 b=efG4qdSnDlCXLN5+C9EOfqwlCH0XSfG/2vsU3LUMO0JUMLGJKLIDIClVqJdPR+JKh
 k5qwzQ+uTlV1iloA9/3A21MRMgxazzqxjgj7DcSkjt6ZDDOmAJmuCM4UZRs0PdBRCK
 Uad71fjm8Tv5u+ndD39vsmRflfyXzBLzYVn1mpY0=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com
 (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1Mn2WF-1k1PEp3VkV-00k6qD for <bug-gnu-emacs@HIDDEN>; Mon, 12 Oct 2020
 16:07:17 +0200
Date: Mon, 12 Oct 2020 10:07:14 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Emacs Bug Reporting <bug-gnu-emacs@HIDDEN>
Subject: remove process-kill-buffer-query-function from
 kill-buffer-query-functions
Message-ID: <20201012140714.3omumvzypamrdiv6@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:YmcxBXOPw7NOOjKd9rk81K9f3lkSvETesQjPr2R/UVS4q5hstF9
 9UbajaANmrsu2z664oB5LG4yynwFVGP9CBC0XMBgv7ei2pq+OD45SZicqh1NmdsB0VHBV6Q
 DWjdDRtJVnNvt7mw/bKxgByixR61fCUoixD6IORRakuWwmbGAnjieVUQIlwdvHhrkvORT57
 GRbgyU8dnYiQM1QOYl0bw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:0A4gaaMsge0=:Hr2zgM8Wd+NZ/hZm7L9g+m
 UybCsDsMBKORxJuKjKYxboHmxqGpgzVKx6tuQ83sBXjn3xv1ViCZlkW8Pt66SrUzCBcbZ1PKJ
 wuBQDYFJzYOU+DvUV+Ua969kS1pRlfopXuMt9/vJu85b63Hhavr8XloRNaWejNRW20qzzivgw
 0tlHzgWfc8uim0V8fH08oKargesywCU06fmab3F2qK6CzA1dHwU4ZcEW3xuu9H0zNvwhW3Vfp
 uJ5Aih9dja4B5OAl8n1ytWz+4c5Zg2SHlOQ7oGp8aCFaj6P43QyVMa3P8//WP67+aMEWsFzad
 P5TGsGfKoUbJ1dOnX8M6OaHfggrmWEVBB9rQXG0sOusYeycqRAiaGgVnWIvGu3NbzSwjNdjIG
 oQsfGOqEGSMqNO59Vqz3bnLE8Sy+uTQhP79/N5Wea4cwvfANrxsFzf5O5FH1yEwayenWHShm0
 C903CforDJ3Vz1rO6Qjlv09XBR3ulwjhu5a00bnxdmSGlzFCv9sCZCNuqPowNZ8afkbfjzCGo
 3SImABRqxkgf7WWvjO2SYImrnWfOGYOq1K2mcryiVuRoytnckk0NihIQ//MYcv1XGxS5MMh0d
 mYkGHt5p95ukzkW2FfxNx0PFX47fGc+Wk5Tl8FRpdOVOo6Ok8vzWyRhQ4d3UsbhQvdLG11zTW
 I6tkkV9EsIa6Sc2hK5rQ9ntMu1IU0ze5qt5qFqE0nxKzOcJUyruieR7QLqk4jcU8kZT9C14U0
 Yf+iD6ES9OdA8S3d7a6BsdM6t1+WfWkyPlEESMIWuKxx6USymvGdg3WH9+vPO8MRjA0RAG5hu
 eoQL9C1G/bzFYMK9V82UsnHzTWBhgdhQy1NhdiPXAT6Ly4S2wbmdUW4OcXo54yC/H9bazZwm+
 19GmcTo3Nl8Vp0JIjSupdLETNqzhX2AE9VgX1B48a5OnWIvCMBajjGCfdaZAWOTA9WegvoBvV
 6cT862aRK93f2LM7yVMNddk8/CbS2rJTEH1+sjpxse45h1YUGcx2MKkxd/tQ6t9X7XltWZHJp
 poY36iv2isa+BTZdvXfEnUzFg6eWKk8wEzXj1XH4aJ4L42lv75IYsJ/8rp3qtYm+4dO4rYFl/
 jzrbnpl4zPwASiOu+NB2ryHJ8wY8rACZg2hg0JeE1D90+o4b0WiU1+RZRr/3Ra8ymFxBEkwGw
 wlnWgdDXqC3tPg7uVMnYjkPcwFOZXa0X4tbFsox+du5ccKmoM/b/0oC9GVY25vnoSNx6YiwqX
 2Gx4cbFTQ1nHR3HDbDC1/bzetfMc/HQLXMu8pLw==
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=212.227.17.21; envelope-from=boruch_baum@HIDDEN;
 helo=mout.gmx.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/12 10:07:17
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic]
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

When explicitly killing a shell/eshell or terminal-emulator
ansi-term/term buffer, a user shouldn't have to take an extra step to
respond to the prompt of process-kill-buffer-query-function. In such
cases, the process for which function process-kill-buffer-query-function
is activated is the foreground shell process, so of course the conscious
user intent is to kill it.

One way to implement this is to have the mode entry functions remove the
entry from the buffer-local copy of kill-buffer-query-functions (if
that's an option for that variable). Another possibility is to put the
logic inside function process-kill-buffer-query-function. There may be
other ways. I'm not sure which is preferable so I haven't included a patch=
.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Acknowledgement sent to Boruch Baum <boruch_baum@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#43957; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 12 Oct 2020 15:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.