GNU bug report logs - #43972
[PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43972 in the body.
You can then email your comments to 43972 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.
Date: Tue, 13 Oct 2020 01:22:50 -0500

[Message part 1 (text/plain, inline)]

Patch file is attached.  There have been a couple of bugfix 
commits since the tagged 1.1.0, so I went ahead and just grabbed 
the current latest master.

--
Joseph LaFreniere

[0001-gnu-emacs-mixed-pitch-Update-to-1.1.0.patch (text/x-patch, attachment)]

Message #8 received at 43972 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Joseph LaFreniere <joseph <at> lafreniere.xyz>
Cc: 43972 <at> debbugs.gnu.org
Subject: Re: [bug#43972] [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.
Date: Tue, 13 Oct 2020 09:08:55 +0200

Hello,

Joseph LaFreniere <joseph <at> lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> There have been a couple of bugfix commits
> since the tagged 1.1.0, so I went ahead and just grabbed the current
> latest master.

AFAICT, there are 3 commits since 1.1.0 release. One is about updating
copyright years, the other two are adding faces to a list. Is there
a strong reason to use a non-tagged commit instead of a regular release?
If you think so, could you explain it in a comment at the beginning of
the package?

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

Message #11 received at 43972 <at> debbugs.gnu.org (full text, mbox):

From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 43972 <at> debbugs.gnu.org
Subject: Re: [bug#43972] [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.
Date: Wed, 14 Oct 2020 18:33:28 -0500

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
> AFAICT, there are 3 commits since 1.1.0 release. One is about 
> updating
> copyright years, the other two are adding faces to a list. Is 
> there
> a strong reason to use a non-tagged commit instead of a regular 
> release?
> If you think so, could you explain it in a comment at the 
> beginning of
> the package?

Given that this package is about faces, both of the two commits 
about adding faces consitute bug fixes for this ticket.  In 
particular, both of those commits address visual misalignment 
caused by the faces used for org-indent and line numbers being 
rendered in variable pitch faces.

I have added a single-sentence comment to the start of the recipe. 
If it would be appropriate to reference the specific issue 
tickets' URLs I can do that instead or in addition to.

Thanks for the review!

--
Joseph LaFreniere

[0001-gnu-emacs-mixed-pitch-Update-to-1.1.0.patch (text/x-patch, attachment)]

Message #16 received at 43972-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Joseph LaFreniere <joseph <at> lafreniere.xyz>
Cc: 43972-done <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#43972] [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.
Date: Wed, 28 Oct 2020 15:56:32 +0100

Hi,

Joseph LaFreniere <joseph <at> lafreniere.xyz> skribis:

> Given that this package is about faces, both of the two commits about
> adding faces consitute bug fixes for this ticket.  In particular, both
> of those commits address visual misalignment caused by the faces used
> for org-indent and line numbers being rendered in variable pitch
> faces.
>
> I have added a single-sentence comment to the start of the recipe. If
> it would be appropriate to reference the specific issue tickets' URLs
> I can do that instead or in addition to.

I think this addresses Nicolas’ concerns.

>>From 1022214b8fbb2c0dcb91ee335ab0c7a6721d782e Mon Sep 17 00:00:00 2001
> From: Joseph LaFreniere <joseph <at> lafreniere.xyz>
> Date: Tue, 13 Oct 2020 01:20:49 -0500
> Subject: [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.
>
> * gnu/packages/emacs-xyz.scm (emacs-mixed-pitch): Update to 1.1.0.

So I went ahead and committed it, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.