GNU bug report logs - #44003
[PATCH] gnu: emacs-julia-mode: Update to 0.4.

Previous Next

Package: guix-patches;

Reported by: Tim Howes <timhowes <at> lavabit.com>

Date: Thu, 15 Oct 2020 07:39:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44003 in the body.
You can then email your comments to 44003 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#44003; Package guix-patches. (Thu, 15 Oct 2020 07:39:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tim Howes <timhowes <at> lavabit.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 15 Oct 2020 07:39:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Howes <timhowes <at> lavabit.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8ea90c7.
Date: Thu, 15 Oct 2020 00:33:05 -0700
[Message part 1 (text/plain, inline)]
Hello,

This patch updates emacs-julia-mode to the latest commit from
https://github.com/JuliaEditorSupport/julia-emacs

Thanks,
Tim

[0001-gnu-emacs-julia-mode-Update-to-0.4-0.8ea90c7.patch (text/x-patch, inline)]
From 3271943c18c93317d89869d9882ae69e6a0677aa Mon Sep 17 00:00:00 2001
From: Tim Howes <timhowes <at> lavabit.com>
Date: Mon, 12 Oct 2020 23:12:29 -0700
Subject: [PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8ea90c7.

* gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4-0.8ea90c7.
---
 gnu/packages/emacs-xyz.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0c49d72cc2..9508d1475e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -81,6 +81,7 @@
 ;;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98 <at> protonmail.com>
 ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
+;;; Copyright © 2020 Tim Howes <timhowes <at> lavabit.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -7731,13 +7732,12 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
       (license license:gpl3+))))
 
 (define-public emacs-julia-mode
-  ;; XXX: Upstream version remained stuck at 0.3.  See
-  ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>.
-  (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4")
-        (revision "1"))
+  (let ((commit "8ea90c7927f6d87a291cfb0216f34dacf43c722e")
+        (version "0.4")
+        (revision "0"))
     (package
       (name "emacs-julia-mode")
-      (version (string-append "0.3-" revision "." (string-take commit 8)))
+      (version (git-version version revision commit))
       (source
        (origin
          (method git-fetch)
@@ -7747,7 +7747,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0"))))
+           "1ymanbalx41xri5kiqs83a80a72yr9831if6cz2m24pg3g7rwr9c"))))
       (build-system emacs-build-system)
       (arguments
        `(#:tests? #t
-- 
2.28.0


Information forwarded to guix-patches <at> gnu.org:
bug#44003; Package guix-patches. (Thu, 15 Oct 2020 22:04:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tim Howes via Guix-patches via <guix-patches <at> gnu.org>
Cc: Tim Howes <timhowes <at> lavabit.com>, 44003 <at> debbugs.gnu.org
Subject: Re: [bug#44003] [PATCH] gnu: emacs-julia-mode: Update to
 0.4-0.8ea90c7.
Date: Fri, 16 Oct 2020 00:03:11 +0200
Hello,

Tim Howes via Guix-patches via <guix-patches <at> gnu.org> writes:

> This patch updates emacs-julia-mode to the latest commit from
> https://github.com/JuliaEditorSupport/julia-emacs

Thank you.

Is there any reason not to use regular 0.4 release from March? If so,
could you explain it in a comment?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#44003; Package guix-patches. (Thu, 15 Oct 2020 22:04:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#44003; Package guix-patches. (Fri, 16 Oct 2020 06:37:01 GMT) Full text and rfc822 format available.

Message #14 received at 44003 <at> debbugs.gnu.org (full text, mbox):

From: Tim Howes <timhowes <at> lavabit.com>
To: 44003 <at> debbugs.gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#44003] [PATCH v2] gnu: emacs-julia-mode: Update to
 0.4-0.8bfc709.
Date: Thu, 15 Oct 2020 23:36:21 -0700
[Message part 1 (text/plain, inline)]
It seemed like the previous package definition used the latest commit,
but I guess that was because they had not yet put out a tagged release.

https://github.com/JuliaEditorSupport/julia-emacs/issues/46

The tagged release from March should work fine. Should it keep the
revision and commit ID as part of the version?

[v2-0001-gnu-emacs-julia-mode-Update-to-0.4-0.8bfc709.patch (text/x-patch, inline)]
From 6975b12dfe2478acf19a299be1942c68a40868ca Mon Sep 17 00:00:00 2001
From: Tim Howes <timhowes <at> lavabit.com>
Date: Thu, 15 Oct 2020 19:52:04 -0700
Subject: [PATCH v2] gnu: emacs-julia-mode: Update to 0.4-0.8bfc709.

* gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4-0.8bfc709.
---
 gnu/packages/emacs-xyz.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3e61e3141..2392c48295 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -81,6 +81,7 @@
 ;;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98 <at> protonmail.com>
 ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
+;;; Copyright © 2020 Tim Howes <timhowes <at> lavabit.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -7786,13 +7787,12 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
       (license license:gpl3+))))
 
 (define-public emacs-julia-mode
-  ;; XXX: Upstream version remained stuck at 0.3.  See
-  ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>.
-  (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4")
-        (revision "1"))
+  (let ((commit "8bfc709716a257521cb386f20b8932e83db930a9")
+        (version "0.4")
+        (revision "0"))
     (package
       (name "emacs-julia-mode")
-      (version (string-append "0.3-" revision "." (string-take commit 8)))
+      (version (git-version version revision commit))
       (source
        (origin
          (method git-fetch)
@@ -7802,7 +7802,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0"))))
+           "1w131jb9mhvyjxa0p93iwfhzidgbcs6b8i6jg79yisqb9wchik99"))))
       (build-system emacs-build-system)
       (arguments
        `(#:tests? #t
-- 
2.28.0


Changed bug title to '[PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8bfc709.' from '[PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8ea90c7.' Request was from Tim Howes <timhowes <at> lavabit.com> to control <at> debbugs.gnu.org. (Fri, 16 Oct 2020 06:50:03 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#44003; Package guix-patches. (Fri, 16 Oct 2020 19:33:02 GMT) Full text and rfc822 format available.

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Tim Howes via Guix-patches via <guix-patches <at> gnu.org>
Cc: Tim Howes <timhowes <at> lavabit.com>, 44003 <at> debbugs.gnu.org,
 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#44003] [PATCH v2] gnu: emacs-julia-mode: Update to
 0.4-0.8bfc709.
Date: Fri, 16 Oct 2020 14:32:24 -0500
Tim Howes via Guix-patches via <guix-patches <at> gnu.org> writes:

>
> The tagged release from March should work fine. Should it keep the
> revision and commit ID as part of the version?
>

Using tagged releases is preferred. I would remove the commit
let-binding and go about it using version numbering.

-- 
Brett M. Gilio
brettg <at> gnu.org
https://brettgilio.com/
E82A C026 95D6 FF02 43CA 1E5C F6C5 2DD1 BA27 CB87




Information forwarded to guix-patches <at> gnu.org:
bug#44003; Package guix-patches. (Fri, 16 Oct 2020 19:33:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#44003; Package guix-patches. (Sat, 17 Oct 2020 22:29:02 GMT) Full text and rfc822 format available.

Message #25 received at 44003 <at> debbugs.gnu.org (full text, mbox):

From: Tim Howes <timhowes <at> lavabit.com>
To: Brett Gilio <brettg <at> gnu.org>
Cc: 44003 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#44003] [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.
Date: Sat, 17 Oct 2020 15:28:26 -0700
[Message part 1 (text/plain, inline)]
Brett Gilio writes:

> Using tagged releases is preferred. I would remove the commit
> let-binding and go about it using version numbering.

OK, sounds good. Here it is using just the version tag.

Thanks,
Tim

[v3-0001-gnu-emacs-julia-mode-Update-to-0.4.patch (text/x-patch, inline)]
From 56fb736e24782937283eda7a3c4ea6b25c2d1014 Mon Sep 17 00:00:00 2001
From: Tim Howes <timhowes <at> lavabit.com>
Date: Thu, 15 Oct 2020 19:52:04 -0700
Subject: [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.

* gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4.
---
 gnu/packages/emacs-xyz.scm | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3e61e3141..d2fb4aaadb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -81,6 +81,7 @@
 ;;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98 <at> protonmail.com>
 ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
+;;; Copyright © 2020 Tim Howes <timhowes <at> lavabit.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -7786,23 +7787,19 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
       (license license:gpl3+))))
 
 (define-public emacs-julia-mode
-  ;; XXX: Upstream version remained stuck at 0.3.  See
-  ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>.
-  (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4")
-        (revision "1"))
     (package
       (name "emacs-julia-mode")
-      (version (string-append "0.3-" revision "." (string-take commit 8)))
+      (version "0.4")
       (source
        (origin
          (method git-fetch)
          (uri (git-reference
                (url "https://github.com/JuliaEditorSupport/julia-emacs")
-               (commit commit)))
+               (commit version)))
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0"))))
+           "1w131jb9mhvyjxa0p93iwfhzidgbcs6b8i6jg79yisqb9wchik99"))))
       (build-system emacs-build-system)
       (arguments
        `(#:tests? #t
@@ -7813,7 +7810,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
       (synopsis "Major mode for Julia")
       (description "This Emacs package provides a mode for the Julia
 programming language.")
-      (license license:expat))))
+      (license license:expat)))
 
 (define-public emacs-smex
   (package
-- 
2.28.0


Changed bug title to '[PATCH] gnu: emacs-julia-mode: Update to 0.4.' from '[PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8bfc709.' Request was from Tim Howes <timhowes <at> lavabit.com> to control <at> debbugs.gnu.org. (Sat, 17 Oct 2020 22:33:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#44003; Package guix-patches. (Mon, 19 Oct 2020 13:43:02 GMT) Full text and rfc822 format available.

Message #30 received at 44003 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Brett Gilio <brettg <at> gnu.org>
Cc: timhowes <at> lavabit.com, 44003 <at> debbugs.gnu.org,
 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#44003] [PATCH v2] gnu: emacs-julia-mode: Update to
 0.4-0.8bfc709.
Date: Mon, 19 Oct 2020 15:42:16 +0200
Dear,

On Fri, 16 Oct 2020 at 21:33, Brett Gilio <brettg <at> gnu.org> wrote:

> Using tagged releases is preferred. I would remove the commit
> let-binding and go about it using version numbering.

It is currently the convention and uniformity matters. :-)
But IMHO it is bad practise.  Using commit hash enforces
content-addressed, which is obviously not the case with "tags".  Tags
are fragile for upstream in-place replacement, for example.  For
reference, [1] and BTW all the thread is worth to read. :-)

1: <https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00236.html>

All the best,
simon




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 02 Nov 2020 13:47:02 GMT) Full text and rfc822 format available.

Notification sent to Tim Howes <timhowes <at> lavabit.com>:
bug acknowledged by developer. (Mon, 02 Nov 2020 13:47:02 GMT) Full text and rfc822 format available.

Message #35 received at 44003-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tim Howes <timhowes <at> lavabit.com>
Cc: 44003-done <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>,
 Brett Gilio <brettg <at> gnu.org>
Subject: Re: [bug#44003] [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.
Date: Mon, 02 Nov 2020 14:46:03 +0100
Hi Tim,

Tim Howes <timhowes <at> lavabit.com> skribis:

>>From 56fb736e24782937283eda7a3c4ea6b25c2d1014 Mon Sep 17 00:00:00 2001
> From: Tim Howes <timhowes <at> lavabit.com>
> Date: Thu, 15 Oct 2020 19:52:04 -0700
> Subject: [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.
>
> * gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4.

Applied, thanks!  And sorry for the delay.

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 01 Dec 2020 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 118 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.