GNU bug report logs - #44024
[PATCH] gnu: emacs-request: Update to latest commit.

Previous Next

Package: guix-patches;

Reported by: Niklas Eklund <niklas.eklund <at> posteo.net>

Date: Thu, 15 Oct 2020 20:32:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44024 in the body.
You can then email your comments to 44024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#44024; Package guix-patches. (Thu, 15 Oct 2020 20:32:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Niklas Eklund <niklas.eklund <at> posteo.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 15 Oct 2020 20:32:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-request: Update to latest commit.
Date: Thu, 15 Oct 2020 22:31:01 +0200
[Message part 1 (text/plain, inline)]
This patch updates emacs-request to the latest commit on git. The reason for
updating the package is that early this year a patch was merged which allowed
emacs-request to utilize the auth-source package providing a more convenient
experience for users and package developers.

[0001-gnu-emacs-request-Update-to-latest-commit.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#44024; Package guix-patches. (Thu, 15 Oct 2020 21:55:01 GMT) Full text and rfc822 format available.

Message #8 received at 44024 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 44024 <at> debbugs.gnu.org
Subject: Re: [bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.
Date: Thu, 15 Oct 2020 23:54:43 +0200
Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> This patch updates emacs-request to the latest commit on git. The reason for
> updating the package is that early this year a patch was merged which allowed
> emacs-request to utilize the auth-source package providing a more convenient
> experience for users and package developers.

Thank you.

Could you add a comment explaining the above at the top of the package
definition and send it again?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#44024; Package guix-patches. (Sun, 18 Oct 2020 19:02:02 GMT) Full text and rfc822 format available.

Message #11 received at 44024 <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 44024 <at> debbugs.gnu.org
Subject: Re: [bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.
Date: Sun, 18 Oct 2020 21:01:17 +0200
[Message part 1 (text/plain, inline)]
Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> Niklas Eklund <niklas.eklund <at> posteo.net> writes:
>
>> This patch updates emacs-request to the latest commit on git. The reason for
>> updating the package is that early this year a patch was merged which allowed
>> emacs-request to utilize the auth-source package providing a more convenient
>> experience for users and package developers.
>
> Thank you.
>
> Could you add a comment explaining the above at the top of the package
> definition and send it again?
>
> Regards,
> -- 
> Nicolas Goaziou

Absolutely, I wasn't sure if I were to put it in the code or not, but
now I know for the future.

Cheers,
Niklas
[v2-0001-gnu-Add-emacs-gcmh.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#44024; Package guix-patches. (Wed, 18 Nov 2020 22:10:01 GMT) Full text and rfc822 format available.

Message #14 received at 44024 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 44024 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.
Date: Wed, 18 Nov 2020 23:09:14 +0100
Hi,

Niklas Eklund <niklas.eklund <at> posteo.net> skribis:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Niklas Eklund <niklas.eklund <at> posteo.net> writes:
>>
>>> This patch updates emacs-request to the latest commit on git. The reason for
>>> updating the package is that early this year a patch was merged which allowed
>>> emacs-request to utilize the auth-source package providing a more convenient
>>> experience for users and package developers.
>>
>> Thank you.
>>
>> Could you add a comment explaining the above at the top of the package
>> definition and send it again?
>>
>> Regards,
>> -- 
>> Nicolas Goaziou
>
> Absolutely, I wasn't sure if I were to put it in the code or not, but
> now I know for the future.

[...]

> +(define-public emacs-gcmh
> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
> +        (revision "0"))

Looks like you forgot the comment.  :-)

Could you send an updated patch?  (Else we can do it for you.)

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#44024; Package guix-patches. (Thu, 19 Nov 2020 08:59:02 GMT) Full text and rfc822 format available.

Message #17 received at 44024 <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 44024 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.
Date: Thu, 19 Nov 2020 09:58:28 +0100
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
>> +(define-public emacs-gcmh
>> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
>> +        (revision "0"))
>
> Looks like you forgot the comment.  :-)
>
> Could you send an updated patch?  (Else we can do it for you.)

>
> Thanks,
> Ludo’.

Hi Ludo,

I could have sworn I updated that, must be something that I have done
wrong here :O.

I will make a new atempt, in this message attaching a new patch. If that
still fails feel free to make the change :)

[v3-0001-gnu-emacs-request-Update-to-latest-commit.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
Thanks,
Niklas

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Thu, 19 Nov 2020 20:30:02 GMT) Full text and rfc822 format available.

Notification sent to Niklas Eklund <niklas.eklund <at> posteo.net>:
bug acknowledged by developer. (Thu, 19 Nov 2020 20:30:02 GMT) Full text and rfc822 format available.

Message #22 received at 44024-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 44024-done <at> debbugs.gnu.org
Subject: Re: [bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.
Date: Thu, 19 Nov 2020 21:28:53 +0100
Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-request): Update to latest commit.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 18 Dec 2020 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 101 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.