GNU bug report logs - #44040
libguestfs + ocaml-hivex help wanted

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44040 in the body.
You can then email your comments to 44040 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: guix-patches <at> gnu.org
Subject: libguestfs + ocaml-hivex help wanted
Date: Fri, 16 Oct 2020 15:43:40 -0400

[Message part 1 (text/plain, inline)]

So I've sunk a lot of time into this package but I actually don't need
it anymore. My use-case is gone. Also I don't have a lot of time these
days. It does build and some of the tests pass, but It's untested since
I don't have a use case.

Basically I'm just posting this here so someone else can finish it. I
don't want to touch this anymore. Sorry for only going half way

[OpenPGP_0x52D93416EEAA45A6.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #8 received at 44040 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 44040 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH 1/2] gnu: Add ocaml-hivex.
Date: Fri, 16 Oct 2020 16:00:51 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/ocaml.scm (ocaml-hivex): New variable.
---
 gnu/packages/ocaml.scm | 104 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 104 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 4cc530509a..88c7f3c1d3 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2019 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Brett Gilio <brettg <at> gnu.org>
 ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
+;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -47,6 +48,8 @@
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gperf)
+  #:use-module (gnu packages gettext)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages libffi)
@@ -68,6 +71,7 @@
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages time)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages virtualization)
   #:use-module (gnu packages web-browsers)
   #:use-module (gnu packages xml)
@@ -2831,6 +2835,106 @@ writing to these structures, and they are accessed via the Bigarray module.")
     (description "Hex is a minimal library providing hexadecimal converters.")
     (license license:isc)))
 
+(define-public ocaml-hivex
+  (package
+    (name "ocaml-hivex")
+    ;; Make sure to update the gnulib input to the commit upstream uses when
+    ;; updating this package
+    (version "1.3.19")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/libguestfs/hivex")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1gw59ac6z4fbg0flajnsh6d25h75pnk4605d5rw9rv0bvhfvway5"))))
+    (build-system ocaml-build-system)
+    (arguments
+     `(;; XXX: I'm not sure why runpath validation doesn't work
+       #:validate-runpath? #f
+       #:configure-flags
+       (list (string-append "CONFIG_SHELL="
+                            (assoc-ref %build-inputs "bash") "/bin/bash")
+             (string-append "SHELL="
+                            (assoc-ref %build-inputs "bash") "/bin/bash"))
+       #:test-target "check"
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'unpack-gnulib
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((gnulib (assoc-ref inputs "gnulib")))
+               ;; Upstream gnulib is cloned into this directory as a submodule
+               (copy-recursively gnulib ".gnulib")
+               #t)))
+         ;; Autogen calls bootstrap and then generates a configure script
+         (add-before 'configure 'autogen
+           (lambda _
+             (chmod "configure.ac" #o644)
+             (invoke "./autogen.sh")
+             #t))
+         (add-before 'autogen 'fix-bootstrap
+           (lambda _
+             ;; Stop bootstrap from cloning gnulib
+             (substitute* "bootstrap"
+               (("^git.*$") ""))
+             #t))
+         (add-before 'autogen 'fix-autogen.sh
+           (lambda _
+             (substitute* "autogen.sh"
+               ;; Forces bootstrap to run
+               (("git submodule status") "echo false")
+               ;; Don't run configure yet
+               (("^.*configure.*$") "echo\n"))
+             #t))
+         (add-after 'autogen 'patch-configure-and-build-aux
+           (lambda* (#:key native-inputs inputs outputs #:allow-other-keys)
+             (patch-shebang "configure")
+             ;; Hard code paths to ld and file in the configure script
+             (substitute* "configure"
+               (("/usr/bin/ld")
+                (string-append (assoc-ref inputs "ld-wrapper") "/bin/ld"))
+               (("/usr/bin/file")
+                (string-append (assoc-ref inputs "file") "/bin/file")))
+             #t))
+         (add-before 'install 'patch-ocaml-installdir
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               ;; Force ocaml installdir to be correct
+               (substitute* "ocaml/Makefile"
+                 (("\\$\\(DESTDIR\\)\\$\\(OCAMLLIB\\)")
+                  (string-append
+                   out "/lib/ocaml/site-lib"))))
+             #t)))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("gperg" ,gperf)
+       ("libtool" ,libtool)
+       ("pkg-config" ,pkg-config)
+       ("gnulib"
+        ;; This is the commit upstream uses
+        ,(let ((commit "5e50baa16ef90204d9048a9e2f23c5a538955121"))
+           (origin
+             (method git-fetch)
+             (uri (git-reference
+                   (url "git://git.savannah.gnu.org/gnulib.git")
+                   (commit commit)))
+             (sha256
+              (base32 "0clx0gq6mmm4dkzp5pqh02cbzggnc3ba491qb79brpxcrjri1pnd"))
+             (file-name (git-file-name "gnulib" commit)))))))
+    (inputs
+     `(("perl" ,perl)
+       ("sed" ,sed)
+       ("gettext" ,gettext-minimal)))
+    (home-page "https://github.com/libguestfs/hivex")
+    (synopsis "Library for reading and writing Windows Registry \"hive\"
+binary files")
+    (description "This library reads Windows NT registry files (ie. not
+Windows 3.1 or Windows 95/98/ME).")
+    (license license:lgpl2.1)))
+
 (define-public ocaml4.07-ezjsonm
   (package
     (name "ocaml4.07-ezjsonm")
-- 
2.28.0

Message #11 received at 44040 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 44040 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH 2/2] gnu: Add libguestfs.
Date: Fri, 16 Oct 2020 16:00:53 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/virtualization.scm (libguestfs): New variable.
---
 gnu/packages/virtualization.scm | 103 ++++++++++++++++++++++++++++++++
 1 file changed, 103 insertions(+)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index ac062dfa15..d958d99330 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2020 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;; Copyright © 2020 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -37,13 +38,16 @@
   #:use-module (gnu packages admin)
   #:use-module (gnu packages assembly)
   #:use-module (gnu packages attr)
+  #:use-module (gnu packages augeas)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
+  #:use-module (gnu packages cdrom)
   #:use-module (gnu packages check)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages cpio)
   #:use-module (gnu packages cross-base)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages cyrus-sasl)
@@ -63,6 +67,7 @@
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages golang)
+  #:use-module (gnu packages gperf)
   #:use-module (gnu packages graphviz)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages haskell)
@@ -79,8 +84,10 @@
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages nettle)
   #:use-module (gnu packages networking)
+  #:use-module (gnu packages ocaml)
   #:use-module (gnu packages onc-rpc)
   #:use-module (gnu packages package-management)
+  #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages polkit)
@@ -2032,3 +2039,99 @@ administrators and developers in managing the database.")
 libosinfo library.  It provides information about guest operating systems for
 use with virtualization provisioning tools")
     (license license:lgpl2.0+)))
+
+(define-public libguestfs
+  (package
+    (name "libguestfs")
+    (version "1.42.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://download.libguestfs.org/"
+                    (version-major+minor version)
+                    "-stable/libguestfs-"
+                    version
+                    ".tar.gz"))
+              (sha256
+               (base32
+                "097hfi53w5lhf3im9l1lrymzv07ksyi1zcmg8bqrg9daycn1kvjg"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(;; XXX: I'm not sure why runpath validation doesn't work
+       #:validate-runpath? #f
+       ;; XXX: It's possible to get at least some of the tests to work
+       #:tests? #f
+       #:configure-flags (list "--disable-gnulib-tests"
+                               "--disable-daemon"
+                               "--disable-appliance"
+                               "--with-distro=none"
+                               "--disable-static")
+       ;; Installation is discouraged because users might want to have multiple
+       ;; versions installed at once. For that reason we have to specify
+       ;; "REALLY_INSTALL=yes" to install
+       #:make-flags (list "REALLY_INSTALL=yes")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'fix-configure
+           (lambda* (#:key inputs #:allow-other-keys)
+             ;; Our ncurses package doesn't have a binary called
+             ;; "ncurses6-config". It probably should though
+             (substitute* "configure"
+               (("ncurses6-config")
+                "ncursesw6-config"))
+             ;; Hard code paths to ld and file in the configure script
+             (substitute* "configure"
+               (("/usr/bin/ld")
+                (string-append (assoc-ref inputs "ld-wrapper") "/bin/ld"))
+               (("/usr/bin/file")
+                (string-append (assoc-ref inputs "file") "/bin/file")))
+             #t))
+         (add-before 'check 'fix-tests
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((bash (string-append (assoc-ref inputs "bash") "/bin/bash")))
+               (setenv "SHELL" bash))
+             #t))
+         (add-before 'install 'patch-ocaml-installdir
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               ;; Force ocaml installdir to be correct
+               (substitute* "ocaml/Makefile"
+                 (("\\$\\(DESTDIR\\)\\$\\(OCAMLLIB\\)")
+                  (string-append
+                   out "/lib/ocaml/site-lib"))))
+             #t)))))
+    (native-inputs
+     `(("bison" ,bison)
+       ("curl" ,curl)
+       ("flex" ,flex)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("augeas" ,augeas)
+       ("cdrkit-libre" ,cdrkit-libre)
+       ("cpio" ,cpio)
+       ("fuse" ,fuse)
+       ("gperf" ,gperf)
+       ("gperf" ,gperf)
+       ("jansson" ,jansson)
+       ("libselinux" ,libselinux)
+       ("libtirpc" ,libtirpc)
+       ("libvirt" ,libvirt)
+       ("libxml2" ,libxml2)
+       ("util-linux" ,util-linux) ; getopt
+       ("ncurses" ,ncurses)
+       ("ocaml" ,ocaml)
+       ("ocaml-findlib" ,ocaml-findlib)
+       ("ocaml-hivex" ,ocaml-hivex)
+       ("pcre" ,pcre)
+       ("perl" ,perl)
+       ("qemu" ,qemu)))
+    (home-page "https://libguestfs.org/")
+    (synopsis "Tools for accessing and modifying virtual machine (VM) disk
+images")
+    (description "libguestfs is a C library and a set of tools for accessing
+and modifying virtual disk images used in platform virtualization.  The tools
+can be used for viewing and editing virtual machines (VMs) managed by libvirt
+and files inside VMs, scripting changes to VMs, and creating VMs.")
+    ;; The library files are released under LGPLv2.1 or later.
+    ;; The programs ;; are released under GPLv2+.
+    (license (list license:lgpl2.1+ license:gpl2+))))
-- 
2.28.0

Message #14 received at 44040 <at> debbugs.gnu.org (full text, mbox):

From: Joshua Branson <jbranso <at> dismail.de>
To: Morgan.J.Smith <at> outlook.com
Cc: 44040 <at> debbugs.gnu.org
Subject: Re: [bug#44040] [PATCH 2/2] gnu: Add libguestfs.
Date: Wed, 28 Oct 2020 13:19:09 -0400

Also libguestfs may be helpful for the Hurd filesystem translators:

https://www.gnu.org/software/hurd/hurd/translator/libguestfs.html

-- 
Joshua Branson
Sent from Emacs and Gnus
https://gnucode.me
https://video.hardlimit.com/accounts/joshua_branson/video-channels
"You can have whatever you want, as long as you help enough other people get what they want." - Zig Ziglar

Message #19 received at 44040-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 44040-done <at> debbugs.gnu.org
Subject: libguestfs + ocaml-hivex help wanted
Date: Mon, 17 Feb 2025 01:09:50 +0000

[Message part 1 (text/plain, inline)]

Hi,

This project is packaged and available:

https://packages.guix.gnu.org/search/?query=libguestfs

Closing as not applied.

Oleg

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.