GNU bug report logs - #44104
guix publish should publish public key

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44104 in the body.
You can then email your comments to 44104 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Amar M. Singh" <nly <at> disroot.org>
To: bug-guix <at> gnu.org
Subject: guix publish should publish public key
Date: Wed, 21 Oct 2020 01:34:51 +0530

Guix Publish should also give you the key for the server.

 "Hi, Guix Publish speaking. Here is the authorization key"

Thanks,

Right now this is what i'm trying to work around.

Message #8 received at 44104 <at> debbugs.gnu.org (full text, mbox):

From: "Amar M. Singh" <nly <at> disroot.org>
To: 44104 <at> debbugs.gnu.org
Subject: [patch] guix/scripts/publish: share signing key
Date: Wed, 21 Oct 2020 03:01:44 +0530

[Message part 1 (text/plain, inline)]

Add procedure (render-signing-key) and use it to serve the signing key.

Cheers

[0001-guix-publish-We-provide-signing-key.-Knock-yourselve.patch (text/x-patch, attachment)]

Message #11 received at 44104 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Amar M. Singh" <nly <at> disroot.org>
Cc: 44104 <at> debbugs.gnu.org
Subject: Re: bug#44104: [patch] guix/scripts/publish: share signing key
Date: Wed, 21 Oct 2020 15:11:09 +0200

Hi,

"Amar M. Singh" <nly <at> disroot.org> skribis:

>>From 554416649b7400d0bbe440016c6a6a7fed0d870a Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly <at> disroot.org>
> Date: Wed, 21 Oct 2020 02:02:02 +0530
> Subject: [PATCH] guix publish: We provide signing key. Knock yourselves out!
>
> Best in industry.
>
> Signed-off-by: Amar Singh <nly <at> disroot.org>
> ---
>  guix/scripts/publish.scm | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)

Great idea!  Some comments:

> +++ b/guix/scripts/publish.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2015 David Thompson <davet <at> gnu.org>
> +;;; Copyright (C) 2020 by Amar M. Singh <nly <at> disroot.org>
>  ;;; Copyright © 2015, 2016, 2017, 2018, 2019, 2020 Ludovic Courtès <ludo <at> gnu.org>

Please use the same format as the other lines.

> +(define (render-signing-key)
> +  "Render signing key."
> +  (let ((file "/etc/guix/signing-key.pub"))
> +    (values `((content-type . (text/plain (charset . "UTF-8")))
> +              (x-raw-file . ,file))
> +            file)))

Use ‘%public-key-file’ (from (guix pki)) instead of ‘file’ here.

It would be great if you could add a test in ‘tests/publish.scm’ that
ensures GET /singing-key.pub returns 200 (you can use the
“/nix-cache-info” as a starting point and we can chat on IRC if you need
guidance.)

Bonus points if you can provide a commit log that follows our
conventions:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

:-)

Could you send an updated patch?

Thanks,
Ludo’.

Message #14 received at 44104 <at> debbugs.gnu.org (full text, mbox):

From: "Amar M. Singh" <nly <at> disroot.org>
To: 44104 <at> debbugs.gnu.org
Subject: [patch] guix publish: provide server's signing key.
Date: Thu, 22 Oct 2020 13:18:44 +0530

[Message part 1 (text/plain, inline)]

Thanks, Updated.

[0001-guix-publish-Provide-server-s-signing-key.patch (text/x-patch, attachment)]

Message #19 received at 44104-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Amar M. Singh" <nly <at> disroot.org>
Cc: 44104-done <at> debbugs.gnu.org
Subject: Re: bug#44104: [patch] guix publish: provide server's signing key.
Date: Mon, 26 Oct 2020 23:57:11 +0100

Hi,

"Amar M. Singh" <nly <at> disroot.org> skribis:

> From fe0098082289a2350002da4e2438c41f6385b3e2 Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly <at> disroot.org>
> Date: Wed, 21 Oct 2020 02:02:02 +0530
> Subject: [PATCH] guix publish: Provide server's signing key.
>
> Published at $(guix-publish-uri)/signing-key.pub
>
> Knock yourselves out! Best in industry.
>
> Signed-off-by: Amar Singh <nly <at> disroot.org>

I tweaked the commit log and committed it.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.